| *** Qiming has quit IRC | 00:25 | |
| *** Qiming has joined #senlin | 01:23 | |
| openstackgerrit | Di XiaoLi proposed openstack/python-senlinclient: Add OpenstackClient plugin for cluster profile type list https://review.openstack.org/281809 | 01:28 |
|---|---|---|
| *** Yanyanhu has joined #senlin | 01:35 | |
| *** sridhar_ram has quit IRC | 01:39 | |
| openstackgerrit | Merged openstack/senlin: Rename SenlinBadRequest to BadRequest https://review.openstack.org/281656 | 01:40 |
| *** Liuqing has joined #senlin | 01:44 | |
| openstackgerrit | Di XiaoLi proposed openstack/python-senlinclient: Add JsonFormat display option https://review.openstack.org/282128 | 01:45 |
| Qiming | Yanyanhu, should we abandon this? https://review.openstack.org/#/c/252231 | 01:59 |
| Yanyanhu | yes, I forgot it | 01:59 |
| Yanyanhu | will abandon it | 02:00 |
| openstackgerrit | Di XiaoLi proposed openstack/python-senlinclient: Add OpenstackClient plugin for cluster profile type show https://review.openstack.org/282133 | 02:00 |
| Qiming | thx | 02:01 |
| Yanyanhu | no problem | 02:01 |
| *** elynn has joined #senlin | 02:02 | |
| *** shu-mutou has joined #senlin | 02:03 | |
| elynn | Morning | 02:07 |
| Yanyanhu | morning | 02:08 |
| openstackgerrit | Merged openstack/senlin-dashboard: Updated from global requirements https://review.openstack.org/268539 | 02:12 |
| openstackgerrit | Merged openstack/senlin: Add unit test for is_admin check in DB interfaces https://review.openstack.org/281714 | 02:21 |
| *** PennyLiu has joined #senlin | 02:22 | |
| *** Qiming has quit IRC | 02:28 | |
| *** Qiming has joined #senlin | 02:28 | |
| *** Yanyanhu has quit IRC | 02:28 | |
| *** PennyLiu has quit IRC | 02:30 | |
| Qiming | CFR (call-for-review): https://review.openstack.org/281696 | 02:30 |
| *** Yanyanhu has joined #senlin | 02:31 | |
| elynn | lgtm ^ | 02:38 |
| openstackgerrit | Liuqing Jing proposed openstack/senlin: Add devstack support for senlin dashboard https://review.openstack.org/282138 | 02:39 |
| Qiming | elynn, Liuqing has some questions regarding the devstack plugin script | 02:39 |
| elynn | in comments? | 02:42 |
| Liuqing | As the cleanup_senlin described, cleanup_senlin should behind the installation of senlin : https://github.com/openstack/senlin/blob/master/devstack/plugin.sh#L13-L17, thanks Qiming elynn | 02:42 |
| Liuqing | https://github.com/openstack/senlin/blob/master/devstack/lib/senlin#L59-L63 | 02:42 |
| Liuqing | one nit :) | 02:42 |
| elynn | What's your question? | 02:44 |
| Liuqing | the cleanup_senlin should before the senlin installation steps, right, elynn | 02:46 |
| openstackgerrit | Merged openstack/senlin: Util function 'validate_sort_param' https://review.openstack.org/281696 | 02:46 |
| elynn | cleanup_senlin will execute after you destroy this env. | 02:48 |
| elynn | I think | 02:49 |
| elynn | Let me check | 02:49 |
| Liuqing | ok thanks | 02:49 |
| elynn | https://github.com/openstack/senlin/blob/master/devstack/plugin.sh#L39-L41 | 02:51 |
| elynn | I think it will be executed when you run clean.sh | 02:52 |
| Liuqing | https://github.com/openstack/senlin/blob/master/devstack/plugin.sh#L17 has the function cleanup_senlin? | 02:53 |
| elynn | I don't think it will be run before installation. | 02:53 |
| elynn | Oh... | 02:54 |
| elynn | Then after install senlin and senlin_client, we will clean the configuration files. | 02:54 |
| elynn | then start to create new configuration files. | 02:54 |
| elynn | You are right :) | 02:55 |
| Liuqing | ok | 02:58 |
| Liuqing | hi elynn, i think you're right.. | 03:04 |
| elynn | Why do you say so... | 03:09 |
| Liuqing | the configure_senlin will regenerate the config file. | 03:12 |
| elynn | Liuqing, you can follow the implementation of murano dashboard https://github.com/openstack/murano/blob/master/devstack/plugin.sh , hope this file can help you :) | 03:12 |
| Liuqing | after cleanup_senlin and the devstack installation works well, | 03:13 |
| Liuqing | thanks elynn | 03:13 |
| *** Qiming has quit IRC | 03:16 | |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Remove an unneeded requirement https://review.openstack.org/282151 | 03:29 |
| openstackgerrit | Liuqing Jing proposed openstack/senlin: Add devstack support for senlin dashboard https://review.openstack.org/282138 | 03:41 |
| openstackgerrit | Liuqing Jing proposed openstack/senlin: Add devstack support for senlin dashboard https://review.openstack.org/282138 | 03:46 |
| *** Yanyanhu has quit IRC | 03:49 | |
| *** Qiming has joined #senlin | 03:50 | |
| *** Yanyanhu has joined #senlin | 03:50 | |
| *** yuanying_ has quit IRC | 04:10 | |
| openstackgerrit | Liuqing Jing proposed openstack/senlin-dashboard: Update README.rst https://review.openstack.org/282159 | 04:18 |
| *** elynn has quit IRC | 04:19 | |
| openstackgerrit | Liuqing Jing proposed openstack/senlin: Add senlin dashboard info in README.rst file https://review.openstack.org/282160 | 04:21 |
| openstackgerrit | Ayush Garg proposed openstack/python-senlinclient: Add filters option to profile-list command https://review.openstack.org/282001 | 04:31 |
| *** Liuqing has quit IRC | 04:47 | |
| *** yuanying has joined #senlin | 04:50 | |
| *** elynn has joined #senlin | 04:54 | |
| *** Liuqing has joined #senlin | 04:55 | |
| *** elynn has quit IRC | 04:58 | |
| *** elynn has joined #senlin | 04:58 | |
| openstackgerrit | Merged openstack/senlin: Update devstack comment https://review.openstack.org/281703 | 05:16 |
| *** yuanying has quit IRC | 05:43 | |
| *** Yanyanhu has quit IRC | 06:00 | |
| *** Yanyanhu has joined #senlin | 06:01 | |
| *** Yanyanhu has quit IRC | 06:07 | |
| *** Yanyanhu has joined #senlin | 06:07 | |
| openstackgerrit | Merged openstack/python-senlinclient: Add filters option to profile-list command https://review.openstack.org/282001 | 06:17 |
| *** Liuqing has quit IRC | 06:22 | |
| *** Liuqing has joined #senlin | 06:24 | |
| openstackgerrit | Merged openstack/python-senlinclient: Add OpenstackClient plugin for cluster profile type list https://review.openstack.org/281809 | 06:42 |
| openstackgerrit | Merged openstack/python-senlinclient: Add JsonFormat display option https://review.openstack.org/282128 | 06:53 |
| *** yuanying has joined #senlin | 07:28 | |
| *** Liuqing has quit IRC | 07:53 | |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Validate 'sort' parameter for profiles in engine https://review.openstack.org/282222 | 08:26 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Validate 'sort' parameter for policies in engine https://review.openstack.org/282226 | 08:32 |
| openstackgerrit | Merged openstack/senlin: Remove an unneeded requirement https://review.openstack.org/282151 | 08:34 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Validate 'sort' parameter for clusters in engine https://review.openstack.org/282228 | 08:35 |
| openstackgerrit | Di XiaoLi proposed openstack/python-senlinclient: Add OpenstackClient plugin for cluster profile delete https://review.openstack.org/281107 | 08:39 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Validate 'sort' parameter for nodes in engine https://review.openstack.org/282231 | 08:40 |
| openstackgerrit | Di XiaoLi proposed openstack/python-senlinclient: Add OpenstackClient plugin for cluster profile type show https://review.openstack.org/282133 | 08:46 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Validate 'sort' parameter for listing cluster-policy https://review.openstack.org/282234 | 08:47 |
| *** yuanying has quit IRC | 08:49 | |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Validate 'sort' parameter when listing actions https://review.openstack.org/282235 | 08:52 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Fix an error in openstack_test driver https://review.openstack.org/282238 | 09:02 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Validate 'sort' parameter for recievers when listing https://review.openstack.org/282239 | 09:03 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Validate 'sort' when listing events https://review.openstack.org/282240 | 09:03 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Fix an error in openstack_test driver https://review.openstack.org/282238 | 09:07 |
| Qiming | Yanyanhu, what's the reason behind 282238? | 09:08 |
| Yanyanhu | Sometimes, an incorrect key name referring was done on an empty dictionary | 09:09 |
| Yanyanhu | so failed a functional test case | 09:09 |
| Qiming | we didn't fake correctly? | 09:09 |
| Yanyanhu | yes, an error is there | 09:10 |
| Yanyanhu | let me find the code | 09:10 |
| Qiming | oh, I see | 09:10 |
| Qiming | it is about the faked driver | 09:10 |
| Yanyanhu | yes | 09:10 |
| Yanyanhu | and also the naming of a functional test is incorrect... | 09:10 |
| Qiming | I was sweating when I see nova_driver has to bee changed | 09:10 |
| Yanyanhu | correct it | 09:10 |
| Yanyanhu | yes, not that problem... | 09:11 |
| Yanyanhu | just fake driver | 09:11 |
| Qiming | okay, feeling a litter better, :) | 09:11 |
| Yanyanhu | :) | 09:12 |
| Qiming | too scared to see any critical bugs | 09:13 |
| Yanyanhu | yes | 09:13 |
| *** shu-mutou has quit IRC | 09:22 | |
| Qiming | Yanyanhu, the server_rebuild method in the fake nova driver | 09:23 |
| Yanyanhu | yes? | 09:23 |
| Qiming | we are modifying the attrs dict in place | 09:23 |
| Qiming | is that okay? | 09:23 |
| Qiming | I'm afraid there could be some side effects | 09:23 |
| Qiming | but not 100% sure | 09:23 |
| Yanyanhu | Qiming, understand your concern. I think it's ok here since currently the functional test is run sequently. | 09:25 |
| Yanyanhu | and also those fake resource attrs will be new for each new created novaclient object | 09:26 |
| Qiming | okay | 09:26 |
| openstackgerrit | Merged openstack/python-senlinclient: Add OpenstackClient plugin for cluster profile delete https://review.openstack.org/281107 | 09:28 |
| *** elynn has quit IRC | 09:35 | |
| Qiming | Yanyanhu, speaking of the fix | 09:43 |
| Qiming | the failure at myside is like this: 2016-02-19 04:38:13.773 TRACE senlin.profiles.os.nova.server attrs['image']['id'] = imageref | 09:43 |
| Qiming | 2016-02-19 04:38:13.773 TRACE senlin.profiles.os.nova.server KeyError: 'image' | 09:43 |
| Qiming | it is not that the 'id' cannot be found | 09:43 |
| Qiming | it is the 'image' attribute is causing a key error | 09:44 |
| Yanyanhu | yes, because attr is empty in some cases | 09:44 |
| Yanyanhu | so in this patch, I use attr['image'] = {} rather than attr['image']['id'] = to avoid that error | 09:44 |
| Qiming | I see, it is an assignment | 09:45 |
| Yanyanhu | yes | 09:45 |
| openstackgerrit | Merged openstack/senlin: Enforce multi-tenancy for event find https://review.openstack.org/281640 | 09:46 |
| openstackgerrit | Merged openstack/senlin: Add senlin dashboard info in README.rst file https://review.openstack.org/282160 | 09:47 |
| *** Qiming has quit IRC | 10:05 | |
| *** branw has quit IRC | 10:11 | |
| *** Liuqing has joined #senlin | 10:12 | |
| *** Liuqing has quit IRC | 10:14 | |
| openstackgerrit | Di XiaoLi proposed openstack/python-senlinclient: Add OpenstackClient plugin for cluster profile create https://review.openstack.org/281229 | 10:14 |
| openstackgerrit | Di XiaoLi proposed openstack/python-senlinclient: Add OpenstackClient plugin for cluster profile update https://review.openstack.org/281758 | 10:21 |
| openstackgerrit | Di XiaoLi proposed openstack/python-senlinclient: Add OpenstackClient plugin for cluster profile update https://review.openstack.org/281758 | 10:24 |
| *** yuanying has joined #senlin | 10:25 | |
| openstackgerrit | Di XiaoLi proposed openstack/senlin: Raise Exception when the paramter is invalid https://review.openstack.org/282265 | 10:33 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Fix an error in openstack_test driver https://review.openstack.org/282238 | 10:42 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Fix a bug in cluster recover action https://review.openstack.org/282267 | 10:42 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Add functional test for cluster check recover https://review.openstack.org/282268 | 10:42 |
| *** yuanying has quit IRC | 10:51 | |
| *** Yanyanhu has quit IRC | 10:51 | |
| *** Qiming has joined #senlin | 11:00 | |
| openstackgerrit | Cindia-blue proposed openstack/senlin: Enable Check and Conditional Recover in Health Manager https://review.openstack.org/282299 | 11:59 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Avoid using literal strings in API layer https://review.openstack.org/282301 | 12:07 |
| openstackgerrit | Merged openstack/python-senlinclient: Add OpenstackClient plugin for cluster profile create https://review.openstack.org/281229 | 12:09 |
| openstackgerrit | Di XiaoLi proposed openstack/python-senlinclient: Add OpenstackClient plugin for cluster node list https://review.openstack.org/282304 | 12:12 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Validate 'sort' parameter for profiles in engine https://review.openstack.org/282222 | 12:16 |
| openstackgerrit | Merged openstack/senlin: Validate 'sort' parameter for profiles in engine https://review.openstack.org/282222 | 12:31 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Validate 'sort' parameter for policies in engine https://review.openstack.org/282322 | 12:55 |
| openstackgerrit | Merged openstack/senlin: Avoid using literal strings in API layer https://review.openstack.org/282301 | 13:15 |
| openstackgerrit | Merged openstack/senlin: Validate 'sort' parameter for policies in engine https://review.openstack.org/282322 | 13:15 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Validate 'sort' parameter for clusters in engine https://review.openstack.org/282228 | 13:56 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Validate 'sort' parameter for nodes in engine https://review.openstack.org/282231 | 14:06 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Validate 'sort' parameter for listing cluster-policy https://review.openstack.org/282234 | 14:07 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Validate 'sort' parameter when listing actions https://review.openstack.org/282235 | 14:07 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Validate 'sort' parameter for recievers when listing https://review.openstack.org/282239 | 14:07 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Validate 'sort' when listing events https://review.openstack.org/282240 | 14:07 |
| openstackgerrit | Merged openstack/senlin: Fix a bug in cluster recover action https://review.openstack.org/282267 | 14:10 |
| openstackgerrit | Merged openstack/senlin: Validate 'sort' parameter for clusters in engine https://review.openstack.org/282228 | 14:10 |
| *** openstackgerrit_ has quit IRC | 14:43 | |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Validate 'sort' parameter for nodes in engine https://review.openstack.org/282231 | 14:55 |
| openstackgerrit | Merged openstack/python-senlinclient: Add OpenstackClient plugin for cluster profile type show https://review.openstack.org/282133 | 14:57 |
| *** openstackgerrit_ has joined #senlin | 15:01 | |
| openstackgerrit | Merged openstack/senlin: Validate 'sort' parameter for nodes in engine https://review.openstack.org/282231 | 15:09 |
| *** Liuqing has joined #senlin | 15:57 | |
| openstackgerrit | Merged openstack/python-senlinclient: Add OpenstackClient plugin for cluster node list https://review.openstack.org/282304 | 15:59 |
| openstackgerrit | Di XiaoLi proposed openstack/python-senlinclient: Add OpenstackClient plugin for cluster profile update https://review.openstack.org/281758 | 16:13 |
| openstackgerrit | Liuqing Jing proposed openstack/senlin: Add devstack support for senlin dashboard https://review.openstack.org/282138 | 16:13 |
| *** Qiming has quit IRC | 16:24 | |
| openstackgerrit | Merged openstack/senlin: Validate 'sort' parameter for listing cluster-policy https://review.openstack.org/282234 | 16:26 |
| openstackgerrit | Liuqing Jing proposed openstack/senlin-dashboard: Update README.rst https://review.openstack.org/282159 | 17:59 |
| *** Liuqing has quit IRC | 18:12 | |
| *** sridhar_ram has joined #senlin | 18:38 | |
| *** sridhar_ram has quit IRC | 20:23 | |
| *** sridhar_ram has joined #senlin | 21:46 | |
| *** sridhar_ram1 has joined #senlin | 23:57 | |
| *** sridhar_ram has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!