| *** openstack has joined #senlin | 00:03 | |
| *** openstackstatus has joined #senlin | 00:05 | |
| *** ChanServ sets mode: +v openstackstatus | 00:05 | |
| *** Qiming has quit IRC | 00:37 | |
| *** Qiming_ has joined #senlin | 00:37 | |
| openstackgerrit | Cindia-blue proposed openstack/senlin: Revise Health Policy for Health Management https://review.openstack.org/285593 | 01:59 |
|---|---|---|
| *** zigo has quit IRC | 02:59 | |
| *** zigo has joined #senlin | 03:00 | |
| *** zigo has quit IRC | 03:48 | |
| *** zigo has joined #senlin | 03:50 | |
| *** zigo has quit IRC | 04:03 | |
| *** zigo has joined #senlin | 04:05 | |
| openstackgerrit | Di XiaoLi proposed openstack/python-senlinclient: Add OpenstackClient plugin for cluster members list https://review.openstack.org/285727 | 04:05 |
| openstackgerrit | Di XiaoLi proposed openstack/python-senlinclient: Add OpenstackClient plugin for cluster members add https://review.openstack.org/285728 | 04:12 |
| *** zigo has quit IRC | 04:21 | |
| *** zigo has joined #senlin | 04:23 | |
| openstackgerrit | Di XiaoLi proposed openstack/python-senlinclient: Add OpenstackClient plugin for cluster members del https://review.openstack.org/285729 | 04:24 |
| openstackgerrit | Di XiaoLi proposed openstack/python-senlinclient: Add OpenstackClient plugin for cluster members list https://review.openstack.org/285727 | 04:45 |
| *** idonotknow_ has joined #senlin | 04:46 | |
| *** zigo has quit IRC | 04:53 | |
| *** zigo has joined #senlin | 04:53 | |
| *** idonotknow__ has joined #senlin | 05:24 | |
| *** idonotknow_ has quit IRC | 05:27 | |
| *** idonotknow__ has quit IRC | 05:31 | |
| *** idonotknow_ has joined #senlin | 05:32 | |
| *** Qiming_ has quit IRC | 05:54 | |
| *** Qiming has joined #senlin | 05:55 | |
| *** zigo_ has joined #senlin | 05:55 | |
| *** zigo has quit IRC | 05:56 | |
| *** idonotknow_ has quit IRC | 05:56 | |
| *** zigo_ has quit IRC | 07:10 | |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Add create method to Action class https://review.openstack.org/285765 | 07:13 |
| *** zigo has joined #senlin | 07:14 | |
| *** lixinhui_ has joined #senlin | 07:25 | |
| openstackgerrit | Cindia-blue proposed openstack/senlin: Enable cluster registry and health check in Health Manager https://review.openstack.org/282299 | 07:33 |
| openstackgerrit | Cindia-blue proposed openstack/senlin: Enable cluster registry and health check in Health Manager https://review.openstack.org/282299 | 07:36 |
| openstackgerrit | Merged openstack/python-senlinclient: Fix SDK exception parsing https://review.openstack.org/285631 | 07:39 |
| openstackgerrit | Merged openstack/python-senlinclient: Fix senlin help receiver-list https://review.openstack.org/285709 | 07:39 |
| *** zzxwill has joined #senlin | 07:44 | |
| openstackgerrit | Merged openstack/senlin: Fix multitenancy check when listing resources https://review.openstack.org/285597 | 07:47 |
| zzxwill | Hello QiMing. I noticed that a fix pack should get two +2 reviews before it could be merged. | 07:52 |
| zzxwill | When a review has two +2 reviews and one of the core team believes it is ready to be merged, he or she should leave a +1 vote in the “Approved” category. You may do so by clicking the “Review” button again, with or without changing your code review vote and optionally leaving a comment. When a +1 Approved review is received, Jenkins will run tests on the change, and if they pass, it will be merged. | 07:52 |
| zzxwill | But the fix above seems only get one +2 review. | 07:53 |
| Qiming | yes, zzxwill | 07:53 |
| zzxwill | As I am new to the process, please correct me if I am wrong:) | 07:53 |
| Qiming | usually two +2 and one workflow +1 is needed | 07:53 |
| Qiming | but sometimes, core teams are not that focused | 07:53 |
| Qiming | this is expecially true in an open community | 07:54 |
| Qiming | you are never supposed to push someone to do reviews | 07:54 |
| Qiming | senlin have 5 cores now | 07:56 |
| Qiming | but ... you know, there are always patches need review | 07:56 |
| Qiming | some are blocking others | 07:56 |
| zzxwill | Got it. This is practical which can speed up the community. | 07:56 |
| zzxwill | Thanks for the explanation:) | 07:56 |
| Qiming | most of the time, for a patch that you want to get more feedbacks, you will ping others for review | 07:57 |
| Qiming | if a patch's correctness is obvious, I'm not that patient to wait for the helps from others | 07:57 |
| Qiming | having only one core to review and approve is really a bad practice, I admit | 07:58 |
| zzxwill | Got the point, but you say it's 'obvious' sometimes. Jumping out of the box sometimes won't do anything wrong. | 08:00 |
| Qiming | for example, https://review.openstack.org/#/c/285765/ | 08:01 |
| Qiming | this one is a starting point | 08:01 |
| Qiming | I'm gonna refact the action creation logic thoroughly | 08:01 |
| Qiming | based on this patch | 08:01 |
| Qiming | it is a new classmethod added | 08:01 |
| Qiming | I'm gonna approve it myself, to unblock following work | 08:02 |
| Qiming | I am not supposed to make phone calls to all core memers for a review of this, especailly during weekend | 08:02 |
| zzxwill | Wise choice. Thx. | 08:05 |
| Qiming | ..., the reason is really that I don't have a choice | 08:06 |
| zzxwill | Got it:) | 08:06 |
| openstackgerrit | Merged openstack/python-senlinclient: Add OSC plugin for openstack cluster show https://review.openstack.org/284157 | 08:09 |
| openstackgerrit | Merged openstack/python-senlinclient: Add OSC plugin for openstack cluster create https://review.openstack.org/284184 | 08:12 |
| *** zigo has quit IRC | 08:13 | |
| openstackgerrit | Merged openstack/python-senlinclient: Add OSC plugin for openstack cluster update https://review.openstack.org/284221 | 08:15 |
| openstackgerrit | Merged openstack/python-senlinclient: OSC plugin for openstack cluster policy type list https://review.openstack.org/282865 | 08:15 |
| openstackgerrit | Merged openstack/python-senlinclient: Add OSC plugin for cluster policy type show https://review.openstack.org/282866 | 08:16 |
| *** idonotknow_ has joined #senlin | 08:16 | |
| *** zigo has joined #senlin | 08:19 | |
| openstackgerrit | Merged openstack/python-senlinclient: Add OSC plugin for openstack cluster receiver list https://review.openstack.org/285642 | 08:51 |
| openstackgerrit | Merged openstack/python-senlinclient: Remove profile permission https://review.openstack.org/283961 | 08:51 |
| openstackgerrit | Merged openstack/python-senlinclient: Add "--filter" for command openstack cluster profile list https://review.openstack.org/284098 | 08:52 |
| *** idonotknow_ has quit IRC | 08:58 | |
| openstackgerrit | Cindia-blue proposed openstack/senlin: Enable cluster registry and health check in Health Manager https://review.openstack.org/282299 | 08:58 |
| openstackgerrit | Cindia-blue proposed openstack/senlin: Revise Health Policy for Health Management https://review.openstack.org/285593 | 09:00 |
| openstackgerrit | Merged openstack/senlin: Add create method to Action class https://review.openstack.org/285765 | 09:14 |
| openstackgerrit | Merged openstack/senlin: Update doc/docbkx/README.rst https://review.openstack.org/285151 | 09:24 |
| openstackgerrit | Merged openstack/senlin: Fix SDK exception parsing https://review.openstack.org/285610 | 09:26 |
| openstackgerrit | Cindia-blue proposed openstack/senlin: Enable cluster registry and health check in Health Manager https://review.openstack.org/282299 | 09:27 |
| *** openstack has joined #senlin | 13:56 | |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Refactor cluster check/recover operations https://review.openstack.org/285794 | 13:56 |
| openstackgerrit | Merged openstack/senlin: Refactor cluster resize operation https://review.openstack.org/285789 | 14:00 |
| openstackgerrit | Merged openstack/senlin: Refactor cluster scale out operation https://review.openstack.org/285790 | 14:00 |
| *** openstackstatus has joined #senlin | 14:04 | |
| *** ChanServ sets mode: +v openstackstatus | 14:04 | |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Refactor node create operation https://review.openstack.org/285795 | 14:06 |
| openstackgerrit | Merged openstack/senlin: Refactor cluster scale in operation https://review.openstack.org/285792 | 14:11 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Refactor node update operation https://review.openstack.org/285796 | 14:15 |
| openstackgerrit | Merged openstack/senlin: Refactor cluster check/recover operations https://review.openstack.org/285794 | 14:18 |
| openstackgerrit | Merged openstack/python-senlinclient: Add OSC plugin for openstack cluster build info https://review.openstack.org/285735 | 14:18 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Refactor node delete operation https://review.openstack.org/285797 | 14:18 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Refactor node check/recover operations https://review.openstack.org/285799 | 14:23 |
| openstackgerrit | Merged openstack/senlin: Refactor node create operation https://review.openstack.org/285795 | 14:31 |
| openstackgerrit | Merged openstack/senlin: Refactor node update operation https://review.openstack.org/285796 | 14:35 |
| openstackgerrit | Merged openstack/senlin: Refactor node delete operation https://review.openstack.org/285797 | 14:35 |
| openstackgerrit | Merged openstack/senlin: Refactor node check/recover operations https://review.openstack.org/285799 | 14:45 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Refactor cluster attach policy operation https://review.openstack.org/285800 | 14:47 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Refactor cluster detach policy operation https://review.openstack.org/285801 | 14:50 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Refactor cluster update policy operation https://review.openstack.org/285802 | 14:54 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Refactor action create operation https://review.openstack.org/285803 | 15:04 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Refactor webhook trigger operation https://review.openstack.org/285809 | 15:14 |
| openstackgerrit | Merged openstack/senlin: Refactor cluster attach policy operation https://review.openstack.org/285800 | 15:14 |
| *** Qiming has quit IRC | 15:39 | |
| *** idonotknow_ has joined #senlin | 15:52 | |
| *** idonotknow_ has quit IRC | 16:36 | |
| *** Qiming has joined #senlin | 23:38 | |
| *** Qiming_ has joined #senlin | 23:40 | |
| *** Qiming has quit IRC | 23:43 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!