| *** zzxwill_ has joined #senlin | 00:21 | |
| *** zzxwill has joined #senlin | 00:21 | |
| *** zzxwill_ has quit IRC | 00:47 | |
| *** zzxwill has quit IRC | 00:47 | |
| *** Liuqing has joined #senlin | 01:12 | |
| *** yanyanhu has joined #senlin | 01:15 | |
| *** zzxwill has joined #senlin | 01:26 | |
| *** zzxwill_ has joined #senlin | 01:26 | |
| openstackgerrit | Merged openstack/senlin-dashboard: Updated from global requirements https://review.openstack.org/344321 | 02:06 |
|---|---|---|
| *** Drago has quit IRC | 02:16 | |
| *** Liuqing has quit IRC | 02:32 | |
| *** Liuqing has joined #senlin | 02:33 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-senlinclient: Updated from global requirements https://review.openstack.org/348683 | 02:35 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/senlin: Updated from global requirements https://review.openstack.org/348689 | 02:35 |
| *** elynn has joined #senlin | 02:37 | |
| *** Liuqing has quit IRC | 02:37 | |
| *** Liuqing has joined #senlin | 02:39 | |
| *** yuanying_ has quit IRC | 02:57 | |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: [WIP]Add version support to schema and spec https://review.openstack.org/348709 | 03:32 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: [WIP]Add version support to schema and spec https://review.openstack.org/348709 | 03:33 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: [WIP]Add version support to schema and spec https://review.openstack.org/348709 | 03:36 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: [WIP]Add version support to schema and spec https://review.openstack.org/348709 | 03:38 |
| *** yuanying has joined #senlin | 03:51 | |
| *** elynn has quit IRC | 04:33 | |
| *** elynn has joined #senlin | 05:00 | |
| openstackgerrit | Merged openstack/senlin: Updated from global requirements https://review.openstack.org/348689 | 05:04 |
| *** elynn has quit IRC | 05:05 | |
| *** elynn has joined #senlin | 05:05 | |
| *** yanyanhu has quit IRC | 05:19 | |
| *** yanyanhu has joined #senlin | 05:21 | |
| openstackgerrit | EldonZhao proposed openstack/senlin: Set node status ERROR when physical id is none https://review.openstack.org/347732 | 05:50 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Add version support to schema and spec https://review.openstack.org/348709 | 05:58 |
| Qiming | hi, eldon_ | 06:07 |
| eldon_ | yes~ | 06:11 |
| openstackgerrit | Qiming Teng proposed openstack/python-senlinclient: Update senlinclient for new sdk version https://review.openstack.org/348746 | 06:17 |
| Qiming | hi, eldon | 06:17 |
| Qiming | saw your patch | 06:17 |
| Qiming | I think you are on the right direction to solve this problem | 06:17 |
| Qiming | but I want to know which version of openstacksdk are you using | 06:18 |
| eldon_ | Let me see. 0.7.3 | 06:23 |
| Qiming | ... | 06:23 |
| Qiming | it is too old | 06:23 |
| Qiming | you are running out of sync from the world | 06:24 |
| Qiming | in global requirements, we are forced to use openstacksdk>=0.9.0 | 06:25 |
| Qiming | see: http://git.openstack.org/cgit/openstack/requirements/tree/global-requirements.txt#n323 | 06:25 |
| Qiming | The reason I am checking sdk version is that in new version of openstacksdk, they are throwing exceptions in different ways | 06:25 |
| eldon_ | Oh, my god. How can I solve this problem:) | 06:26 |
| Qiming | and those exceptions are mostly (if not all) caught by this logic in senlin: http://git.openstack.org/cgit/openstack/senlin/tree/senlin/drivers/openstack/sdk.py#n85 | 06:26 |
| eldon_ | Our product uses the old one. | 06:26 |
| Qiming | if no other project is using sdk, you can upgrade separately | 06:27 |
| Qiming | let me show you how things work, so you can have a better idea how driver level exceptions are handled in senlin | 06:28 |
| Qiming | as you may know, the profile code calls to the driver code (under drivers/openstack/) for interacting with nova, heat ... etc | 06:29 |
| eldon_ | yes~ | 06:29 |
| Qiming | and we believe there could be many unexpected exceptions thrown by those backend services | 06:30 |
| Qiming | we cannot handle them one by one, because ... in the worst cases, those exceptions are not documented | 06:30 |
| Qiming | so here is what we did | 06:30 |
| Qiming | when, for example, nova server profile calls server_create() : http://git.openstack.org/cgit/openstack/senlin/tree/senlin/profiles/os/nova/server.py#n387 | 06:31 |
| Qiming | it is calling the code at the driver layer: http://git.openstack.org/cgit/openstack/senlin/tree/senlin/drivers/openstack/nova_v2.py#n97 | 06:32 |
| Qiming | note that the server_create() function called (line 97) has an annotator "@sdk.translate_exception" | 06:32 |
| Qiming | that annotator is located here: http://git.openstack.org/cgit/openstack/senlin/tree/senlin/drivers/openstack/sdk.py#n85 | 06:33 |
| eldon_ | yes, I see | 06:33 |
| Qiming | we are effectively wrapping all calls to sdk functions into a try..except block on line 90-94 | 06:33 |
| eldon_ | great, we use decorator to deal with such scene. | 06:33 |
| Qiming | before raising the exception, we do a parse_exception() processing (see line 34 in the same module) | 06:34 |
| Qiming | we check if it is a SDK HttpException, or SDKException or requests.RequestException ... | 06:34 |
| Qiming | even something we cannot figure out -- line 79 | 06:35 |
| Qiming | this logic is actually trying to handle all exceptions that may get thrown by sdk or the backend services | 06:35 |
| Qiming | we preserve the exception message (for debugging), but translate the exception type to senlin.common.exception.InternalError | 06:36 |
| Qiming | then we can handle all exceptions in a common way | 06:36 |
| Qiming | hope this explanation helps you understand how we are handling all exceptions here | 06:37 |
| Qiming | if you still have some exceptions we cannot catch, there must be something wrong ... | 06:37 |
| Qiming | that is why yanyan and I are very curious about the problem you met, and we hope you can help identify the case we missed | 06:38 |
| *** eldon_ has left #senlin | 06:38 | |
| *** eldon_ has quit IRC | 06:38 | |
| *** eldon_ has joined #senlin | 06:38 | |
| eldon_ | Thank you very much, Qiming:) | 06:39 |
| Qiming | no problem | 06:39 |
| eldon_ | Now I got a deep understanding of it, thank you. | 06:39 |
| eldon_ | have you ever encountered such problem when running tox? | 06:41 |
| eldon_ | ERROR: InvocationError: '/media/eldon/work/git/senlin/.tox/functional/bin/ostestr --slowest' | 06:42 |
| Qiming | try: | 06:42 |
| Qiming | tox -r -e functional | 06:42 |
| eldon_ | the same problem | 06:47 |
| eldon_ | Details: Credentials are: {'username': None, 'project_name': None, 'user_id': None, 'tenant_name': None, 'tenant_id': None, 'project_id': None} Password is not defined. | 06:47 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Add version support to schema and spec https://review.openstack.org/348709 | 06:57 |
| eldon_ | :q | 06:59 |
| *** zhenguo has joined #senlin | 07:04 | |
| Qiming | okay | 07:04 |
| Qiming | when you run functional test | 07:04 |
| Qiming | you will need to source your senlinrc file | 07:04 |
| *** yanyanhu has quit IRC | 07:17 | |
| *** jdandrea has joined #senlin | 07:25 | |
| *** jdandrea_ has quit IRC | 07:29 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/senlin-dashboard: Imported Translations from Zanata https://review.openstack.org/348162 | 07:31 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Move some config options into senlin_api group https://review.openstack.org/348772 | 08:01 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Move some config options into senlin_api group https://review.openstack.org/348772 | 08:05 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Move some config options into senlin_api group https://review.openstack.org/348772 | 08:45 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Add version support to schema and spec https://review.openstack.org/348709 | 08:50 |
| *** yanyanhu has joined #senlin | 08:51 | |
| openstackgerrit | Qiming Teng proposed openstack/senlin: User scenario documentation for autoscaling (1) https://review.openstack.org/348798 | 09:15 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Move some config options into senlin_api group https://review.openstack.org/348772 | 09:20 |
| *** yanyanhu has quit IRC | 09:20 | |
| *** Liuqing has quit IRC | 10:03 | |
| *** chenfei has quit IRC | 10:08 | |
| *** Qiming has quit IRC | 10:08 | |
| *** chenfei has joined #senlin | 10:13 | |
| *** Qiming has joined #senlin | 10:13 | |
| *** elynn has quit IRC | 10:16 | |
| openstackgerrit | Shan Guo proposed openstack/senlin: command in doc is incorrect https://review.openstack.org/348830 | 10:23 |
| *** Qiming has quit IRC | 10:25 | |
| *** chenfei has quit IRC | 10:25 | |
| *** chenfei_ has joined #senlin | 10:25 | |
| *** Qiming has joined #senlin | 10:27 | |
| *** Qiming has quit IRC | 10:46 | |
| *** chenfei_ has quit IRC | 10:46 | |
| *** chenfei has joined #senlin | 10:51 | |
| *** Qiming has joined #senlin | 10:52 | |
| *** chenfei has quit IRC | 10:56 | |
| *** Qiming has quit IRC | 10:57 | |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Move some config options into senlin_api group https://review.openstack.org/348772 | 11:00 |
| *** Qiming has joined #senlin | 11:01 | |
| *** chenfei has joined #senlin | 11:02 | |
| *** Liuqing has joined #senlin | 12:20 | |
| *** Drago has joined #senlin | 14:05 | |
| *** Drago has quit IRC | 14:05 | |
| *** Drago has joined #senlin | 14:05 | |
| *** Liuqing has quit IRC | 15:33 | |
| *** zzxwill has quit IRC | 16:11 | |
| *** zzxwill_ has quit IRC | 16:11 | |
| *** Liuqing has joined #senlin | 16:21 | |
| *** Liuqing has quit IRC | 16:44 | |
| *** Liuqing has joined #senlin | 16:47 | |
| *** Liuqing has quit IRC | 16:54 | |
| *** Liuqing has joined #senlin | 16:55 | |
| *** Liuqing has quit IRC | 17:36 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!