*** zhurong has joined #senlin | 00:15 | |
*** zhurong has quit IRC | 00:22 | |
*** hanwei has joined #senlin | 01:05 | |
*** ruijie has joined #senlin | 01:08 | |
*** yanyanhu has joined #senlin | 01:32 | |
*** zhurong has joined #senlin | 01:33 | |
*** XueFeng has quit IRC | 01:49 | |
*** XueFeng has joined #senlin | 01:49 | |
*** XueFeng has left #senlin | 01:52 | |
*** XueFeng has joined #senlin | 01:52 | |
*** XueFeng has quit IRC | 02:00 | |
*** XueFeng has joined #senlin | 02:00 | |
openstackgerrit | Merged openstack/senlin-dashboard: Updated from global requirements https://review.openstack.org/395387 | 02:20 |
---|---|---|
*** Drago has quit IRC | 02:42 | |
*** yuanying has quit IRC | 02:51 | |
*** Drago has joined #senlin | 02:52 | |
*** shu-mutou-AWAY is now known as shu-mutou | 02:55 | |
openstackgerrit | Qiming Teng proposed openstack/senlin: A spec for generic event/notification support https://review.openstack.org/394874 | 02:59 |
*** lvdongbing has joined #senlin | 03:30 | |
openstackgerrit | RUIJIE YUAN proposed openstack/senlin: engine service support policy-create v2 https://review.openstack.org/395923 | 03:33 |
*** yuanying has joined #senlin | 03:49 | |
*** elynn has joined #senlin | 03:49 | |
xuhaiwei | hi Qiming, are you around? | 04:38 |
*** XueFeng has quit IRC | 04:56 | |
*** XueFeng has joined #senlin | 04:57 | |
*** yuanying has quit IRC | 05:34 | |
*** XueFeng has quit IRC | 05:37 | |
*** XueFeng has joined #senlin | 05:37 | |
openstackgerrit | RUIJIE YUAN proposed openstack/senlin: engine service support policy-create v2 https://review.openstack.org/395923 | 05:40 |
*** XueFeng has quit IRC | 05:48 | |
*** XueFeng has joined #senlin | 05:49 | |
ruijie | hi, Qiming, around? | 05:57 |
Qiming | yes | 06:01 |
ruijie | https://review.openstack.org/#/c/395679/ | 06:01 |
ruijie | for this patch | 06:01 |
ruijie | https://review.openstack.org/gitweb?p=openstack/senlin.git;a=blob;f=senlin/objects/base.py;h=0e1292d9bc6b0de2fba814f8e8a17b78b1500a2e;hb=e2d81eaf7619c64a6afc9930e53aee18e8639e63#l73 | 06:02 |
ruijie | I checked this method. | 06:02 |
ruijie | I found it is a 2 level check and will construct the request obj. | 06:02 |
Qiming | yes? | 06:02 |
ruijie | like request: {body: ''} | 06:03 |
openstackgerrit | Yanyan Hu proposed openstack/senlin: Remove dead code about receiver list https://review.openstack.org/395300 | 06:03 |
openstackgerrit | Yanyan Hu proposed openstack/senlin: API support for receiver_list2 https://review.openstack.org/395299 | 06:03 |
ruijie | but the policy-validate and policy-create request has 3 level | 06:03 |
Qiming | we don't check the policy spec, right? | 06:03 |
ruijie | but we need to construct it | 06:04 |
Qiming | it is {"policy": {"name": "foo", "spec": { a json here}, "version": "1.0"}} ? | 06:05 |
Qiming | oh, no, no version key | 06:05 |
Qiming | should be just {"policy": {"name": "foo", "spec": { a json here}} | 06:06 |
ruijie | actually, it is {"policy": {"spec": {"name": "", "version": "", "properties": {}}}} | 06:06 |
ruijie | it's a 3 level construction | 06:07 |
Qiming | at the api layer, we didn't define the format of the 'spec' value, right? | 06:07 |
ruijie | hm.. but the request sample shows that.. | 06:08 |
Qiming | then that sample is wrong | 06:08 |
Qiming | read the code | 06:08 |
Qiming | from senlinclient | 06:08 |
ruijie | and for the policy-create, the request format should be the same as policy-validate | 06:09 |
Qiming | yes, that was the design I think | 06:10 |
Qiming | a real world example, I just tried, is this: | 06:10 |
Qiming | curl -g -i -X POST http://192.168.42.11:8778/v1/policies -H "openstack-api-version: clustering 1.2" -H "User-Agent: python-senlinclient openstacksdk/0.9.10 keystoneauth1/2.14.0 python-requests/2.11.1 CPython/2.7.12" -H "Content-Type: application/json" -H "X-Auth-Token: {SHA1}298a84a39e22b794ae6fa4a0ced465a2173ff803" -d '{"policy": {"name": "pr01", "spec": {"version": 1.0, "type": "senlin.policy.region_placement", "description": "A policy for node placement ac | 06:10 |
Qiming | ross regions", "properties": {"regions": [{"cap": 150, "name": "RegionOne", "weight": 100}, {"cap": 200, "name": "RegionTwo", "weight": 100}]}}}}' | 06:10 |
ruijie | yes, the 3 level one is strange... | 06:10 |
Qiming | the data part is this: | 06:11 |
Qiming | '{"policy": {"name": "pr01", "spec": {"version": 1.0, "type": "senlin.policy.region_placement", "description": "A policy for node placement across regions", "properties": {"regions": [{"cap": 150, "name": "RegionOne", "weight": 100}, {"cap": 200, "name": "RegionTwo", "weight": 100}]}}}}' | 06:11 |
Qiming | yes, in the 'spec' key, we are expecting a dict that contains 'type', 'version', 'description' and 'properties' values, but those are details the API layer should not care | 06:12 |
Qiming | actually, the 'spec' value comes from a spec file content | 06:12 |
Qiming | the content and format of the spec is a policy format specification, not part of the API specification | 06:13 |
ruijie | I got it, like 'policy': fields.Obj....field('PolicyRequestBody') and in the body definition it will be 'spec': fields.Json...Field() | 06:14 |
ruijie | we don't need to define the content of spec. | 06:15 |
*** XueFeng has quit IRC | 06:16 | |
*** XueFeng has joined #senlin | 06:16 | |
*** XueFeng has quit IRC | 06:26 | |
*** XueFeng has joined #senlin | 06:26 | |
openstackgerrit | Yanyan Hu proposed openstack/senlin: Fix unstable test https://review.openstack.org/395970 | 06:39 |
Qiming | yes, ruijie | 06:40 |
ruijie | okay, thanks, Qiming. | 06:44 |
openstackgerrit | Shu Muto proposed openstack/senlin-dashboard: Add delete action for angular nodes panel https://review.openstack.org/395976 | 06:55 |
openstackgerrit | Shu Muto proposed openstack/senlin-dashboard: Add JS tests for profile delete service https://review.openstack.org/395978 | 07:02 |
openstackgerrit | RUIJIE YUAN proposed openstack/senlin: fields support policy-validate2 https://review.openstack.org/395412 | 07:07 |
openstackgerrit | RUIJIE YUAN proposed openstack/senlin: engine service support policy validate v2 https://review.openstack.org/395495 | 07:18 |
*** XueFeng has quit IRC | 07:25 | |
*** XueFeng has joined #senlin | 07:25 | |
*** XueFeng has quit IRC | 07:34 | |
*** XueFeng has joined #senlin | 07:34 | |
*** XueFeng has quit IRC | 07:37 | |
*** XueFeng has joined #senlin | 07:37 | |
*** openstackgerrit has quit IRC | 07:48 | |
*** openstackgerrit has joined #senlin | 07:49 | |
*** ChanServ sets mode: +v openstackgerrit | 07:49 | |
*** yuanying has joined #senlin | 07:55 | |
*** Drago has quit IRC | 08:31 | |
openstackgerrit | xu-haiwei proposed openstack/senlin: Add container profile infor to cluster dependents https://review.openstack.org/396016 | 08:37 |
*** shu-mutou is now known as shu-mutou-AWAY | 08:37 | |
openstackgerrit | RUIJIE YUAN proposed openstack/senlin: api support policy validate v2 https://review.openstack.org/395679 | 09:06 |
openstackgerrit | RUIJIE YUAN proposed openstack/senlin: remove dead code in policy validate https://review.openstack.org/395680 | 09:11 |
*** elynn has quit IRC | 09:23 | |
*** elynn has joined #senlin | 09:24 | |
openstackgerrit | RUIJIE YUAN proposed openstack/senlin: api support policy validate v2 https://review.openstack.org/395679 | 09:39 |
openstackgerrit | RUIJIE YUAN proposed openstack/senlin: remove dead code in policy validate https://review.openstack.org/395680 | 09:40 |
*** lvdongbing has quit IRC | 09:43 | |
*** yanyanhu has quit IRC | 09:59 | |
*** zhurong has quit IRC | 10:01 | |
*** hanwei has quit IRC | 10:17 | |
openstackgerrit | Merged openstack/senlin-dashboard: Add JS tests for profile delete service https://review.openstack.org/395978 | 10:27 |
*** hanwei has joined #senlin | 10:47 | |
openstackgerrit | Kenji Ishii proposed openstack/senlin-dashboard: Add update profile action for angular profile panel https://review.openstack.org/391332 | 10:57 |
openstackgerrit | Kenji Ishii proposed openstack/senlin-dashboard: Add filterFacets for angular profile table https://review.openstack.org/389544 | 11:04 |
*** gongysh has joined #senlin | 11:05 | |
*** gongysh has quit IRC | 11:07 | |
openstackgerrit | Kenji Ishii proposed openstack/senlin-dashboard: Add update profile action for angular profile panel https://review.openstack.org/391332 | 11:14 |
*** gongysh2 has joined #senlin | 11:17 | |
*** hanwei has quit IRC | 12:43 | |
*** hanwei has joined #senlin | 12:44 | |
*** zhurong has joined #senlin | 12:46 | |
*** catintheroof has joined #senlin | 13:08 | |
openstackgerrit | XueFeng Liu proposed openstack/senlin: Api support for action_list2 https://review.openstack.org/396188 | 13:21 |
*** Drago has joined #senlin | 14:15 | |
*** Drago has quit IRC | 14:19 | |
*** Drago has joined #senlin | 14:25 | |
*** elynn has quit IRC | 14:41 | |
*** elynn_ has joined #senlin | 14:41 | |
*** elynn_ has quit IRC | 14:46 | |
*** zhurong has quit IRC | 15:24 | |
*** Drago has quit IRC | 16:40 | |
*** Drago has joined #senlin | 16:41 | |
*** catinthe_ has joined #senlin | 16:45 | |
*** catintheroof has quit IRC | 16:46 | |
*** elynn has joined #senlin | 16:59 | |
*** elynn has quit IRC | 17:02 | |
*** Drago has quit IRC | 17:05 | |
*** Drago has joined #senlin | 17:11 | |
*** Drago has quit IRC | 17:21 | |
*** hanwei has quit IRC | 18:15 | |
*** Drago has joined #senlin | 19:33 | |
*** openstackgerrit has quit IRC | 19:48 | |
*** openstackgerrit has joined #senlin | 19:49 | |
*** ChanServ sets mode: +v openstackgerrit | 19:49 | |
*** Drago has quit IRC | 21:49 | |
*** catinthe_ has quit IRC | 21:59 | |
*** Drago has joined #senlin | 22:27 | |
*** catintheroof has joined #senlin | 23:05 | |
*** catintheroof has quit IRC | 23:09 | |
*** catintheroof has joined #senlin | 23:17 | |
*** yuanying has quit IRC | 23:34 | |
*** yuanying has joined #senlin | 23:44 | |
*** elynn has joined #senlin | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!