| *** zhurong has joined #senlin | 00:09 | |
| *** catintheroof has joined #senlin | 00:11 | |
| *** guoshan has joined #senlin | 00:22 | |
| *** zhurong has quit IRC | 00:24 | |
| *** guoshan has quit IRC | 00:26 | |
| *** catintheroof has quit IRC | 00:54 | |
| *** ruijie has joined #senlin | 01:08 | |
| *** yanyanhu_ has joined #senlin | 01:21 | |
| *** guoshan has joined #senlin | 01:25 | |
| *** zhurong has joined #senlin | 01:35 | |
| *** elynn has joined #senlin | 01:59 | |
| *** elynn_ has joined #senlin | 02:05 | |
| *** elynn_ has quit IRC | 02:07 | |
| *** elynn has quit IRC | 02:08 | |
| *** elynn has joined #senlin | 02:11 | |
| *** elynn_ has joined #senlin | 02:13 | |
| openstackgerrit | Merged openstack/senlin: Add request object for event-list https://review.openstack.org/397583 | 02:15 |
|---|---|---|
| *** elynn has quit IRC | 02:17 | |
| *** guoshan has quit IRC | 02:20 | |
| *** guoshan has joined #senlin | 02:24 | |
| openstackgerrit | Merged openstack/senlin: Add engine support for event_list2 https://review.openstack.org/398340 | 02:27 |
| openstackgerrit | Merged openstack/senlin: Api support for event_list2 https://review.openstack.org/398341 | 02:30 |
| openstackgerrit | Merged openstack/senlin: Remove dead code related to profile list https://review.openstack.org/398179 | 02:30 |
| openstackgerrit | Merged openstack/senlin: API support for profile-get2 https://review.openstack.org/397493 | 02:30 |
| openstackgerrit | Merged openstack/senlin: APi support for profile-delete2 https://review.openstack.org/398147 | 02:30 |
| openstackgerrit | Merged openstack/senlin: Update the cli in doc of policy command https://review.openstack.org/398156 | 02:30 |
| *** lixinhui has joined #senlin | 02:50 | |
| *** zhurong_ has joined #senlin | 03:10 | |
| *** zhurong has quit IRC | 03:12 | |
| *** lixinhui has quit IRC | 03:15 | |
| *** guoshan has quit IRC | 03:17 | |
| *** lixinhui has joined #senlin | 03:18 | |
| *** guoshan has joined #senlin | 03:19 | |
| *** lixinhui has quit IRC | 03:25 | |
| *** elynn_ has quit IRC | 03:31 | |
| *** lixinhui has joined #senlin | 03:35 | |
| *** zhurong_ has quit IRC | 03:42 | |
| *** zhurong has joined #senlin | 03:43 | |
| *** guoshan has quit IRC | 03:57 | |
| *** lixinhui has quit IRC | 04:19 | |
| *** lixinhui has joined #senlin | 04:24 | |
| openstackgerrit | xu-haiwei proposed openstack/senlin: Add container node profile id to vm cluster's 'dependents' property https://review.openstack.org/398154 | 04:57 |
| *** guoshan has joined #senlin | 04:58 | |
| *** guoshan has quit IRC | 05:03 | |
| *** XueFeng has joined #senlin | 05:19 | |
| *** XueFeng has quit IRC | 05:24 | |
| *** XueFeng has joined #senlin | 05:25 | |
| Qiming | hi, all, just changed the status of the bp to review: https://blueprints.launchpad.net/senlin/+spec/generic-event | 05:37 |
| ruijie | Hi, Qiming. This feature is about sending the events and notification to a 3rd party tools or something periodically? | 05:44 |
| Qiming | ruijie, my fault, I didn't add link to the spec in the bp | 05:47 |
| Qiming | because I was moving the spec file into the 'approved' directory after it was approved but that file movement patch wasn't approved for some days | 05:48 |
| Qiming | fixing the link now | 05:48 |
| Qiming | now you can find the link to the spec from the bp | 05:48 |
| Qiming | just edited it | 05:49 |
| ruijie | thanks Qiming, will read it | 05:50 |
| *** elynn_ has joined #senlin | 05:54 | |
| *** guoshan has joined #senlin | 05:59 | |
| *** XueFeng has quit IRC | 06:01 | |
| *** XueFeng has joined #senlin | 06:01 | |
| *** elynn_ has quit IRC | 06:01 | |
| *** elynn_ has joined #senlin | 06:01 | |
| *** guoshan has quit IRC | 06:03 | |
| *** XueFeng has quit IRC | 06:22 | |
| *** XueFeng has joined #senlin | 06:22 | |
| *** XueFeng has quit IRC | 06:24 | |
| *** XueFeng has joined #senlin | 06:28 | |
| *** XueFeng has quit IRC | 06:29 | |
| *** XueFeng has joined #senlin | 06:30 | |
| *** guoshan has joined #senlin | 06:30 | |
| *** XueFeng has quit IRC | 06:40 | |
| *** XueFeng has joined #senlin | 06:41 | |
| *** XueFeng has quit IRC | 06:41 | |
| openstackgerrit | miaohb proposed openstack/python-senlinclient: event list display error https://review.openstack.org/399391 | 06:42 |
| openstackgerrit | howard lee proposed openstack/python-senlinclient: Modify development doc url in CONTRIBUTING.rst https://review.openstack.org/399399 | 07:00 |
| Qiming | yanyanhu_, we still haven't got the mascot design draft? | 07:06 |
| yanyanhu_ | Qiming, yes, not yet... | 07:06 |
| yanyanhu_ | maybe I should send a mail to heidi | 07:06 |
| Qiming | seeing patch like this: https://review.openstack.org/#/c/399278/ | 07:06 |
| Qiming | maybe we should check with heidi | 07:06 |
| yanyanhu_ | yes | 07:07 |
| yanyanhu_ | will send her a mail today | 07:07 |
| Qiming | great | 07:07 |
| yanyanhu_ | oh, BTW, do you have the image or a link to it when we proposed for senlin mascot? | 07:08 |
| yanyanhu_ | want to include it in the mail as reference | 07:09 |
| Qiming | lemme check | 07:09 |
| yanyanhu_ | ok, thanks | 07:09 |
| Qiming | sent | 07:09 |
| Qiming | can any cores help review the event BP and get it approved? (https://blueprints.launchpad.net/senlin/+spec/generic-event) the spec has been merged. | 07:10 |
| Qiming | I have commited two patches with bp/generic-event | 07:11 |
| Qiming | still waiting for approval before continuing down this path ... | 07:11 |
| yanyanhu_ | hi, have approved it | 07:11 |
| openstackgerrit | miaohb proposed openstack/senlin: Add sort key "cluster_id" for event list https://review.openstack.org/399403 | 07:12 |
| Qiming | great ... | 07:14 |
| ruijie | in my current understanding, all the events will be transfer to notifications if the user configure the spec ? | 07:17 |
| Qiming | no, not necessarily | 07:34 |
| Qiming | we will build the infrastructure to enable that | 07:34 |
| Qiming | but we will also provide some default configuration options for users to control what are the notifications they want to emit | 07:35 |
| Qiming | we will make such decisions when we are there | 07:35 |
| openstackgerrit | Qiming Teng proposed openstack/python-senlinclient: Fix cluster_id field when listing events https://review.openstack.org/399391 | 07:38 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Revise event dump to use the DB driver https://review.openstack.org/399413 | 07:39 |
| Qiming | sigh ... the 399413 patch above was ... messing up with previous patches still under review | 07:39 |
| Qiming | guys, could you please help review these patches? https://review.openstack.org/#/c/398105/ | 07:40 |
| Qiming | https://review.openstack.org/#/c/398225/ | 07:40 |
| Qiming | maybe I can get a chance to revive this one: https://review.openstack.org/#/c/399413/ | 07:40 |
| yanyanhu_ | hi, Qiming, I have approved this one. https://review.openstack.org/#/c/398105 | 07:44 |
| yanyanhu_ | you can rebase dependent after it is merged | 07:44 |
| Qiming | okay, forgot to create a branch for the latest patch | 07:48 |
| Qiming | forever waiting ... | 07:48 |
| yanyanhu_ | ... | 07:50 |
| yanyanhu_ | so it's on master... | 07:50 |
| yanyanhu_ | ok, if so, lets let them in and fix issues in other patches if needed | 07:51 |
| yanyanhu_ | rebase is really a headache | 07:51 |
| Qiming | cannot move on now | 07:56 |
| Qiming | The outstanding commits are: | 07:56 |
| Qiming | dafd987 (HEAD -> db-event-driver) Revise event dump to use the DB driver | 07:56 |
| Qiming | e9570e2 Revise the DB event dumper | 07:56 |
| Qiming | b47d9b6 (mv-event-driver) Move event database driver out of engine | 07:56 |
| Qiming | Do you really want to submit the above commits? | 07:56 |
| Qiming | Type 'yes' to confirm, other to cancel: yes | 07:56 |
| Qiming | remote: Processing changes: refs: 1, done | 07:56 |
| Qiming | remote: (W) No changes between prior commit d3a65e1 and new commit dafd987 | 07:56 |
| Qiming | To https://tengqm:ZcK4qjpWkuIY@review.openstack.org/openstack/senlin.git | 07:56 |
| Qiming | ! [remote rejected] HEAD -> refs/publish/master/bp/generic-event (no changes made) | 07:56 |
| Qiming | error: failed to push some refs to 'https://tengqm:ZcK4qjpWkuIY@review.openstack.org/openstack/senlin.git' | 07:56 |
| *** openstackgerrit has quit IRC | 08:03 | |
| *** openstackgerrit has joined #senlin | 08:04 | |
| *** ChanServ sets mode: +v openstackgerrit | 08:04 | |
| yanyanhu_ | this is terrible... | 08:06 |
| yanyanhu_ | maybe start from the dependency, one by one | 08:06 |
| yanyanhu_ | have you made further changes on https://review.openstack.org/#/c/398225/ and https://review.openstack.org/#/c/399413 | 08:07 |
| yanyanhu_ | if not, we can merge 398225 first and then 399413 | 08:07 |
| openstackgerrit | XueFeng Liu proposed openstack/senlin: Support action project_safe in db layer https://review.openstack.org/399423 | 08:08 |
| openstackgerrit | Merged openstack/senlin: Move event database driver out of engine https://review.openstack.org/398105 | 08:10 |
| openstackgerrit | XueFeng Liu proposed openstack/python-senlinclient: Support "global_project" arguments for action-list https://review.openstack.org/397805 | 08:11 |
| openstackgerrit | miaohb proposed openstack/python-senlinclient: The output of event-list by filter "cluster_id" return empty https://review.openstack.org/399425 | 08:17 |
| openstackgerrit | miaohb proposed openstack/python-senlinclient: The output of action list filtered by "target" returns empty https://review.openstack.org/399437 | 08:31 |
| openstackgerrit | Merged openstack/senlin: Add sort key "cluster_id" for event list https://review.openstack.org/399403 | 08:38 |
| *** gongysh2 has quit IRC | 08:39 | |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Revise event dump to use the DB driver https://review.openstack.org/399413 | 08:43 |
| *** gongysh2 has joined #senlin | 08:51 | |
| openstackgerrit | miaohb proposed openstack/python-senlinclient: The output of event-list by filter "cluster_id" return empty https://review.openstack.org/399425 | 08:57 |
| ruijie | hi Qiming. | 08:59 |
| ruijie | https://review.openstack.org/gitweb?p=openstack/senlin.git;a=blob;f=senlin/engine/service.py;h=2dedefa9a2082e4ebd99bad049b68d2b7b709e66;hb=e9570e2a363ed863d142e6820edd6e583175175f#l1220 | 08:59 |
| ruijie | For this 'TODO', I didn't get the point of it .. | 09:00 |
| *** XueFeng has joined #senlin | 09:00 | |
| Qiming | okay, profile_find was provided as a convenience for finding a profile object using its name, or ID, or short ID | 09:01 |
| Qiming | the logic is in the same module | 09:01 |
| *** zhurong has quit IRC | 09:01 | |
| Qiming | however, line 1221 is using cluster.profile_id, which is always a full ID of a profile | 09:01 |
| Qiming | we should not waste time doing a 'find' | 09:01 |
| Qiming | just go to the database and grab it would be fine | 09:02 |
| *** zhurong has joined #senlin | 09:02 | |
| ruijie | em, right | 09:02 |
| ruijie | and for the lines between 1264-1282 | 09:03 |
| ruijie | I set different msg depends on different situation | 09:04 |
| Qiming | that is good, but not good enough | 09:04 |
| Qiming | the point, or the value, of differentiating error situations is that we are attempting to report as many errors as possible in a single attempt | 09:05 |
| ruijie | all the wrong messages connot be combined together ? | 09:05 |
| openstackgerrit | miaohb proposed openstack/python-senlinclient: The output of action list filtered by "target" returns empty https://review.openstack.org/399437 | 09:06 |
| Qiming | or else we should have raise an exception directly in the loop at line 1231, abort the processing immediately | 09:06 |
| Qiming | it is like what a compiler does today | 09:06 |
| ruijie | yes, Qiming. Get the point now :) .. | 09:06 |
| Qiming | it will complain that a included file cannot be found, while at the same time, it also continues to check other things | 09:07 |
| ruijie | so, now we want to raise an exception once it happens or we collect all errors? | 09:07 |
| Qiming | the current logic is killing the value for accumulating errors | 09:07 |
| Qiming | I'd prefer we do an aggregation | 09:08 |
| Qiming | e.g. | 09:08 |
| Qiming | there could be some nodes A, C could not be found, node B is in bad status | 09:08 |
| Qiming | then we return a detailed error with all of that | 09:08 |
| Qiming | line 1263 can be this: msg = [] | 09:09 |
| Qiming | then we do msg.append(...) in each if or elif branch | 09:09 |
| ruijie | sure Qiming. we append all error messages to the list | 09:09 |
| Qiming | finally, we combine them into LOG.error('\n'.join(msg)) | 09:10 |
| Qiming | get the points now? | 09:10 |
| ruijie | yes Qiming, exactly :) | 09:10 |
| ruijie | Will fix it and other cluster_actions | 09:11 |
| Qiming | thx | 09:11 |
| ruijie | thanks for explaining :) | 09:12 |
| Qiming | np | 09:13 |
| *** elynn_ has quit IRC | 09:17 | |
| *** AlexeyAbashkin has joined #senlin | 09:53 | |
| *** zhurong has quit IRC | 09:59 | |
| openstackgerrit | Merged openstack/senlin: Revise action's raise catch https://review.openstack.org/398988 | 10:03 |
| *** lixinhui has quit IRC | 10:04 | |
| *** yanyanhu_ has quit IRC | 10:05 | |
| *** AlexeyAbashkin has quit IRC | 10:16 | |
| *** ruijie has quit IRC | 10:30 | |
| *** guoshan has quit IRC | 10:32 | |
| *** guoshan has joined #senlin | 11:12 | |
| *** guoshan has quit IRC | 11:16 | |
| *** guoshan has joined #senlin | 12:13 | |
| *** guoshan has quit IRC | 12:15 | |
| *** zhurong has joined #senlin | 14:18 | |
| *** zhurong has quit IRC | 14:30 | |
| *** zhurong has joined #senlin | 14:35 | |
| *** zhurong has quit IRC | 14:55 | |
| *** Drago1 has joined #senlin | 16:32 | |
| *** Drago1 has quit IRC | 16:37 | |
| *** Drago1 has joined #senlin | 16:45 | |
| *** catintheroof has joined #senlin | 21:31 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!