*** catintheroof has joined #senlin | 00:05 | |
*** XueFeng has quit IRC | 00:38 | |
*** XueFeng has joined #senlin | 00:50 | |
*** XueFeng has quit IRC | 00:56 | |
*** XueFeng has joined #senlin | 00:56 | |
*** Drago1 has quit IRC | 00:57 | |
*** XueFeng has quit IRC | 01:30 | |
*** XueFeng has joined #senlin | 01:31 | |
*** guoshan has joined #senlin | 01:32 | |
*** XueFeng has quit IRC | 01:35 | |
*** XueFeng has joined #senlin | 01:37 | |
*** catintheroof has quit IRC | 01:40 | |
openstackgerrit | Merged openstack/senlin: Add http_proxy_to_wsgi to api-paste https://review.openstack.org/384482 | 01:42 |
---|---|---|
*** chohoor has joined #senlin | 01:43 | |
openstackgerrit | Merged openstack/senlin: Reorg the documentation structure https://review.openstack.org/413409 | 01:55 |
*** elynn has joined #senlin | 01:56 | |
*** yanyanhu has joined #senlin | 01:59 | |
openstackgerrit | Merged openstack/senlin: rework profile-get2/list2 https://review.openstack.org/412725 | 02:09 |
openstackgerrit | Merged openstack/senlin: revise action api https://review.openstack.org/412331 | 02:17 |
*** XueFeng has quit IRC | 02:21 | |
*** XueFeng has joined #senlin | 02:23 | |
*** XueFeng has quit IRC | 02:46 | |
*** XueFeng has joined #senlin | 02:46 | |
openstackgerrit | Hongbin Li proposed openstack/senlin: fix typo in doc https://review.openstack.org/413905 | 02:47 |
openstackgerrit | Tony Breeds proposed openstack/python-senlinclient: Revert "Fix `openstack cluster profile validate` bug" https://review.openstack.org/414388 | 03:01 |
openstackgerrit | Tony Breeds proposed openstack/python-senlinclient: Add Constraints support https://review.openstack.org/413345 | 03:02 |
yanyanhu | hi, Qiming | 03:10 |
yanyanhu | tony just proposed the patch to revert the change which breaks the senlinclient test job | 03:11 |
yanyanhu | https://review.openstack.org/#/c/414388/ | 03:11 |
yanyanhu | before sdk's upper constraint is updated, maybe we should merge it as workaround? | 03:12 |
Qiming | what? | 03:13 |
Qiming | which revert? | 03:13 |
Qiming | his patch is working now | 03:14 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/senlin: Updated from global requirements https://review.openstack.org/414303 | 03:20 |
openstackgerrit | Merged openstack/python-senlinclient: Revert "Fix `openstack cluster profile validate` bug" https://review.openstack.org/414388 | 03:25 |
openstackgerrit | Merged openstack/senlin: revise node api (1) https://review.openstack.org/412359 | 03:42 |
*** elynn has quit IRC | 03:52 | |
openstackgerrit | Merged openstack/senlin: revise node api (2) https://review.openstack.org/412385 | 03:57 |
openstackgerrit | Merged openstack/senlin: use policy_obj to load policy objects https://review.openstack.org/413447 | 04:12 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/senlin: Updated from global requirements https://review.openstack.org/414303 | 04:17 |
*** guoshan has quit IRC | 04:25 | |
openstackgerrit | Merged openstack/senlin: use action_obj to load action objects https://review.openstack.org/413476 | 04:44 |
openstackgerrit | Merged openstack/senlin: Support to more nova server operations https://review.openstack.org/412370 | 04:44 |
openstackgerrit | Merged openstack/senlin: revise profile api https://review.openstack.org/412266 | 04:45 |
*** Drago1 has joined #senlin | 05:09 | |
*** guoshan has joined #senlin | 05:26 | |
*** Drago1 has quit IRC | 05:30 | |
*** guoshan has quit IRC | 05:31 | |
*** elynn has joined #senlin | 05:40 | |
*** guoshan has joined #senlin | 06:06 | |
openstackgerrit | Merged openstack/python-senlinclient: Add Constraints support https://review.openstack.org/413345 | 06:11 |
openstackgerrit | Merged openstack/senlin: Updated from global requirements https://review.openstack.org/414303 | 06:17 |
openstackgerrit | Zhenguo Niu proposed openstack/senlin-dashboard: Following up patch of ddf8b00fe49c571994955eff25c1e2d6e7255c06 https://review.openstack.org/414433 | 06:24 |
openstackgerrit | Qiming Teng proposed openstack/senlin: Disable message notification by default https://review.openstack.org/414434 | 06:29 |
openstackgerrit | miaohb proposed openstack/senlin: Remove deadcode about get_revision https://review.openstack.org/414443 | 06:53 |
openstackgerrit | Merged openstack/senlin: Versioned object and engine support for credential_get https://review.openstack.org/413427 | 06:56 |
openstackgerrit | miaohb proposed openstack/senlin: Trivial: fix the error description in receiver_get2 https://review.openstack.org/414451 | 07:08 |
openstackgerrit | Merged openstack/senlin: API support for credential_get2 https://review.openstack.org/413457 | 07:09 |
openstackgerrit | Merged openstack/senlin: Remove dead code about credential_get https://review.openstack.org/413463 | 07:09 |
openstackgerrit | Merged openstack/senlin: fix typo in doc https://review.openstack.org/413905 | 07:09 |
openstackgerrit | Merged openstack/senlin: Make soft link _50_senlin.py from enabled folder https://review.openstack.org/413523 | 07:09 |
openstackgerrit | miaohb proposed openstack/senlin: Trivial: fix the error description in receiver_list2 https://review.openstack.org/414453 | 07:13 |
openstackgerrit | miaohb proposed openstack/senlin: Versioned request and engine support for credential_update https://review.openstack.org/413050 | 07:29 |
openstackgerrit | Qiming Teng proposed openstack/senlin: Disable message notification by default https://review.openstack.org/414434 | 07:32 |
openstackgerrit | Qiming Teng proposed openstack/senlin: User/developer doc for event dispatchers https://review.openstack.org/414461 | 07:32 |
openstackgerrit | miaohb proposed openstack/senlin: Versioned request and engine support for credential_update https://review.openstack.org/413050 | 07:35 |
*** dinghh1 has joined #senlin | 07:40 | |
*** dinghh has quit IRC | 07:42 | |
openstackgerrit | Merged openstack/senlin: Fix typo in examples https://review.openstack.org/412699 | 08:11 |
openstackgerrit | Merged openstack/senlin: Trivial: Arrange the imported objects in alphabetical order https://review.openstack.org/412843 | 08:57 |
openstackgerrit | Merged openstack/senlin: use receiver_obj to load receiver objects https://review.openstack.org/413496 | 08:57 |
Qiming | just tried swagger for api definitions ... | 09:10 |
Qiming | interestingly, if we model the action urls with parameters, it can work | 09:10 |
Qiming | for example: /v1/clusters/actions?action=add_nodes and /v1/clusters/actions?action=del_nodes can be treated correctly as different endpoints | 09:11 |
*** XueFeng has quit IRC | 09:12 | |
openstackgerrit | Qiming Teng proposed openstack/python-senlinclient: Revert "Revert "Get project_id and user_id when show profile"" https://review.openstack.org/414501 | 09:13 |
Qiming | ^ is a revert to a revert :D | 09:13 |
Qiming | let's see if gerrit can handle it correctly | 09:13 |
*** XueFeng has joined #senlin | 09:13 | |
ruijie | Qiming, I didn't get the point :( | 09:15 |
Qiming | the patch? | 09:15 |
ruijie | the API | 09:16 |
Qiming | okay, I was playing with swagger, aka Open-API | 09:16 |
Qiming | rumors said it is powerful and brilliant | 09:16 |
ruijie | the API-gateway? | 09:16 |
Qiming | you will write your API definitionsl in YAML or JSON, for once | 09:17 |
Qiming | then you can generate docs, client, server implementation automatically in different lanaguages | 09:17 |
Qiming | several months ago, the OpenStack community considered migrating from WSDL to swagger, but that didn't lead to anything | 09:18 |
Qiming | one obstacle is that swagger requires each URL represent a unique resource | 09:18 |
Qiming | a URL plus a verb (POST, GET, DELETE, etc) defines a single operation | 09:19 |
Qiming | however, in Nova, /servers/<server_id>/actions have been overloaded by many operations, such reboot, restart, pause, resume | 09:19 |
Qiming | it cannot be modeled using swagger (open-api) | 09:19 |
ruijie | like /v1/clusters/action/add_nodes | 09:19 |
Qiming | one proposal is to do POST /v1/clusters/<ID>/actions/add_nodes for add nodes | 09:20 |
Qiming | however, 'add_nodes' is not a resource for you to do a POST | 09:20 |
Qiming | it is against ReSt definition | 09:20 |
ruijie | thanks Qiming, that makes sense :) | 09:22 |
openstackgerrit | Qiming Teng proposed openstack/python-senlinclient: Revert "Revert "Fix `openstack cluster profile validate` bug"" https://review.openstack.org/414506 | 09:22 |
Qiming | post something to a verb is not ideal | 09:23 |
Qiming | but ... with swagger, we don't have a choice | 09:23 |
Qiming | so an alternative is to do this: POST /v1/clusters/<ID>/actions?action=attach_policy | 09:23 |
Qiming | since the path is now unique to swagger, swagger is happy with it | 09:24 |
ruijie | is that a compulsive requirement that all projects should use swagger ? | 09:24 |
openstackgerrit | Merged openstack/senlin: Add get-revision requests in object and service https://review.openstack.org/413412 | 09:24 |
Qiming | and we are avoiding posting to a verb | 09:24 |
openstackgerrit | Merged openstack/senlin: Api support for get-revision2 https://review.openstack.org/413460 | 09:24 |
Qiming | no | 09:24 |
Qiming | just experimentations | 09:24 |
Qiming | we have already migrated from WSDL to os-api-ref lib | 09:24 |
Qiming | APIs are documented in RST today | 09:25 |
Qiming | won't change it in forseeable future | 09:25 |
Qiming | em, the revert to revert was a success, :D | 09:25 |
*** XueFeng has quit IRC | 09:26 | |
*** XueFeng has joined #senlin | 09:27 | |
ruijie | great, reworking ALL api would be heavy work ... | 09:28 |
openstackgerrit | miaohb proposed openstack/senlin: Remove deadcode about get_revision https://review.openstack.org/414443 | 09:31 |
Qiming | ruijie, yes, no need to do that | 09:32 |
openstackgerrit | Qiming Teng proposed openstack/senlin: Add request object for node operations https://review.openstack.org/414513 | 09:32 |
Qiming | unless we are reimplementing the api layer completely | 09:33 |
openstackgerrit | miaohb proposed openstack/senlin: Remove deadcode about request_context https://review.openstack.org/414516 | 09:39 |
openstackgerrit | Qiming Teng proposed openstack/senlin: Add ProfileTypeOpListRequest https://review.openstack.org/414520 | 09:45 |
*** elynn has quit IRC | 09:47 | |
*** XueFeng has quit IRC | 09:50 | |
*** XueFeng has joined #senlin | 09:51 | |
*** guoshan has quit IRC | 10:07 | |
openstackgerrit | Qiming Teng proposed openstack/senlin: Add profile_type_ops RPC call https://review.openstack.org/414535 | 10:12 |
*** dinghh1 has left #senlin | 10:12 | |
*** yanyanhu has quit IRC | 10:48 | |
*** chohoor has quit IRC | 10:51 | |
openstackgerrit | Merged openstack/senlin: Versioned request and engine support for credential_update https://review.openstack.org/413050 | 11:43 |
openstackgerrit | Merged openstack/senlin: Trivial: fix the error description in receiver_get2 https://review.openstack.org/414451 | 12:08 |
openstackgerrit | Merged openstack/senlin: Trivial: fix the error description in receiver_list2 https://review.openstack.org/414453 | 12:08 |
openstackgerrit | XueFeng Liu proposed openstack/python-senlinclient: Fix `openstack cluster policy show` bug https://review.openstack.org/411122 | 13:10 |
openstackgerrit | XueFeng Liu proposed openstack/python-senlinclient: Fix `openstack cluster policy vaildate` bug https://review.openstack.org/411135 | 13:11 |
openstackgerrit | XueFeng Liu proposed openstack/python-senlinclient: Fix `openstack cluster policy vaildate` bug https://review.openstack.org/411135 | 13:26 |
openstackgerrit | XueFeng Liu proposed openstack/python-senlinclient: Fix `openstack cluster policy show` bug https://review.openstack.org/411122 | 13:27 |
openstackgerrit | Merged openstack/python-senlinclient: Revert "Revert "Fix `openstack cluster profile validate` bug"" https://review.openstack.org/414506 | 13:59 |
*** Qiming has quit IRC | 18:53 | |
*** Drago has joined #senlin | 20:22 | |
*** edisonxiang has quit IRC | 20:59 | |
*** edisonxiang has joined #senlin | 21:00 | |
*** Jeffrey4l has quit IRC | 21:35 | |
*** Jeffrey4l has joined #senlin | 21:48 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!