Wednesday, 2017-11-29

« Tuesday, 2017-11-28 Index Thursday, 2017-11-30 »
*** liyi has joined #senlin00:19
*** XueFeng has quit IRC00:20
*** XueFeng has joined #senlin00:20
*** liyi has quit IRC00:23
*** XueFeng has quit IRC00:33
*** XueFeng has joined #senlin00:33
*** liyi has joined #senlin00:48
openstackgerritMerged openstack/senlin master: Fix nova handle_rebuild return error  https://review.openstack.org/51865101:34
liyihi all, I have a question about lb ceration. https://github.com/openstack/senlin/blob/master/senlin/drivers/openstack/lbaas.py#L66, The code shows that when we create a lb, we need to check provisioning_status and operating_status, but when lb is created at the first time, the operating_status must be offline, because no member in lb.01:58
ruijie_the response sample on LBaas's api documentation shows that the "operating_status == ONLINE" ?02:09
*** shu-mutou-AWAY has quit IRC02:09
*** liyi has quit IRC02:11
*** liyi has joined #senlin02:11
*** liyi_ has joined #senlin02:13
*** liyi has quit IRC02:13
liyi_ONLINE02:14
liyi_Entity is operating normally02:14
liyi_All pool members are healthy02:14
liyi_ruijie, if members are healthy, operating_status is ONLINE02:14
liyi_but the lb initiate with no any member, so the operating_status must be OFFLINE,02:15
liyi_I don't know right answer02:16
liyi_https://developer.openstack.org/api-ref/load-balancer/v2/index.html#operating-status-codes02:17
liyi_Is it necessary to check operating_status is ONLINE?02:20
*** XueFeng has quit IRC02:35
*** XueFeng has joined #senlin02:35
ruijie_not sure about that :<02:36
openstackgerritMerged openstack/senlin master: Remove redundant character.  https://review.openstack.org/52334502:38
chenyb4Hi, all! I have a question. when engine service stop or restart don't stop all thread, only stop one thread, the other stop appear "NoneType" error. look this bug https://bugs.launchpad.net/senlin/+bug/173506404:29
openstackLaunchpad bug 1735064 in senlin "Engine service stop or restart 'NoneType' object has no attribute 'stop'" [Undecided,New] - Assigned to chenyb4 (chenyb4)04:29
*** shu-mutou has joined #senlin04:29
chenyb4So, the engine-service stop, It doesn't seem to be thinking about "num_workers"04:30
openstackgerritchenyb4 proposed openstack/senlin master: Fix node check no server found record error  https://review.openstack.org/52369205:35
*** liyi has joined #senlin05:56
*** liyi_ has quit IRC05:57
chenyb4Hi, all! I have a question. when engine service stop or restart don't stop all thread, only stop one thread, the other stop appear "NoneType" error. look this bug https://bugs.launchpad.net/senlin/+bug/173506406:06
openstackLaunchpad bug 1735064 in senlin "Engine service stop or restart 'NoneType' object has no attribute 'stop'" [Undecided,New] - Assigned to chenyb4 (chenyb4)06:06
chenyb4So, the engine-service stop, It doesn't seem to be thinking about "num_workers"06:07
Qimingwhat do you mean, chenyb4 ?06:09
Qimingthere are two layers of "workers"06:09
Qimingthe configuration option "workers" actually means the number of engine-services you are running06:09
Qiminginside each engine-service instances there are many threads06:10
chenyb4Qiming, https://github.com/openstack/senlin/blob/master/senlin/engine/service.py#L166 In this, the engine stop only stop one06:11
Qimingyes06:12
Qimingeach engine-service has an associated dispatcher06:12
chenyb4So, I think must stop all06:12
Qimingthat engine-service is only responsible to kill its own dispatcher06:12
Qiminghaving multiple dispatcher is to maintain the availability of the senlin engine service06:13
chenyb4But mutiple dispatcher start after execute stop, will appear "ERROR senlin-engine AttributeError: 'EngineService' object has no attribute 'dispatcher'"06:14
Qimingwhich line is throwing that exceptoin?06:14
chenyb4https://github.com/openstack/senlin/blob/master/senlin/engine/service.py#L166 in this call06:15
Qimingthe engine-service instance is not yet stopped, the current logic seems correct06:15
Qimingyou mean that call or that line?06:15
chenyb4yes06:16
QimingI'm asking question06:16
Qimingdo you mean that "call" ? or that line?06:16
Qimingself.dispatcher is initialized at line 11606:16
Qimingit was never changed later06:16
Qiminghow could it become None?06:17
chenyb4when i update to this, the error, don't appear. http://paste.ubuntu.com/26069902/06:17
Qimingit has nothing to do how it seems working06:17
Qimingwe don't make decisions based on testing06:18
Qimingwe have to ensure we are doing the right thing06:18
chenyb4in this, I record log it has nothing to do how it seems working06:18
Qimingit is dangerous if an engine-service doesn't have a dispatcher started06:18
chenyb4sorry06:18
chenyb4 in this, I record log https://bugs.launchpad.net/senlin/+bug/173506406:19
openstackLaunchpad bug 1735064 in senlin "Engine service stop or restart 'NoneType' object has no attribute 'stop'" [Undecided,New] - Assigned to chenyb4 (chenyb4)06:19
chenyb4start is not problem, only stop appear error06:20
Qimingsigh ...06:22
Qiming看样子你听不懂 ...06:22
Qiming问题不在于你修改后的代码是不是测试没有问题06:23
Qiming问题在于背后的逻辑是不是对的06:23
Qiming你这样修改之后，默认就认为engine启动之后，dispatcher没有创建也是没有关系的，stop可以正确结束了06:23
Qiming这是错的06:23
Qimingdispatcher必须启动，不然engine没有意义06:24
Qiming还可能带来其它不可预料的问题06:24
chenyb4我明白你的意思了,在服务停止时,每一个workers都会执行stop操作,那么就不会存在None type06:24
chenyb4是这样的吗?06:24
Qimingworker这个名字不豪06:24
Qiming不好06:24
Qiming其实是engines06:24
Qiming每个engine自己启动的时候，设置自己的dispatcher，必须成功，不然engine没用了06:24
Qiming结束的时候，当然dispatcher不应该为空06:25
Qiming如果self.dispatcher为空，证明engine出大问题了06:25
Qiming懂了么？06:25
chenyb4嗯,明白了.06:25
Qiming所以问题的本质是，engine是怎么停掉的06:25
Qiming这个调用流程是不是出问题了06:26
Qiming怎么会启动的时候初始化了self.dispatcher，stop的时候变成NoneType了06:26
Qiming例如，所有的后台service都不应该用control-C来停止06:28
chenyb4服务启动后,我执行ps -ef|grep senlin-engine, 多个engines是存在的, 当我执行stop操作的时候,虽然日志出现了错误,但是senlin-engine进程是结束了的06:28
QimingControl-C发送的是SIGINT，是对整个引擎运行状态的破坏性操作06:29
Qiming停止服务的正确信号应该是SIGTERM06:29
chenyb4Qiming, 我明白你的意思, 我使用的是systemctl 管理06:29
Qiming相关的控制逻辑比较复杂06:29
Qiming在 senlin/api/common/wsgi.py 里面06:30
Qiming所以先不要这样去修06:30
chenyb4好的.06:30
Qiming从头看一下杀死service-engine的流程是不是哪里有大问题06:31
chenyb4好06:31
Qiming最近一直很忙，没有参与这些讨论，很抱歉06:31
*** liyi has quit IRC07:16
*** liyi has joined #senlin07:17
*** liyi has quit IRC07:17
*** liyi has joined #senlin07:18
*** AlexeyAbashkin has joined #senlin07:47
*** XueFeng has quit IRC07:59
*** XueFeng has joined #senlin07:59
*** XueFeng has quit IRC08:37
*** XueFeng has joined #senlin08:38
*** XueFeng has quit IRC08:39
*** XueFeng has joined #senlin08:40
openstackgerritOpenStack Proposal Bot proposed openstack/senlin master: Updated from global requirements  https://review.openstack.org/52379709:22
openstackgerritliyi proposed openstack/senlin master: Merge loadbalancer to Octavia  https://review.openstack.org/52382609:48
openstackgerritliyi proposed openstack/senlin master: Migrate loadbalancer to Octavia  https://review.openstack.org/52382609:50
*** liyi has quit IRC09:53
*** shu-mutou is now known as shu-mutou-AWAY10:21
*** AlexeyAbashkin has quit IRC10:28
*** liyi has joined #senlin11:16
*** haint_ has joined #senlin11:16
*** AlexeyAbashkin has joined #senlin11:19
*** liyi has quit IRC11:20
*** haint has quit IRC11:21
*** AlexeyAbashkin has quit IRC11:23
*** AlexeyAbashkin has joined #senlin11:27
*** ruijie_ has quit IRC12:31
*** liyi has joined #senlin13:14
*** chenybd_ has joined #senlin13:15
*** liyi has quit IRC13:18
*** zhurong has joined #senlin13:38
*** openstackstatus has quit IRC13:43
*** openstack has joined #senlin13:47
*** ChanServ sets mode: +o openstack13:47
*** zhurong has quit IRC13:56
*** zhurong has joined #senlin13:58
*** zhurong has quit IRC14:46
*** zhurong has joined #senlin14:46
*** openstack has quit IRC14:46
*** openstack has joined #senlin14:53
*** ChanServ sets mode: +o openstack14:53
*** liyi has joined #senlin14:55
*** liyi has quit IRC14:59
*** chenybd_ has quit IRC15:49
*** chenybd_ has joined #senlin15:49
*** chenybd_ has quit IRC15:54
*** AlexeyAbashkin has quit IRC16:23
*** liyi has joined #senlin16:24
*** liyi has quit IRC16:29
*** liyi has joined #senlin17:44
*** liyi has quit IRC17:49
openstackgerritDuc Truong proposed openstack/senlin master: Add lifecycle hook spec  https://review.openstack.org/52396519:10
*** AlexeyAbashkin has joined #senlin20:14
*** AlexeyAbashkin has quit IRC20:18
*** liyi has joined #senlin20:32
*** liyi has quit IRC20:37
*** jmlowe has quit IRC22:16
*** liyi has joined #senlin22:22
*** liyi has quit IRC22:26
*** jmlowe has joined #senlin22:31
*** liyi has joined #senlin23:11
*** jmlowe has quit IRC23:13
*** AlexeyAbashkin has joined #senlin23:14
*** liyi has quit IRC23:16
*** AlexeyAbashkin has quit IRC23:19
*** jmlowe has joined #senlin23:21
« Tuesday, 2017-11-28 Index Thursday, 2017-11-30 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!