*** ChanServ sets mode: +o openstack | 00:00 | |
*** AlexeyAbashkin has joined #senlin | 00:16 | |
*** AlexeyAbashkin has quit IRC | 00:21 | |
*** chenyb4 has joined #senlin | 00:56 | |
*** pzchen has quit IRC | 01:05 | |
*** pzchen has joined #senlin | 01:10 | |
*** openstackgerrit has joined #senlin | 01:51 | |
*** ChanServ sets mode: +v openstackgerrit | 01:51 | |
openstackgerrit | chenyb4 proposed openstack/python-senlinclient master: Add functional initialize test client call. https://review.openstack.org/535188 | 01:51 |
---|---|---|
chenyb4 | Qiming, It looks very strange. run unit test, the functional test it worked together. http://logs.openstack.org/88/535188/12/check/openstack-tox-py27/dddc496/testr_results.html.gz | 01:56 |
chenyb4 | In tox.ini i was add "[testenv:debug-py27] and configure running test path | 01:58 |
chenyb4 | and [testenv:debug-py34] | 01:58 |
Qiming | I noticed that | 02:49 |
Qiming | seems there are still something to be corrected in tox.ini | 02:50 |
chenyb4 | in my local test, when i was exec "tox -e py27" running unit test, the functional test it worked together. | 02:53 |
chenyb4 | I find this reason is [testenv], when running [testenv] execute "python setup.py testr --slowest --testr-args='{posargs}'" | 02:54 |
chenyb4 | [testenv] will runnning all test. about unit test ,functional test | 02:55 |
openstackgerrit | Qiming Teng proposed openstack/senlin master: Fix devgate https://review.openstack.org/533108 | 03:39 |
Qiming | the posargs should be customized | 03:40 |
chenyb4 | execute "tox -e py27" [testenv] running not load "python subunit.run discover -t ./ ${OS_TEST_PATH:-./senlinclient/tests/unit} --list" | 03:43 |
chenyb4 | so, tox -epy27 not running unit test | 03:43 |
Qiming | yes, tox.ini is broken | 03:44 |
Qiming | it is strange | 03:58 |
openstackgerrit | Qiming Teng proposed openstack/python-senlinclient master: Add functional initialize test client call. https://review.openstack.org/535188 | 04:02 |
Qiming | trying using ostestr | 04:02 |
*** Qiming has quit IRC | 04:18 | |
*** Qiming has joined #senlin | 04:18 | |
openstackgerrit | Merged openstack/python-senlinclient master: Update the home page https://review.openstack.org/532008 | 04:22 |
*** pzchen has quit IRC | 04:35 | |
openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/python-senlinclient master: [WIP] Refactored make_client https://review.openstack.org/536673 | 04:35 |
openstackgerrit | Qiming Teng proposed openstack/senlin master: Fix devgate https://review.openstack.org/533108 | 04:46 |
*** pzchen has joined #senlin | 05:00 | |
openstackgerrit | Qiming Teng proposed openstack/python-senlinclient master: Add functional initialize test client call. https://review.openstack.org/535188 | 05:01 |
openstackgerrit | chenyb4 proposed openstack/python-senlinclient master: Add functional initialize test client call. https://review.openstack.org/535188 | 05:09 |
chenyb4 | Hi, Qiming I'm lost something in .tester.conf file | 05:09 |
Qiming | yep, that is why tox ini is not doing the right thing | 05:10 |
chenyb4 | lost "${OS_TEST_PATH:-./senlinclient/tests/unit}" in .testr.conf | 05:10 |
openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/python-senlinclient master: [WIP] Refactored make_client https://review.openstack.org/536673 | 05:22 |
*** eanderson_ has joined #senlin | 05:24 | |
eanderson_ | Qiming, if you have some time can you take a look at https://review.openstack.org/#/c/536673/ ? | 05:26 |
eanderson_ | After the issue with region_name I felt like it might be worth refactoring these functions | 05:27 |
Qiming | sure, eanderson_ , will jump onto it when I'm getting out of the pond | 05:28 |
openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/python-senlinclient master: [WIP] Refactored make_client https://review.openstack.org/536673 | 05:35 |
eanderson_ | I added some comments that I wasn't sure about | 05:35 |
Qiming | yes, eanderson_ I have left some comments | 05:45 |
openstackgerrit | chenyb4 proposed openstack/python-senlinclient master: Add functional initialize test client call. https://review.openstack.org/535188 | 05:45 |
openstackgerrit | chenyb4 proposed openstack/python-senlinclient master: Add functional initialize test client call. https://review.openstack.org/535188 | 05:48 |
*** dtruong2 has joined #senlin | 05:57 | |
chenyb4 | hi, Qiming. experimental it looks can't finish senlinclient-dsvm-functional | 06:07 |
Qiming | before a job matures, we put it on the experimental pipeline and triggers it using 'check experimental' | 06:09 |
openstackgerrit | Duc Truong proposed openstack/senlin-tempest-plugin master: Fix broken test cases https://review.openstack.org/536518 | 06:10 |
Qiming | when the a job is good to be checked every time, we move it to gate and set it non-voting | 06:10 |
Qiming | when a job is eventually completed and can be used as a gate, we switch it to voting status | 06:11 |
Qiming | I have just triggered the experimental pipeline | 06:11 |
chenyb4 | ok | 06:11 |
dtruong2 | qiming: looks like there is only two test cases that were still failing in py27 of https://review.openstack.org/#/c/533108/ | 06:11 |
Qiming | oh really? | 06:11 |
Qiming | cool! | 06:12 |
dtruong2 | so i push another patch set for https://review.openstack.org/#/c/536518/5 that hopefully fixes it | 06:12 |
dtruong2 | i will recheck https://review.openstack.org/#/c/533108/ | 06:12 |
Qiming | looking ... | 06:12 |
Qiming | \o/ | 06:13 |
Qiming | finally ... | 06:13 |
Qiming | the changes to oslo.versionedobjects was annoying | 06:13 |
dtruong2 | yes, crossing my fingers that py27 api will pass all tests | 06:13 |
Qiming | ya, so do py35 | 06:14 |
dtruong2 | yea. from a glance at the logs it seems like all py35 failures are because of a single error: | 06:18 |
dtruong2 | ERROR oslo_messaging.rpc.server oslo_db.exception.DBError: 'list' object has no attribute 'lower' | 06:18 |
openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/python-senlinclient master: Refactored make_client https://review.openstack.org/536673 | 06:27 |
openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/python-senlinclient master: Refactored make_client https://review.openstack.org/536673 | 06:30 |
eanderson_ | forgot to run pep8 tests first :D | 06:30 |
eanderson_ | oh and also take a look at https://review.openstack.org/#/c/536544/ when you have time | 06:32 |
*** dtruong2 has quit IRC | 07:09 | |
openstackgerrit | Merged openstack/senlin-tempest-plugin master: Fix broken test cases https://review.openstack.org/536518 | 07:13 |
openstackgerrit | Qiming Teng proposed openstack/python-senlinclient master: Add functional initialize test client call. https://review.openstack.org/535188 | 07:16 |
Qiming | dtruong, do you think we can kick 533108 in and continue polish/fix the gate jobs in other patches? | 07:27 |
openstackgerrit | chenyb4 proposed openstack/python-senlinclient master: Add functional initialize test client call. https://review.openstack.org/535188 | 07:28 |
openstackgerrit | Qiming Teng proposed openstack/python-senlinclient master: Add functional initialize test client call. https://review.openstack.org/535188 | 07:28 |
Qiming | sigh ... | 07:29 |
*** AlexeyAbashkin has joined #senlin | 08:05 | |
*** blkart has joined #senlin | 08:06 | |
chenyb4 | Qiming, We should add test results. view this https://github.com/openstack/python-heatclient/blob/master/heatclient/tests/functional/hooks/post_test_hook.sh#L17 | 08:15 |
Qiming | for what reason? | 08:15 |
chenyb4 | We cannot now get a functional test record. | 08:17 |
Qiming | where the record is shown? | 08:18 |
openstackgerrit | Qiming Teng proposed openstack/python-senlinclient master: Add functional initialize test client call. https://review.openstack.org/535188 | 08:22 |
Qiming | we haven't seen the function test outputs yet | 08:23 |
Qiming | let's focus on getting pass this step first | 08:24 |
chenyb4 | ok | 08:26 |
*** eanderson_ has quit IRC | 08:29 | |
openstackgerrit | Qiming Teng proposed openstack/senlin master: Remove localization at db layer https://review.openstack.org/536721 | 09:07 |
*** blkart has quit IRC | 10:19 | |
*** chenyb4 has quit IRC | 10:23 | |
*** blkart has joined #senlin | 10:27 | |
openstackgerrit | Qiming Teng proposed openstack/senlin master: Fake driver for Octavia https://review.openstack.org/536758 | 10:46 |
openstackgerrit | Qiming Teng proposed openstack/python-senlinclient master: Add functional initialize test client call. https://review.openstack.org/535188 | 10:48 |
*** AlexeyAbashkin has quit IRC | 11:06 | |
*** AlexeyAbashkin has joined #senlin | 11:23 | |
*** blkart has quit IRC | 11:38 | |
*** blkart has joined #senlin | 12:21 | |
*** chenyb4 has joined #senlin | 12:38 | |
openstackgerrit | Qiming Teng proposed openstack/python-senlinclient master: Add basic functional tests https://review.openstack.org/535188 | 12:43 |
openstackgerrit | Qiming Teng proposed openstack/senlin master: Fake driver for Octavia https://review.openstack.org/536758 | 12:45 |
Qiming | chenyb4, client functional test is ready | 12:47 |
chenyb4 | Qiming, ok, i see. thanks Qiming | 12:47 |
*** fabian_ has joined #senlin | 12:51 | |
*** fabian_ has quit IRC | 12:52 | |
*** zhurong has joined #senlin | 12:57 | |
Qiming | meeting started in #openstack-meeting | 13:01 |
*** zhurong has quit IRC | 13:14 | |
*** blkart has quit IRC | 13:21 | |
openstackgerrit | Qiming Teng proposed openstack/senlin master: Remove localization at db layer https://review.openstack.org/536721 | 13:31 |
*** xinhuili has joined #senlin | 13:33 | |
openstackgerrit | Merged openstack/senlin master: Fix devgate https://review.openstack.org/533108 | 14:02 |
openstackgerrit | Qiming Teng proposed openstack/senlin master: Remove localization at db layer https://review.openstack.org/536721 | 14:07 |
openstackgerrit | Qiming Teng proposed openstack/python-senlinclient master: Add basic functional tests https://review.openstack.org/535188 | 14:07 |
chenyb4 | Qiming, https://review.openstack.org/#/c/536758/ this patch should rebase | 14:13 |
openstackgerrit | Qiming Teng proposed openstack/senlin master: Fake driver for Octavia https://review.openstack.org/536758 | 14:13 |
Qiming | done | 14:14 |
*** xinhuili has quit IRC | 15:13 | |
*** chenyb4 has quit IRC | 15:14 | |
openstackgerrit | Merged openstack/python-senlinclient master: Refactored make_client https://review.openstack.org/536673 | 15:48 |
*** openstackgerrit has quit IRC | 16:03 | |
*** xinhuili has joined #senlin | 16:14 | |
*** xinhuili has quit IRC | 16:18 | |
*** AlexeyAbashkin has quit IRC | 17:02 | |
*** openstackgerrit has joined #senlin | 17:31 | |
*** ChanServ sets mode: +v openstackgerrit | 17:31 | |
openstackgerrit | Merged openstack/senlin master: Remove localization at db layer https://review.openstack.org/536721 | 17:31 |
*** xinhuili has joined #senlin | 17:45 | |
*** xinhuili has quit IRC | 17:50 | |
*** AlexeyAbashkin has joined #senlin | 18:31 | |
*** dtruong has quit IRC | 18:34 | |
*** AlexeyAbashkin has quit IRC | 18:35 | |
*** Jeffrey4l has quit IRC | 20:25 | |
*** Jeffrey4l has joined #senlin | 20:25 | |
*** xinhuili has joined #senlin | 20:46 | |
*** xinhuili has quit IRC | 20:50 | |
*** xinhuili has joined #senlin | 22:17 | |
*** xinhuili has quit IRC | 22:21 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!