openstackgerrit | Merged openstack/senlin-tempest-plugin master: Skip health policy tests that are failing https://review.openstack.org/609563 | 00:02 |
---|---|---|
*** longkb has joined #senlin | 00:33 | |
*** zigo has quit IRC | 02:29 | |
dtruong | Everyone, this is a reminder that we will be having the Senlin weekly meeting in about 20 minutes. | 05:08 |
dtruong | #startmeeting senlin | 05:30 |
openstack | Meeting started Fri Oct 12 05:30:56 2018 UTC and is due to finish in 60 minutes. The chair is dtruong. Information about MeetBot at http://wiki.debian.org/MeetBot. | 05:30 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 05:30 |
*** openstack changes topic to " (Meeting topic: senlin)" | 05:31 | |
openstack | The meeting name has been set to 'senlin' | 05:31 |
dtruong | it's time for senlin meeting | 05:31 |
dtruong | anyone here to join? | 05:31 |
Qiming | hi | 05:34 |
dtruong | hi qiming | 05:35 |
dtruong | ok, let's get started then. | 05:36 |
dtruong | #topic autoscaling forum in berlin | 05:36 |
*** openstack changes topic to "autoscaling forum in berlin (Meeting topic: senlin)" | 05:36 | |
dtruong | #link http://lists.openstack.org/pipermail/openstack-dev/2018-September/134770.html | 05:37 |
dtruong | Qiming: I saw your replies to the ML | 05:37 |
dtruong | do you have anything else to add on this topic? | 05:37 |
Qiming | If you mean something I want to stress again, I would say ... users first | 05:39 |
dtruong | yes, i agree with that 100% | 05:39 |
Qiming | If there are people who just want to find something to work on for a particular project or play games ... we can just ignore them | 05:40 |
dtruong | i think the important thing to recognize is that there are different types of users as well | 05:41 |
Qiming | yes | 05:41 |
dtruong | there are users of heat ASG or senlin. but then there is k8s users who want autoscaling but have different use cases | 05:42 |
Qiming | yep. I would vote for supporting the k8s use cases | 05:43 |
Qiming | a k8s cluster can live and scale happily on google cloud or aws, it would be desirable to have it better supported on openstack | 05:44 |
Qiming | again, at the end of the day, the community agenda should be driven by use cases | 05:46 |
dtruong | yes. but i think it is important to support the use cases of clustering or autoscaling with only openstack | 05:46 |
dtruong | that is the traditional scaling use case | 05:46 |
Qiming | if no one seems interested in running k8s on openstack, the above assumption won't be true | 05:46 |
Qiming | right | 05:46 |
Qiming | back to the proposed forum topic | 05:47 |
Qiming | IIUC, the key pain point from Heat team's perspective is that "there are existing users already doing autoscaling using ASG..." | 05:48 |
Qiming | a valid concern but they won't reinvent a new thing seriously, i guess | 05:49 |
dtruong | yes, so i proposed that you could potentially switch the Heat ASG implementation to use Senlin | 05:49 |
dtruong | and then slowly deprecate Heat ASG in favor of Senlin resource in Heat | 05:49 |
Qiming | exactly | 05:49 |
Qiming | long live Heat ASG resource type, but .... just kill the implementation | 05:50 |
dtruong | to me this follows what other openstack projects have done. | 05:50 |
dtruong | e.g. cinder split from nova-volume | 05:50 |
Qiming | if there are feature requirement to autoscaling, the requirements should be redirected to Senlin team | 05:50 |
dtruong | yes | 05:50 |
Qiming | Heat should only cares about orchestration, period | 05:51 |
dtruong | i think we are in agreement. so i'll discuss that proposal with the Heat team at the forum | 05:51 |
dtruong | ok, moving on to the next topic then | 05:52 |
dtruong | #topic blueprint status | 05:52 |
*** openstack changes topic to "blueprint status (Meeting topic: senlin)" | 05:52 | |
dtruong | fail-fast blueprint is implemented. waiting for more reviews. | 05:53 |
dtruong | multiple detection type implementation has been merged. | 05:53 |
dtruong | i need to add documentation and release notes. | 05:53 |
Qiming | cool | 05:53 |
dtruong | about the documentation, i thinking we should add a sphinx extension so that we can automatically generate docs for policy and profiles | 05:54 |
Qiming | could you please double check if the gate failures are real for #602460? | 05:54 |
dtruong | using the schema defined in the policy and profile | 05:54 |
Qiming | https://review.openstack.org/#/c/602460/ | 05:54 |
Qiming | that is a great idea | 05:55 |
dtruong | about the gate failure, the health policy tempest are broken | 05:55 |
dtruong | seems to be a timing issue | 05:55 |
dtruong | so i merged a patch to disable them for now | 05:55 |
Qiming | i see. that is the reason I didn't w+1 it | 05:55 |
dtruong | https://review.openstack.org/#/c/609563/ | 05:55 |
Qiming | understood | 05:55 |
dtruong | let me recheck #602460 to make sure that the failures are gone with my patchset to disable health policy tempest test | 05:56 |
dtruong | looks like you did already =) | 05:58 |
dtruong | going back to the sphinx extension, i want to extract the description in the schema for each field | 05:58 |
Qiming | impatient me | 05:59 |
dtruong | and build it into the docs | 05:59 |
dtruong | so that we don't have to change the docs every time the policy or profile changes | 05:59 |
Qiming | I have no idea how to do that, although I have the same requirement in a different project | 05:59 |
Qiming | ya, that would be awesome | 06:00 |
Qiming | my requirement is to generate web UIs from the class definition | 06:00 |
dtruong | it's new for me too. so i'm looking into it right now. mainly because i rather write code than documentation =P | 06:00 |
Qiming | great, looking forward to your findings | 06:01 |
XueFeng | That's great | 06:02 |
dtruong | hi xuefeng | 06:02 |
XueFeng | hi dtruong Qiming | 06:02 |
Qiming | you scared me XueFeng | 06:02 |
dtruong | sphinx has the ability to create your own extension so hopefully it won't be too difficult | 06:02 |
Qiming | suddenly showed up from nowhere | 06:03 |
XueFeng | Why? | 06:03 |
Qiming | em | 06:03 |
XueFeng | HAHA | 06:03 |
Qiming | so it is basically walking through the class field definitions and to extract the docstrings for those fields? | 06:04 |
dtruong | yes | 06:04 |
Qiming | that was my guess, but it looked to me not so straightforward how to get the doc string for a class field | 06:04 |
dtruong | actually, extract the description in the schema field | 06:04 |
dtruong | https://github.com/openstack/senlin/blob/master/senlin/policies/health_policy.py#L119 | 06:05 |
Qiming | okay ... that is a much easier job | 06:05 |
dtruong | sphinx can already get the docstring | 06:05 |
dtruong | that have something called autodoc built-in that extract docstring for classes and their attributes and members | 06:06 |
Qiming | em ... | 06:07 |
dtruong | but in our case that is not that useful because we keep the usage information inside the description string | 06:07 |
Qiming | like this line? http://git.openstack.org/cgit/openstack/openstacksdk/tree/openstack/clustering/v1/profile.py#n36 | 06:07 |
dtruong | yes, that would get extracted by sphinx | 06:07 |
Qiming | okay, maybe I should try dig into it again | 06:08 |
dtruong | but it's too generic for profile spec and policy spec | 06:08 |
dtruong | the policy spec is a dictionary with lots of parameters and the description string has the most useful information | 06:09 |
Qiming | indeed | 06:09 |
Qiming | the so called "doc" can be extracted from python variable/field values, that is making things a lot easier | 06:10 |
dtruong | yes | 06:10 |
Qiming | I'm looking for something that can help extract data from comments such as: | 06:11 |
Qiming | # max=1200,optional=true | 06:11 |
Qiming | repeatable | 06:12 |
Qiming | sorry, repeat_interval is more appropriate here | 06:12 |
Qiming | then by reading the source code I can generate a jsonschema for this particular field and even web form input for validation | 06:13 |
Qiming | or else I will have to do the schema definition again ... boring | 06:13 |
dtruong | if the comment is formatted with the #: then sphinx can extract using autoattribute | 06:15 |
dtruong | http://www.sphinx-doc.org/en/master/usage/extensions/autodoc.html#directive-autoattribute | 06:15 |
Qiming | I see, there is the trick | 06:15 |
dtruong | so maybe you can reuse the autodoc implementation to generate a web form instead of a doc | 06:16 |
Qiming | em, worth a try | 06:16 |
dtruong | ok, let's move on | 06:18 |
dtruong | #topic stein community goals | 06:18 |
*** openstack changes topic to "stein community goals (Meeting topic: senlin)" | 06:18 | |
dtruong | no updates for python 3 goal or upgrade checkers goal | 06:19 |
dtruong | #topic reviews | 06:20 |
*** openstack changes topic to "reviews (Meeting topic: senlin)" | 06:20 | |
dtruong | i added functional tests for senlin in openstacksdk | 06:20 |
dtruong | #link https://review.openstack.org/#/c/607061/ | 06:20 |
dtruong | please review it when you have time | 06:20 |
Qiming | wow ... I still have w+1 privilege there ... | 06:21 |
dtruong | i only added the basic tests for senlin but that should be enough to detect any breaking change in openstacksdk that could affect senlin | 06:21 |
Qiming | I see | 06:22 |
dtruong | a good time to use that privilege =) | 06:22 |
Qiming | :D | 06:22 |
dtruong | #topic open discussion | 06:23 |
*** openstack changes topic to "open discussion (Meeting topic: senlin)" | 06:23 | |
dtruong | that's all i had an the agenda | 06:23 |
dtruong | anybody have anything else to discuss> | 06:23 |
dtruong | ? | 06:23 |
Qiming | no from me | 06:23 |
Qiming | XueFeng has vapored into thin air again | 06:24 |
dtruong | lol | 06:25 |
dtruong | ok, let's end the meeting then | 06:25 |
dtruong | thanks everyone for attending | 06:25 |
Qiming | thx | 06:25 |
dtruong | #endmeeting | 06:25 |
*** openstack changes topic to "IRCLog: http://eavesdrop.openstack.org/irclogs/%23senlin/ | Bugs: bugs.launchpad.net/senlin | Review: https://review.openstack.org/#/q/project:openstack/senlin,n,z" | 06:25 | |
openstack | Meeting ended Fri Oct 12 06:25:37 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 06:25 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/senlin/2018/senlin.2018-10-12-05.30.html | 06:25 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/senlin/2018/senlin.2018-10-12-05.30.txt | 06:25 |
openstack | Log: http://eavesdrop.openstack.org/meetings/senlin/2018/senlin.2018-10-12-05.30.log.html | 06:25 |
*** sam_wan has joined #senlin | 07:12 | |
*** sam_wan has left #senlin | 07:13 | |
*** zigo has joined #senlin | 08:36 | |
*** bno1 has quit IRC | 10:42 | |
*** bno1 has joined #senlin | 10:43 | |
*** longkb has quit IRC | 11:20 | |
*** jmlowe has quit IRC | 15:03 | |
*** jmlowe has joined #senlin | 15:18 | |
*** irclogbot_7 has joined #senlin | 16:35 | |
*** irclogbot_7 has quit IRC | 16:42 | |
*** jmlowe has quit IRC | 19:12 | |
*** jmlowe has joined #senlin | 23:18 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!