| *** sapd1 has joined #senlin | 00:30 | |
| *** sapd1 has quit IRC | 01:02 | |
| *** jmlowe has joined #senlin | 01:32 | |
| *** jmlowe has quit IRC | 02:10 | |
| *** jmlowe has joined #senlin | 16:30 | |
| rm_work | hmmm another one this morning: | 17:32 |
|---|---|---|
| rm_work | http://paste.openstack.org/show/7vHtseUVooETndpUu0YL/ | 17:35 |
| rm_work | i added a debug line to dump server_dara to see what's actually in there | 17:41 |
| rm_work | *server_data | 17:41 |
| rm_work | wtf | 17:57 |
| rm_work | flavor has no `id` | 17:57 |
| rm_work | eandersson: ^^ | 17:57 |
| rm_work | http://paste.openstack.org/show/r1QEejUbETzT0b3mtJ34/ | 18:00 |
| dtruong | He fixed that here: https://review.opendev.org/#/c/696767/ | 18:09 |
| rm_work | ahh ok... uhh | 18:10 |
| rm_work | so master is broken ATM? | 18:11 |
| rm_work | I'm not sure i get how this passed gates if it's an issue? | 18:11 |
| dtruong | I just workflowed that fix. | 18:12 |
| dtruong | So should be in master later today. | 18:12 |
| rm_work | ok | 18:12 |
| rm_work | just, it concerns me that an issue like this could get through gates? | 18:12 |
| rm_work | because we're deploying master senlin directly into envs | 18:13 |
| dtruong | We probably don't have an integration test case for that | 18:13 |
| rm_work | it won't get to prod because our QE pipelines won't promote it since our own testing fails, but | 18:13 |
| rm_work | then our pipelines are blocked and i come here and am sad, lol | 18:13 |
| rm_work | I am just curious what your estimation of the stability of the repo is, with regards to testing and such | 18:14 |
| dtruong | Integration tests are definitely the weakest link. | 18:28 |
| dtruong | Our integration tests were non-voting, so we missed some failures like this one where the flavor id broke, | 18:29 |
| rm_work | there isn't a devstack-based test that actually spins up a cluster with nodes? | 18:29 |
| rm_work | ah | 18:29 |
| rm_work | ok so it exists but is just non-voting | 18:29 |
| dtruong | Yea. | 18:29 |
| rm_work | is that job unstable? | 18:29 |
| rm_work | like, when there isn't a real issue obviously | 18:30 |
| dtruong | It was. There was a race condition that made it fail intermittently. | 18:30 |
| eandersson | I spent all weekend fixing making it votable again btw! It' | 18:30 |
| rm_work | eandersson: \o/ | 18:30 |
| rm_work | thanks | 18:30 |
| eandersson | s just a lot of patches that needs to be merged | 18:30 |
| eandersson | but we are getting close | 18:30 |
| rm_work | looking forward to that | 18:30 |
| rm_work | anything else you're aware of on master that would cause me issues? | 18:31 |
| dtruong | Yea, so I'll go thru the open patch sets today and work flow them. | 18:31 |
| dtruong | Not that I know of | 18:34 |
| rm_work | ok | 18:39 |
| rm_work | if that patch lands and is the only remaining issue, we may win "first to production" :D | 18:39 |
| rm_work | not sure if that's good or not, lol | 18:39 |
| eandersson | We are in PROD btw but with a slightly older version | 18:45 |
| eandersson | So you'll be first in PROD with Train and/or master :p | 18:46 |
| *** openstackgerrit has joined #senlin | 19:04 | |
| *** ChanServ sets mode: +v openstackgerrit | 19:04 | |
| openstackgerrit | Merged openstack/senlin master: Make sure we always populate flavor_id https://review.opendev.org/696767 | 19:04 |
| rm_work | yep | 19:25 |
| rm_work | kicked the build pipeline now | 19:25 |
| rm_work | if it goes well, it'll be in prod in a few hours | 19:25 |
| rm_work | has to build/test the venv, deploy to qe -> smoketest -> staging -> smoketest -> prod | 19:26 |
| openstackgerrit | Merged openstack/senlin-dashboard master: Imported Translations from Zanata https://review.opendev.org/694475 | 20:06 |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/senlin-tempest-plugin master: Always clean up nodes and cluster https://review.opendev.org/696768 | 21:22 |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/senlin-tempest-plugin master: Always clean up nodes and cluster https://review.opendev.org/696768 | 21:37 |
| openstackgerrit | Merged openstack/senlin-tempest-plugin master: Always clean up nodes and cluster https://review.opendev.org/696768 | 22:18 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!