| openstackgerrit | hamza proposed openstack/senlin master: Adding certfile/keyfile to authentication https://review.opendev.org/c/openstack/senlin/+/768371 | 01:42 |
|---|---|---|
| openstackgerrit | hamza proposed openstack/senlin master: Adding certfile/keyfile to authentication https://review.opendev.org/c/openstack/senlin/+/768371 | 01:59 |
| *** spatel has joined #senlin | 03:19 | |
| *** sapd1 has joined #senlin | 03:54 | |
| *** sapd1 has quit IRC | 04:00 | |
| *** sapd1 has joined #senlin | 04:18 | |
| spatel | Thank dtruong, let me try that | 04:24 |
| openstackgerrit | Satish Patel proposed openstack/senlin master: Add flavor_id property to Load-Balancing Policy https://review.opendev.org/c/openstack/senlin/+/768296 | 05:14 |
| openstackgerrit | Satish Patel proposed openstack/senlin master: Add flavor_id property to Load-Balancing Policy https://review.opendev.org/c/openstack/senlin/+/768296 | 05:25 |
| spatel | dtruong: It works, POC - http://paste.openstack.org/show/801468/ | 05:25 |
| spatel | FYI, I have removed ignore_missing variable from flavor_get definition in drivers/os/octavia_v2.py because i got getting this error around that variable - http://paste.openstack.org/show/801469/ | 05:29 |
| *** sapd1 has quit IRC | 05:42 | |
| *** spatel has quit IRC | 06:54 | |
| *** spatel has joined #senlin | 10:57 | |
| *** spatel has quit IRC | 11:02 | |
| *** irclogbot_1 has quit IRC | 14:09 | |
| *** irclogbot_2 has joined #senlin | 14:13 | |
| *** spatel has joined #senlin | 14:18 | |
| openstackgerrit | Hervé Beraud proposed openstack/senlin-tempest-plugin master: Add doc/requirements https://review.opendev.org/c/openstack/senlin-tempest-plugin/+/769780 | 16:02 |
| *** sapd1 has joined #senlin | 16:11 | |
| *** sapd1 has quit IRC | 16:28 | |
| *** sapd1 has joined #senlin | 16:45 | |
| spatel | dtruong: morning | 17:10 |
| openstackgerrit | Satish Patel proposed openstack/senlin master: Add flavor_id property to Load-Balancing Policy https://review.opendev.org/c/openstack/senlin/+/768296 | 17:20 |
| dtruong | morning | 17:29 |
| spatel | dtruong: i made change according, just verify, I didn't user ignore_missing variable though - https://review.opendev.org/c/openstack/senlin/+/768296/13/senlin/drivers/os/octavia_v2.py#180 | 17:33 |
| dtruong | oh, in order to use ignore_missing you need to call find_flavor instead of get_flavor | 17:37 |
| dtruong | https://github.com/openstack/openstacksdk/blob/master/openstack/load_balancer/v2/_proxy.py#L933 | 17:37 |
| spatel | what is the difference doing it find instead of get ? | 17:38 |
| spatel | if find_flavor is good choice then i can change it to "find_flavor" dtruong | 17:41 |
| dtruong | the only difference is that find_flavor allows you to pass in the ignore_missing | 17:43 |
| dtruong | since the other functions are using find as well, we should use it for flavor too to keep consistent | 17:44 |
| spatel | dtruong: okay that make sense let me change it to find | 17:44 |
| spatel | dtruong: how about this - http://paste.openstack.org/show/801488/ | 17:52 |
| spatel | I have verified and it works | 17:52 |
| spatel | going to commit if no objection | 17:53 |
| spatel | also i have changed lb_policy.py with oc.find_flavor(flavor_id) | 17:53 |
| dtruong | sounds good | 18:05 |
| spatel | Thanks | 18:05 |
| openstackgerrit | Satish Patel proposed openstack/senlin master: Add flavor_id property to Load-Balancing Policy https://review.opendev.org/c/openstack/senlin/+/768296 | 18:12 |
| spatel | dtruong: do you think these changes can be part of victoria ? | 18:22 |
| dtruong | Victoria was already released in Oct 2020. | 18:30 |
| dtruong | They can be part of Wallaby release | 18:30 |
| spatel | oh! i need to cherry pick them for my environment :) | 18:32 |
| spatel | Assuming soon we can merge them to master so i can start playing in lab (without hacking) | 18:33 |
| *** hamalq has joined #senlin | 20:11 | |
| *** noonedeadpunk has quit IRC | 21:47 | |
| *** noonedeadpunk has joined #senlin | 21:48 | |
| *** spatel has quit IRC | 23:07 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!