*** hamalq has quit IRC | 00:41 | |
*** spatel has joined #senlin | 03:03 | |
*** spatel has quit IRC | 03:22 | |
*** __ministry has quit IRC | 08:07 | |
*** __ministry has joined #senlin | 08:08 | |
*** spatel has joined #senlin | 14:24 | |
spatel | dtruong morning | 14:53 |
---|---|---|
spatel | If i set only type: SOURCE_IP in policy file then COOKIE_NAME getting set to none and that causing issue, its successfully building pool but session showing none (that means it doesn't work) | 14:57 |
spatel | for experiment i hack code and removed COOKIE_NAME completely from code lb_policy.py and then build pool and it works with SOURCE_IP | 14:58 |
spatel | In short when we passing SOURCE_IP then we should set COOKIE_NAME otherwise it won't work. | 14:58 |
*** spatel has quit IRC | 15:00 | |
*** spatel has joined #senlin | 15:02 | |
*** openstackgerrit has quit IRC | 15:35 | |
dtruong | spatel morning | 16:35 |
dtruong | ok, then we should add a check before calling pool create at https://github.com/openstack/senlin/blob/master/senlin/drivers/os/lbaas.py#L160 and only set cookie_name if it is not None. Same way we do here: https://github.com/openstack/senlin/blob/master/senlin/drivers/os/octavia_v2.py#L47 | 16:47 |
spatel | hey! sorry i was in meeting, now i am here | 17:36 |
spatel | dtruong ^ | 17:36 |
spatel | Let me try and play with that condition logic. but don't you think it would be great if we have that logic here, i am not expert in python schema but it would be easy if it allow - https://opendev.org/openstack/senlin/src/branch/master/senlin/policies/lb_policy.py#L183 | 17:38 |
spatel | If type: not APP_COOKIE then ignore COOKIE_NAME something like that. | 17:39 |
spatel | Let me play with octavia_v2.py also to see if that is easy or not | 17:40 |
*** hamalq has joined #senlin | 18:38 | |
spatel | dtruong how do i extract type value from this session_persistence': {'type': 'SOURCE_IP', 'cookie_name': None} | 20:22 |
*** spatel has quit IRC | 20:25 | |
dtruong | it's a dictionary so you should be able to do session_presistence['type'] | 21:03 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!