| noonedeadpunk | hey folks! We're seing an upgrade error after migration to alembic | 08:40 |
|---|---|---|
| noonedeadpunk | #link https://opendev.org/openstack/senlin/commit/18540721f4dd4741dce8e914446bfca19da8a334 | 08:40 |
| noonedeadpunk | So alembic basically tries to apply all migrations from the beggining and obviously fails | 08:41 |
| noonedeadpunk | https://paste.openstack.org/show/be46cwMZH7KBMrsken5B/ | 08:41 |
| noonedeadpunk | eandersson: since you're the one who made a patch andhopefully most aware of the topic, will ping you explicitly :) | 08:43 |
| noonedeadpunk | I kinda see `is_migration_needed` among legacy_utils, that likely should have been used to cover that, but I don't think it's ever used? | 09:09 |
| noonedeadpunk | ah, ok I see it's used in migrations... | 09:09 |
| noonedeadpunk | weird, https://paste.openstack.org/show/bNVYuJ9jFivXtQAGluGX/ | 09:12 |
| noonedeadpunk | Well, metadata is completely empty here: https://opendev.org/openstack/senlin/src/branch/master/senlin/db/sqlalchemy/alembic/legacy_utils.py#L28 | 09:18 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/senlin master: Do not use deperecated MetaData.bind https://review.opendev.org/c/openstack/senlin/+/892487 | 09:53 |
| noonedeadpunk | this should fix it ^ | 09:53 |
| * noonedeadpunk testing if this will fix our upgrade jobs in https://review.opendev.org/c/openstack/openstack-ansible-os_senlin/+/890131 as well | 09:55 | |
| eandersson | Thanks. I'll try to take a look later today/ | 10:54 |
| eandersson | noonedeadpunk: Thanks. We are fixing it for Designate as well (as I copied the code from there lol) | 14:37 |
| eandersson | https://review.opendev.org/c/openstack/designate/+/892543 | 14:37 |
| noonedeadpunk | eandersson: to have that said - it also failed with 1.4 for me | 14:40 |
| eandersson | Interesting | 14:44 |
| noonedeadpunk | https://paste.openstack.org/show/bjGeUYTvmccNWwZF6kEh/ | 14:48 |
| noonedeadpunk | and that's pip freeze https://paste.openstack.org/show/bqXJDwfvnNClhcrL7Fvw/ | 14:48 |
| noonedeadpunk | but given it also allows to get rid of using deprecated approach - it's win-win:) | 14:51 |
| noonedeadpunk | what is even more interesting, is that we don't catch same error with same pip freeze for designate | 14:53 |
| noonedeadpunk | so likely root cause is somewhere else... | 14:55 |
| eandersson | 100% win-win! | 15:11 |
| eandersson | And 200% win-win as this is now fixed in both Designate and Senlin :D | 15:11 |
| eandersson | We were able to reproduce it there as well | 15:11 |
| noonedeadpunk | ah, ok then | 15:18 |
| noonedeadpunk | that is sweet indeed then | 15:18 |
| -opendevstatus- NOTICE: Gerrit is going to be restarted to pick up a small config update. You will notice a short outage of the service. | 15:34 | |
| opendevreview | Merged openstack/senlin master: Do not use deperecated MetaData.bind https://review.opendev.org/c/openstack/senlin/+/892487 | 16:06 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!