| *** yassine has quit IRC | 00:12 | |
| *** nhicher has quit IRC | 00:12 | |
| *** logan- has quit IRC | 00:12 | |
| *** gundalow has quit IRC | 00:12 | |
| *** pabelanger has quit IRC | 00:12 | |
| *** EmilienM has quit IRC | 00:12 | |
| *** migi has quit IRC | 00:12 | |
| *** sbadia has quit IRC | 00:12 | |
| *** ChanServ has quit IRC | 00:12 | |
| *** ChanServ has joined #softwarefactory | 00:13 | |
| *** sbadia has joined #softwarefactory | 00:13 | |
| *** EmilienM has joined #softwarefactory | 00:13 | |
| *** pabelanger has joined #softwarefactory | 00:13 | |
| *** migi has joined #softwarefactory | 00:13 | |
| *** gundalow has joined #softwarefactory | 00:13 | |
| *** barjavel.freenode.net sets mode: +o ChanServ | 00:13 | |
| tristanC | gundalow: pabelanger: let's try to make unit test works in containers first, there is f27-oci labels with all python version from 2.7 to 3.6 | 00:36 |
|---|---|---|
| *** yassine has joined #softwarefactory | 01:28 | |
| *** nhicher has joined #softwarefactory | 01:28 | |
| *** logan- has joined #softwarefactory | 01:28 | |
| *** yassine has quit IRC | 03:07 | |
| *** yassine has joined #softwarefactory | 03:08 | |
| *** caowei has joined #softwarefactory | 03:35 | |
| *** flepied has joined #softwarefactory | 06:31 | |
| *** flepied has quit IRC | 06:35 | |
| tristanC | gundalow: pabelanger: ok i reproduced the "pr merged without approval" issue, for some reason, zuul added the pr to the gate pipeline after a new commit is added to the pr | 06:52 |
| tristanC | now onto debugging the gate pipeline require and trigger filter to understand why this happened | 06:53 |
| tristanC | this should fixes the issue: https://github.com/ansible-network/zuul-config/pull/14 | 07:29 |
| gundalow | tristanC: Cool. Is this just a work around? That feels like something that should be built into Zuul's GitHub code. | 07:45 |
| gundalow | (merged) | 07:46 |
| gundalow | And I merged the revert | 07:46 |
| gundalow | Thanks for looking into this so quickly :) | 07:47 |
| tristanC | gundalow: well the gate pipeline definition was incorrect, the "trigger" list are not ANDed, so requirements needs to be in the "require" section | 08:15 |
| gundalow | Ah, I see | 08:19 |
| gundalow | Thanks | 08:19 |
| gundalow | Enjoy your weekend | 08:19 |
| tristanC | i haven't been able to test the require myself as github doesn't let me approve my own pr, i'm waiting for fbo to do more tests on https://github.com/ZuulTestOrg/GithuhGate/pull/1 | 08:20 |
| tristanC | though the "type: approve" should prevent further pr to be merged right after a check success | 08:21 |
| sfbender | Fabien Boucher created software-factory/sf-docs master: zuul github setup doc fix webhook path + acl required https://softwarefactory-project.io/r/11732 | 09:04 |
| tristanC | gundalow: we'll need to update the github application permission to read repository administration, otherwise the exclude-unprotected-branches option doesn't work | 09:28 |
| tristanC | can you please access the new permission in your org installation? | 09:28 |
| tristanC | in the "configure" page, it will say "softwarefactory-project-zuul is requesting different permissions" | 09:29 |
| tristanC | you need to click "detail" and "accept" | 09:30 |
| gundalow | New: Read-only access to Repository administration | 09:50 |
| gundalow | Done | 09:50 |
| fbo_ | Thanks we'll validate by reloading the scheduler conf | 09:52 |
| *** maeca has quit IRC | 09:55 | |
| tristanC | gundalow: also we found out that github doesn't remove approved review when new commit are added to a PR | 10:07 |
| tristanC | gundalow: it seems like the solution is to add a label requirement in the gate pipeline, and we can make zuul remove the label when the check pipeline start | 10:07 |
| tristanC | gundalow: would you like to enforce a "shipit" label? or maybe a "zuulit" ? :-) | 10:08 |
| *** caowei has quit IRC | 10:41 | |
| sfbender | Tristan de Cacqueray created software-factory/sf-config master: zuul: add github gate, post and release pipeline auto-configuration https://softwarefactory-project.io/r/11733 | 10:58 |
| tristanC | fbo_: the github gate pipeline integration in sf-config ^ | 10:58 |
| fbo_ | tristanC: thanks I'll have a look. | 11:08 |
| *** yassine has quit IRC | 11:49 | |
| *** yassine has joined #softwarefactory | 11:54 | |
| *** nijaba has quit IRC | 12:31 | |
| *** nijaba has joined #softwarefactory | 12:45 | |
| sfbender | Tristan de Cacqueray created software-factory/sf-ci master: provisioner: debug user lists https://softwarefactory-project.io/r/11734 | 13:21 |
| *** dsariel has joined #softwarefactory | 14:07 | |
| *** dsariel has quit IRC | 14:55 | |
| *** dsariel has joined #softwarefactory | 15:10 | |
| *** dsariel has quit IRC | 15:45 | |
| *** yassine has quit IRC | 16:14 | |
| *** EmilienM has quit IRC | 17:58 | |
| *** sbadia has quit IRC | 18:21 | |
| *** sbadia has joined #softwarefactory | 18:26 | |
| *** ChanServ sets mode: +o sbadia | 18:26 | |
| *** yassine has joined #softwarefactory | 21:14 | |
| *** yassine has quit IRC | 22:00 | |
| *** dsariel has joined #softwarefactory | 22:26 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!