| tristanC | gundalow: don't see any odd in scheduler logs... perhaps it didn't get the branch-protection event? I'll reload it and redeliver the event | 02:00 |
|---|---|---|
| gundalow | tristanC: oh, branch-protection is delivered as an event, rather than checking each time. The branch was created and used *before* branch-protection was enabled. Annoyingly you don't seem to be able to set default permissions for new branches in GitHub | 02:02 |
| gundalow | Thanks :) | 02:02 |
| tristanC | maybe the application is missing a permission to get the event? | 02:05 |
| tristanC | gundalow: do you remember when you added the branch-protection? | 02:05 |
| tristanC | there, zuul is now running the PR after the reload | 02:07 |
| tristanC | (after redelivering the 'recheck' comment event) | 02:07 |
| gundalow | ~4 hours ago, comment on https://github.com/ansible-network/network-engine/pull/107 | 02:07 |
| gundalow | tristanC: Excellent, thank you | 02:07 |
| gundalow | Is there something I need to do differently when creating branches? | 02:08 |
| tristanC | gundalow: oh well it seems like the app is missing a permission, i can't find the event in the deliveries history | 02:14 |
| tristanC | well i wonder if we need to subscribe to the Repository events | 02:20 |
| tristanC | gundalow: we'll do some test with fbo and get back to you, if that's a missing subscription you'll may have to accept the app new permission | 02:21 |
| gundalow | tristanC: Sounds like a plan. I guess the GitHub integration is still fairly new, so it's expected that we might trip over a few things, and that's fine. | 02:30 |
| tristanC | gundalow: thank you for your understanding | 02:31 |
| gundalow | Thanks to all the team for the support :) | 02:32 |
| trishnag | tristanC: Hi | 03:35 |
| tristanC | trishnag: hey! | 03:35 |
| trishnag | I noticed this for https://github.com/ansible-network/network-engine/pull/106 also like gundalow said | 03:35 |
| trishnag | zuul only started running gate after I added recheck in the comment. it wasn't running gate before I added recheck. | 03:36 |
| trishnag | I am guessing it will be similar for the PR #107 that John mentioned. | 03:37 |
| tristanC | let me check logs, it should trigger the gate pipeline once you complete those requirements: https://github.com/ansible-network/zuul-config/blob/master/zuul.d/pipelines.yaml#L44 | 03:39 |
| trishnag | tristanC: does the order matter here? | 03:40 |
| tristanC | not it should not, those are AND condition | 03:41 |
| tristanC | in logs we have: DEBUG zuul.Pipeline.ansible-network.gate: Change <Change 0x7fd121a47128 107,eca9a9b7235414ed64baf633b15018b1d5c8e669> does not match pipeline requirement <GithubRefFilter connection_name: github.com statuses: softwarefactory-project-zuul\[bot\]:ansible-network/check:success required-reviews: [{'type': 'approved', 'permission': 'write'}] open: True current-patchset: True labels: | 03:41 |
| trishnag | it looks like it is waiting for check after approval and mergeit label. | 03:41 |
| tristanC | ['mergeit']> | 03:41 |
| tristanC | unfortunately, GithubRefFilter needs to be more verbose so that we can know why it didn't match | 03:42 |
| trishnag | ack | 03:43 |
| trishnag | Thanks | 03:43 |
| trishnag | hmm #107 is running gate after a recheck | 03:45 |
| trishnag | I will wait for gundalow to look into it. he has gone afk now. | 03:45 |
| tristanC | the 'labeled' event got delivered, but zuul doesn't seems to have processed the event | 03:46 |
| tristanC | the last log was 2018-07-05 03:14:33,714 DEBUG zuul.Scheduler: Processing trigger event <GithubTriggerEvent 0x7fd121109588 pull_request labeled github.com/ansible-network/network-engine 106,c304569046d95b68ca31d2c04f1c1f1c58454757 delivery: 889aa940-8001-11e8-9dcd-0b63d1fbd0b4> | 03:46 |
| tristanC | and nothing after... iirc openstack-infra also notice event not being processed | 03:47 |
| tristanC | i'll look into adding more debug and checking with #zuul | 03:47 |
| trishnag | Thanks very much :) | 03:47 |
| gundalow | tristanC: trishnag thanks! | 03:47 |
| gundalow | If there is something we can do to help test then let us know. | 03:48 |
| gundalow | One off, or putting some testing framework together | 03:49 |
| tristanC | that's fine, we'll try to reproduce using a test zuul, i think we need to add some debug statement to https://git.zuul-ci.org/cgit/zuul/tree/zuul/driver/github/githubmodel.py#n205 matches method | 03:51 |
| tristanC | and do some tracing of the GithubTriggerEvent, so it's better if we don't do that on the production :) | 03:51 |
| gundalow | :D | 03:53 |
| tristanC | rcarrillocruz: we rebuilt every executors and mergers to be running on SSDs, this should help fix the retry_limit issue. Please let us know if it happens again. | 04:19 |
| sfbender | Merged software-factory/managesf master: managesf/configuration/repoxplorer: Fix in case tenant does not have default-connection https://softwarefactory-project.io/r/12878 | 04:45 |
| sfbender | Merged software-factory/managesf master: managesf/configuration: handle the private attribute https://softwarefactory-project.io/r/12879 | 05:57 |
| *** Guest38444 has quit IRC | 05:57 | |
| *** nchakrab has joined #softwarefactory | 06:20 | |
| sfbender | Tristan de Cacqueray created software-factory/sf-config master: nodepool: remove legacy logging configuration files https://softwarefactory-project.io/r/12886 | 06:51 |
| rcarrillocruz | Cool, will let you know | 06:57 |
| *** jpena|off is now known as jpena | 07:05 | |
| *** Guest38444 has joined #softwarefactory | 07:38 | |
| sfbender | Tristan de Cacqueray created software-factory/sfinfo master: Add stable info file for release sf-3.1 https://softwarefactory-project.io/r/12887 | 08:08 |
| sfbender | Merged software-factory/sfinfo master: Add stable info file for release sf-3.1 https://softwarefactory-project.io/r/12887 | 08:10 |
| rcarrillocruz | tristanC: seems much faster, i'm seeing jobs transitioning from queued to running quicker | 08:52 |
| *** jangutter_ has joined #softwarefactory | 09:01 | |
| *** jangutter_ has quit IRC | 09:02 | |
| *** jangutter has quit IRC | 09:03 | |
| *** jangutter has joined #softwarefactory | 09:03 | |
| *** jangutter_ has joined #softwarefactory | 09:28 | |
| *** jangutter_ has quit IRC | 09:29 | |
| *** jangutter has quit IRC | 09:29 | |
| *** jangutter_ has joined #softwarefactory | 09:29 | |
| *** jangutter_ has quit IRC | 09:38 | |
| *** jangutter has joined #softwarefactory | 09:38 | |
| sfbender | Merged software-factory/sf-config master: nodepool: remove legacy logging configuration files https://softwarefactory-project.io/r/12886 | 10:01 |
| *** nijaba has quit IRC | 10:14 | |
| *** nijaba has joined #softwarefactory | 10:32 | |
| *** apevec has joined #softwarefactory | 10:37 | |
| *** apevec has joined #softwarefactory | 10:37 | |
| *** jpena is now known as jpena|lunch | 11:05 | |
| sfbender | Merged software-factory/sf-config master: cgit and hound config + welcome.js: take care of the private attribute https://softwarefactory-project.io/r/12880 | 12:07 |
| *** nchakrab has quit IRC | 12:23 | |
| *** nchakrab has joined #softwarefactory | 12:24 | |
| *** nchakrab_ has joined #softwarefactory | 12:31 | |
| *** nchakrab has quit IRC | 12:35 | |
| sfbender | Merged software-factory/sf-config master: Add executor HDD usage to zuul-status graph https://softwarefactory-project.io/r/12863 | 13:23 |
| *** jpena|lunch is now known as jpena | 13:28 | |
| *** nchakrab_ has quit IRC | 13:30 | |
| *** nchakrab has joined #softwarefactory | 13:31 | |
| *** caphrim007 has quit IRC | 14:00 | |
| *** nchakrab has quit IRC | 14:07 | |
| *** nchakrab has joined #softwarefactory | 14:46 | |
| *** nchakrab_ has joined #softwarefactory | 14:47 | |
| *** nchakrab has quit IRC | 14:51 | |
| *** nchakrab_ has quit IRC | 15:30 | |
| *** caphrim007 has joined #softwarefactory | 15:58 | |
| *** Guest38444 has quit IRC | 16:13 | |
| *** jpena is now known as jpena|off | 17:24 | |
| gundalow | https://softwarefactory-project.io/docs/zuul/admin/drivers/github.html talks about adding a webhook or creating an application. In ansible-network's "Installed GitHub Apps" I see "softwarefactory-project-zuul", though I don't see that listed in https://github.com/organizations/ansible-network/settings/apps (my apps), is their a global all that I can install now? Rather than have to create a custom GH app per GH Org? | 18:54 |
| pabelanger | gundalow: you add https://github.com/apps/softwarefactory-project-zuul to all the projects you want to zuul to have access too | 18:59 |
| pabelanger | that is the global configuration | 18:59 |
| gundalow | pabelanger: Ace, thanks that's what I was after | 19:03 |
| *** sfbender has quit IRC | 20:27 | |
| *** apevec has quit IRC | 22:02 | |
| gundalow | Where is the source for https://softwarefactory-project.io/docs/zuul/admin/drivers/github.html I'll raise a PR to detail how to use the GH App (rather than rolling your own) | 22:46 |
| tristanC | gundalow: that would be http://git.zuul-ci.org/cgit/zuul/tree/doc/source/admin/drivers/github.rst | 22:53 |
| tristanC | so git clone zuul source and use git-review to submit change | 22:53 |
| *** caphrim007 has quit IRC | 22:57 | |
| gundalow | Thanks :) | 23:02 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!