*** sshnaidm|afk is now known as sshnaidm | 06:48 | |
*** dpawlik has joined #softwarefactory | 07:34 | |
*** apevec has joined #softwarefactory | 08:15 | |
*** jpena|off is now known as jpena | 08:52 | |
*** harrymichal has joined #softwarefactory | 09:12 | |
*** harrymichal has quit IRC | 09:36 | |
*** harrymichal has joined #softwarefactory | 09:38 | |
*** harrymichal has quit IRC | 09:48 | |
*** harrymichal has joined #softwarefactory | 09:58 | |
sfbender | Merged rdopkg master: Run coverage html generation during run job https://softwarefactory-project.io/r/17334 | 10:05 |
---|---|---|
*** electrofelix has joined #softwarefactory | 10:10 | |
sfbender | Merged rdopkg master: Sanitize req when parsing requirements.txt https://softwarefactory-project.io/r/17016 | 10:42 |
sfbender | Merged rdopkg master: Show additional pkgs present in spec file https://softwarefactory-project.io/r/17052 | 10:42 |
*** jpena is now known as jpena|lunch | 12:23 | |
*** jpena|lunch is now known as jpena | 13:20 | |
*** harrymichal has quit IRC | 14:34 | |
*** harrymichal has joined #softwarefactory | 14:34 | |
*** harrymichal has quit IRC | 14:36 | |
*** jpena is now known as jpena|brb | 16:45 | |
*** rfolco is now known as rfolco|bbl | 16:46 | |
*** jpena|brb is now known as jpena | 17:24 | |
*** electrofelix has quit IRC | 17:59 | |
*** jpena is now known as jpena|off | 18:32 | |
*** rfolco|bbl has quit IRC | 19:19 | |
adamw | tristanC: ahoy! around? | 20:04 |
adamw | tristanC: so i tried setting up os-autoinst-distri-fedora to run a real test via tox, but it's failing when it should pass. it looks like the test environment has some kind of bug in its tox setup - it seems to install python2 packages when it should be installing python3 ones | 20:15 |
adamw | https://fedora.softwarefactory-project.io/zuul/build/7bed71d680d6405d9f0de498f9ea3cd2 | 20:15 |
adamw | note the python2 deprecation warning, we should not see that if it was installing python3 packages as it should (note the env is 'py38') | 20:16 |
adamw | so i think maybe it installs a python2 jsonschema and that's why the test fails...' | 20:16 |
adamw | well, unless it's the ./fifloader.py invocation specifically that's the problem. hrm. | 20:17 |
*** rfolco has joined #softwarefactory | 20:24 | |
tristanC | adamw: looking | 20:27 |
adamw | tristanC: i'm twiddling around with tox.ini to see if i can get anything that works | 20:28 |
adamw | the tox.ini from the initial pull request does work when i run it here | 20:28 |
adamw | though i do have jsonschema installed systemwide here, which is a difference. | 20:28 |
adamw | hmm, got a different error this ime | 20:29 |
adamw | huh. can't import unittest...that's a core module, though... | 20:30 |
tristanC | adamw: perhaps adding 'install_command = pip install -U {opts} {packages}' to the [testenv] section would help? | 20:30 |
adamw | that ought to be the default | 20:31 |
adamw | https://fedora.softwarefactory-project.io/zuul/build/393f210afed24a8f9afd2561c6c34931 is the latest failure | 20:31 |
adamw | from unittest import mock | 20:32 |
adamw | E ImportError: cannot import name mock | 20:32 |
adamw | which is odd, because unittest.mock should be part of the core. | 20:32 |
tristanC | adamw: what about 'basepython = python3' in [testenv] section too? | 20:33 |
adamw | can try it... | 20:33 |
adamw | "tox allows setting the python version for an environment via the basepython setting. If that’s not set tox can set a default value from the environment name ( e.g. py37 implies Python 3.7)." | 20:33 |
adamw | what is the environment this is running in exactly? i couldn't find anything explaining that | 20:34 |
tristanC | my tox fu is a bit rusty, it seems like the job is running with py2 according to the 'py38 installed: DEPRECATION: Python 2.7 reached the end of its life on January 1st' error message | 20:34 |
adamw | yes, that was my inference too | 20:34 |
adamw | but i don't get why - it should be python3 everything if it's in the 'py38' env | 20:34 |
tristanC | oh, that is running in centos | 20:35 |
tristanC | adamw: you can see that by looking at the zuul-info/inventory.yaml file, e.g. https://fedora.softwarefactory-project.io/zuul/build/393f210afed24a8f9afd2561c6c34931/log/zuul-info/inventory.yaml | 20:35 |
adamw | aha | 20:35 |
adamw | centos...7? 8? | 20:36 |
tristanC | adamw: you could try using the `nodeset: fedora-31-vm` job attribute to use a fedora cloud based image instead | 20:36 |
tristanC | adamw: that's centos-7 | 20:36 |
adamw | that might help | 20:36 |
adamw | we might be on a really old tox here where 'py38' is not an env it understands at all, i guess | 20:37 |
adamw | so that would go in the -job bit of .zuul.yaml ? | 20:37 |
tristanC | yes, that seems like the issue, an old tox | 20:39 |
tristanC | adamw: cloud image might be too much for such tox job, i'm proposing new pod labels here: https://pagure.io/fedora-zuul-jobs/pull-request/29 | 20:41 |
adamw | cool | 20:41 |
tristanC | adamw: in any case, yes in the .zuul.yaml, in the job object you can add a nodeset attribute here: https://pagure.io/fedora-qa/os-autoinst-distri-fedora/blob/dfe5b99edd6e52b4d15aff29b2c80421c21c67a1/f/.zuul.yaml#_2 | 20:41 |
tristanC | adamw: and in https://pagure.io/fedora-qa/os-autoinst-distri-fedora/blob/6dd97792c25bda4cabbda30137f619db1e105414/f/ci/tox.yaml , you can add a 'include_role: {name: ensure-tox}' to setup tox | 20:43 |
adamw | aha, okay, thanks | 21:12 |
adamw | btw, the zuul 'failure' link points to https://sftests.com , which doesn't exist... | 21:12 |
adamw | the 'pending' link points to the right place | 21:12 |
*** dpawlik has quit IRC | 21:55 | |
tristanC | adamw: that's odd, where do you see sftests.com link? | 22:09 |
tristanC | oh, on the flags | 22:10 |
*** rfolco has quit IRC | 22:46 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!