| @jreed:matrix.org | Update - Am working on getting the core devs set the four of us, and we can go from there. | 13:37 |
|---|---|---|
| @jreed:matrix.org | fungi: Any docs on adding zuul to a repo? Searching doesn't really turn up much. I could always just start by copying what another repo is doing? | 13:40 |
| @jreed:matrix.org | Found this - https://docs.starlingx.io/contributor/development_process.html | 13:40 |
| @fungicide:matrix.org | jreed: from opendev's perspective, we have some rudimentary recommendations in the project creators guide: https://docs.opendev.org/opendev/infra-manual/latest/creators.html#add-jobs-for-project https://docs.opendev.org/opendev/infra-manual/latest/creators.html#zuul-best-practices but lots more detailed documentation is provided by the zuul maintainers: https://zuul-ci.org/docs/zuul/latest/config/project.html | 14:02 |
| @jreed:matrix.org | Thanks! Hard to know what's documented on opendev and what would be documented on starlingx. | 14:02 |
| @fungicide:matrix.org | yeah, i can't speak to what more starlingx-specific docs may exist on those topics, but you may want to look at the `.zuul.yaml` or `.zuul.d/*.yaml` files in other starlingx projects to see what they generally do | 14:04 |
| @jreed:matrix.org | will do. :) ty | 14:04 |
| @jreed:matrix.org | Core reviewers are fixed up, we can kinda move our own code along now. | 18:46 |
| @brunomuniz:matrix.org | Oh, yeah, noticed that from your review... can I `+2` and then `+1 workflow` my own code now (the .gitreview thing)? | 18:53 |
| @tcervi:matrix.org | It is not a good practice to review your own code, on any repo. For repos in which you are a core reviewer, the practice is to ask for others cores review when submitting changes | 18:55 |
| @brunomuniz:matrix.org | Yeah, that's my understanding. I was wondering if in this case we should be more pragmatic given the Review I'm talking about is technically still setting up the repo. | 18:59 |
| @jreed:matrix.org | core reviewers for the new repo can change as needed over time | 19:02 |
| @jreed:matrix.org | Is there a way to get this to merge? https://review.opendev.org/c/starlingx/app-gen-tool/+/899511 - Trying to add a .gitreview file so I can go back and add Zuul project files. | 20:41 |
| @jreed:matrix.org | brunomuniz: I guess you can't send Direct Messages without doing some sort of strange encryption/verification thing. | 20:53 |
| @jreed:matrix.org | Dude.. I can read your direct messages | 20:56 |
| @jreed:matrix.org | * I can read your direct messages | 20:56 |
| @brunomuniz:matrix.org | Ah, cool... no need for the dumb system I proposed, hahaha | 20:56 |
| @jreed:matrix.org | i don't know what the heck is up with this chat tool | 20:57 |
| @brunomuniz:matrix.org | Well, I've exchanged messages with other people... maybe they're also not verified? | 20:57 |
| @brunomuniz:matrix.org | And you're so I need to be verified to talk to you? | 20:57 |
| @jreed:matrix.org | in settings it says my desktop app is verified | 20:58 |
| @jreed:matrix.org | perhaps | 20:58 |
| @jreed:matrix.org | ... this works. | 20:58 |
| @jreed:matrix.org | Tried to add zuul to project. | 20:58 |
| @jreed:matrix.org | https://review.opendev.org/c/starlingx/app-gen-tool/+/899636 | 20:58 |
| @jreed:matrix.org | But the .gitreview you posted won't merge. Any ideas there? | 20:58 |
| @jreed:matrix.org | I think there are no zuul files so zuul can't "verify" the code review. | 20:59 |
| @brunomuniz:matrix.org | Well, it needs 2 `+2`, right? | 20:59 |
| @brunomuniz:matrix.org | It only has one. | 20:59 |
| @jreed:matrix.org | maybe. | 20:59 |
| @jreed:matrix.org | I'll go get igor to give it another +2 | 21:00 |
| @brunomuniz:matrix.org | Daniel won't be available until tomorrow | 21:00 |
| @jreed:matrix.org | i just made a temp file in my folder so I could submit my review | 21:01 |
| @jreed:matrix.org | Once I get zuul up and alive, I'll move on with reworking the whole smash as a python package, and getting it added to the manifest repo. | 21:01 |
| @fungicide:matrix.org | > <@jreed:matrix.org> Is there a way to get this to merge? https://review.opendev.org/c/starlingx/app-gen-tool/+/899511 - Trying to add a .gitreview file so I can go back and add Zuul project files. | 21:06 |
| once you add jobs to the check/gate pipelines it should work normally. minimally adding a noop-jobs template is the simplest way until you have jobs that actually do something: https://docs.opendev.org/opendev/infra-manual/latest/creators.html#add-jobs-for-project | ||
| @jreed:matrix.org | My review only needed another +2... my mistake | 21:06 |
| @jreed:matrix.org | Is it okay to have noop-jobs in the template section and make my own jobs below? | 21:08 |
| @jreed:matrix.org | like so? | 21:08 |
| @jreed:matrix.org | https://review.opendev.org/c/starlingx/app-gen-tool/+/899636/2/.zuul.yaml | 21:08 |
| @jreed:matrix.org | hang on... that links old | 21:08 |
| @fungicide:matrix.org | how many +2 votes it has doesn't really matter from a "will it merge" standpoint. basically you need a code review +1 and a workflow +1 and no code review -2 or workflow -1. also it can't be wip. but unless you have jobs (even if it's just noop jobs) nothing will happen when it gets approved | 21:08 |
| @jreed:matrix.org | patchset 4 is current | 21:08 |
| @jreed:matrix.org | https://review.opendev.org/c/starlingx/app-gen-tool/+/899636/4/.zuul.yaml | 21:08 |
| @fungicide:matrix.org | * how many +2 votes it has doesn't really matter from a "will it merge" standpoint. basically you need a code review +2 and a workflow +1 and no code review -2 or workflow -1. also it can't be wip. but unless you have jobs (even if it's just noop jobs) nothing will happen when it gets approved | 21:08 |
| @fungicide:matrix.org | right, you could do that. your .gitreview change isn't going to merge until that job addition change merges though | 21:09 |
| @jreed:matrix.org | The review already has one +2 and +1 Workflow though.... (i meant the .gitreview review) | 21:09 |
| @jreed:matrix.org | So zuul has to be there first... got it | 21:10 |
| @jreed:matrix.org | chicken in the egg problem | 21:10 |
| @fungicide:matrix.org | zuul won't merge anything unless there are jobs. adding the noop jobs is the easiest way to get things merging until you're ready to add your real jobs | 21:10 |
| @fungicide:matrix.org | you could put the .gitreview addition in your other change that's adding the jobs, and abandon the change that only has the .gitreview file | 21:10 |
| @fungicide:matrix.org | or you can just wait until the job addition change merges | 21:11 |
| @brunomuniz:matrix.org | Oh, ok, got it now! | 21:12 |
| @fungicide:matrix.org | not really a chicken-and-egg problem, just a question of what order you're doing things in | 21:12 |
| @jreed:matrix.org | it's a chicken-and-egg problem if you're not in the know :P | 21:12 |
| @jreed:matrix.org | we do appreciate the guidance. | 21:13 |
| @fungicide:matrix.org | my pleasure | 21:13 |
| @jreed:matrix.org | I really do try to RTFM but it doesn't always click. | 21:13 |
| @brunomuniz:matrix.org | I see you added the .gitreview file in your review, jreed , so I'll abandon mine. | 21:14 |
| @jreed:matrix.org | Perfect. was about to request you do so. | 21:14 |
| @fungicide:matrix.org | it's a very complex (but powerful) system, just reading the docs doesn't always convey basic principles like the pipelining and speculative execution zuul performs | 21:15 |
| @jreed:matrix.org | I put noop-jobs in there temporarily... can go take it back out later. I "borrowed" a .zuul.yaml from another repo. | 21:15 |
| @brunomuniz:matrix.org | I understand the thing about the zuul jobs regarding the merge, but still I believe we need 2 `+2`s and a `+1 workflow` to get things going, right? | 21:15 |
| But honestly I don't know where this info fits with everything now. | ||
| @jreed:matrix.org | TBH - I'm a Jenkins Fanboy XD | 21:15 |
| @jreed:matrix.org | Gitlab CI / GitHub actions may also be winning me over. | 21:16 |
| @fungicide:matrix.org | having more than one code review +2 is convention, but not enforced by any tooling. a single +2 (and workflow +1) is sufficient from zuul's perspective as long as your jobs also pass | 21:16 |
| @brunomuniz:matrix.org | hun, interesting... | 21:17 |
| @fungicide:matrix.org | https://zuul-ci.org/blog/#20200207a might be an interesting read from a jenkins perspective. it explains how we got to where we are from our prior use of jenkins (well, hudson initially) | 21:17 |
| @brunomuniz:matrix.org | So the requirement that we have for 2 `+2`s is not enforced, just a convention... which explains why always the second `+2` should be the one `+1 workflo`. | 21:18 |
| @fungicide:matrix.org | for a long time, zuul was an intelligent scheduler for jenkins jobs, and then a multi-master jenkins coordinator | 21:18 |
| @brunomuniz:matrix.org | * So the requirement that we have for 2 `+2`s is not enforced, just a convention... which explains why always the second `+2` should be the one `+1 workflow`. | 21:18 |
| @jreed:matrix.org | I remember when Jenkins was Hudson 😇 | 21:18 |
| @fungicide:matrix.org | around 7-ish years ago, we replaced jenkins with ansible as part of zuul's continued evolution | 21:19 |
| @jreed:matrix.org | brunomuniz: - Submitted another patchset. | 21:29 |
| @jreed:matrix.org | sorry for the spam | 21:29 |
| @jreed:matrix.org | I think my review can merge unless you want to give Daniel a chance to look at it. | 21:30 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!