| @jreed:matrix.org | fungi: | 17:49 |
|---|---|---|
| igorpsoares put this review out: | ||
| https://review.opendev.org/c/starlingx/nginx-ingress-controller-armada-app/+/907539?tab=change-view-tab-header-zuul-results-summary | ||
| Only one Zuul job ran out of the several that it has listed here: | ||
| https://opendev.org/starlingx/nginx-ingress-controller-armada-app/src/branch/master/.zuul.yaml | ||
| Has there been some change with the nodes that would cause the jobs not to run? | ||
| @fungicide:matrix.org | jreed: can you give me an example name of a job you expected to run on that change? zuul job definitions can include lists of filename patterns for what changes should and shouldn't trigger them. my guess is the jobs you expected to run are set to not run when only that metadata.yaml file is changed | 18:25 |
| @fungicide:matrix.org | but if in knew what job(s) you're asking about, i could look at their definitions to confirm that | 18:26 |
| @jreed:matrix.org | > <@fungicide:matrix.org> jreed: can you give me an example name of a job you expected to run on that change? zuul job definitions can include lists of filename patterns for what changes should and shouldn't trigger them. my guess is the jobs you expected to run are set to not run when only that metadata.yaml file is changed | 18:26 |
| Oh... that's not good. | ||
| @jreed:matrix.org | Um. I was expecting these to run as well: | 18:26 |
| - k8sapp-nginx-ingress-controller-tox-flake8 | ||
| - k8sapp-nginx-ingress-controller-tox-pylint | ||
| - k8sapp-nginx-ingress-controller-tox-metadata | ||
| - k8sapp-nginx-ingress-controller-tox-bandit | ||
| @fungicide:matrix.org | well, it's good when you have a project with 50 different jobs and you only want certain ones to be run for certain files | 18:26 |
| @jreed:matrix.org | i meant it's not good if the jobs aren't running when only metadata.yaml is changed. It should run in that case too. | 18:27 |
| @jreed:matrix.org | I really don't want to have to update zuul.yaml for all the apps again... | 18:27 |
| @fungicide:matrix.org | jreed: https://opendev.org/starlingx/nginx-ingress-controller-armada-app/src/branch/master/.zuul.yaml#L53-L54 | 18:28 |
| @jreed:matrix.org | i can see the file lives in a different folder than what it's expecting to check for. | 18:28 |
| @jreed:matrix.org | ... great | 18:28 |
| @fungicide:matrix.org | i recommend not using `files` or `irrelevant-files` filters in job definitions unless you know you really need them | 18:29 |
| @fungicide:matrix.org | more often than not, they lead to you scratching your head trying to figure out why some jobs you expected didn't run | 18:29 |
| @jreed:matrix.org | i just did the best I could with zippo experience with zuul. | 18:29 |
| @jreed:matrix.org | But I know what the issue is now. Thank you. | 18:30 |
| @fungicide:matrix.org | zuul's default, if there are no `files` or `irrelevant-files` lists for a job definition, is to run all jobs in the pipeline | 18:30 |
| @jreed:matrix.org | For all the starlingx app repos, the .zuul.yaml has a ```files``` entry for all the jobs. I made them all consistent at least. I should just be able to remove them. | 18:31 |
| @fungicide:matrix.org | so you don't technically need them, they're useful in cases where you really want to avoid running a particular job unless certain files changed or not when only certain files changed | 18:31 |
| @fungicide:matrix.org | but are best used sparingly | 18:32 |
| @jreed:matrix.org | yeah sure. I get you. | 18:32 |
| @jreed:matrix.org | thanks. | 18:32 |
| @fungicide:matrix.org | any time! | 18:33 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!