| @daniel.caires:matrix.org | Honestly.. I don't know much about wheels and was just following along a makefile that I had available. My initial intention was not to create this file, but to have the function do the packaging, but I didn't stop to study and make like I wanted | 11:09 |
|---|---|---|
| @brunomuniz:matrix.org | It's just a way of packaging and distributing python code, in my understanding. I don't know if StarlingX requires the plugin to be packaged in a wheel format or not, though. | 11:53 |
| @jreed:matrix.org | Okay. Cool. I see what your motivation was now. | 14:15 |
| @jreed:matrix.org | Can see the code review moving along. Perhaps after its merged, I'll take a pass at it. | 14:16 |
| @jreed:matrix.org | Just want to get it on the board to start with :) | 14:16 |
| @brunomuniz:matrix.org | Thanks for taking the time, jreed . This is important so we all can do things that bring value to the community. | 14:17 |
| @jreed:matrix.org | Yeppers! I posted on the review places where I had to tweak the code to make it work on my end. | 14:28 |
| @jreed:matrix.org | Hopefully this merges soon! | 14:28 |
| @igorpsoares:matrix.org | I've left a few comments on the review as well | 15:31 |
| @daniel.caires:matrix.org | Thank you everyone for the comments. I will address them and push the modifications in the review | 16:20 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!