| *** jcoufal has quit IRC | 00:29 | |
| *** openstackgerrit has quit IRC | 00:44 | |
| *** openstackgerrit has joined #storyboard | 00:44 | |
| krotscheck | Anyone familiar with what the syntax is to make a column default to a certain value, specifically a boolean? My migration's not doing what I think ti's doing. | 00:57 |
|---|---|---|
| krotscheck | op.add_column('projects', sa.Column('is_active', sa.Boolean(), default=True)) | 00:57 |
| *** cody-somerville has quit IRC | 01:02 | |
| *** jcoufal has joined #storyboard | 01:14 | |
| *** jcoufal has quit IRC | 01:15 | |
| mordred | krotscheck: ola! | 01:26 |
| krotscheck | mordred: ola! | 01:26 |
| krotscheck | mordred: I feel like I'm the only person in this channel. | 01:28 |
| mordred | krotscheck: yeah - it's a bit lonely | 01:29 |
| krotscheck | Except for the occasional person asking me when things are going to be done. | 01:29 |
| krotscheck | That's nice. | 01:29 |
| krotscheck | Makes me feel like people care. | 01:29 |
| mordred | krotscheck: well, we do - and we're sad we're not giving you more love | 01:30 |
| krotscheck | So you in town already, or are you flying in tomorrow? | 01:30 |
| mordred | krotscheck: wednesday | 01:32 |
| mordred | krotscheck: I'll be there in the morning | 01:32 |
| krotscheck | kk | 01:33 |
| krotscheck | How's TripleO? | 01:33 |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: [WIP] Added DELETE method for projects, stories, and tasks. https://review.openstack.org/77763 | 02:52 |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard-webclient: Enable story and project 'deletion' https://review.openstack.org/77764 | 02:54 |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard-webclient: Task, story, and project fixes https://review.openstack.org/77013 | 02:54 |
| *** krotscheck has quit IRC | 02:57 | |
| *** drdee has joined #storyboard | 03:50 | |
| *** drdee has quit IRC | 04:49 | |
| *** saju_m has joined #storyboard | 07:12 | |
| ttx | IS IT DONE YET | 08:21 |
| *** saju_m has quit IRC | 08:26 | |
| *** hashar has joined #storyboard | 08:36 | |
| openstackgerrit | Nikita Konovalov proposed a change to openstack-infra/storyboard: Auth Token Middleware https://review.openstack.org/74735 | 08:52 |
| *** saju_m has joined #storyboard | 09:41 | |
| openstackgerrit | Nikita Konovalov proposed a change to openstack-infra/storyboard: Auth Token Middleware https://review.openstack.org/74735 | 11:17 |
| *** hashar_ has joined #storyboard | 11:27 | |
| *** hashar has quit IRC | 11:27 | |
| openstackgerrit | Nikita Konovalov proposed a change to openstack-infra/storyboard: Add superuser check https://review.openstack.org/77859 | 11:36 |
| *** hashar_ has quit IRC | 11:53 | |
| *** miqui has joined #storyboard | 12:36 | |
| *** david-lyle has quit IRC | 12:39 | |
| *** saju_m has quit IRC | 12:40 | |
| *** hashar has joined #storyboard | 12:41 | |
| *** saju_m has joined #storyboard | 12:51 | |
| *** saju_m has quit IRC | 13:04 | |
| *** miqui_ has joined #storyboard | 13:15 | |
| *** miqui has quit IRC | 13:15 | |
| *** miqui_ is now known as miqui | 13:23 | |
| *** hashar has quit IRC | 13:51 | |
| *** hashar has joined #storyboard | 13:52 | |
| *** drdee has joined #storyboard | 13:57 | |
| openstackgerrit | Nikita Konovalov proposed a change to openstack-infra/storyboard: Load superusers from a yaml file https://review.openstack.org/77884 | 14:06 |
| openstackgerrit | Nikita Konovalov proposed a change to openstack-infra/storyboard: Fix session usage in db_api https://review.openstack.org/77885 | 14:09 |
| *** mfer has joined #storyboard | 14:36 | |
| *** david-lyle has joined #storyboard | 15:28 | |
| *** krotscheck has joined #storyboard | 16:56 | |
| ttx | krotscheck, NikitaKonovalov: sorry i don't have any review bandwidth as we are on feature freeze day and I herd cats | 16:57 |
| * krotscheck does his best cat impression | 16:57 | |
| ttx | I hope mordred will help getting stuff +2ed | 16:57 |
| krotscheck | He's in seattle tomorrow. | 16:57 |
| krotscheck | I will sit on his head | 16:57 |
| ttx | tried to review as much as I could yesterday | 16:57 |
| ttx | and last week | 16:58 |
| ttx | krotscheck: commented on the task/story creation review though | 16:58 |
| ttx | I think we are touching on a key point there | 16:58 |
| ttx | (in the "should the API implement some business logic" dept) | 16:59 |
| ttx | i'll let you read | 16:59 |
| krotscheck | Response posted. | 17:13 |
| krotscheck | Going through more. | 17:13 |
| krotscheck | ttx: You available to help me interview candidates in the next two weeks? | 17:13 |
| krotscheck | (Maybe after the cats are fed?) | 17:13 |
| krotscheck | ruhe: How about you, do you have time to interview some candidates for storyboard? | 17:14 |
| ruhe | krotscheck: hi! | 17:14 |
| ttx | krotscheck: replied to your meail | 17:14 |
| ttx | or email | 17:14 |
| ruhe | krotscheck: it depends on day and time, but i'd be happy to help with that | 17:15 |
| krotscheck | NikitaKonovalov: Thank you for all your comments on python - more of those kinds of comments help me learn the language faster :) | 17:15 |
| krotscheck | ruhe: Well, I'm going to have them schedule with you directly. If they're not proactive enough to do that, then they're likely not proactive enough to succeed on an open source project like this. | 17:16 |
| *** jcoufal has joined #storyboard | 17:16 | |
| krotscheck | That way you can arrange a time that works for both of you. | 17:17 |
| ruhe | krotscheck: woah, i like your approach :) | 17:17 |
| * mordred goes to look at things | 17:23 | |
| *** cody-somerville has joined #storyboard | 17:33 | |
| krotscheck | david-lyle: Do you have the time to interview two candidates for me next week? | 17:36 |
| krotscheck | (or this week) | 17:36 |
| ttx | krotscheck: re-commented | 17:36 |
| ttx | story without task would not appear anywhere, except on a special "stories without task" view (most people will access stories from a project or projectgroup-specific view). It's also not automatically repairable. So if we allow creation of stories without tasks, we need to have a group of people assigned to looking into them and fixing them. Given my experience of the OpenStack crowd, nobody will consistently sign up to do that. So WHY allow it to happe | 17:37 |
| ttx | n in the first place ? The tool should match what we accept to do, rather than force us into unpleasant tasks. Because there lies... launchpad. | 17:37 |
| ttx | krotscheck: you basically artificially create a chore that someone will have to go through | 17:38 |
| ttx | by allowing something to happen, something that nobody wants to support | 17:39 |
| ttx | or spend time to fix | 17:39 |
| david-lyle | krotscheck: yes, later this week or next is best | 17:40 |
| ttx | krotscheck: launchpad is full of extra maintenance chores like this (because it lets us do weird things) - and getting rid of those is one of the main drivers behind storyboard | 17:41 |
| krotscheck | david-lyle: thanks, I'll have them contact you and arrange with your schedule | 17:41 |
| ttx | If the API "only" reflects the database structure without adding some value, then it's a bit of a useless overhead | 17:42 |
| krotscheck | ttx: Ok, I still disagree, because all of your concerns, to me, are things taht can be polished and refined in the clients. | 17:42 |
| ttx | krotscheck: except that some people will not use the client and talk to the API directly | 17:42 |
| krotscheck | ttx: And those people will likely be engineers who have read the documentation | 17:43 |
| ttx | creating bad records that somebody will have to go through | 17:43 |
| krotscheck | ttx: Rather than brainless scriptkiddies who are randomly writing POST requests | 17:43 |
| krotscheck | If you're writing a client, and you create a story, and it doesn't show up anywhere... what are you likely to do? Read the docs? Ask questions? Or just shrug and say: Oh, well! | 17:44 |
| ttx | krotscheck: most of them will be. Some of them won't. So you will end up with bad records with nobody looking at them | 17:44 |
| krotscheck | ttx: Should we be looking at bad records? | 17:44 |
| krotscheck | If all the pieces aren't there, why bother showing them? | 17:44 |
| ttx | krotscheck: ok, I see your point there. We can just ignore the bad records | 17:45 |
| krotscheck | Sure, we can give the author a way of finding things that they've craeted and triage them, but it's not the responsibility of the API to surface invalid data. | 17:45 |
| ttx | krotscheck: not totally convinced we should let people create things that won't appear anywhere... | 17:46 |
| ttx | but maybe the tradeoff is sane | 17:46 |
| ttx | between the REST purity argument and the fact that sane people will use clients anyway | 17:46 |
| krotscheck | ttx: Yeah - most people are lazy. | 17:47 |
| krotscheck | ...and will try to automate things. | 17:47 |
| * krotscheck points at mordred | 17:47 | |
| ttx | Just sounds weird to me that we allow something we don't want to happen | 17:47 |
| ttx | but maybe that's what REST is about | 17:47 |
| krotscheck | Well, there's an alternate solution that I'm not familiar enough with python to implement. | 17:47 |
| ruhe | i thought it will be automatically prevented by: 1) create_story => creates default task 2) finish_last_task => finish/deprecate/close story | 17:47 |
| ttx | ruhe: but the API will let you create story without a default task. thats' the whole discussion here | 17:48 |
| ttx | ruhe: krotscheck argues that the APi should let you do that. I argue it should not | 17:48 |
| krotscheck | And that's to create a POST request for stories that require the additional data for the first task | 17:48 |
| krotscheck | So instead of just a story, we post something like this: | 17:49 |
| krotscheck | {name:"foo", tasks[{name: "task1"}]} | 17:49 |
| krotscheck | Really, what I care about is giving the client control over what goes in that task. | 17:49 |
| ttx | krotscheck: I guess we can revisit later anyway. Go for REST purity for the time being and APRV this one | 17:50 |
| krotscheck | kk | 17:50 |
| ruhe | our current api already creates default task | 17:51 |
| * ttx needs a break and a dinner now | 17:51 | |
| ttx | before entering meeting tunnel | 17:51 |
| ttx | ruhe: krotscheck would like you to fix that. | 17:51 |
| *** hashar has quit IRC | 17:51 | |
| ttx | discussion @ https://review.openstack.org/#/c/77013/ | 17:51 |
| ruhe | no problem :) | 17:51 |
| krotscheck | Already done that | 17:52 |
| krotscheck | ruhe: That's done. Don't worry about it :) | 17:52 |
| *** che-arne has quit IRC | 17:53 | |
| krotscheck | Also, I'm about ready to let the Auth stuff drop, given that the meat of the implementation is in the middleware patch. | 17:53 |
| openstackgerrit | A change was merged to openstack-infra/storyboard: Decoupled API story and task creation. https://review.openstack.org/77668 | 17:56 |
| krotscheck | Anyone know why the API unit tests are failing to migrate the database properly? | 17:57 |
| krotscheck | http://logs.openstack.org/63/77763/1/check/gate-storyboard-python26/4a104f5/console.html | 17:57 |
| krotscheck | I suspect it has something to do with using SQLite instead of MySQL... | 17:57 |
| ruhe | krotscheck: right and NikitaKonovalov had a patch to fix that | 17:59 |
| krotscheck | ruhe: ooh, thanks! Digging.... | 17:59 |
| openstackgerrit | A change was merged to openstack-infra/storyboard-webclient: Task, story, and project fixes https://review.openstack.org/77013 | 17:59 |
| ruhe | krotscheck: this one https://review.openstack.org/#/c/75381/7/storyboard/common/migration_patch.py | 18:01 |
| *** jcoufal_ has joined #storyboard | 18:02 | |
| krotscheck | mordred: Can you explain your comments on https://review.openstack.org/#/c/77085/ to me? | 18:03 |
| krotscheck | Or maybe give me more context? | 18:03 |
| *** jcoufal has quit IRC | 18:05 | |
| krotscheck | ruhe: Methinks I'm going to approve 74713 - We need to create a story where we actually address the "what are we going to do with docs" problem, gerrit isn't the place to do it. | 18:05 |
| ruhe | krotscheck: i've read your link. thanks a lot for it | 18:07 |
| krotscheck | ruhe: It's a good discussion on the topic, but really it's just a starting point. | 18:08 |
| ruhe | i wanted to discuss that topic with you and ttx but have been overloaded with other stuff recently | 18:08 |
| krotscheck | Sorry about -1'ing your change. It didn't occur to me that the resulting discussion would be big. | 18:08 |
| ruhe | krotscheck: well, i've learned a lot of things from that discussion | 18:08 |
| mordred | krotscheck: yes! | 18:09 |
| mordred | krotscheck: pip does not have a real dependency resolver - it's depth-first | 18:09 |
| mordred | krotscheck: so, sadly, order matters | 18:09 |
| mordred | it conveys actual potential different operation | 18:09 |
| krotscheck | mordred: Oh. Well, that explains that. | 18:09 |
| mordred | things that are specifically listed first i nthe files are pbr in the requirements.txt and hacking in the test-requirements.txt repo | 18:10 |
| mordred | it's painful | 18:10 |
| *** che-arne has joined #storyboard | 18:10 | |
| openstackgerrit | A change was merged to openstack-infra/storyboard: Fix session usage in db_api https://review.openstack.org/77885 | 18:10 |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Update developer documentation https://review.openstack.org/74713 | 18:12 |
| * krotscheck is riding the rebase train | 18:12 | |
| mordred | mmm. train | 18:18 |
| krotscheck | mordred: I'd like to drop the Auth side of things. I'm comfortable with the javascript, but I'd like a final set of eyes on https://review.openstack.org/#/c/68642/ (most of the meat is actually in the followup). Can you take a look? | 18:19 |
| mordred | krotscheck: looking | 18:20 |
| krotscheck | Thanks | 18:20 |
| * krotscheck is riding the waiting for zuul train.... | 18:37 | |
| krotscheck | :/ | 18:37 |
| openstackgerrit | A change was merged to openstack-infra/storyboard: Update developer documentation https://review.openstack.org/74713 | 18:41 |
| openstackgerrit | A change was merged to openstack-infra/storyboard: Clean up doc, private func, removed unused file https://review.openstack.org/77179 | 18:55 |
| *** jcoufal_ has quit IRC | 19:37 | |
| *** drdee has quit IRC | 19:57 | |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Remove Branch and Milestone legacy tables https://review.openstack.org/77187 | 20:01 |
| krotscheck | Even though we're not quite ready with Auth yet, I think it's safe to start entering stories. http://storyboard.openstack.org/#!/project/5/stories | 20:08 |
| *** jcoufal has joined #storyboard | 20:14 | |
| *** hashar has joined #storyboard | 20:29 | |
| *** cody-somerville has quit IRC | 20:50 | |
| *** jcoufal has quit IRC | 20:58 | |
| krotscheck | Ugh, I cannot win. | 20:58 |
| krotscheck | Something's wacky with our DB unit tests | 20:59 |
| krotscheck | Or, well, the migrations during the tests | 20:59 |
| *** jcoufal has joined #storyboard | 21:03 | |
| *** hashar has quit IRC | 21:41 | |
| *** jcoufal has quit IRC | 21:50 | |
| *** jcoufal has joined #storyboard | 21:52 | |
| krotscheck | Is subunit known to fail on warnings? | 22:02 |
| *** mfer has quit IRC | 22:24 | |
| *** jcoufal has quit IRC | 23:06 | |
| mordred | krotscheck: no? | 23:26 |
| krotscheck | Yeah. | 23:26 |
| krotscheck | Something wacky is going on with ttx's change. I'm currently fixing the npm mirror bit. | 23:26 |
| krotscheck | But | 23:26 |
| mordred | krotscheck: kk | 23:27 |
| krotscheck | I'll dig into it in a bit | 23:27 |
| mordred | krotscheck: I just tried adding a story and it failed. is that the wacky that you mentioned? | 23:27 |
| krotscheck | But the error messages are not helpful | 23:27 |
| mordred | krotscheck: also, I was thinking I should add puppet to run the projects.yaml utility - do you think I shoudl do that? or hold off? | 23:27 |
| krotscheck | mordred: You mean on storyboard.o.o? I just created a story without a problem. | 23:28 |
| krotscheck | Refresh your cache maybe? | 23:28 |
| krotscheck | http://storyboard.openstack.org/#!/story/15/overview | 23:28 |
| krotscheck | I have an LKDL-story | 23:29 |
| mordred | oh! | 23:29 |
| krotscheck | I'm guessing the UI didn't refresh | 23:29 |
| krotscheck | http://storyboard.openstack.org/#!/project/5/stories | 23:29 |
| mordred | http://storyboard.openstack.org/#!/story/17/overview | 23:29 |
| *** jcoufal has joined #storyboard | 23:30 | |
| mordred | krotscheck: NEAT! | 23:30 |
| mordred | krotscheck: I need to warn you | 23:34 |
| mordred | krotscheck: you may have just become a verb | 23:34 |
| *** david-lyle has quit IRC | 23:34 | |
| krotscheck | A verb that means... | 23:35 |
| mordred | "mordred | I'll krotscheck it" | 23:35 |
| mordred | krotscheck: I believe it may mean "fix it in deep and awesome ways that I don't fully understand" | 23:36 |
| krotscheck | ...urrr. Alright | 23:37 |
| *** jcoufal has quit IRC | 23:39 | |
| *** jcoufal has joined #storyboard | 23:41 | |
| krotscheck | mordred: Well, I could use some deep and awesome Alembic fixing on thierry's migrations | 23:43 |
| mordred | krotscheck: where are you seeing the badnesses? | 23:45 |
| krotscheck | mordred: Here - http://logs.openstack.org/87/77187/4/check/gate-storyboard-python26/7a9e8bf/console.html | 23:46 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!