*** david-lyle has joined #storyboard | 00:09 | |
*** persia has quit IRC | 01:12 | |
openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard-webclient: Comments UI https://review.openstack.org/82213 | 01:22 |
---|---|---|
krotscheck | Ok, let’s give that one a try | 01:23 |
*** krotscheck has quit IRC | 01:24 | |
*** david-lyle has quit IRC | 01:46 | |
*** persia has joined #storyboard | 01:49 | |
*** david-lyle has joined #storyboard | 02:28 | |
*** persia has quit IRC | 02:30 | |
*** persia has joined #storyboard | 02:30 | |
*** lifeless has joined #storyboard | 02:30 | |
*** persia has quit IRC | 02:31 | |
*** persia has joined #storyboard | 02:31 | |
*** lifeless has quit IRC | 02:35 | |
*** lifeless has joined #storyboard | 02:53 | |
*** saju_m has joined #storyboard | 04:38 | |
*** saju_m has quit IRC | 06:07 | |
*** saju_m has joined #storyboard | 06:50 | |
*** che-arne has quit IRC | 07:56 | |
*** jcoufal has joined #storyboard | 07:58 | |
*** saju_m has quit IRC | 08:43 | |
*** saju_m has joined #storyboard | 08:55 | |
*** hashar has joined #storyboard | 08:55 | |
*** saju_m has quit IRC | 09:16 | |
*** saju_m has joined #storyboard | 09:27 | |
*** che-arne has joined #storyboard | 10:11 | |
*** saju_m has quit IRC | 10:24 | |
*** david-lyle has quit IRC | 11:03 | |
*** saju_m has joined #storyboard | 11:14 | |
*** saju_m has quit IRC | 11:33 | |
*** saju_m has joined #storyboard | 11:35 | |
*** hashar is now known as hasharEat | 11:39 | |
*** hasharEat is now known as hashar | 12:35 | |
openstackgerrit | Thierry Carrez proposed a change to openstack-infra/storyboard: Add data load instructions to dev install doc https://review.openstack.org/83129 | 12:42 |
ruhe | ttx: would it make sense to provide a link to openstack-infra/config/..../projects.yaml in this doc? | 12:50 |
ttx | ruhe: why ? People have it in /etc anyway... | 12:51 |
ruhe | ttx: just to give a reference | 12:52 |
persia | Could someone point me the docs for being a reviewer? I've been reading the patches as they arrive, and playing with the code a bit, and thought I may as well leave notes in gerrit about what works for me, what breaks things, if I thought something ought be different, etc. | 13:05 |
ruhe | persia: the only one i'm aware about is https://wiki.openstack.org/wiki/Gerrit_Workflow | 13:07 |
persia | Yeah | 13:07 |
persia | Unfortunately, that's written from the other perspective. | 13:08 |
persia | Should I just leave comments on patches I've merged locally and tested or used? | 13:08 |
persia | https://wiki.openstack.org/wiki/GerritJenkinsGit#Reviewing_a_Change also seems close | 13:19 |
*** mfer has joined #storyboard | 13:29 | |
ttx | persia: https://wiki.openstack.org/wiki/ReviewChecklist maybe | 13:45 |
ttx | persia: and yes, review is free-for-all game so please don't hesitate to comment | 13:46 |
persia | Excellent. That was the thing I mostly wanted to check :) | 13:47 |
ttx | it seems to be reasonably current for a wiki page | 13:47 |
*** mtaylor has joined #storyboard | 14:05 | |
*** mordred has quit IRC | 14:08 | |
*** mtaylor has quit IRC | 14:08 | |
*** mtaylor has joined #storyboard | 14:08 | |
*** mtaylor is now known as mordred | 14:08 | |
*** jcoufal has quit IRC | 14:23 | |
*** jcoufal has joined #storyboard | 14:24 | |
*** david-lyle has joined #storyboard | 14:28 | |
*** hashar has quit IRC | 14:34 | |
*** hashar has joined #storyboard | 14:35 | |
openstackgerrit | Thierry Carrez proposed a change to openstack-infra/storyboard: Add data load instructions to dev install doc https://review.openstack.org/83129 | 14:38 |
*** hashar has quit IRC | 15:36 | |
*** david_lyle_ has joined #storyboard | 15:43 | |
*** saju_m has quit IRC | 15:44 | |
*** hashar has joined #storyboard | 15:44 | |
*** david-lyle has quit IRC | 15:46 | |
cody-somerville | Hi Folks. | 15:48 |
cody-somerville | Logging into storyboard is currently broken. Is this a known issue? | 15:48 |
cody-somerville | 500 error when you click login. | 15:49 |
ttx | cody-somerville: nope first time I see it | 16:00 |
ttx | but then I've been testing locally lately | 16:00 |
ttx | meeting time ? | 16:00 |
ttx | no krotscheck yet | 16:01 |
ttx | NikitaKonovalov, ruhe: ? | 16:01 |
ruhe | o/ | 16:02 |
ttx | gothicmindfood: ^ | 16:02 |
ttx | meeting on #openstack-meeting | 16:02 |
*** krotscheck has joined #storyboard | 16:07 | |
ttx | krotscheck: removed my -1, don't want my bitching to block your progress | 16:22 |
ttx | krotscheck: btw did you see my point above about 'tox -egrunt_no_api server:prod' not working for me ? Can't see stories / Ge 500 when I try to login | 16:26 |
krotscheck | ttx: That's because our API is FUBAR | 16:27 |
krotscheck | The dependency thing just mentioned. | 16:27 |
ttx | krotscheck: cool. Was fearing I was doing something wrong | 16:32 |
ttx | this grunt thing is black voodoo | 16:32 |
krotscheck | ttx: It's maven | 16:34 |
krotscheck | ttx: In javascript | 16:34 |
ttx | minus the xml crap | 16:35 |
ttx | jeblair: I would prefer project pages to live at URLs like storyboard.o.o/#!/project/nova (LP-style) rather than storyboard.o.o/#!/project/72 (gerrit-style) but maybe that's not RESTful | 16:47 |
cody-somerville | ttx: storyboard.o.o/#!/project/nova is entirely restful | 16:48 |
cody-somerville | ttx: nothing in REST says you have to use numbers ;) | 16:48 |
persia | Either is equally RESTful, but the former means that one can't safely change the project name. | 16:48 |
ttx | hmmkay | 16:49 |
cody-somerville | though for RESTful access, using id is better for reason persia mentions. | 16:51 |
persia | An analogy to relational databases: one typically doesn't use a string as the PRIMARY KEY, but one may. | 16:51 |
cody-somerville | but the web UI could certainly continue to use storyboard.o.o/#!/project/nova | 16:51 |
persia | cody-somerville: But that meas the URL presented by the webclient won't have close relation to the object URI, which might annoy someone trying to do something special. | 16:52 |
openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Added missing requirements back to storyboard https://review.openstack.org/83501 | 16:52 |
cody-somerville | persia: True. | 16:53 |
persia | IF the webclient is a tool that happens to consume the API service, this is fine. If the webclient is intended as *the* frontend to the API service, it's a bit odd. | 16:53 |
krotscheck | persia: the client maps the parameter from the URI directly through to the API. It would have to be updated. | 16:53 |
persia | krotscheck: Right. Needs a parser. | 16:54 |
persia | Not that I'm advocating one: I personally like consistency between the API service and the webclient. | 16:55 |
krotscheck | persia: Urrr... no. I'm saying that if the API is /project/NAME, then storyboard will need to also use #!/project/NAME | 16:57 |
krotscheck | Sorry - the webclient | 16:57 |
krotscheck | I'm trying to keep the URI patterns on the webclient as close to the natural API as possible. | 16:57 |
persia | Your preference there matches mine. I assert that someone could add a parser and not do that as suggested by cody-somerville, but that's a theoretical assertion only :) | 16:58 |
cody-somerville | I'm fine with it as is :) | 16:58 |
ruhe | krotscheck: re https://review.openstack.org/83501, i can't find where we use sqlalchemy-migrate | 17:00 |
krotscheck | I'm just following what cody-somerville said was missing | 17:00 |
krotscheck | I was in the meeting, so my attention was split. I'll have to do more forensics to figure out what's actually missing. | 17:01 |
ruhe | that's so strange. sqlalchemy-migrate was added to test-requirements.txt because it is imported from oslo module which we use | 17:01 |
ttx | hmm actually the room is not free | 17:02 |
ttx | jeblair: ^ | 17:02 |
ttx | Metering team meeting in #openstack-meeting | 17:02 |
ttx | every two weeks seriously | 17:02 |
*** mfer has quit IRC | 17:05 | |
ttx | cody-somerville, krotscheck, jeblair, ruhe, NikitaKonovalov: if we want to keep that hour we need to move to Friday/Monday... or just have the meeting in channel | 17:05 |
ttx | Friday will make it late in week for Russians, Monday early in week for Californians | 17:06 |
ttx | maybe we should just have it here | 17:06 |
jeblair | ttx: oh, that's why i didn't see it on the calendar | 17:06 |
jeblair | ttx: oh no! i've just been arguing that we don't permit that. :) | 17:07 |
ttx | "Neutron L3 Sub Team Meeting". Is that even a thing | 17:07 |
krotscheck | Ehn, I'm ok with monday | 17:10 |
ttx | krotscheck: seriously, if it's a pain for you we should have it at some other time | 17:10 |
krotscheck | It's not | 17:11 |
ttx | krotscheck: it's a good test for seattle coffee, for sure | 17:11 |
krotscheck | My mornings start at 6AM because my fiance has to be at work by 7 | 17:11 |
krotscheck | So anything after 730 means I'm awake. | 17:11 |
krotscheck | (Though usually I'm hacking on my own things at that time :) | 17:12 |
ttx | cody-somerville, krotscheck, jeblair, ruhe, NikitaKonovalov: how about Monday 1500 UTC ? | 17:12 |
ruhe | yeah, i've heard good things about seattle coffee :) | 17:12 |
ruhe | ttx: perfect | 17:12 |
krotscheck | ruhe: Come visit :) | 17:12 |
krotscheck | Urm. | 17:12 |
krotscheck | Well, wait for the current international tensions to subside a bit, THEN come visit. | 17:12 |
ruhe | willdo! | 17:14 |
NikitaKonovalov | ttx: monday 1500 UTC wfm | 17:14 |
jeblair | ttx: wfm | 17:14 |
*** krotscheck has quit IRC | 17:14 | |
jeblair | NikitaKonovalov: is that when the stackalytics meeting is? | 17:14 |
*** krotscheck has joined #storyboard | 17:15 | |
ttx | jeblair: yes, every two weeks | 17:17 |
krotscheck | ruhe: So, any thoughts on that requirements patch? | 17:18 |
ttx | erm. | 17:18 |
ttx | ruhe: would Friday 1500 UTC work better for you ? | 17:18 |
ttx | NikitaKonovalov: ^ | 17:18 |
krotscheck | Oh, bloody hell | 17:18 |
ttx | krotscheck: NikitaKonovalov has a biweekly conflict | 17:19 |
krotscheck | I was referring to jenkins dying on duplicate requirements. | 17:20 |
ttx | Ah :) | 17:20 |
*** che-arne has quit IRC | 17:20 | |
krotscheck | Stupid me not knowing python that well | 17:20 |
NikitaKonovalov | jeblair: I dont participate in stackalytics meeting | 17:22 |
NikitaKonovalov | so conflicts for me | 17:23 |
openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Added missing requirements back to storyboard https://review.openstack.org/83501 | 17:24 |
NikitaKonovalov | no conflicts I mean | 17:24 |
krotscheck | Let’s try that again | 17:24 |
NikitaKonovalov | we need three requirement files: requirements.txt test-requirements.txt and we-dont-use-but-still-need-requirements.txt | 17:27 |
ttx | OK so Monday 1500 UTC it is | 17:28 |
ruhe | any ideas how come our tests missed those missing requirements? | 17:28 |
krotscheck | ruhe: Because the test requirements installed them. | 17:30 |
ruhe | ahh | 17:30 |
krotscheck | ruhe: Had we been gating storyboard with the webclient properly, I think it would have caught them. | 17:30 |
ruhe | right | 17:31 |
*** david_lyle_ is now known as david_lyle | 17:31 | |
SergeyLukjanov | ttx, wfm too | 17:33 |
ruhe | SergeyLukjanov: that's much better compared to 7pm Friday ;) | 17:34 |
ttx | heh | 17:35 |
SergeyLukjanov | ruhe, 7 pm Saturday is better than Friday ;) | 17:35 |
krotscheck | ttx: So, a few things regarding your last UI comments | 17:39 |
krotscheck | 1- Yeah, we need to tighten up the padding. It’s way too much everywhere. | 17:39 |
krotscheck | 2- Mobile UI is probably going to involve a context menu at the bottom f the screen that lets you select separate pages. | 17:40 |
krotscheck | 3- I disgree with the average user story that you’ve proposed,because everyone I’ve watched using launchpad goes for the discussion first. | 17:44 |
persia | Depends on what they are doing. | 17:45 |
persia | Folk who are dealing with the issue read the discussion. Folk who are tracking the issue look at the tasks. | 17:45 |
persia | Folk who have been engaged in release management for several years may have a different view than folk who are focused on specific development tasks. | 17:45 |
openstackgerrit | A change was merged to openstack-infra/storyboard: Added missing requirements back to storyboard https://review.openstack.org/83501 | 17:46 |
*** mfer has joined #storyboard | 17:47 | |
persia | Also, small available pixel area doesn't necessarily mean mobile: consider folk who use tiling window managers, etc. | 17:47 |
*** hashar has quit IRC | 17:48 | |
krotscheck | persia: That’s fair - hard to make one screen serve double purpose though. Would you say that release management would care more about overviews and summaries? | 17:48 |
persia | I suspect mostly about tasks, but I suspect strongly that ttx is a better example user for that. | 17:48 |
persia | I'm opinionated, and do some development, but I generally ignore the minutae of release management. | 17:49 |
persia | So for me, primary view of discussion is better, because that is where I want to convince people to do things differently. But my use case is unlikely to be a majority one. | 17:49 |
krotscheck | I personally feel that people like ttx have been grossly underserved by launchpad, and that they’re so familiar with making do “the launchpad way” that feature asks are still focused around managing tasks and stories, when in reality they need overviews, dashboards, and rollups. | 17:57 |
persia | In this context, what do you mean by "rollup"? | 17:59 |
krotscheck | Rollup - sortof like what zuul does with the individual items in the queue. The details are available on request, however only the most pertinent information is displayed by default. | 18:01 |
persia | Ah, so hidden content that becomes available by UI interaction? | 18:01 |
krotscheck | Indeed | 18:02 |
persia | (or not-yet-loaded content: that's an implementation detail I didn't mean to specify) | 18:02 |
persia | Then yes, I agree. | 18:02 |
persia | While not MVP, I suspect that there's really a need for different views. | 18:02 |
persia | For project planning, I want to see a bunch of tasks (which I understand) and move them about. | 18:03 |
persia | For understanding something, I want to review the description and discussion. | 18:03 |
persia | For release management, I need to know what isn't ready, and who to ask about it. | 18:03 |
persia | For development, I just want to be able to tag my commit to indicate that it relates to a specific story, and have that add something indicating that something is available for review to the story view. | 18:04 |
persia | etc. | 18:04 |
persia | (and the very nature of my descriptions only underscores the insight of your criticism of the feature requestors) | 18:05 |
krotscheck | persia: Right, and for IRC I want to be able to go #storyboard story krotscheck Fix paging on the projects page. | 18:06 |
persia | Yes, although I disagree with your syntax. | 18:07 |
krotscheck | persia: implementation detail :) | 18:07 |
persia | The bot should use services to identify you, rather than you passing an ident, and service metadata to link that ident to something storyboard understands. | 18:08 |
persia | Next is that "Fix paging on the projects page" isn't clear: is that you adding a story, adding a task, asking for status on a story, asking for status on a task, or what? | 18:08 |
openstackgerrit | A change was merged to openstack-infra/storyboard-webclient: Comments UI https://review.openstack.org/82213 | 18:19 |
krotscheck | Ok, so the API is working again, now it’s just Auth that’s fubar. | 18:38 |
krotscheck | And only on the return trip. | 18:38 |
krotscheck | jeblair: when you get a chance can you poke at the logs to see what’s happening? I think we may have not configured the token storage yet... | 18:39 |
krotscheck | NikitaKonovalov might know more. | 18:39 |
jeblair | krotscheck: ack | 18:40 |
jeblair | DBError: (ProgrammingError) (1146, "Table 'storyboard.authorizationcodes' doesn't exist") | 18:41 |
krotscheck | Oh my | 18:42 |
jeblair | i'm assuming there's something in puppet that runs the db manage script...? | 18:44 |
krotscheck | Looking now. | 18:44 |
mordred | jeblair: yes. there is | 18:44 |
openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard-webclient: Task status updates https://review.openstack.org/82690 | 18:44 |
jeblair | mordred: i guess the run would have happened more than 1.5 hours ago though | 18:45 |
jeblair | mordred: so we can't see it on http://puppetdb.openstack.org/node/storyboard.openstack.org | 18:45 |
mordred | jeblair: http://git.openstack.org/cgit/openstack-infra/config/tree/modules/storyboard/manifests/init.pp#n103 | 18:45 |
mordred | jeblair: I'm so happy about that limit | 18:45 |
jeblair | mordred: it's delightful | 18:46 |
krotscheck | For a short amount of time we had two 009 migration versions. I suspect that’s what happened. | 18:46 |
mordred | krotscheck: that sounds about right | 18:46 |
mordred | I wonder if we should put in a test to make sure that a change doesn't add an inappropriately numbered migration? | 18:47 |
mordred | seems like an easy thing fora computer to trap for | 18:47 |
*** mfer has quit IRC | 18:47 | |
jeblair | mordred: also, we need puppetboard to be in utc | 18:47 |
krotscheck | mordred, jeblair: we _might_ be able to get away with clearing the pyc, downgrading to 008 and then upgrading again | 18:47 |
mordred | jeblair: I was thinking it might be nice to have a puppet snipped in base.pp that ensures timezones are set to utc | 18:48 |
krotscheck | Assuming the downgrades work.... | 18:48 |
krotscheck | Wait, no | 18:48 |
krotscheck | That would fail | 18:48 |
krotscheck | Crap | 18:48 |
mordred | so, the state we're in now is one of the 009's that is now called 008? | 18:48 |
krotscheck | No, it’s the 010 that used to be called 009 | 18:49 |
jeblair | mordred: taking puppetboard conversation to -infra | 18:49 |
mordred | and the thing that is called 009 is the one taht didn't run | 18:49 |
krotscheck | yes | 18:49 |
mordred | I believe we can downgrade to 009 | 18:50 |
mordred | then set the db table to 008 | 18:50 |
mordred | then upgrade | 18:50 |
mordred | OR | 18:50 |
mordred | we can just apply the change | 18:50 |
mordred | jeblair: ^^ thoughts on which one is less icky? | 18:50 |
jeblair | mordred: just apply the change? | 18:53 |
NikitaKonovalov | mordred: the missing 009 with auth tables does not impact anything else, so it's pretty safe to run | 18:53 |
mordred | jeblair: k. I can do that | 18:53 |
jeblair | mordred: do we know how this passed tests? | 18:53 |
mordred | jeblair: no. I haven't dug in to that - anybody else? | 18:54 |
krotscheck | Nope. Not yet | 18:54 |
krotscheck | ttx might have some insight, he committed the fix. | 18:54 |
mordred | I continue to be less than confident that our database tests test our database | 18:54 |
NikitaKonovalov | I've noticed the warning with two 009 only once | 18:54 |
NikitaKonovalov | and it was a WARNING from alembic, not an ERROR | 18:55 |
mordred | sigh. why would that be a warning. | 18:55 |
mordred | I ahvea better idea | 18:58 |
mordred | how about we rename 009 to 011 - parent 010 on 008 and the land that? | 18:58 |
mordred | jeblair, krotscheck ^^ | 18:58 |
krotscheck | Oh man that sounds hacky | 18:59 |
*** mfer has joined #storyboard | 19:00 | |
krotscheck | It’d work though. Let’s make sure there’s a comment in 009 though that explains why it’s empty. | 19:00 |
mordred | nod | 19:00 |
krotscheck | Are you working on that, or shall I? | 19:01 |
SergeyLukjanov | sounds good | 19:02 |
mordred | krotscheck: I got it | 19:03 |
krotscheck | kk, I’ll work on getting pagination | 19:05 |
*** mfer has quit IRC | 19:10 | |
openstackgerrit | Monty Taylor proposed a change to openstack-infra/storyboard: Fix the deployment sequencing https://review.openstack.org/83537 | 19:10 |
mordred | krotscheck: ^^ | 19:11 |
krotscheck | mordred: You forgot to add 11 | 19:11 |
jeblair | storyboard migrations go to 11 | 19:15 |
krotscheck | mordred: ^^ | 19:18 |
mordred | krotscheck: bother. one sec | 19:18 |
openstackgerrit | Monty Taylor proposed a change to openstack-infra/storyboard: Fix the deployment sequencing https://review.openstack.org/83537 | 19:18 |
krotscheck | Looks good to me! jeblair ? | 19:31 |
jeblair | lgtm; anyone else want to take a look, or are we ready to aprv? | 19:34 |
jeblair | i take that as a no; aprvd | 19:38 |
*** jcoufal has quit IRC | 19:38 | |
*** jcoufal has joined #storyboard | 19:39 | |
krotscheck | kk | 19:42 |
krotscheck | yay silence | 19:42 |
openstackgerrit | A change was merged to openstack-infra/storyboard: Fix the deployment sequencing https://review.openstack.org/83537 | 19:45 |
openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Added pagination to comments API https://review.openstack.org/83568 | 20:14 |
openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Added pagination to comments API https://review.openstack.org/83568 | 20:16 |
openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard-webclient: Added pagination directives https://review.openstack.org/83575 | 20:20 |
krotscheck | Allrightey | 20:21 |
krotscheck | jeblair: mordred: Looks like the change merged, but the auth api is still borked. Another dead migration? | 20:29 |
krotscheck | I’m guessing we wait on puppet? | 20:29 |
jeblair | should have run already; i'll check in a sec (i'm working in -infra on finding out why the puppet reports aren't helpful) | 20:31 |
krotscheck | Yeah, saw that | 20:31 |
jeblair | Mar 27 19:50:43 storyboard puppet-agent[10258]: (/Stage[main]/Storyboard/Exec[migrate-storyboard-db]) Failed to call refresh: storyboard-db-manage --config-file /etc/storyboard/storyboard.conf upgrade head returned 255 instead of one of [0] at /opt/config/production/modules/storyboard/manifests/init.pp:111 | 20:33 |
jeblair | 255 this time instead of 1. wonder what that means. | 20:34 |
jeblair | i'll run it by and and see if there's output we're missing | 20:34 |
jeblair | No such revision '009' | 20:35 |
jeblair | (that's the sole output) | 20:35 |
krotscheck | knew it. | 20:35 |
krotscheck | I think I know what’s missing, sec. | 20:35 |
krotscheck | Actually - does our puppet install delete the migration *.pyc files? | 20:36 |
jeblair | krotscheck: the pyc for 009 isn't there, i believe the python installation takes care of that | 20:37 |
krotscheck | jeblair: There is no mention in the master right now of 009 other than mordred’s comment. | 20:38 |
jeblair | krotscheck: that appears to be the case for the installed version of the code too. | 20:38 |
krotscheck | select * from alembic_version; ? | 20:39 |
jeblair | i will increase verbosity | 20:39 |
jeblair | so i kind of thought setting --debug or --verbose would, like, output more stuff. they don't. | 20:40 |
jeblair | also, none of the subcommands are documented :/ | 20:42 |
jeblair | krotscheck: alembic_version is 009 in the db | 20:43 |
krotscheck | jeblair: huhn. | 20:43 |
krotscheck | That suggests 010 never ran | 20:43 |
krotscheck | Wait, that makes sense. | 20:44 |
krotscheck | If the one we left as 9 was the one that never ran, and then we moved the 9 that ran to 10, of course it’s going to break | 20:44 |
krotscheck | Change the revision to 008 and rerun? | 20:44 |
jeblair | krotscheck: so if the 9 that ran is now 10, won't it upgrade from 8 to 10 and break? | 20:47 |
krotscheck | jeblair: fff… yeah, point | 20:47 |
krotscheck | so we know 8 ran | 20:47 |
krotscheck | and we know the 9 that is now 10 ran | 20:48 |
krotscheck | So I guess the correct revision for us to be at is 10 | 20:48 |
krotscheck | Since we know 11 didn’t run | 20:48 |
jeblair | that _sounds_ right. :) | 20:48 |
krotscheck | What’s the worst that could happen? | 20:48 |
krotscheck | …don’t answer that,. | 20:49 |
jeblair | krotscheck: i set it to 10 then ran upgrade; exit code of 0 | 20:49 |
jeblair | db reports 11 | 20:49 |
krotscheck | wooo! | 20:49 |
krotscheck | Logging in worked! | 20:49 |
jeblair | yay! | 20:49 |
krotscheck | We have comments! https://storyboard.openstack.org/#!/story/2 | 20:50 |
krotscheck | Task status changes are currently in gate. | 20:51 |
persia | Um. https://storyboard.openstack.org/ no longer loads at all from here (it did ~15 minutes ago, although it had the login issue). | 20:51 |
krotscheck | Loads for me. | 20:51 |
jeblair | wfm too | 20:51 |
persia | Odd. | 20:51 |
krotscheck | There’s an outstanding issue with pagination that’s fixed in https://review.openstack.org/#/c/83575/, which requires https://review.openstack.org/#/c/83568/ | 20:52 |
persia | Nevermind. Works with a different browser, just not with the one I was using 15 minutes ago. Apparently a coincidental issue. | 20:53 |
openstackgerrit | A change was merged to openstack-infra/storyboard-webclient: Task status updates https://review.openstack.org/82690 | 20:55 |
persia | Does 83568 need an associated docs change to update http://ci.openstack.org/storyboard/webapi/v1.html , or is there some magic in place for that? | 21:04 |
krotscheck | I believe that’s magic | 21:05 |
krotscheck | Although the magic appears to be broken. | 21:05 |
krotscheck | Gase and point, look at the parameters list age GET /v1/projects | 21:05 |
krotscheck | *case | 21:05 |
persia | Indeed, and there isn't a line for rest-controller to call the comment API at all | 21:07 |
krotscheck | Wow, that’s really broken | 21:08 |
krotscheck | all the api endpoints are /v1/project | 21:08 |
persia | My thought is perhaps that the magic isn't defined correctly, rather than being operationally broken in some way. | 21:09 |
krotscheck | persia: Well, the magic doesn’t like multiline parameter comments. | 21:10 |
krotscheck | persia: And it needs prefix help. | 21:10 |
persia | I don't think it likes multiline comments at all. It's also not collecting the erroneous comment about the project API being read-only | 21:12 |
openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Fixes to parameters and layout in documentation https://review.openstack.org/83591 | 21:16 |
krotscheck | Let’s see what jenkins thinks of this one. | 21:16 |
*** mfer has joined #storyboard | 21:20 | |
*** jcoufal has quit IRC | 21:27 | |
persia | Well, that's very frustrating. Something in my attempt to use https://review.openstack.org/#/c/83568 seems to have broken my API server entirely :/ | 21:54 |
*** mfer has quit IRC | 22:08 | |
*** david_lyle has quit IRC | 23:19 | |
mordred | krotscheck: hey! tasks, task statuses and comments!!! | 23:44 |
krotscheck | mordred: Yes! | 23:45 |
krotscheck | mordred: Go look at https://review.openstack.org/#/c/83575/, which requires https://review.openstack.org/#/c/83568/ | 23:45 |
mordred | looking | 23:45 |
mordred | krotscheck: also, I'm assuming that you've noticed that the pagination seems to limit my ability to see all of the projects in the dropdown menu to assign a task to a project ... | 23:45 |
krotscheck | mordred: That’s what those two patches are about | 23:45 |
mordred | woot | 23:46 |
krotscheck | I just needed the comments API to support it as well so I can be lazy on the javascript side and assume a consistent API contract | 23:46 |
mordred | krotscheck: ooh! 83575 looks good - AND actually makes sense | 23:48 |
krotscheck | Technicalities | 23:48 |
mordred | krotscheck: both look good | 23:53 |
persia | 83591 is stacked on those: is it directly related, or just descendant? | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!