Thursday, 2014-03-27

*** david-lyle has joined #storyboard00:09
*** persia has quit IRC01:12
openstackgerritMichael Krotscheck proposed a change to openstack-infra/storyboard-webclient: Comments UI  https://review.openstack.org/8221301:22
krotscheckOk, let’s give that one a try01:23
*** krotscheck has quit IRC01:24
*** david-lyle has quit IRC01:46
*** persia has joined #storyboard01:49
*** david-lyle has joined #storyboard02:28
*** persia has quit IRC02:30
*** persia has joined #storyboard02:30
*** lifeless has joined #storyboard02:30
*** persia has quit IRC02:31
*** persia has joined #storyboard02:31
*** lifeless has quit IRC02:35
*** lifeless has joined #storyboard02:53
*** saju_m has joined #storyboard04:38
*** saju_m has quit IRC06:07
*** saju_m has joined #storyboard06:50
*** che-arne has quit IRC07:56
*** jcoufal has joined #storyboard07:58
*** saju_m has quit IRC08:43
*** saju_m has joined #storyboard08:55
*** hashar has joined #storyboard08:55
*** saju_m has quit IRC09:16
*** saju_m has joined #storyboard09:27
*** che-arne has joined #storyboard10:11
*** saju_m has quit IRC10:24
*** david-lyle has quit IRC11:03
*** saju_m has joined #storyboard11:14
*** saju_m has quit IRC11:33
*** saju_m has joined #storyboard11:35
*** hashar is now known as hasharEat11:39
*** hasharEat is now known as hashar12:35
openstackgerritThierry Carrez proposed a change to openstack-infra/storyboard: Add data load instructions to dev install doc  https://review.openstack.org/8312912:42
ruhettx: would it make sense to provide a link to openstack-infra/config/..../projects.yaml in this doc?12:50
ttxruhe: why ? People have it in /etc anyway...12:51
ruhettx: just to give a reference12:52
persiaCould someone point me the docs for being a reviewer?  I've been reading the patches as they arrive, and playing with the code a bit, and thought I may as well leave notes in gerrit about what works for me, what breaks things, if I thought something ought be different, etc.13:05
ruhepersia: the only one i'm aware about is https://wiki.openstack.org/wiki/Gerrit_Workflow13:07
persiaYeah13:07
persiaUnfortunately, that's written from the other perspective.13:08
persiaShould I just leave comments on patches I've merged locally and tested or used?13:08
persiahttps://wiki.openstack.org/wiki/GerritJenkinsGit#Reviewing_a_Change also seems close13:19
*** mfer has joined #storyboard13:29
ttxpersia: https://wiki.openstack.org/wiki/ReviewChecklist maybe13:45
ttxpersia: and yes, review is free-for-all game so please don't hesitate to comment13:46
persiaExcellent.  That was the thing I mostly wanted to check :)13:47
ttxit seems to be reasonably current for a wiki page13:47
*** mtaylor has joined #storyboard14:05
*** mordred has quit IRC14:08
*** mtaylor has quit IRC14:08
*** mtaylor has joined #storyboard14:08
*** mtaylor is now known as mordred14:08
*** jcoufal has quit IRC14:23
*** jcoufal has joined #storyboard14:24
*** david-lyle has joined #storyboard14:28
*** hashar has quit IRC14:34
*** hashar has joined #storyboard14:35
openstackgerritThierry Carrez proposed a change to openstack-infra/storyboard: Add data load instructions to dev install doc  https://review.openstack.org/8312914:38
*** hashar has quit IRC15:36
*** david_lyle_ has joined #storyboard15:43
*** saju_m has quit IRC15:44
*** hashar has joined #storyboard15:44
*** david-lyle has quit IRC15:46
cody-somervilleHi Folks.15:48
cody-somervilleLogging into storyboard is currently broken. Is this a known issue?15:48
cody-somerville500 error when you click login.15:49
ttxcody-somerville: nope first time I see it16:00
ttxbut then I've been testing locally lately16:00
ttxmeeting time ?16:00
ttxno krotscheck yet16:01
ttxNikitaKonovalov, ruhe: ?16:01
ruheo/16:02
ttxgothicmindfood: ^16:02
ttxmeeting on #openstack-meeting16:02
*** krotscheck has joined #storyboard16:07
ttxkrotscheck: removed my -1, don't want my bitching to block your progress16:22
ttxkrotscheck: btw did you see my point above about 'tox -egrunt_no_api server:prod' not working for me ? Can't see stories / Ge 500 when I try to login16:26
krotscheckttx: That's because our API is FUBAR16:27
krotscheckThe dependency thing just mentioned.16:27
ttxkrotscheck: cool. Was fearing I was doing something wrong16:32
ttxthis grunt thing is black voodoo16:32
krotscheckttx: It's maven16:34
krotscheckttx: In javascript16:34
ttxminus the xml crap16:35
ttxjeblair: I would prefer project pages to live at URLs like storyboard.o.o/#!/project/nova (LP-style) rather than storyboard.o.o/#!/project/72 (gerrit-style) but maybe that's not RESTful16:47
cody-somervillettx: storyboard.o.o/#!/project/nova is entirely restful16:48
cody-somervillettx: nothing in REST says you have to use numbers ;)16:48
persiaEither is equally RESTful, but the former means that one can't safely change the project name.16:48
ttxhmmkay16:49
cody-somervillethough for RESTful access, using id is better for reason persia mentions.16:51
persiaAn analogy to relational databases: one typically doesn't use a string as the PRIMARY KEY, but one may.16:51
cody-somervillebut the web UI could certainly continue to use storyboard.o.o/#!/project/nova16:51
persiacody-somerville: But that meas the URL presented by the webclient won't have close relation to the object URI, which might annoy someone trying to do something special.16:52
openstackgerritMichael Krotscheck proposed a change to openstack-infra/storyboard: Added missing requirements back to storyboard  https://review.openstack.org/8350116:52
cody-somervillepersia: True.16:53
persiaIF the webclient is a tool that happens to consume the API service, this is fine.  If the webclient is intended as *the* frontend to the API service, it's a bit odd.16:53
krotscheckpersia: the client maps the parameter from the URI directly through to the API. It would have to be updated.16:53
persiakrotscheck: Right.  Needs a parser.16:54
persiaNot that I'm advocating one: I personally like consistency between the API service and the webclient.16:55
krotscheckpersia: Urrr... no. I'm saying that if the API is /project/NAME, then storyboard will need to also use #!/project/NAME16:57
krotscheckSorry - the webclient16:57
krotscheckI'm trying to keep the URI patterns on the webclient as close to the natural API as possible.16:57
persiaYour preference there matches mine.  I assert that someone could add a parser and not do that as suggested by cody-somerville, but that's a theoretical assertion only :)16:58
cody-somervilleI'm fine with it as is :)16:58
ruhekrotscheck: re https://review.openstack.org/83501, i can't find where we use sqlalchemy-migrate17:00
krotscheckI'm just following what cody-somerville said was missing17:00
krotscheckI was in the meeting, so my attention was split. I'll have to do more forensics to figure out what's actually missing.17:01
ruhethat's so strange. sqlalchemy-migrate was added to test-requirements.txt because it is imported from oslo module which we use17:01
ttxhmm actually the room is not free17:02
ttxjeblair: ^17:02
ttxMetering team meeting in #openstack-meeting17:02
ttxevery two weeks seriously17:02
*** mfer has quit IRC17:05
ttxcody-somerville, krotscheck, jeblair, ruhe, NikitaKonovalov: if we want to keep that hour we need to move to Friday/Monday... or just have the meeting in channel17:05
ttxFriday will make it late in week for Russians, Monday early in week for Californians17:06
ttxmaybe we should just have it here17:06
jeblairttx: oh, that's why i didn't see it on the calendar17:06
jeblairttx: oh no!  i've just been arguing that we don't permit that.  :)17:07
ttx"Neutron L3 Sub Team Meeting". Is that even a thing17:07
krotscheckEhn, I'm ok with monday17:10
ttxkrotscheck: seriously, if it's a pain for you we should have it at some other time17:10
krotscheckIt's not17:11
ttxkrotscheck: it's a good test for seattle coffee, for sure17:11
krotscheckMy mornings start at 6AM because my fiance has to be at work by 717:11
krotscheckSo anything after 730 means I'm awake.17:11
krotscheck(Though usually I'm hacking on my own things at that time :)17:12
ttxcody-somerville, krotscheck, jeblair, ruhe, NikitaKonovalov: how about Monday 1500 UTC ?17:12
ruheyeah, i've heard good things about seattle coffee :)17:12
ruhettx: perfect17:12
krotscheckruhe: Come visit :)17:12
krotscheckUrm.17:12
krotscheckWell, wait for the current international tensions to subside a bit, THEN come visit.17:12
ruhewilldo!17:14
NikitaKonovalovttx: monday 1500 UTC wfm17:14
jeblairttx: wfm17:14
*** krotscheck has quit IRC17:14
jeblairNikitaKonovalov: is that when the stackalytics meeting is?17:14
*** krotscheck has joined #storyboard17:15
ttxjeblair: yes, every two weeks17:17
krotscheckruhe: So, any thoughts on that requirements patch?17:18
ttxerm.17:18
ttxruhe: would Friday 1500 UTC work better for you ?17:18
ttxNikitaKonovalov: ^17:18
krotscheckOh, bloody hell17:18
ttxkrotscheck: NikitaKonovalov has a biweekly conflict17:19
krotscheckI was referring to jenkins dying on duplicate requirements.17:20
ttxAh :)17:20
*** che-arne has quit IRC17:20
krotscheckStupid me not knowing python that well17:20
NikitaKonovalovjeblair: I dont participate in stackalytics meeting17:22
NikitaKonovalovso conflicts for me17:23
openstackgerritMichael Krotscheck proposed a change to openstack-infra/storyboard: Added missing requirements back to storyboard  https://review.openstack.org/8350117:24
NikitaKonovalovno conflicts I mean17:24
krotscheckLet’s try that again17:24
NikitaKonovalovwe need three requirement files: requirements.txt test-requirements.txt and we-dont-use-but-still-need-requirements.txt17:27
ttxOK so Monday 1500 UTC it is17:28
ruheany ideas how come our tests missed those missing requirements?17:28
krotscheckruhe: Because the test requirements installed them.17:30
ruheahh17:30
krotscheckruhe: Had we been gating storyboard with the webclient properly, I think it would have caught them.17:30
ruheright17:31
*** david_lyle_ is now known as david_lyle17:31
SergeyLukjanovttx, wfm too17:33
ruheSergeyLukjanov: that's much better compared to 7pm Friday ;)17:34
ttxheh17:35
SergeyLukjanovruhe, 7 pm Saturday is better than Friday ;)17:35
krotscheckttx: So, a few things regarding your last UI comments17:39
krotscheck1- Yeah, we need to tighten up the padding. It’s way too much everywhere.17:39
krotscheck2- Mobile UI is probably going to involve a context menu at the bottom f the screen that lets you select separate pages.17:40
krotscheck3- I disgree with the average user story that you’ve proposed,because everyone I’ve watched using launchpad goes for the discussion first.17:44
persiaDepends on what they are doing.17:45
persiaFolk who are dealing with the issue read the discussion.  Folk who are tracking the issue look at the tasks.17:45
persiaFolk who have been engaged in release management for several years may have a different view than folk who are focused on specific development tasks.17:45
openstackgerritA change was merged to openstack-infra/storyboard: Added missing requirements back to storyboard  https://review.openstack.org/8350117:46
*** mfer has joined #storyboard17:47
persiaAlso, small available pixel area doesn't necessarily mean mobile: consider folk who use tiling window managers, etc.17:47
*** hashar has quit IRC17:48
krotscheckpersia: That’s fair - hard to make one screen serve double purpose though. Would you say that release management would care more about overviews and summaries?17:48
persiaI suspect mostly about tasks, but I suspect strongly that ttx is a better example user for that.17:48
persiaI'm opinionated, and do some development, but I generally ignore the minutae of release management.17:49
persiaSo for me, primary view of discussion is better, because that is where I want to convince people to do things differently.  But my use case is unlikely to be a majority one.17:49
krotscheckI personally feel that people like ttx have been grossly underserved by launchpad, and that they’re so familiar with making do “the launchpad way” that feature asks are still focused around managing tasks and stories, when in reality they need overviews, dashboards, and rollups.17:57
persiaIn this context, what do you mean by "rollup"?17:59
krotscheckRollup - sortof like what zuul does with the individual items in the queue. The details are available on request, however only the most pertinent information is displayed by default.18:01
persiaAh, so hidden content that becomes available by UI interaction?18:01
krotscheckIndeed18:02
persia(or not-yet-loaded content: that's an implementation detail I didn't mean to specify)18:02
persiaThen yes, I agree.18:02
persiaWhile not MVP, I suspect that there's really a need for different views.18:02
persiaFor project planning, I want to see a bunch of tasks (which I understand) and move them about.18:03
persiaFor understanding something, I want to review the description and discussion.18:03
persiaFor release management, I need to know what isn't ready, and who to ask about it.18:03
persiaFor development, I just want to be able to tag my commit to indicate that it relates to a specific story, and have that add something indicating that something is available for review to the story view.18:04
persiaetc.18:04
persia(and the very nature of my descriptions only underscores the insight of your criticism of the feature requestors)18:05
krotscheckpersia: Right, and for IRC I want to be able to go #storyboard story krotscheck Fix paging on the projects page.18:06
persiaYes, although I disagree with your syntax.18:07
krotscheckpersia: implementation detail :)18:07
persiaThe bot should use services to identify you, rather than you passing an ident, and service metadata to link that ident to something storyboard understands.18:08
persiaNext is that "Fix paging on the projects page" isn't clear: is that you adding a story, adding a task, asking for status on a story, asking for status on a task, or what?18:08
openstackgerritA change was merged to openstack-infra/storyboard-webclient: Comments UI  https://review.openstack.org/8221318:19
krotscheckOk, so the API is working again, now it’s just Auth that’s fubar.18:38
krotscheckAnd only on the return trip.18:38
krotscheckjeblair: when you get a chance can you poke at the logs to see what’s happening? I think we may have not configured the token storage yet...18:39
krotscheckNikitaKonovalov might know more.18:39
jeblairkrotscheck: ack18:40
jeblair DBError: (ProgrammingError) (1146, "Table 'storyboard.authorizationcodes' doesn't exist")18:41
krotscheckOh my18:42
jeblairi'm assuming there's something in puppet that runs the db manage script...?18:44
krotscheckLooking now.18:44
mordredjeblair: yes. there is18:44
openstackgerritMichael Krotscheck proposed a change to openstack-infra/storyboard-webclient: Task status updates  https://review.openstack.org/8269018:44
jeblairmordred: i guess the run would have happened more than 1.5 hours ago though18:45
jeblairmordred: so we can't see it on http://puppetdb.openstack.org/node/storyboard.openstack.org18:45
mordredjeblair: http://git.openstack.org/cgit/openstack-infra/config/tree/modules/storyboard/manifests/init.pp#n10318:45
mordredjeblair: I'm so happy about that limit18:45
jeblairmordred: it's delightful18:46
krotscheckFor a short amount of time we had two 009 migration versions. I suspect that’s what happened.18:46
mordredkrotscheck: that sounds about right18:46
mordredI wonder if we should put in a test to make sure that a change doesn't add an inappropriately numbered migration?18:47
mordredseems like an easy thing fora  computer to trap for18:47
*** mfer has quit IRC18:47
jeblairmordred: also, we need puppetboard to be in utc18:47
krotscheckmordred, jeblair: we _might_ be able to get away with clearing the pyc, downgrading to 008 and then upgrading again18:47
mordredjeblair: I was thinking it might be nice to have a puppet snipped in base.pp that ensures timezones are set to utc18:48
krotscheckAssuming the downgrades work....18:48
krotscheckWait, no18:48
krotscheckThat would fail18:48
krotscheckCrap18:48
mordredso, the state we're in now is one of the 009's that is now called 008?18:48
krotscheckNo, it’s the 010 that used to be called 00918:49
jeblairmordred: taking puppetboard conversation to -infra18:49
mordredand the thing that is called 009 is the one taht didn't run18:49
krotscheckyes18:49
mordredI believe we can downgrade to 00918:50
mordredthen set the db table to 00818:50
mordredthen upgrade18:50
mordredOR18:50
mordredwe can just apply the change18:50
mordredjeblair: ^^ thoughts on which one is less icky?18:50
jeblairmordred: just apply the change?18:53
NikitaKonovalovmordred: the missing 009 with auth tables does not impact anything else, so it's pretty safe to run18:53
mordredjeblair: k. I can do that18:53
jeblairmordred: do we know how this passed tests?18:53
mordredjeblair: no. I haven't dug in to that - anybody else?18:54
krotscheckNope. Not yet18:54
krotscheckttx might have some insight, he committed the fix.18:54
mordredI continue to be less than confident that our database tests test our database18:54
NikitaKonovalovI've noticed the warning with two 009 only once18:54
NikitaKonovalovand it was a WARNING from alembic, not an ERROR18:55
mordredsigh. why would that be a warning.18:55
mordredI ahvea  better idea18:58
mordredhow about we rename 009 to 011 - parent 010 on 008 and the land that?18:58
mordredjeblair, krotscheck ^^18:58
krotscheckOh man that sounds hacky18:59
*** mfer has joined #storyboard19:00
krotscheckIt’d work though. Let’s make sure there’s a comment in 009 though that explains why it’s empty.19:00
mordrednod19:00
krotscheckAre you working on that, or shall I?19:01
SergeyLukjanovsounds good19:02
mordredkrotscheck: I got it19:03
krotscheckkk, I’ll work on getting pagination19:05
*** mfer has quit IRC19:10
openstackgerritMonty Taylor proposed a change to openstack-infra/storyboard: Fix the deployment sequencing  https://review.openstack.org/8353719:10
mordredkrotscheck: ^^19:11
krotscheckmordred: You forgot to add 1119:11
jeblairstoryboard migrations go to 1119:15
krotscheckmordred: ^^19:18
mordredkrotscheck: bother. one sec19:18
openstackgerritMonty Taylor proposed a change to openstack-infra/storyboard: Fix the deployment sequencing  https://review.openstack.org/8353719:18
krotscheckLooks good to me! jeblair ?19:31
jeblairlgtm; anyone else want to take a look, or are we ready to aprv?19:34
jeblairi take that as a no; aprvd19:38
*** jcoufal has quit IRC19:38
*** jcoufal has joined #storyboard19:39
krotscheckkk19:42
krotscheckyay silence19:42
openstackgerritA change was merged to openstack-infra/storyboard: Fix the deployment sequencing  https://review.openstack.org/8353719:45
openstackgerritMichael Krotscheck proposed a change to openstack-infra/storyboard: Added pagination to comments API  https://review.openstack.org/8356820:14
openstackgerritMichael Krotscheck proposed a change to openstack-infra/storyboard: Added pagination to comments API  https://review.openstack.org/8356820:16
openstackgerritMichael Krotscheck proposed a change to openstack-infra/storyboard-webclient: Added pagination directives  https://review.openstack.org/8357520:20
krotscheckAllrightey20:21
krotscheckjeblair: mordred: Looks like the change merged, but the auth api is still borked. Another dead migration?20:29
krotscheckI’m guessing we wait on puppet?20:29
jeblairshould have run already; i'll check in a sec (i'm working in -infra on finding out why the puppet reports aren't helpful)20:31
krotscheckYeah, saw that20:31
jeblairMar 27 19:50:43 storyboard puppet-agent[10258]: (/Stage[main]/Storyboard/Exec[migrate-storyboard-db]) Failed to call refresh: storyboard-db-manage --config-file /etc/storyboard/storyboard.conf upgrade head returned 255 instead of one of [0] at /opt/config/production/modules/storyboard/manifests/init.pp:11120:33
jeblair255 this time instead of 1.  wonder what that means.20:34
jeblairi'll run it by and and see if there's output we're missing20:34
jeblair  No such revision '009'20:35
jeblair(that's the sole output)20:35
krotscheckknew it.20:35
krotscheckI think I know what’s missing, sec.20:35
krotscheckActually - does our puppet install delete the migration *.pyc files?20:36
jeblairkrotscheck: the pyc for 009 isn't there, i believe the python installation takes care of that20:37
krotscheckjeblair: There is no mention in the master right now of 009 other than mordred’s comment.20:38
jeblairkrotscheck: that appears to be the case for the installed version of the code too.20:38
krotscheckselect * from alembic_version; ?20:39
jeblairi will increase verbosity20:39
jeblairso i kind of thought setting --debug or --verbose would, like, output more stuff.  they don't.20:40
jeblairalso, none of the subcommands are documented :/20:42
jeblairkrotscheck: alembic_version is 009 in the db20:43
krotscheckjeblair: huhn.20:43
krotscheckThat suggests 010 never ran20:43
krotscheckWait, that makes sense.20:44
krotscheckIf the one we left as 9 was the one that never ran, and then we moved the 9 that ran to 10, of course it’s going to break20:44
krotscheckChange the revision to 008 and rerun?20:44
jeblairkrotscheck: so if the 9 that ran is now 10, won't it upgrade from 8 to 10 and break?20:47
krotscheckjeblair: fff… yeah, point20:47
krotscheckso we know 8 ran20:47
krotscheckand we know the 9 that is now 10 ran20:48
krotscheckSo I guess the correct revision for us to be at is 1020:48
krotscheckSince we know 11 didn’t run20:48
jeblairthat _sounds_ right.  :)20:48
krotscheckWhat’s the worst that could happen?20:48
krotscheck…don’t answer that,.20:49
jeblairkrotscheck: i set it to 10 then ran upgrade; exit code of 020:49
jeblairdb reports 1120:49
krotscheckwooo!20:49
krotscheckLogging in worked!20:49
jeblairyay!20:49
krotscheckWe have comments! https://storyboard.openstack.org/#!/story/220:50
krotscheckTask status changes are currently in gate.20:51
persiaUm.  https://storyboard.openstack.org/ no longer loads at all from here (it did ~15 minutes ago, although it had the login issue).20:51
krotscheckLoads for me.20:51
jeblairwfm too20:51
persiaOdd.20:51
krotscheckThere’s an outstanding issue with pagination that’s fixed in https://review.openstack.org/#/c/83575/, which requires https://review.openstack.org/#/c/83568/20:52
persiaNevermind.  Works with a different browser, just not with the one I was using 15 minutes ago.  Apparently a coincidental issue.20:53
openstackgerritA change was merged to openstack-infra/storyboard-webclient: Task status updates  https://review.openstack.org/8269020:55
persiaDoes 83568 need an associated docs change to update http://ci.openstack.org/storyboard/webapi/v1.html , or is there some magic in place for that?21:04
krotscheckI believe that’s magic21:05
krotscheckAlthough the magic appears to be broken.21:05
krotscheckGase and point, look at the parameters list age GET /v1/projects21:05
krotscheck*case21:05
persiaIndeed, and there isn't a line for rest-controller to call the comment API at all21:07
krotscheckWow, that’s really broken21:08
krotscheckall the api endpoints are /v1/project21:08
persiaMy thought is perhaps that the magic isn't defined correctly, rather than being operationally broken in some way.21:09
krotscheckpersia: Well, the magic doesn’t like multiline parameter comments.21:10
krotscheckpersia: And it needs prefix help.21:10
persiaI don't think it likes multiline comments at all.  It's also not collecting the erroneous comment about the project API being read-only21:12
openstackgerritMichael Krotscheck proposed a change to openstack-infra/storyboard: Fixes to parameters and layout in documentation  https://review.openstack.org/8359121:16
krotscheckLet’s see what jenkins thinks of this one.21:16
*** mfer has joined #storyboard21:20
*** jcoufal has quit IRC21:27
persiaWell, that's very frustrating.  Something in my attempt to use https://review.openstack.org/#/c/83568 seems to have broken my API server entirely :/21:54
*** mfer has quit IRC22:08
*** david_lyle has quit IRC23:19
mordredkrotscheck: hey! tasks, task statuses and comments!!!23:44
krotscheckmordred: Yes!23:45
krotscheckmordred: Go look at https://review.openstack.org/#/c/83575/, which requires https://review.openstack.org/#/c/83568/23:45
mordredlooking23:45
mordredkrotscheck: also, I'm assuming that you've noticed that the pagination seems to limit my ability to see all of the projects in the dropdown menu to assign a task to a project ...23:45
krotscheckmordred: That’s what those two patches are about23:45
mordredwoot23:46
krotscheckI just needed the comments API to support it as well so I can be lazy on the javascript side and assume a consistent API contract23:46
mordredkrotscheck: ooh! 83575 looks good - AND actually makes sense23:48
krotscheckTechnicalities23:48
mordredkrotscheck: both look good23:53
persia83591 is stacked on those: is it directly related, or just descendant?23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!