| *** wuhg has joined #storyboard | 01:58 | |
| *** mase_x200 has joined #storyboard | 02:01 | |
| *** mase_x200 has quit IRC | 04:13 | |
| *** alexismonville has joined #storyboard | 06:23 | |
| *** alexismonville has quit IRC | 06:39 | |
| *** alexismonville has joined #storyboard | 06:47 | |
| *** jcoufal has joined #storyboard | 07:00 | |
| *** jcoufal_ has joined #storyboard | 07:49 | |
| *** jcoufal has quit IRC | 07:52 | |
| *** jtomasek has joined #storyboard | 08:06 | |
| *** MaxV has joined #storyboard | 08:57 | |
| *** MaxV has quit IRC | 09:02 | |
| *** MaxV has joined #storyboard | 09:13 | |
| *** mase_x200 has joined #storyboard | 10:57 | |
| *** mrmartin has joined #storyboard | 11:11 | |
| yolanda | ttx, i was reading your comments, they make a lot of sense. But do you still want to keep this step, maybe calling that "merged" stories, or shall we create a wider one about story relationships? | 11:32 |
|---|---|---|
| yolanda | btw, how was your Storyboard presentation? | 11:33 |
| nibalizer | yolanda: he killed it | 11:35 |
| nibalizer | packjed room, i coukdnt get in | 11:35 |
| nibalizer | but heard a lot of good things | 11:35 |
| yolanda | nice, great to have that interest on the project | 11:35 |
| yolanda | it motivates us to work harder | 11:36 |
| yolanda | nibalizer, did you hear feedback from people, requests, usability problems, etc? | 11:36 |
| mrmartin | hi | 11:39 |
| mrmartin | there was a great interest, but some guys want to use jira instead :) | 11:39 |
| nibalizer | yolanda: buzz mostly | 11:41 |
| nibalizer | and ttx's talk was about a bunch of infra toola | 11:41 |
| nibalizer | not just sb | 11:41 |
| yolanda | how long were the talks? | 11:41 |
| mrmartin | there was some video recording I guess | 11:42 |
| mrmartin | they not published the videos, but will be here: http://video.fosdem.org | 11:43 |
| yolanda | i want to watch it | 11:44 |
| yolanda | mm, tons of interesting topics there | 11:44 |
| mrmartin | just a small part was about storyboard, but the people noticed that. I think most of them had problems with lp previously | 11:44 |
| mrmartin | but all of our Infra sessions was great | 11:45 |
| mrmartin | nibalizer's presentation about upstream/downstream usage at hp was awesome | 11:45 |
| yolanda | i should have posted some conf proposals, maybe they could have accepted one | 11:46 |
| mrmartin | basically the event was overcrowded | 11:46 |
| mrmartin | a lot of rooms was simply full, it was impossible to get in | 11:46 |
| yolanda | It’s not a bug, it’s an environment problem. | 11:47 |
| yolanda | nibalizer, we could tell taht! | 11:47 |
| yolanda | we could close tons of jira tickets with that answer | 11:47 |
| *** miqui_away has quit IRC | 12:21 | |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Delete created_at and updated_at fields from requests https://review.openstack.org/151641 | 13:35 |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Reject false creator_id from requests https://review.openstack.org/151650 | 13:38 |
| openstackgerrit | Nikita Konovalov proposed openstack-infra/storyboard: Fix status code on delete https://review.openstack.org/151603 | 14:12 |
| ttx | yolanda: we should have a longer discussion about it | 14:15 |
| ttx | I'm travelling right now, so not optimal for a long discussion | 14:15 |
| ttx | I'll miss the Storyboard meeting btw | 14:15 |
| yolanda | ok, we can do it other day, that's no urgent item | 14:15 |
| ttx | Maybe ping me later this week ? | 14:15 |
| ttx | mrmartin: I see you're safely back home | 14:16 |
| mrmartin | hi ttx | 14:16 |
| mrmartin | yeap :) | 14:16 |
| yolanda | sure, i'll ping you this week when i see you online | 14:16 |
| *** mase_x200 has quit IRC | 14:27 | |
| *** rcarrillocruz has quit IRC | 14:35 | |
| *** ongk has quit IRC | 14:38 | |
| *** rcarrillocruz has joined #storyboard | 14:38 | |
| *** ongk has joined #storyboard | 14:41 | |
| openstackgerrit | yolanda.robla proposed openstack-infra/storyboard-webclient: Fix in project groups validation https://review.openstack.org/152133 | 14:42 |
| openstackgerrit | Nikita Konovalov proposed openstack-infra/storyboard: Fix NotFound errors https://review.openstack.org/152137 | 14:46 |
| *** openstackgerrit has quit IRC | 14:52 | |
| *** openstackgerrit has joined #storyboard | 14:52 | |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added branches to storyboard https://review.openstack.org/150447 | 15:03 |
| krotscheck | aripinen, NikitaKonovalov: I’m seeing two different ways of handling error code responses in the API. One is abort(400), the other is something like raise exc.NotFound(). Does it make sense for us to use both ways, or should we stick to one method of handling errors? | 15:21 |
| openstackgerrit | Merged openstack-infra/storyboard: Fix stories put method https://review.openstack.org/151643 | 15:24 |
| openstackgerrit | Merged openstack-infra/storyboard: Whitelisted bash in the tox configuration https://review.openstack.org/151293 | 15:28 |
| openstackgerrit | Merged openstack-infra/python-storyboardclient: Stories and Tasks support https://review.openstack.org/150067 | 15:29 |
| yolanda | krotscheck, ah, i had same question, i posted on a review | 15:33 |
| yolanda | about the abort or custom validation | 15:33 |
| NikitaKonovalov | krotscheck: abort or raise exception is pretty much the same thing | 15:34 |
| NikitaKonovalov | abort call is shorter though | 15:34 |
| krotscheck | NikitaKonovalov: Do we care about keeping our calls consistent in our codebase? | 15:35 |
| * krotscheck doesn’t care that much. | 15:35 | |
| NikitaKonovalov | me neither, but what I care about is make sure that the correct code is set everywhere | 15:36 |
| NikitaKonovalov | that's why I did that NotFound patch and delete | 15:36 |
| NikitaKonovalov | delete handling I mean | 15:36 |
| krotscheck | NikitaKonovalov: Makes sense. I’ll go in and +2 that patch | 15:36 |
| NikitaKonovalov | there are also a few places where something like response.status_code=400; return response; I'll fix those too. | 15:37 |
| krotscheck | Storyboard meeting in #openstack-meeting-3 | 16:00 |
| *** tteggel_ is now known as tteggel | 16:04 | |
| krotscheck | Argh, not enough time for technical discussions :/ | 17:00 |
| rcarrillocruz | heh | 17:00 |
| rcarrillocruz | so yeah | 17:00 |
| rcarrillocruz | two use cases | 17:00 |
| rcarrillocruz | 'reconnect' and 'replay' | 17:00 |
| rcarrillocruz | first for ocassional and short connection drops | 17:01 |
| rcarrillocruz | we can leave consumer queues to stay live for 2-5minutes | 17:01 |
| *** aripinen has quit IRC | 17:02 | |
| rcarrillocruz | 'replay' use case i don't think we should use amqp queues. We should rather handle that in the backend with SQL by querying the events table... and make sure the events shown back to the client appear in the same format as normal rabbitmq events | 17:02 |
| rcarrillocruz | so the client doesn't see any difference | 17:02 |
| krotscheck | Is replay part of the pubsub spec? | 17:03 |
| * rcarrillocruz searching the spec... | 17:06 | |
| krotscheck | AFK for an hour or so, have to get my run in and get to the office. | 17:06 |
| rcarrillocruz | it is | 17:07 |
| rcarrillocruz | https://review.openstack.org/#/c/105252/6/specs/storyboard_automated_pub_sub.rst | 17:07 |
| rcarrillocruz | line 240 | 17:07 |
| *** wuhg has quit IRC | 17:09 | |
| *** coolsvap is now known as coolsvap|afk | 17:12 | |
| *** MaxV has quit IRC | 17:30 | |
| *** jcoufal_ has quit IRC | 17:46 | |
| *** coolsvap|afk is now known as coolsvap | 17:52 | |
| *** reed has joined #storyboard | 19:01 | |
| *** coolsvap is now known as coolsvap|afk | 19:36 | |
| *** MaxV has joined #storyboard | 19:51 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Explicit Hook Priorities https://review.openstack.org/152253 | 19:51 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Explicit Hook Priorities https://review.openstack.org/152253 | 19:54 |
| openstackgerrit | Merged openstack-infra/storyboard: Delete created_at and updated_at fields from requests https://review.openstack.org/151641 | 19:55 |
| *** alexismonville has quit IRC | 20:23 | |
| *** MaxV has quit IRC | 20:36 | |
| *** cody-somerville has joined #storyboard | 21:15 | |
| *** cody-somerville has quit IRC | 21:15 | |
| *** cody-somerville has joined #storyboard | 21:15 | |
| *** cody-somerville has quit IRC | 21:39 | |
| *** mrmartin has quit IRC | 21:51 | |
| *** jtomasek has quit IRC | 22:24 | |
| *** greghaynes has joined #storyboard | 22:25 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Explicit Hook Priorities https://review.openstack.org/152253 | 22:38 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Pass the old entity values in the NotificationHook https://review.openstack.org/151645 | 22:38 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: API events now include resource before/after state. https://review.openstack.org/152318 | 22:38 |
| krotscheck | rcarrillocruz: ^^ I made a couple of changes to your patch. I rebased it on top of the hook priority patch that I put out, and pulled the mapping logic into a reusable internal method so it can be used in before() and in after() | 22:38 |
| greghaynes | pecan hook priorities are wierd | 22:58 |
| greghaynes | krotscheck: is the idea of them to basically get a hook order within one of the possible hook states | 22:59 |
| greghaynes | like an ordering from within on_before | 22:59 |
| *** reed has quit IRC | 23:00 | |
| krotscheck | greghaynes: Yeah, especially since you can have hooks in controllers, at the app level, etc etc. | 23:00 |
| greghaynes | cool. Another Q - whats your dev setup like? | 23:01 |
| greghaynes | oh, youre a mac user arent you ;) | 23:03 |
| greghaynes | aye, tox py3* test isnt happy because Mysql-Python | 23:08 |
| krotscheck | Mine? | 23:25 |
| krotscheck | Yep | 23:25 |
| krotscheck | greghaynes: Is there a reasonably clean path to get us to 3*? I’m unfamiliar with the migration. | 23:26 |
| greghaynes | krotscheck: yea, review inbound | 23:26 |
| greghaynes | krotscheck: well, for the mysql fix | 23:26 |
| krotscheck | Oh, nice. | 23:26 |
| greghaynes | which is just to juse pymysql | 23:26 |
| krotscheck | greghaynes: Implications? | 23:27 |
| * krotscheck seems to remember a reason we used mysql-python, but can’t remember specifics. | 23:28 | |
| greghaynes | krotscheck: mostly positive implications. really the only downside is pymysql is slightly slower, but no in a way that should matter | 23:28 |
| greghaynes | its basically just a pure python implementation | 23:29 |
| greghaynes | and a drop in replacement | 23:29 |
| krotscheck | greghaynes: Oh, hah. Yeah, well, the major issue in our DB interaction speed is that every query gets its own connection. This might just make it painful enough to force someone to fix that. | 23:29 |
| greghaynes | fun | 23:30 |
| greghaynes | if it comes up I might poke at it :) | 23:30 |
| *** cody-somerville has joined #storyboard | 23:34 | |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Switch from mysql-python to PyMySQL https://review.openstack.org/152339 | 23:37 |
| *** mase_x200 has joined #storyboard | 23:40 | |
| krotscheck | greghaynes: Is that patch going to require updates to the configuration files on deployed instances? | 23:45 |
| krotscheck | i.e. will I have to update the puppet module? | 23:45 |
| greghaynes | that is a good question | 23:45 |
| greghaynes | I would say very likely | 23:45 |
| greghaynes | well, actually, I dont think 'require' | 23:46 |
| greghaynes | if youre using the same connect string as before and you have mysql-python installed it should work the same as before | 23:46 |
| greghaynes | We should probably include a deprecated warning or somesuch though | 23:47 |
| *** gforcada_ has joined #storyboard | 23:48 | |
| greghaynes | krotscheck: where does the puppet code live for the deployed instance? | 23:48 |
| gforcada_ | hi all, is ther any sysamdin around? I'm trying to log in but I keep getting a "500 Internal Server Error" | 23:49 |
| gforcada_ | should I just wait until tomorrow? | 23:49 |
| krotscheck | hiya | 23:51 |
| krotscheck | gforcada_: Let me check for ya. | 23:51 |
| gforcada_ | krotscheck: thanks! | 23:51 |
| krotscheck | gforcada_: I can repro. Checking localhost. | 23:52 |
| krotscheck | gforcada_: Broken on master, working on a patch. | 23:53 |
| krotscheck | greghaynes: https://review.openstack.org/#/q/status:open+project:openstack-infra/puppet-storyboard,n,z | 23:53 |
| gforcada_ | krotscheck: thanks a lot, will wait for the fix then | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!