Friday, 2015-02-06

*** reed has quit IRC00:08
*** Piet has quit IRC00:22
*** openstack has joined #storyboard01:34
*** mase_x200 has joined #storyboard01:36
*** mase_x200 has quit IRC02:09
*** mase_x200 has joined #storyboard02:48
*** mattfarina has joined #storyboard03:40
*** mase_x200 has quit IRC03:57
*** mattfarina has quit IRC04:51
*** mrmartin has joined #storyboard05:34
*** mrmartin has quit IRC05:44
*** mrmartin has joined #storyboard06:19
*** openstackgerrit has quit IRC06:35
*** openstackgerrit has joined #storyboard06:35
*** mrmartin has quit IRC06:56
*** jtomasek has joined #storyboard07:34
*** CTtpollard has joined #storyboard08:30
*** ssam2 has joined #storyboard08:52
*** mrmartin has joined #storyboard08:54
*** jtomasek has quit IRC09:30
*** jtomasek has joined #storyboard09:33
*** jtomasek has quit IRC09:43
*** MaxV has joined #storyboard09:45
*** jcoufal has joined #storyboard09:46
CTtpollardare you here yolanda?09:54
yolandahi09:55
yolandaalways :)09:55
CTtpollard:q09:55
CTtpollard:)09:55
CTtpollard'vim'09:55
*** jcoufal has quit IRC09:55
yolandawhat's up, CTpollard?09:57
CTtpollardjust looking at how to override the default storyboard icon09:57
*** jtomasek has joined #storyboard09:57
CTtpollardwould it just be a case of replacing storyboard.svg?09:58
yolandamm, we have some css in place for themes, so do you have a new theme?10:02
CTtpollardnothing much i want to change, I've changed brand colour and favicion10:02
CTtpollardjust want to change the storyboard logo now10:03
yolandaso what i can see is that it uses a custom-icon font10:03
yolandaand there is an icon_storyboard10:04
CTtpollardthere is stroyboard.svg in /src/fonts/src10:04
yolandamm, you need to edit the custom_icons.svg10:06
yolandait's the one that seems to be used10:06
CTtpollard:q10:09
CTtpollard:/10:09
*** jedimike has joined #storyboard10:10
CTtpollardok I'll give it a go10:24
CTtpollardty :)10:24
*** jcoufal has joined #storyboard10:33
openstackgerritMerged openstack-infra/storyboard: OAuth Storage Abstraction Removed  https://review.openstack.org/15310610:38
openstackgerritMerged openstack-infra/storyboard: OAuth Functional Tests  https://review.openstack.org/15306810:40
*** reed has joined #storyboard11:21
*** mrmartin has quit IRC11:56
*** wendar has quit IRC12:19
*** rainya has quit IRC12:19
*** wendar has joined #storyboard12:20
*** rainya has joined #storyboard12:20
*** alexismonville has joined #storyboard13:04
*** alexismonville has quit IRC13:37
*** alexismonville has joined #storyboard13:43
openstackgerritMerged openstack-infra/storyboard-webclient: Fix to show errors again  https://review.openstack.org/15317614:31
*** mattfarina has joined #storyboard14:32
*** CTtpollard has quit IRC14:45
*** CTtpollard has joined #storyboard14:48
openstackgerritAleksey Ripinen proposed openstack-infra/storyboard: Added controller for refresh tokens  https://review.openstack.org/15359115:05
openstackgerritNikita Konovalov proposed openstack-infra/storyboard: User abort call instead of returning response  https://review.openstack.org/15251515:07
openstackgerritAleksey Ripinen proposed openstack-infra/storyboard: Added new paginate query  https://review.openstack.org/15323115:24
*** alexismonville has quit IRC15:25
*** Piet has joined #storyboard15:31
*** MaxV has quit IRC15:44
*** CTtpollard has quit IRC15:46
*** CTtpollard has joined #storyboard15:57
*** alexismonville has joined #storyboard16:02
openstackgerritAleksey Ripinen proposed openstack-infra/storyboard: Added milestones  https://review.openstack.org/15250016:14
*** jcoufal has quit IRC16:19
*** openstackgerrit has quit IRC16:21
*** openstackgerrit has joined #storyboard16:22
*** CTtpollard has quit IRC16:54
*** jtomasek has quit IRC17:00
*** alexismonville has quit IRC17:09
*** ssam2 has quit IRC17:22
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: OAuth Authorize Scope Validation  https://review.openstack.org/15340617:29
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: OAuth tests for authorize_return  https://review.openstack.org/15340717:29
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: OAuth validates redirect_uri  https://review.openstack.org/15340517:29
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: OAuth check for no response_type  https://review.openstack.org/15310717:29
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: OAuth checks for remote data access permissions.  https://review.openstack.org/15340917:29
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: OAuth Exception on invalid oauth return data  https://review.openstack.org/15340817:29
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: OAuth check for no client_id  https://review.openstack.org/15310817:29
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: OAuth check for response_type 'code'  https://review.openstack.org/15306917:29
krotscheckAnyone want to help kick off a merge tornado? https://review.openstack.org/#/c/153069/17:30
yolandahi17:30
yolandareviewing that17:30
yolandamm, i still see missing _() in that change?17:31
yolandashall i ignore i?17:31
yolandait?17:32
yolandamm, my change for showing errors have been merged, but i don't see results yet.. maybe it takes some time to go through puppet?17:36
yolandait works locally for me, but errors are not displayed on production yet17:37
krotscheckyolanda: I added the _() call in decorators.py, but the very next patch converts all the error messages into constants that all have the _() around them.17:43
krotscheckyolanda: Here-> https://review.openstack.org/#/c/153107/3/storyboard/api/auth/__init__.py17:43
openstackgerritMerged openstack-infra/storyboard: OAuth check for response_type 'code'  https://review.openstack.org/15306917:44
yolandaok +217:45
openstackgerritMerged openstack-infra/storyboard: OAuth check for no response_type  https://review.openstack.org/15310717:49
openstackgerritMerged openstack-infra/storyboard: OAuth check for no client_id  https://review.openstack.org/15310817:49
openstackgerritMerged openstack-infra/storyboard: OAuth validates redirect_uri  https://review.openstack.org/15340517:50
krotscheckdum dee dum dee dum17:50
yolandahow much lines of code have you written in the latest days?17:51
krotscheckMe?17:51
krotscheckNo idea17:51
openstackgerritMerged openstack-infra/storyboard: OAuth Authorize Scope Validation  https://review.openstack.org/15340617:55
openstackgerritMerged openstack-infra/storyboard: OAuth tests for authorize_return  https://review.openstack.org/15340717:57
openstackgerritMerged openstack-infra/storyboard: OAuth Exception on invalid oauth return data  https://review.openstack.org/15340817:57
*** mrmartin has joined #storyboard18:01
*** mrmartin has quit IRC18:14
*** mrmartin has joined #storyboard18:39
*** jedimike has quit IRC18:42
*** mattfarina has quit IRC19:04
*** mattfarina has joined #storyboard19:04
*** mrmartin has quit IRC19:32
*** mrmartin has joined #storyboard19:47
*** mrmartin has quit IRC19:49
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: OAuth Validate Token Grant Types  https://review.openstack.org/15367420:17
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: OAuth tests for invalid authorization codes.  https://review.openstack.org/15367520:17
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: OAuth tests for invalid authorization codes.  https://review.openstack.org/15367520:18
yolandakrostcheck, how do you see the spec? makes sense to start working on it, or shall i wait for final approval?20:22
yolandai want to give a shot over the weekend20:22
yolandayou are a test machine :)20:22
krotscheckI’m annoyed at our lack of coveage.20:23
krotscheckyolanda: I’ve got two more to do, then I’ll look at the spec.20:23
yolandaok, just ping me here or on the spec and i'll catch tomorrow20:23
yolandabasically i added your comments there, to clarify that a bit more20:28
yolandaleaving for the weekend, have a nice day!20:29
krotscheckToodles!22:02
*** mattfarina has quit IRC22:02
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: Remaining functional tests for the OAuth Endpoint  https://review.openstack.org/15275222:06
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: OAuth delete refresh tokens when access tokens deleted.  https://review.openstack.org/15371022:07
*** mattfarina has joined #storyboard22:10
*** mattfarina has quit IRC22:10
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: OAuth now validates client ID against a configured list.  https://review.openstack.org/15371522:19
krotscheckHeads up, everyone ^^ downstream breaking change.22:20
krotscheck(i.e. dependent on new configuration flag)22:20
krotscheckBut with that, I’m done with oauth.22:20
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: Explicit Hook Priorities  https://review.openstack.org/15225322:21
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: Pass the old entity values in the NotificationHook  https://review.openstack.org/15164522:50
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: API events now include resource before/after state.  https://review.openstack.org/15231822:51
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: Email base plugin.  https://review.openstack.org/15194822:52
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: Email Templating Engine  https://review.openstack.org/14773422:52
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: Email SMTP Sender  https://review.openstack.org/14979222:52
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: Email configuration.  https://review.openstack.org/15194622:52
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: [WIP] Email Send Cron Worker  https://review.openstack.org/15141622:52
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: Email Working Directory Utility Method  https://review.openstack.org/15194722:52
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: Email Outbox  https://review.openstack.org/15141322:52
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: Email base plugin.  https://review.openstack.org/15194822:55
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: Email SMTP Sender  https://review.openstack.org/14979222:55
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: [WIP] Email Send Cron Worker  https://review.openstack.org/15141622:55
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: Email Working Directory Utility Method  https://review.openstack.org/15194722:55
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: Email Outbox  https://review.openstack.org/15141322:55
*** reed has quit IRC23:11

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!