*** reed has quit IRC | 00:08 | |
*** Piet has quit IRC | 00:22 | |
*** openstack has joined #storyboard | 01:34 | |
*** mase_x200 has joined #storyboard | 01:36 | |
*** mase_x200 has quit IRC | 02:09 | |
*** mase_x200 has joined #storyboard | 02:48 | |
*** mattfarina has joined #storyboard | 03:40 | |
*** mase_x200 has quit IRC | 03:57 | |
*** mattfarina has quit IRC | 04:51 | |
*** mrmartin has joined #storyboard | 05:34 | |
*** mrmartin has quit IRC | 05:44 | |
*** mrmartin has joined #storyboard | 06:19 | |
*** openstackgerrit has quit IRC | 06:35 | |
*** openstackgerrit has joined #storyboard | 06:35 | |
*** mrmartin has quit IRC | 06:56 | |
*** jtomasek has joined #storyboard | 07:34 | |
*** CTtpollard has joined #storyboard | 08:30 | |
*** ssam2 has joined #storyboard | 08:52 | |
*** mrmartin has joined #storyboard | 08:54 | |
*** jtomasek has quit IRC | 09:30 | |
*** jtomasek has joined #storyboard | 09:33 | |
*** jtomasek has quit IRC | 09:43 | |
*** MaxV has joined #storyboard | 09:45 | |
*** jcoufal has joined #storyboard | 09:46 | |
CTtpollard | are you here yolanda? | 09:54 |
---|---|---|
yolanda | hi | 09:55 |
yolanda | always :) | 09:55 |
CTtpollard | :q | 09:55 |
CTtpollard | :) | 09:55 |
CTtpollard | 'vim' | 09:55 |
*** jcoufal has quit IRC | 09:55 | |
yolanda | what's up, CTpollard? | 09:57 |
CTtpollard | just looking at how to override the default storyboard icon | 09:57 |
*** jtomasek has joined #storyboard | 09:57 | |
CTtpollard | would it just be a case of replacing storyboard.svg? | 09:58 |
yolanda | mm, we have some css in place for themes, so do you have a new theme? | 10:02 |
CTtpollard | nothing much i want to change, I've changed brand colour and favicion | 10:02 |
CTtpollard | just want to change the storyboard logo now | 10:03 |
yolanda | so what i can see is that it uses a custom-icon font | 10:03 |
yolanda | and there is an icon_storyboard | 10:04 |
CTtpollard | there is stroyboard.svg in /src/fonts/src | 10:04 |
yolanda | mm, you need to edit the custom_icons.svg | 10:06 |
yolanda | it's the one that seems to be used | 10:06 |
CTtpollard | :q | 10:09 |
CTtpollard | :/ | 10:09 |
*** jedimike has joined #storyboard | 10:10 | |
CTtpollard | ok I'll give it a go | 10:24 |
CTtpollard | ty :) | 10:24 |
*** jcoufal has joined #storyboard | 10:33 | |
openstackgerrit | Merged openstack-infra/storyboard: OAuth Storage Abstraction Removed https://review.openstack.org/153106 | 10:38 |
openstackgerrit | Merged openstack-infra/storyboard: OAuth Functional Tests https://review.openstack.org/153068 | 10:40 |
*** reed has joined #storyboard | 11:21 | |
*** mrmartin has quit IRC | 11:56 | |
*** wendar has quit IRC | 12:19 | |
*** rainya has quit IRC | 12:19 | |
*** wendar has joined #storyboard | 12:20 | |
*** rainya has joined #storyboard | 12:20 | |
*** alexismonville has joined #storyboard | 13:04 | |
*** alexismonville has quit IRC | 13:37 | |
*** alexismonville has joined #storyboard | 13:43 | |
openstackgerrit | Merged openstack-infra/storyboard-webclient: Fix to show errors again https://review.openstack.org/153176 | 14:31 |
*** mattfarina has joined #storyboard | 14:32 | |
*** CTtpollard has quit IRC | 14:45 | |
*** CTtpollard has joined #storyboard | 14:48 | |
openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added controller for refresh tokens https://review.openstack.org/153591 | 15:05 |
openstackgerrit | Nikita Konovalov proposed openstack-infra/storyboard: User abort call instead of returning response https://review.openstack.org/152515 | 15:07 |
openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added new paginate query https://review.openstack.org/153231 | 15:24 |
*** alexismonville has quit IRC | 15:25 | |
*** Piet has joined #storyboard | 15:31 | |
*** MaxV has quit IRC | 15:44 | |
*** CTtpollard has quit IRC | 15:46 | |
*** CTtpollard has joined #storyboard | 15:57 | |
*** alexismonville has joined #storyboard | 16:02 | |
openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added milestones https://review.openstack.org/152500 | 16:14 |
*** jcoufal has quit IRC | 16:19 | |
*** openstackgerrit has quit IRC | 16:21 | |
*** openstackgerrit has joined #storyboard | 16:22 | |
*** CTtpollard has quit IRC | 16:54 | |
*** jtomasek has quit IRC | 17:00 | |
*** alexismonville has quit IRC | 17:09 | |
*** ssam2 has quit IRC | 17:22 | |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: OAuth Authorize Scope Validation https://review.openstack.org/153406 | 17:29 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: OAuth tests for authorize_return https://review.openstack.org/153407 | 17:29 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: OAuth validates redirect_uri https://review.openstack.org/153405 | 17:29 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: OAuth check for no response_type https://review.openstack.org/153107 | 17:29 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: OAuth checks for remote data access permissions. https://review.openstack.org/153409 | 17:29 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: OAuth Exception on invalid oauth return data https://review.openstack.org/153408 | 17:29 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: OAuth check for no client_id https://review.openstack.org/153108 | 17:29 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: OAuth check for response_type 'code' https://review.openstack.org/153069 | 17:29 |
krotscheck | Anyone want to help kick off a merge tornado? https://review.openstack.org/#/c/153069/ | 17:30 |
yolanda | hi | 17:30 |
yolanda | reviewing that | 17:30 |
yolanda | mm, i still see missing _() in that change? | 17:31 |
yolanda | shall i ignore i? | 17:31 |
yolanda | it? | 17:32 |
yolanda | mm, my change for showing errors have been merged, but i don't see results yet.. maybe it takes some time to go through puppet? | 17:36 |
yolanda | it works locally for me, but errors are not displayed on production yet | 17:37 |
krotscheck | yolanda: I added the _() call in decorators.py, but the very next patch converts all the error messages into constants that all have the _() around them. | 17:43 |
krotscheck | yolanda: Here-> https://review.openstack.org/#/c/153107/3/storyboard/api/auth/__init__.py | 17:43 |
openstackgerrit | Merged openstack-infra/storyboard: OAuth check for response_type 'code' https://review.openstack.org/153069 | 17:44 |
yolanda | ok +2 | 17:45 |
openstackgerrit | Merged openstack-infra/storyboard: OAuth check for no response_type https://review.openstack.org/153107 | 17:49 |
openstackgerrit | Merged openstack-infra/storyboard: OAuth check for no client_id https://review.openstack.org/153108 | 17:49 |
openstackgerrit | Merged openstack-infra/storyboard: OAuth validates redirect_uri https://review.openstack.org/153405 | 17:50 |
krotscheck | dum dee dum dee dum | 17:50 |
yolanda | how much lines of code have you written in the latest days? | 17:51 |
krotscheck | Me? | 17:51 |
krotscheck | No idea | 17:51 |
openstackgerrit | Merged openstack-infra/storyboard: OAuth Authorize Scope Validation https://review.openstack.org/153406 | 17:55 |
openstackgerrit | Merged openstack-infra/storyboard: OAuth tests for authorize_return https://review.openstack.org/153407 | 17:57 |
openstackgerrit | Merged openstack-infra/storyboard: OAuth Exception on invalid oauth return data https://review.openstack.org/153408 | 17:57 |
*** mrmartin has joined #storyboard | 18:01 | |
*** mrmartin has quit IRC | 18:14 | |
*** mrmartin has joined #storyboard | 18:39 | |
*** jedimike has quit IRC | 18:42 | |
*** mattfarina has quit IRC | 19:04 | |
*** mattfarina has joined #storyboard | 19:04 | |
*** mrmartin has quit IRC | 19:32 | |
*** mrmartin has joined #storyboard | 19:47 | |
*** mrmartin has quit IRC | 19:49 | |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: OAuth Validate Token Grant Types https://review.openstack.org/153674 | 20:17 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: OAuth tests for invalid authorization codes. https://review.openstack.org/153675 | 20:17 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: OAuth tests for invalid authorization codes. https://review.openstack.org/153675 | 20:18 |
yolanda | krostcheck, how do you see the spec? makes sense to start working on it, or shall i wait for final approval? | 20:22 |
yolanda | i want to give a shot over the weekend | 20:22 |
yolanda | you are a test machine :) | 20:22 |
krotscheck | I’m annoyed at our lack of coveage. | 20:23 |
krotscheck | yolanda: I’ve got two more to do, then I’ll look at the spec. | 20:23 |
yolanda | ok, just ping me here or on the spec and i'll catch tomorrow | 20:23 |
yolanda | basically i added your comments there, to clarify that a bit more | 20:28 |
yolanda | leaving for the weekend, have a nice day! | 20:29 |
krotscheck | Toodles! | 22:02 |
*** mattfarina has quit IRC | 22:02 | |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Remaining functional tests for the OAuth Endpoint https://review.openstack.org/152752 | 22:06 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: OAuth delete refresh tokens when access tokens deleted. https://review.openstack.org/153710 | 22:07 |
*** mattfarina has joined #storyboard | 22:10 | |
*** mattfarina has quit IRC | 22:10 | |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: OAuth now validates client ID against a configured list. https://review.openstack.org/153715 | 22:19 |
krotscheck | Heads up, everyone ^^ downstream breaking change. | 22:20 |
krotscheck | (i.e. dependent on new configuration flag) | 22:20 |
krotscheck | But with that, I’m done with oauth. | 22:20 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Explicit Hook Priorities https://review.openstack.org/152253 | 22:21 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Pass the old entity values in the NotificationHook https://review.openstack.org/151645 | 22:50 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: API events now include resource before/after state. https://review.openstack.org/152318 | 22:51 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email base plugin. https://review.openstack.org/151948 | 22:52 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email Templating Engine https://review.openstack.org/147734 | 22:52 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email SMTP Sender https://review.openstack.org/149792 | 22:52 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email configuration. https://review.openstack.org/151946 | 22:52 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: [WIP] Email Send Cron Worker https://review.openstack.org/151416 | 22:52 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email Working Directory Utility Method https://review.openstack.org/151947 | 22:52 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email Outbox https://review.openstack.org/151413 | 22:52 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email base plugin. https://review.openstack.org/151948 | 22:55 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email SMTP Sender https://review.openstack.org/149792 | 22:55 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: [WIP] Email Send Cron Worker https://review.openstack.org/151416 | 22:55 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email Working Directory Utility Method https://review.openstack.org/151947 | 22:55 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email Outbox https://review.openstack.org/151413 | 22:55 |
*** reed has quit IRC | 23:11 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!