| *** openstackgerrit has quit IRC | 00:16 | |
| *** openstackgerrit has joined #storyboard | 00:17 | |
| *** mrmartin has joined #storyboard | 06:31 | |
| *** mrmartin has quit IRC | 06:35 | |
| *** wuhg has joined #storyboard | 08:13 | |
| *** mrmartin has joined #storyboard | 08:25 | |
| *** openstackgerrit has quit IRC | 09:16 | |
| *** openstackgerrit has joined #storyboard | 09:17 | |
| Zara | morning, storyboard! | 10:22 |
|---|---|---|
| SotK | morning! | 10:24 |
| * pedroalvarez waves | 10:24 | |
| SotK | I can finally speak without being chased away | 10:25 |
| SotK | :) | 10:25 |
| Zara | \o/ | 10:27 |
| Zara | depends on what you say :P | 10:27 |
| * SotK only ever says nice things! | 10:28 | |
| Zara | that's because StoryBoard is a mythical utopia. | 10:30 |
| SotK | Comment event notifications need to link to the comment | 10:45 |
| SotK | or at least to the story the comment is on | 10:45 |
| Zara | Maybe we should start by putting together a list of events? (I'm not sure how much of that is already done) I started a spec plan thing for notifications in general here, though it's still very woolly: https://wiki.openstack.org/wiki/StoryBoard/Notifications | 10:49 |
| Zara | If it's the same as the options in 'timeline events' in user preferences, is that a sufficient list? | 10:49 |
| SotK | there might be more for subscriptions to projects/project groups | 10:50 |
| * SotK isn't sure though | 10:51 | |
| Zara | I think there should be if there aren't, though it might not be the highest priority. I'm also not sure what 'user comment' means in that list atm. | 10:52 |
| Zara | ie: update timeline when the user comments? or when another user comments in their thread? or when a story they've commented on updates? | 10:53 |
| SotK | the "timeline" being referred to is the "comments section" bit of a story | 10:54 |
| Zara | oh, I thought it corresponded to 'recent events' on the dashboard? | 10:56 |
| Zara | (I may need more tea before I can type in a readable way. :P) | 10:56 |
| SotK | nope, they come from the "subscription_events" table in the database | 10:57 |
| SotK | which is populated by the subscription worker iirc | 10:57 |
| SotK | that works by each time there is a PUT POST or DELETE running a function that creates records in that table for people who are subscribed to the object referred to by the PUT, POST or DELETE | 10:58 |
| SotK | where "subscribed to" == "subscribed to the thing or a thing containing the thing" | 10:59 |
| Zara | ah, I was talking about how they're displayed rather than how they're decided; we might be taking about two halves of the same thing? | 10:59 |
| SotK | perhaps, but I don't know if any filtering based on those preferences is done | 11:00 |
| SotK | (for recent events, it is done in the story detail page) | 11:00 |
| * SotK checks | 11:00 | |
| Zara | ohhh, I see what you mean | 11:01 |
| Zara | I never noticed that was called 'events timeline' | 11:01 |
| Zara | so I was thoroughly confused, that makes sense. though that does make me wonder how far 'recent events' corresponds to a combination of 'user preferences' and the various 'events timelines' | 11:02 |
| * SotK unchecks everything and still sees all of the recent events | 11:02 | |
| Zara | hm, is that past recent events or new ones? | 11:03 |
| Zara | maybe unchecking can't delete things from the list but can stop things being added? | 11:03 |
| SotK | past ones | 11:03 |
| Zara | whew. | 11:04 |
| SotK | I'll see if it does anything for new ones | 11:04 |
| * SotK finds a bug on the preferences page | 11:04 | |
| Zara | \o/ | 11:05 |
| * SotK finds another bug, his preferences aren't being updated | 11:06 | |
| Zara | \o/ \o/ | 11:07 |
| SotK | pedroalvarez: did you ever have any luck getting openstackid working with storyboard? | 11:39 |
| * Zara updates spec page thing with new knowledge. | 11:51 | |
| pedroalvarez | SotK: nope, I guess I didn't configure it properly. | 11:53 |
| pedroalvarez | storyboard failed with that openid because it wasn't giving some information that storyboard needs (full name in my case) | 11:53 |
| Zara | going back through reviews now. other patches depend on these: https://review.openstack.org/#/c/222268/4 and https://review.openstack.org/#/c/231971/ , which are awaiting further review. I've tested them and they don't seem to break anything, but would be good to get another pair of eyes when someone has a minute. | 12:11 |
| SotK | relating to discussion elsewhere, I think that I want to assert that migrations 022 and 042 are broken | 12:32 |
| pedroalvarez | \o/ | 12:32 |
| SotK | either that or searching needs to work without fulltext indexes | 12:32 |
| pedroalvarez | \o/ for that too | 12:33 |
| SotK | 022 is idempotent if the database's reported version is less than 5.6 (which assumes it is using mysql instead of checking) | 12:34 |
| pedroalvarez | that's true, my suggestion was to check for the feature instead of checking for a version number | 12:34 |
| SotK | that also means that 022 leaves behind a database that raises errors when used by the API if the database !mysql with version >= 5.6 | 12:34 |
| pedroalvarez | given that mariadb will report different version numbers and will have the features needed | 12:34 |
| pedroalvarez | indeed | 12:35 |
| pedroalvarez | awfull errors | 12:35 |
| pedroalvarez | -; | 12:35 |
| pedroalvarez | -l | 12:35 |
| SotK | checking for the feature would be much better than the current state | 12:37 |
| SotK | I don't know what should happen if the feature isn't present though | 12:37 |
| SotK | I don't like just "do nothing" very much, since that leads to confusing error messages caused by a seemingly successful migration | 12:37 |
| pedroalvarez | I agree, some kind of fallback in the searches would be good too | 12:38 |
| pedroalvarez | (do you have these fulltext indexes? no? then something else) | 12:39 |
| pedroalvarez | we have been living without them for a long time, something else should be possible | 12:39 |
| * SotK creates a story for search fallback | 12:43 | |
| SotK | I'm not entirely sure how to go about changing old migrations | 12:43 |
| pedroalvarez | I'm not a database guy, so my suggestions may be wrong :) | 12:45 |
| persia | Maybe ask in -infra for advice on dealing with old migrations. | 12:47 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Fix tags causing 500 error when editing stories https://review.openstack.org/249208 | 13:30 |
| * SotK unbreaks tags | 13:30 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Don't add unexpected `story_id` attribute to Comment https://review.openstack.org/249219 | 13:49 |
| pedroalvarez | great! | 13:52 |
| SotK | I haven't actually tested that with an updated version of WSME but it no longer adds the offending attribute so it should work I think | 13:52 |
| pedroalvarez | I was having a look at the tags bugfix | 13:57 |
| SotK | ah, thanks :) | 14:01 |
| SotK | pedroalvarez: thanks for testing :) | 14:26 |
| pedroalvarez | I tried that fix, and failed... | 14:31 |
| pedroalvarez | well, I also removed the "{}" | 14:31 |
| pedroalvarez | :) | 14:31 |
| pedroalvarez | i don't know what i did, but I didn't manage | 14:31 |
| SotK | I find that angular's $resource stuff can be very weird sometimes | 14:34 |
| pedroalvarez | the tags bugfix also works | 14:36 |
| SotK | \o/ | 14:36 |
| * SotK tries to remember if he has said he'll do anything else today | 14:39 | |
| pedroalvarez | you need worklists and boards to remember what you are going to do :) | 14:42 |
| Zara | there are updates to the email patches, though idk if you had that planned for today | 14:44 |
| Zara | (am now testing 500 bugfix m'self) | 14:46 |
| SotK | ah yes, I should probably get round to changing that patch I said I'd change | 14:47 |
| Zara | yeah, I think monty put a -1 on it so it was easier to find/remember | 14:47 |
| Zara | heh, thought there was a bug in the tags fix but there's not. is a different bug. sometimes stories don't update until they're refreshed (eg: edit a story's detail page, go back to stories page, then click on the story. change detail won't display until refresh.) | 14:51 |
| Zara | *changed detail | 14:51 |
| SotK | oh huh, that is weird | 14:54 |
| * SotK suspects caching | 14:55 | |
| Zara | yeah, same behaviour on storyboard.openstack.org so definitely nothing strangely unique to my instance | 14:56 |
| Zara | gah, wish it were simpler to reply to review comments in gerrit. | 15:06 |
| SotK | me too | 15:07 |
| pedroalvarez | as in new versions? | 15:07 |
| SotK | yeah, its nice in newer versions (the reply button that is added | 15:08 |
| pedroalvarez | btw, I've put an screenshot in https://review.openstack.org/#/c/231972/ | 15:08 |
| Zara | we should get some common terminology; I was using 'navbar on the left' to refer to the black navbar (that's on the right in that screenshot xD) | 15:12 |
| Zara | I forgot that it flips on smaller screens.... | 15:13 |
| * SotK goes for "sidebar" for that and "top bar" for the green bit in the picture | 15:13 | |
| pedroalvarez | "sidebar" can be also "menu" with "submenus" | 15:14 |
| Zara | I think I referred to it as navbar because that was the word used in the code, I'm not fussed about how we do it but we should probably pick and then have a screenshot on the wiki labelling the different bits. | 15:20 |
| Zara | if the sidebar's always at the side and the topbar's always at the top, that wfm | 15:21 |
| Zara | I could imagine both bars having submenus someday, so I think we should steer away from that. | 15:21 |
| Zara | (naming them that way, I mean) | 15:21 |
| * persia likes "sidebar" and "topbar", and suggests it may be worth a code adjustment to conform to the selected nomenclature | 15:22 | |
| SotK | oh, the lack of link to comments on the dashboard isn't as simple as expected :( | 15:23 |
| Zara | I seem to remember there were a lot of overrides and things that would make it complicated. | 15:23 |
| Zara | for nomeclature, I mean | 15:23 |
| * SotK wonders if Zara is thinking of the bootstrap nav classes here? | 15:24 | |
| SotK | the templates themselves are called "header_menu.html" and "side_menu.html" | 15:24 |
| Zara | yeah, sorry, I think I'm thinking of the classes | 15:25 |
| SotK | oh, its not unsimple, its just a typo causing it to not work | 15:26 |
| SotK | heh | 15:26 |
| Zara | \o/ | 15:28 |
| pedroalvarez | I prefer sidebar without specifying side, given that in small screens it goes to the right :) | 15:29 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Link to the relevant story in comment notifications https://review.openstack.org/249273 | 15:30 |
| * SotK fixes all the small things! | 15:32 | |
| pedroalvarez | hm.. I don't know what bug is that fixing :/ | 15:35 |
| pedroalvarez | I think I've only ever seen one of those notifications | 15:35 |
| pedroalvarez | 2h ago | 15:35 |
| pedroalvarez | and it says "Adam Coldrick updated Fix API for commenting on stories." | 15:35 |
| pedroalvarez | being "Fix API....." a link to the story, and it was working | 15:36 |
| SotK | its only broken in notifications of comments | 15:36 |
| SotK | (eg I have one saying "Zara left a comment 2015-11-13 at 15:26:18 :") | 15:37 |
| SotK | with no context or hint as to where I can find it | 15:37 |
| pedroalvarez | I see, I didn't get any notification for that | 15:38 |
| SotK | you should get them for anything you're subscribed to | 15:38 |
| pedroalvarez | also, the other notification is notifying me of something that happend 5h ago | 15:38 |
| pedroalvarez | saying that it was 5h ago | 15:38 |
| pedroalvarez | sorry | 15:38 |
| pedroalvarez | saying that it was 2h ago | 15:38 |
| pedroalvarez | maybe the notification will arrive in 1h :) | 15:39 |
| * SotK suspects the notifications aren't quite working properly on storyboard.openstack.org | 15:39 | |
| SotK | given I found the story with Zara's comment, and there were more recent comments that I didn't have notifications for | 15:40 |
| persia | Just out of curiosity: if I am subscribed to a project, is there a way to unsubscribe from a specific story therein? | 15:41 |
| SotK | not yet :) | 15:43 |
| * SotK has yet to figure out a neat way of representing that | 15:43 | |
| persia | You might ask the #launchpad team, as they have some way to represent that content. | 15:45 |
| * Zara dunks a pedro's screencap on the wiki with handy labels. feel free to replace wtih something that looks better. :P https://wiki.openstack.org/wiki/StoryBoard | 15:50 | |
| Zara | 'a pedro's?' | 15:50 |
| Zara | "a pedro's" ? | 15:50 |
| Zara | I can't type. best ignore me. | 15:51 |
| pedroalvarez | heh, good | 15:55 |
| Zara | it was meant to be a three second job, but it took longer than expected to find out how to upload + embed a picture. (I thought I could upload it from the edit window, turned out I had to do it from the 'tools' menu at the top of the page, then embed it from the edit window after that.) | 15:57 |
| Zara | so TIL. | 15:57 |
| *** mrmartin has quit IRC | 18:34 | |
| *** b3rnard0 has joined #storyboard | 18:56 | |
| *** wuhg has quit IRC | 19:01 | |
| *** mrmartin has joined #storyboard | 19:35 | |
| *** mrmartin has quit IRC | 19:47 | |
| *** mrmartin has joined #storyboard | 19:55 | |
| *** b3rnard0 is now known as b3rnard0_away | 20:53 | |
| *** mrmartin has quit IRC | 21:01 | |
| *** SotK has quit IRC | 22:16 | |
| *** SotK has joined #storyboard | 22:17 | |
| *** b3rnard0_away is now known as b3rnard0 | 22:56 | |
| *** wuhg has joined #storyboard | 22:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!