| -openstackstatus- NOTICE: Tox tests are broken at the moment. From openstack-infra we are working to fix them. Please don't approve changes until we notify that tox tests work again. | 09:32 | |
| *** openstackgerrit has quit IRC | 10:32 | |
| *** openstackgerrit has joined #storyboard | 10:33 | |
| SotK | good morning! | 10:50 |
|---|---|---|
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Tidy up project groups states https://review.openstack.org/253049 | 10:57 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add an "Unlimited" option to the paging controls https://review.openstack.org/235993 | 10:58 |
| SotK | ugh, the recent events list passes a JSON dump of each event object to the templates rather than passing the object | 12:05 |
| persia | Does that make life easier by allowing streaming updates of recent events, or just consume more cycles in the browser? | 12:25 |
| Zara | (I return! I was ill earlier but I feel better now.) | 12:35 |
| SotK | persia: makes life more difficult because I can't just pass an object that will be useful once its contents are resolved, and instead have to wait for the result before passing it | 12:57 |
| SotK | otherwise the rendered template is blank | 12:58 |
| SotK | Zara: good afternoon! | 12:58 |
| persia | Ah. Somehow I thought there might be some polling function that would consume JSON from the server. Given the situation, it indeed sounds suboptimal. | 12:59 |
| SotK | sadly not, I'd like something like that to be the case eventually though | 12:59 |
| SotK | (also for boards/worklists, so the contents are automatically updated when changed elsewhere | 13:00 |
| SotK | ) | 13:00 |
| pedroalvarez | oh, just remembered, when doing some testing yesteraday I noted that the worklists didn't update automatically after adding some "works" to it | 13:02 |
| pedroalvarez | having to refresh to see them | 13:03 |
| SotK | hmm, it seems to work in Chrome on my test instance (and also on storyboard.sotk.co.uk) | 13:04 |
| pedroalvarez | Just tried in storyboard.openstack.org with what we have right now | 13:12 |
| pedroalvarez | and I needed to F5 | 13:13 |
| SotK | o.O | 13:14 |
| SotK | me too | 13:14 |
| SotK | looks like a race between the items being added and the contents being reloaded | 13:20 |
| * SotK doesn't know why that exists off the top of his head | 13:20 | |
| pedroalvarez | ahh, so I guess it tries to load from the db before they have been created | 13:24 |
| SotK | yeah, its weird because my understanding of the code was that it would load once the update was finished | 13:25 |
| SotK | I must have gone wrong somewhere | 13:25 |
| pedroalvarez | GET happens at the same time than the POST | 13:37 |
| pedroalvarez | (i'm talking like an expert here but I'm just looking at google chrome network tab) | 13:37 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Make the recent events list collapsible https://review.openstack.org/253497 | 13:40 |
| pedroalvarez | well, that was fast | 13:41 |
| SotK | ah, its because the load is triggered by the modal closing not the request returning | 13:44 |
| pedroalvarez | Oh! I remember another bug | 14:07 |
| SotK | heh, what was it? | 14:08 |
| pedroalvarez | I won't tell until I can reproduce it :) | 14:08 |
| pedroalvarez | Nope, I cant reproduce it | 14:10 |
| pedroalvarez | link in tasks (not stories) in worklist weren't working properly | 14:10 |
| pedroalvarez | but seems to work fine in s.openstack.o and s.sotk.co.uk | 14:11 |
| SotK | hmm, I think Zara saw that once upon a time too | 14:11 |
| SotK | but I thought I'd fixed it | 14:11 |
| pedroalvarez | yeah, not to worry | 14:19 |
| pedroalvarez | it is probably fixed given that it works in other places | 14:19 |
| pedroalvarez | btw, I'm the owner of the first worklist in production | 14:22 |
| pedroalvarez | muahahah | 14:22 |
| * SotK really dislikes his "add items to worklists" UI now he's used it on the production db | 14:24 | |
| Zara | :D | 14:24 |
| SotK | it was fine on my test instance with only a few stories, but showing the first 5 results from nearly 700 stories is useless | 14:26 |
| Zara | yeah, most UX problems we've encountered with our patches seem to be to do with things being scaled up in unpredicted ways in production. We really could do with that dev branch with a big db. | 14:28 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Don't close the "add item" modal until the items are added https://review.openstack.org/253526 | 14:28 |
| SotK | Zara: storyboard.sotk.co.uk is now using the production db from earlier in the week :) | 14:28 |
| SotK | however, it currently is a mish-mash of patches | 14:28 |
| SotK | and not called storyboard-dev.openstack.org | 14:28 |
| Zara | heheh, yaeh, I wasn't sure if it counted, yet | 14:29 |
| Zara | guess not | 14:30 |
| SotK | getting closer though :) | 14:30 |
| SotK | pedroalvarez: does https://review.openstack.org/253526 fix the add items thing for you? | 14:30 |
| pedroalvarez | SotK: that indeed works | 14:46 |
| pedroalvarez | btw, I tried yesterday to look at how to add a checkbox to the preferences for tag events, but failed to understand how it works :S | 14:55 |
| pedroalvarez | (which is my main problem with angular :) | 14:55 |
| Zara | welcome to the club! :D | 14:56 |
| pedroalvarez | too much magic | 14:57 |
| pedroalvarez | but I see the point, I've done JS in the past without using any framework | 14:57 |
| Zara | yeah, the thing I find trickiest with angular is the naming of the different parts-- you have services, and resources, and factories, and modules, and controllers, and none of the terms are used in a standard way. So currently I roughly understand how controllers and modules work with the templates, but once it gets deeper into the services and resource stuff, I have to look at help guides every time. | 15:00 |
| Zara | help guides and the existing code, that is, and move things around until they work, then try to puzzle out why. :/ | 15:00 |
| Zara | I daresay that's normal in software, but it makes me feel slow. | 15:01 |
| pedroalvarez | the tricky for me is when you try to grep for a string that you think it's useful, and you can't find it anywhere else | 15:02 |
| pedroalvarez | :) | 15:02 |
| pedroalvarez | s/useful/useful to understand what's going on in the code/ | 15:03 |
| Zara | heh | 15:03 |
| Zara | there's also something where variable names between two files can be subtly different, but I can't remember exactly what it was now (something to do with dots or underscores or something swapping around) | 15:09 |
| Zara | which makes grepping a pain | 15:09 |
| * pedroalvarez finishes reviewing easy patches | 15:12 | |
| Zara | (aha, I'm not imagining things; it's mentioned here: https://egghead.io/lessons/angularjs-isolate-scope-two-way-binding#/tab-discuss . Conversion of camelCase to dashes.) | 15:16 |
| * SotK likes that we have loads of variables called `currentUser` and also a service (I think its a service) called `CurrentUser` | 15:17 | |
| SotK | fsvo likes | 15:17 |
| Zara | ahaha yeah | 15:17 |
| SotK | pedroalvarez: what didn't you understand about them? | 15:17 |
| Zara | also in general things are getting unwieldy in the controllers | 15:18 |
| Zara | we're importing lots of thigns | 15:18 |
| Zara | (I'm pretty sure there's one somewhere that has 'Stories, Story and story' or something like that | 15:19 |
| Zara | ah, yeah, the story detail controller. not quite as I remembered, but: | 15:23 |
| Zara | function ($log, $rootScope, $scope, $state, $stateParams, $modal, Session, | 15:23 |
| Zara | Preference, TimelineEvent, Comment, TimelineEventTypes, story, | 15:23 |
| Zara | Story, creator, tasks, Task, DSCacheFactory, User, | 15:24 |
| Zara | storyboardApiBase, SubscriptionList, CurrentUser, | 15:24 |
| Zara | SessionModalService) { | 15:24 |
| Zara | maybe 'importing' isn't quite the right word since it implies dependencies or something, rather than just existing services and things, but yeahhhh | 15:25 |
| SotK | I think 'injecting' is the word | 15:27 |
| Zara | hah, I considered saying 'injecting' and then thought that might be confusing for people used to anything other than angular (and I wasn't 100% sure I'd be right to use it). good to know I've not got it confused, anyway. | 15:29 |
| Zara | btw, search dropdown for worklists probably needs to hide previous searches and only show the dropdown of items found | 15:34 |
| Zara | atm I get a dropdown of previous searches obscuring the first couple of results | 15:34 |
| SotK | yeah, I noticed that today | 15:34 |
| SotK | damn web browsers being clever | 15:35 |
| Zara | iirc I noticed it a few days ago but had already lumped about 5 more important bugs on you or something | 15:35 |
| Zara | hm, doesn't seem to be a way to save changes to a worklist (eg: the title). might have mentioned it. | 15:36 |
| SotK | just click the pencil again :) | 15:37 |
| * SotK is aware that that UI is horrible | 15:37 | |
| Zara | ahhh, a secret save button | 15:37 |
| Zara | secret save pencil works | 15:38 |
| * SotK tries to remember the magic that was required to set up rabbitmq | 15:39 | |
| Zara | I hope it's clear when CI comes back | 16:26 |
| * SotK too | 16:26 | |
| Zara | the notice saying it was down would have been easy to miss over a weekend etc, since it's not in the topic | 16:26 |
| pedroalvarez | <yolanda> ttx, fungi, can you send a notice to status, telling that everything should be back again?¿ | 16:30 |
| SotK | \o/ | 16:31 |
| pedroalvarez | merge all the things :D | 16:31 |
| Zara | I'm still half waiting for someone to say 'WAIT, DON'T MERGE ANYTHING YET' | 16:36 |
| pedroalvarez | hehe, yolanda is waiting for this patch to be merged (https://review.openstack.org/#/c/253586/) to be able to announce it :) | 16:37 |
| Zara | :D | 16:37 |
| Zara | should we aim to get a storyboard release ready for the next milestone? I'm not sure how all this works. ( ones from this milestone: http://docs.openstack.org/releases/releases/mitaka.html ) | 16:38 |
| Zara | Jan 19th-21st is the next milestone date. | 16:38 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Document manually setting up notifications https://review.openstack.org/253591 | 16:39 |
| * SotK suspects Zara may find https://review.openstack.org/253591 useful | 16:40 | |
| Zara | way ahead of ya | 16:43 |
| Zara | well I wrote that afterwards | 16:43 |
| Zara | but only because I was already looking at it | 16:43 |
| Zara | honest | 16:43 |
| SotK | :) | 16:43 |
| Zara | not sure I'll have time for it tonight (if something acts weirdly I won't have a good chunk of time to debug) but should be able to look at it early next week | 16:43 |
| SotK | there is no rush, but I figured it would be useful to document it | 16:44 |
| Zara | yeah, agreed | 16:44 |
| Zara | especially since we reckon the vagrant up steps aren't sufficient yet | 16:45 |
| SotK | I think they are, but just unclear | 16:45 |
| SotK | (source: I span up a vagrant machine to run unit tests in) | 16:45 |
| Zara | ah, okay. hadn't used them myself. either way, I'm hoping betherly can help with that side a bit when she has time to set up a dev vm :) | 16:46 |
| -openstackstatus- NOTICE: The earlier JJB bug which disrupted tox-based job configurations has been reverted and applied; jobs seem to be running successfully for the past two hours. | 16:55 | |
| pedroalvarez | there you go | 16:55 |
| Zara | :P | 16:55 |
| SotK | \o/ | 16:59 |
| * Zara merges all the things | 17:00 | |
| Zara | I daresay, in practise, one will merge and all the others will need rebasing | 17:00 |
| Zara | but hey | 17:00 |
| * SotK adds a little to https://wiki.openstack.org/wiki/StoryBoard/Notifications | 17:00 | |
| Zara | ooh, thanks | 17:01 |
| Zara | I hope the general ordering of things made sense so it was straightforward to edit | 17:01 |
| Zara | every time I look at it I seem to shuffle everything around ^^' | 17:01 |
| openstackgerrit | Merged openstack-infra/storyboard: Work around "duplicate preferences" issue https://review.openstack.org/251970 | 17:02 |
| SotK | \o/ | 17:03 |
| Zara | now we wait for everything to break... :S | 17:03 |
| SotK | I don't know if I added in the right place, but I think I did :) | 17:03 |
| SotK | everything to work great again you mean! :P | 17:03 |
| Zara | oh, sorry, that | 17:03 |
| Zara | easy mistake | 17:03 |
| Zara | btw, any conversations on the email patches? afaik they're blocked in review, in much the same place as last week | 17:05 |
| SotK | not yet, sorry | 17:07 |
| Zara | are you okay with chasing that up either tonight or early next week? I'm wary of them hanging around for ages, and a bit worried we'll get too caught up in smaller things and forget about them (not that the preferences stuff is smaller, but the project group ux and things like that). | 17:09 |
| SotK | yeah, I'll chase it on Monday :) | 17:10 |
| Zara | cool, thanks! :) | 17:12 |
| Zara | you've patched it all so fast, so it's a shame that's it's getting held up. | 17:12 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Make the recent events list collapsible https://review.openstack.org/253497 | 17:18 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Don't close the "add item" modal until the items are added https://review.openstack.org/253526 | 17:18 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Update $resource wrappers to use new permissions API https://review.openstack.org/235475 | 17:19 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Tidy up project groups states https://review.openstack.org/253049 | 18:12 |
| *** openstack has joined #storyboard | 23:38 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!