| *** jasondotstar has quit IRC | 01:24 | |
| *** jasondotstar has joined #storyboard | 01:29 | |
| *** cody-somerville- has quit IRC | 02:06 | |
| *** cody-somerville- has joined #storyboard | 02:07 | |
| *** coolsvap|away is now known as coolsvap | 03:36 | |
| *** jtomasek has joined #storyboard | 07:15 | |
| *** coolsvap is now known as coolsvap|away | 08:44 | |
| pedroalvarez | it's not slow anyway | 09:10 |
|---|---|---|
| Zara | morning, storyboard! | 10:13 |
| SotK | morning! | 10:14 |
| Zara | so, am I correct to think that any leftover slowness is down to the way the webclient is doing things? =D | 10:26 |
| SotK | short of us simplifying the query in story_get_all(), I don't think we can speed up the API much more | 10:27 |
| Zara | \o/ | 10:27 |
| * SotK wonders why the speedup on storyboard.o.o hasn't been as drastic as on storyboard.sotk.co.uk | 10:29 | |
| pedroalvarez | latency? | 10:29 |
| pedroalvarez | i don't know :( | 10:29 |
| Zara | are we able to see the speed of GETs there? | 10:31 |
| SotK | pedroalvarez: yeah, latency is the issue I think | 10:32 |
| SotK | (33ms to receive the response on storyboard.sotk.co.uk, 544ms to receive it on storyboard.o.o) | 10:33 |
| Zara | I'm guessing there's not much we can do about that | 10:34 |
| Zara | though guessing that means that any group hosting their own instance on an intranet would have pretty awesome speeds | 10:42 |
| Zara | hm, now wondering about this (ie: if the lag is as noticeable now as it was at the time the story was written. if not, it might be preferable these days to have the fields populate immediately instead of using the spinner) https://storyboard.openstack.org/#!/story/2000183 | 11:08 |
| Zara | especially if the first few fields load fast enough that the loading appears to happen instantaneously. this will be difficult to test, though. | 11:10 |
| Zara | eg: I'm thinking of cases where a user opts to view 100 stories in a go, but only the first 7 will appear on their screen before they have to scroll | 11:11 |
| Zara | ooh, the libravatar api also has openid support | 11:33 |
| * pedroalvarez upgrades baserock's storyboard | 11:37 | |
| Zara | \o/ | 11:38 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Notifications: Don't change the resource_id on POST unnecessarily https://review.openstack.org/267486 | 11:39 |
| SotK | pedroalvarez: nice :D | 11:39 |
| pedroalvarez | with emails enabled. :P | 11:40 |
| Zara | the templates aren't very useful yet! | 11:40 |
| SotK | the patch I just sent will allow comment emails to actually be sent | 11:41 |
| Zara | testing now btw | 11:51 |
| pedroalvarez | I know they aren't really useful yet, but some people might appreciate having them enabled | 11:51 |
| pedroalvarez | I will not have more complains like "it doesn't send emails yet??!?" :) | 11:52 |
| Zara | aw, I'm betting you'll get complaints like 'THESE EMAILS AREN'T USEFUL HOW CAN YOU POSSIBLY THINK THIS IS THE WAY TO DO EMAILS' but we'll see! :) | 11:53 |
| Zara | Idk some engineers seem to have a weird double standard for their own software vs other people's | 11:55 |
| Zara | ie: assuming every feature is the developers' ideal | 11:55 |
| Zara | and that it's not a WIP. | 11:55 |
| pedroalvarez | I understand that openstack's storyboard has more users, mine are just a few, so easier to deal with complains | 11:56 |
| Zara | yeah. I just don't want people yelling abuse at you! :) though I suspect the kind of people who'd do that would do that anyway, whatever you did. | 11:56 |
| Zara | I think everyone in this channel knows where you're coming from, anyway. good luck with it. | 11:58 |
| Zara | SotK: patch looks good, getting the expected messages about comments from the worker! | 12:09 |
| Zara | made test templates and those sent, ace | 12:11 |
| Zara | though then tried sending templates with {{sub_resource}} and it's reporting that as none. {{resource.comment}} doesn't seem to be a thing | 12:21 |
| SotK | argh, comments aren't in the class_mappings dict in notification_hook.py | 12:28 |
| Zara | \o/ | 12:29 |
| Zara | thanks for helping on this. hopefully it'll just be today. | 12:30 |
| SotK | no problem :) | 12:31 |
| Zara | hm, template still not working. sub_resource still none, resource.comment still a blank | 12:41 |
| SotK | can you paste your class_mappings dict? | 12:42 |
| SotK | resource.comment won't exist, but sub_resource should work now | 12:42 |
| Zara | class_mappings = {'task': [models.Task, wmodels.Task], | 12:43 |
| Zara | 'project_group': [models.ProjectGroup, wmodels.ProjectGroup], | 12:43 |
| Zara | 'project': [models.ProjectGroup, wmodels.Project], | 12:43 |
| Zara | 'user': [models.User, wmodels.User], | 12:43 |
| Zara | 'team': [models.Team, wmodels.Team], | 12:43 |
| Zara | 'story': [models.Story, wmodels.Story], | 12:43 |
| Zara | 'branch': [models.Branch, wmodels.Branch], | 12:43 |
| Zara | 'milestone': [models.Milestone, wmodels.Milestone], | 12:43 |
| Zara | 'tag': [models.StoryTag, wmodels.Tag], | 12:43 |
| Zara | 'worklist': [models.Worklist, wmodels.Worklist], | 12:43 |
| Zara | 'board': [models.Board, wmodels.Board], | 12:43 |
| Zara | 'comment': [models.Comment, wmodels.Comment]} | 12:44 |
| SotK | hm, that is the same as my working one... did you definitely restart the worker and the API? | 12:45 |
| Zara | I thought so but should check | 12:45 |
| Zara | aha there we go | 12:46 |
| Zara | ^^' oh well seems to work, anyway | 12:46 |
| SotK | :) | 12:46 |
| Zara | hmm just thinking | 12:50 |
| Zara | so my PUT template is currently Comment added to story {{resource.title}} by {{author.full_name}} | 12:50 |
| Zara | but does that author correspond ot the story? | 12:50 |
| Zara | I'm imagining it matches the resource, not the sub_resource | 12:51 |
| Zara | so it wouldn't say who posted the comment, just who made the story | 12:51 |
| Zara | am I wrong on that? | 12:51 |
| SotK | it matches the legged in user that caused the request to be sent, so it should be the right name for the commenter I think | 12:51 |
| SotK | s/legged/logged | 12:51 |
| Zara | oh okay | 12:51 |
| * SotK thinks "{{author.full_name}} commented on {{resource.title}}" would probably be a nicer subject btw | 12:53 | |
| Zara | sure | 12:54 |
| * SotK tries to think of the best way to change the API to make it easy to find the new/deleted tag | 12:55 | |
| Zara | though we might wanna keep word 'story' in there so it's obvious it refers to one | 12:55 |
| Zara | idk, maybe that's implied. | 12:55 |
| Zara | eh. | 12:55 |
| SotK | if you put a link to the story in the body you probably don't need it I guess | 12:56 |
| Zara | still need to work out how to do that. but agree we need it | 12:57 |
| SotK | I'll look at making publish() take more useful parts of the pecan request object | 12:58 |
| SotK | such as the fqdn and the querystring (which will make it possible to know which tags were added/deleted) | 12:58 |
| openstackgerrit | Zara proposed openstack-infra/storyboard: Add email templates for comments https://review.openstack.org/267534 | 13:01 |
| Zara | ah, I think it's currently possible to know which are created, but not deleted | 13:03 |
| Zara | and yeah, no urls in any nice way yet | 13:03 |
| Zara | I think the only template we're completely missing now is the task deletion one | 13:04 |
| Zara | the others are all wip of varying quality | 13:04 |
| Zara | btw https://review.openstack.org/#/c/265935/ now has enough +1s and 2s to merge | 13:05 |
| * SotK pushes the button | 13:05 | |
| Zara | :D | 13:05 |
| Zara | so this is the error I get when I delete a task atm. http://paste.openstack.org/show/483885/ | 13:15 |
| Zara | it seems to handle deleting tags so I guess it's a question of looking at the difference between them. maybe it's because one is a resource and one is a sub_resource, so tags still have a story_id when deleted | 13:15 |
| Zara | well, tags aren't a sub_resource, sorry | 13:15 |
| Zara | but tags fall under stories | 13:16 |
| SotK | yeah, tags are weird, since they are kind of a sub_resource, but the API for them is odd | 13:18 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Fix Project Group Edit https://review.openstack.org/265935 | 13:18 |
| Zara | I think we really need a link to a story's project on the story detail page. I often navigate to a story via the dash, so the back button doesn't work in those circumstances | 13:39 |
| Zara | well, the task-within-the-story's project | 13:40 |
| Zara | currently there's just the edit button. wonder if that should be part of task metadata, or if it's easier to just make the editable project name function as a link if clicked in a different place. | 13:41 |
| SotK | maybe the project name in the task list should be a link, and there should just be one edit button per task | 13:41 |
| SotK | oh, snap :) | 13:41 |
| Zara | yeah, I'd be in favour of making the fa-pencil-square thing function as an edit button while the name just works as a link | 13:42 |
| Zara | or one edit button if there's a neat place for it | 13:42 |
| Zara | worried it'll look crowded next to delete | 13:42 |
| Zara | but might be fine | 13:42 |
| SotK | so I've engaged my brain re: url, and realised belatedly that the URL in the pecan request object won't be sufficient if we care about federation | 13:43 |
| SotK | or even if we care about having the ability to serve the API and the webclient from different places | 13:44 |
| SotK | aha, but I bet the Referer header will be enough | 13:45 |
| * SotK stops panicking | 13:45 | |
| Zara | made tasks story. https://storyboard.openstack.org/#!/story/2000463 | 13:47 |
| SotK | sending the query string did indeed make the tags template easy to do | 14:21 |
| Zara | \o/ | 14:23 |
| Zara | now you can look at my old efforts and laugh | 14:23 |
| Zara | hmm, started looking at tasks-projects link... | 14:49 |
| Zara | oh nvm | 14:51 |
| Zara | was wondering where pencil-square-o is but I think it's just aliased | 14:51 |
| Zara | to edit | 14:51 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Make task project titles link to projects https://review.openstack.org/267633 | 15:04 |
| Zara | quick fix. maybe not ideal. | 15:04 |
| pedroalvarez | question: is possible that all the emails related to one story appear in the same thread? | 15:06 |
| SotK | I'd imagine so, but I'd have to learn more about what would be required before I could implement it | 15:19 |
| * Zara patches tasks, remembers that task templates are currently a bit dorky | 15:28 | |
| Zara | didn't have a good way of finding what changed | 15:28 |
| Zara | in a user-friendly way. so it just lists the type of resource with ids, and the user can work it out, and then a friendlier list of current task data-- but a bit ugly | 15:29 |
| Zara | http://paste.openstack.org/show/483896/ | 15:29 |
| SotK | hmm | 15:32 |
| openstackgerrit | Merged openstack-infra/storyboard: Notifications: Don't change the resource_id on POST unnecessarily https://review.openstack.org/267486 | 15:33 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Add more detail to event messages https://review.openstack.org/267651 | 15:35 |
| Zara | yay, notification resource_id patch merged! that means https://review.openstack.org/#/c/267534/ can be merged if it gets a +2 | 15:35 |
| * SotK obliges | 15:36 | |
| SotK | I can't really think of a good way to solve this task issue at the moment | 15:38 |
| Zara | if it's a pain then I'm happy for them to be merged and just be slightly less-informative than they would be ideally | 15:39 |
| Zara | I don't want it to block emails entirely. | 15:39 |
| Zara | well, I'd like everything to include a story url where possible, but other than that. | 15:39 |
| Zara | as long as they're more useful than not having them at all would be... | 15:40 |
| Zara | horrible sentence but you get what I mean | 15:40 |
| Zara | yay, it's looking for task delete templates with that patch! | 15:41 |
| Zara | it did still give me an error, but it's looking for it | 15:41 |
| SotK | I can think of some less good ways.... I'll experiment sometime | 15:42 |
| Zara | :) | 15:43 |
| openstackgerrit | Merged openstack-infra/storyboard: Add email templates for comments https://review.openstack.org/267534 | 15:44 |
| Zara | \o/ I'll have to patch it in the future to include a story url, can hopefully do that with others | 15:45 |
| SotK | the patch I sent will allow the url to be included :) | 15:47 |
| SotK | `{{url}}#!/story/{{resource.id}}` is all you'll need | 15:48 |
| SotK | it also makes it easy to find the tag that is being added or deleted... | 15:49 |
| SotK | `{{query_string.split('=', 1)[1]}}` | 15:49 |
| Zara | heh, added was okay for me but deleted was rubbish. | 15:49 |
| Zara | Had to learn a new python thing but it was pretty straightforward | 15:49 |
| Zara | gah, task deletion is giving me the same old error again and not asking for templates | 15:54 |
| SotK | which error is that? | 15:54 |
| Zara | http://paste.openstack.org/show/483901/ | 15:55 |
| SotK | :( | 15:55 |
| Zara | I was testing the 'add more detail to event messages' patch | 15:55 |
| Zara | it asked for templates, I made them | 15:55 |
| Zara | then just got that | 15:56 |
| Zara | will try removing the templates | 15:56 |
| Zara | still not looking for them so it's not an error that happens after that step | 15:57 |
| Zara | gah | 15:57 |
| SotK | do DELETEs work for other things that aren't subresources? | 16:03 |
| Zara | they've been working for tags and other things in the past; tasks were weird. should see if that's changed. | 16:04 |
| SotK | tags are weird because they're sort-of-a-subresource | 16:05 |
| Zara | ah, stories don't do anything on deletion but I don't think we've ever been expecting that | 16:06 |
| Zara | there's no user preference for it | 16:06 |
| Zara | so probably only looked at tags and tasks | 16:06 |
| Zara | tags delete works, tasks delete doesn't, though sometimes it does look for the templates | 16:06 |
| Zara | it's happened a couple of times and I can't work out what's different | 16:06 |
| Zara | wondering if there's a race-condition | 16:07 |
| Zara | hope not. | 16:07 |
| SotK | I suspect its a race between the deletion making it into the database and `subscription_get_all_subscriber_ids()` returning | 16:07 |
| Zara | yay | 16:08 |
| Zara | can we treat tasks as a sort-of-a subresource somehow, just for emails? or does it have to be global? | 16:10 |
| SotK | subresource-ness is decided based on the url used, so it has to be global | 16:11 |
| SotK | we can write a special case for getting subscribers when the actual thing has been deleted though | 16:11 |
| Zara | oh, cool | 16:12 |
| SotK | hmm, might be weird actually | 16:14 |
| Zara | IT'S ALL YOURS HAVE FUN | 16:14 |
| Zara | =D | 16:14 |
| SotK | oh dear, I think if someone is subscribed to just a task (not its story) they won't get an email about the task being deleted | 16:16 |
| SotK | and since the plugin that handles subscriptions obliterates the subscription on deletion we can't easily find out who used to be subscribed | 16:17 |
| SotK | maybe we should change "deleted" to "archived" and not have this problem | 16:17 |
| Zara | wfm | 16:18 |
| Zara | the only issue is if things get enormous, but I guess we could give admin powers of deletion later for those scenarios? | 16:18 |
| SotK | hmm, I'm somewhat wary of permanent deletion of things anyway | 16:20 |
| SotK | I wonder if paulsherwood or persia have opinions on this? | 16:20 |
| Zara | I think it should be an option but not available as easily as it is atm | 16:22 |
| Zara | I also wonder what happens in the case of removing a subscription, ie: if that's treated like a delete | 16:23 |
| SotK | you mean the the subscribed-to thing is deleted? | 16:23 |
| Zara | no, just that the subscription itself is removed | 16:24 |
| SotK | yeah, the subscription is deleted | 16:24 |
| Zara | yeah, to me that makes sense to keep that way, otherwise there could be a loooot of archived subscriptions. | 16:24 |
| SotK | yeah, I only care about not deleting things that are "data" (so stories, projects, tasks, and so on) | 16:26 |
| Zara | you've probably seen on gerrit, but the tests don't like the 'add more detail to event messages' patch. for my part I've tested it and it works. | 16:43 |
| SotK | oops, missed a test update | 16:44 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Add more detail to event messages https://review.openstack.org/267651 | 16:54 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Improve usability of the "Edit project" form https://review.openstack.org/263762 | 17:01 |
| Zara | so other than task-deletion, I'm confident we can get all templates to a minimal state of usefulness very quickly. thanks for helping out today, it's sped things up A LOT | 17:03 |
| SotK | no problem :) | 17:03 |
| Zara | hopefully once event messages patch is merged I can go back to the templates and do things on my own again. | 17:04 |
| Zara | exception being task-deletion, but I don't think that's a frequent-enough use-case that it should be a blocker | 17:04 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Work around task deletion making it impossible to get subscribers https://review.openstack.org/267717 | 17:19 |
| SotK | oh, that won't be enough to make task deletion work | 17:20 |
| Zara | 'just subscribed to other tasks in the story'? | 17:21 |
| Zara | you can't subscribe to a task afaik | 17:21 |
| SotK | you can, but only on the search results page | 17:21 |
| Zara | so there wouldn't be an issue with people getting mail they haven't requested. | 17:21 |
| Zara | oh right | 17:21 |
| Zara | didn't know that | 17:21 |
| Zara | hah | 17:21 |
| Zara | that's really strange. | 17:22 |
| SotK | I knew it was possible but thought there was no button for it in the UI until I found that one yesterday | 17:22 |
| SotK | I don't really know why anyone would ever subscribe to a task instead of the story though | 17:22 |
| Zara | I'm guessing it probably works, too, since I updated all subscribes... maybe not, though | 17:23 |
| Zara | hah | 17:23 |
| Zara | I think it should be an option for users but it's not a high priority for me. | 17:23 |
| Zara | if we can't get task-deletion working nicely with templates, then I'm okay just leaving it for now, anyway, largely because I don't think tasks are deleted that often | 17:24 |
| Zara | marked invalid, yes | 17:24 |
| Zara | it does mean users won't get some mail they've requested, but I'd be okay making a note and trying to fix it after getting initial emails merged | 17:24 |
| SotK | I'll update that patch tomorrow, at the moment the handle_email() function will have a bad time | 17:26 |
| Zara | :) | 17:27 |
| Zara | hope we can get https://review.openstack.org/#/c/267651/ merged soon, since that lets us put urls in emails! then we can link to stories at laaast | 17:28 |
| * SotK decides its time to disappear | 17:36 | |
| SotK | night :) | 17:36 |
| SotK | we'll have emails soon I think \o/ | 17:36 |
| pedroalvarez | yay! | 17:38 |
| Zara | :) soooon! once that patch goes through I'll update mine with urls, after that it's just waiting for things to be merged. | 17:38 |
| Zara | they won't be perfect, but they'll useful :) | 17:38 |
| Zara | *be | 17:38 |
| Zara | okay, heading home! anyone who's interested in having relevant links in their email notifications, https://review.openstack.org/#/c/267651/ is riiiiight there waiting | 17:58 |
| * Zara finishes plugging it for the evening | 17:58 | |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Show Project Groups on search page https://review.openstack.org/267027 | 17:58 |
| Zara | night, all! :) | 17:59 |
| * pedroalvarez reviews given that he asked for that feature | 18:05 | |
| Zara | EXCELLENT LIFE DECISION | 18:06 |
| Zara | right, now I am actually going home | 18:06 |
| Zara | night-night, really this time! | 18:07 |
| openstackgerrit | Merged openstack-infra/storyboard: Add more detail to event messages https://review.openstack.org/267651 | 18:16 |
| *** jtomasek has quit IRC | 21:52 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!