| *** coolsvap|away is now known as coolsvap | 03:36 | |
| *** coolsvap is now known as coolsvap|away | 03:59 | |
| *** coolsvap|away is now known as coolsvap | 04:13 | |
| *** pedroalvarez has quit IRC | 05:02 | |
| *** dabukalam has quit IRC | 05:02 | |
| *** pedroalvarez has joined #storyboard | 05:03 | |
| *** Zara has quit IRC | 07:03 | |
| *** paulsherwood has quit IRC | 07:03 | |
| *** krotscheck has quit IRC | 07:03 | |
| *** Zara has joined #storyboard | 07:04 | |
| *** paulsherwood has joined #storyboard | 07:04 | |
| *** krotscheck has joined #storyboard | 07:04 | |
| *** jtomasek has joined #storyboard | 08:14 | |
| Zara | morning, storyboard! | 09:56 |
|---|---|---|
| Zara | meetup cupcakes are ready! Days in advance, so they may be stale by Weds! =D | 09:57 |
| Zara | stale, but sugary. | 09:57 |
| Zara | hm... just noticed that some patches are stuck on 'needs verified' | 10:06 |
| Zara | specifically the ones for package author, repository field, and license. | 10:07 |
| Zara | that's odd since they have a +1 from jenkins | 10:07 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Make header 'quick navigate' and 'search' clearer https://review.openstack.org/278987 | 10:18 |
| SotK | are they dependent on something that doesn't have workflow +1 | 10:26 |
| SotK | ? | 10:26 |
| Zara | I don't think so. it's this batch: https://review.openstack.org/#/c/278058/ | 10:26 |
| Zara | I haven't got round to testing the bower install one, but the others in that topic shouldn't depend on it afaict | 10:27 |
| SotK | that all seems to depend on https://review.openstack.org/#/c/278057/1 | 10:27 |
| SotK | (depend in the sense that they are later in the branch than it and gerrit doesn't automatically rebase later patches if one of their ancestors is in review) | 10:28 |
| Zara | ahhh, right, I didn't know that. I didn't see anything explicitly saying they depended... | 10:29 |
| Zara | TIL! | 10:29 |
| * SotK finds that the "related changes" section is usually in the right order (with the thing on the bottom needing to be merged first) | 10:30 | |
| Zara | useful to know. I've put off testing that one in case something goes wrong and it takes a while to reinstall dependencies, since I'm expecting a deluge of patches to review this week | 10:31 |
| Zara | I had some troubles originally installing the webclient so yeah, wary. | 10:31 |
| *** jtomasek_ has joined #storyboard | 12:17 | |
| Zara | aw, npm updated their docs and now the old faq stuff is gone. I found it entertaining. | 12:22 |
| *** openstackgerrit_ has joined #storyboard | 12:27 | |
| *** coolsvap is now known as coolsvap|away | 12:36 | |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Move search icon https://review.openstack.org/279204 | 12:39 |
| *** jtomasek_ has quit IRC | 13:20 | |
| * SotK finally gets a due date displaying on a card | 13:59 | |
| Zara | \o/ | 13:59 |
| Zara | time to go home! :D | 13:59 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Show Each Task ID in Story Detail View https://review.openstack.org/272667 | 14:07 |
| Zara | ^ it's a little neater like that. still don't think it looks great; I'd like it to look like the story id next to stories in the story list view | 14:08 |
| Zara | BUT I tested it with pretty big numbers and it was okay | 14:08 |
| Zara | if/when the numbers get realllly big, I should improve it, but there's no point splitting hairs before that. | 14:09 |
| SotK | \o/ | 14:11 |
| * Zara confirms that that should be okay until the number of tasks is > a million times the current number of stories on s.o.o | 14:14 | |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Remove Priority Button https://review.openstack.org/280259 | 14:27 |
| *** b3rnard0_away is now known as b3rnard0 | 14:40 | |
| Zara | aha! I have a moment, so now is a good time to face my old nemesis | 14:44 |
| * Zara does git checkout king-of-the-north | 14:44 | |
| Zara | hm, it's also giving a 401 when trying to post the refresh token (maybe that's just my conf) | 15:01 |
| Zara | hm. far more 401s on the dash than other pages. (3 on projects/project groups/stories; 103 on dash) | 15:19 |
| SotK | I assume the dash makes a bunch more requests than the other pages do | 15:20 |
| Zara | yeah | 15:20 |
| Zara | okay, we definitely can't merge king-of-the-north yet because the dashboard redirect interacts badly with it | 15:21 |
| Zara | I just clicked on a specific project group, refreshed, and when it logged me out it tried to take me to the dash. at which point it got really confused and started making endless requests (and giving 401s in the process) | 15:21 |
| Zara | refreshing a specific project seems to work, though...(?) | 15:23 |
| Zara | and I only get the one 401, for posting the refresh token | 15:23 |
| Zara | so that's interesting | 15:23 |
| Zara | stories also panic and go back to the dash | 15:24 |
| Zara | (a specific story, that is) | 15:24 |
| Zara | so there's something different about the project detail page | 15:25 |
| Zara | okay, so params that project group detail controller has that project detail controller lacks: 'preference', 'subscriptionlist' and 'currentuser'. story detail controller also has these (and more) | 15:35 |
| Zara | *projectgroupdetailcontroller function takes | 15:35 |
| Zara | (though the dashboard redirect persists after I hackily remove those from the project group detail controller, so that's a separate thing.) | 15:53 |
| Zara | hm, sometimes it gives loads of errors, sometimes not... race condition of some sort? | 17:30 |
| Zara | it really seems to dislike it if I refresh after the token's expired. if I just browse to another page, I get fewer errors. | 17:33 |
| *** openstackgerrit has quit IRC | 17:45 | |
| Zara | hacking around in the controllers makes no difference; I think the problem may be to do with the way stories and project groups are resolved in the modules. | 17:46 |
| *** openstackgerrit has joined #storyboard | 17:46 | |
| Zara | (especially since the story detail module looks a lot like the project group one, and is pretty different from the project one.) | 17:46 |
| Zara | yup, deleting the 'pre resolve foo' bits removes the 401s. | 17:50 |
| Zara | though I'd imagine we want to pre-resolve them... | 17:51 |
| Zara | there are still a couple of other 401s, but fixing the way stories/project groups resolve would fix those (of course I have no idea how to do that yet) | 18:01 |
| Zara | heading off now. have written up my findings in the story; hopefully will help a bit. | 18:14 |
| Zara | 'night! | 18:16 |
| *** b3rnard0 is now known as b3rnard0_status | 18:27 | |
| *** b3rnard0_status is now known as b3rnard0 | 19:12 | |
| *** openstackgerrit has quit IRC | 20:17 | |
| *** openstackgerrit_ is now known as openstackgerrit | 20:17 | |
| *** openstackgerrit has quit IRC | 20:17 | |
| *** openstackgerrit_ has joined #storyboard | 20:17 | |
| *** openstackgerrit_ is now known as openstackgerrit | 20:18 | |
| *** openstackgerrit_ has joined #storyboard | 20:19 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!