openstackgerrit | Merged openstack-infra/storyboard: Fix updating automatic worklists with no filters https://review.openstack.org/307362 | 02:33 |
---|---|---|
openstackgerrit | Merged openstack-infra/storyboard-webclient: Go to story from card https://review.openstack.org/306454 | 03:25 |
*** thrace has quit IRC | 03:33 | |
*** thrace has joined #storyboard | 03:36 | |
*** persia has quit IRC | 03:40 | |
*** persia has joined #storyboard | 03:50 | |
*** bethwhite has joined #storyboard | 08:21 | |
Zara | morning, storyboard! | 09:33 |
*** bethwhite has quit IRC | 09:36 | |
*** bethwhite has joined #storyboard | 09:53 | |
Zara | oh, I forgot about https://review.openstack.org/#/c/288910/ | 10:08 |
Zara | will test | 10:08 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Remove pointless variable creation https://review.openstack.org/306401 | 10:08 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Show a modal when editing worklists in a board https://review.openstack.org/306400 | 10:08 |
Zara | argh patches | 10:09 |
SotK | I fixed the "no link when logged out" thing | 10:09 |
Zara | \o/ | 10:09 |
Zara | will take a look after this one | 10:09 |
Zara | I've got Buttery Biscuit Base (or Bass?) stuck in my head | 10:18 |
Zara | this is really distracting | 10:19 |
bethwhite | Zara: ...how?! | 10:54 |
Zara | :D | 10:55 |
betherly | pedroalvarez: i hear you are also enjoying the 'joys' of d3 ;) | 10:56 |
pedroalvarez | betherly: not yet, but yes, I'll start soon :) | 10:58 |
pedroalvarez | for now just looking at some examples like http://bl.ocks.org/GerHobbelt/3104394 | 10:58 |
betherly | pedroalvarez: if you want to collaborate on ideas let me know. its a nightmare of a code base but the effects are awesome | 10:58 |
pedroalvarez | betherly: yeah, same thing for you, although I guess you know a lot more about this than me at the moment :) | 11:00 |
betherly | :) | 11:01 |
* Zara stops making the example go 'boing!' and goes back to testing... ;_; | 11:05 | |
Zara | hahaha, just kidding, I'm still making it go 'boing!' | 11:06 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Properly populate Worklist.items in automatic worklists https://review.openstack.org/307712 | 11:06 |
Zara | :< well one of us is very productive | 11:07 |
SotK | that patch stops automatic worklists always appearing to have 0 items when viewed in the list on the dashboard | 11:07 |
SotK | :) | 11:07 |
Zara | ah, I noticed that and then forgot about it, ace | 11:08 |
openstackgerrit | Merged openstack-infra/storyboard-webclient: Fix dashboard template to show the right information https://review.openstack.org/307448 | 11:16 |
pedroalvarez | \o/ | 11:16 |
*** bethwhite has quit IRC | 11:19 | |
Zara | :D | 11:24 |
Zara | https://review.openstack.org/#/c/306497/ , https://review.openstack.org/#/c/306399/7 and https://review.openstack.org/#/c/306400/8 await reives | 11:28 |
Zara | (well, so does https://review.openstack.org/#/c/306401/8 , but I haven't got to it yet) | 11:29 |
Zara | argh, buttery biscuit base, make it stopppp | 11:30 |
Zara | thanks for the review1 | 11:36 |
Zara | erm, 'review!' | 11:36 |
openstackgerrit | Merged openstack-infra/storyboard-webclient: Don't allow users to interact with cards in automatic worklists https://review.openstack.org/306497 | 11:42 |
Zara | should probably be able to add cards to a manual worklist in the 'create new worklist' modal | 11:43 |
Zara | I think we know about that, just noticing it more since I'm testing them atm | 11:43 |
pedroalvarez | wow 660 jobs in the check queue | 11:44 |
Zara | :0 | 11:45 |
Zara | I think zuul had some downtime the other day or something | 11:45 |
pedroalvarez | It was surprising that the merge of that patch only took 6 minutes | 11:47 |
Zara | hehe | 11:47 |
Zara | I wonder if it's to do with hiding the jenkins logs | 11:48 |
Zara | (ie: maybe it takes a while to put that data up? I don't know.) | 11:48 |
Zara | and now that they can't show them, it's faster as a side effect? | 11:49 |
Zara | ... they're up now... wuh? | 11:50 |
Zara | ... not all of them | 11:51 |
Zara | hm, maybe I misunderstood and there's another thing going on | 11:51 |
Zara | (click on the logs links here to see what I was confused by: https://review.openstack.org/#/c/306399/7 ) | 11:52 |
Zara | huh, they're mostly fine | 11:52 |
Zara | welp Idk what was going on then. | 11:53 |
Zara | =D | 11:53 |
Zara | /strange, nonsensical noise | 11:53 |
persia | I'm a big fan of there being one obvious way to do things, so I'd be opposed to adding cards from the create new worklist dialog: when one creates one, one ought end up in an interface where it is trivial to add cards | 11:57 |
openstackgerrit | Merged openstack-infra/storyboard-webclient: Make the Add Lane button show the new worklist modal https://review.openstack.org/306399 | 12:01 |
Zara | to me, adding cards to a worklist is part of creating it. atm, for automatic worklists, you create a title, private setting and filters in the same step, so it's populated. for a manual one, you only create the title and private setting. seems a bit less fluid than it could be. | 12:05 |
Zara | may depend how different people make todo lists. for my own part I only make one when I want to put something in it and think 'hm, I should note all the tasks related to this somewhere' | 12:06 |
SotK | I'd like to be able to do the initial population based on filters, then use the list manually | 12:06 |
Zara | (so I'd never have a situation where I wanted just a worklist title with no items, but might not be the case for all) | 12:07 |
persia | Needs discussion. While I agree with those models of creating static todo lists, I think them less useful for long-lived dynamic worklists. | 12:07 |
persia | Probably intersects with the priority discussion | 12:07 |
persia | But this is why we have summit, right? | 12:08 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Avoid false positives when filtering projects by subscriber https://review.openstack.org/307756 | 12:24 |
SotK | That fixes a stupid bug that's been annoying me for a while | 12:24 |
Zara | hm, I think we may have crossed wires, so it may help with that (I just can't see what's complicated about this, so think we might be talking about different things... or maybe not!). :) | 12:25 |
Zara | I'm looking forward to talking about scaling storyboard development. more users and general interest means I'm thinking about it more. | 12:25 |
Zara | s/talking/mainly listening, in this case | 12:26 |
Zara | eg: I'm already aware that we should be replying to stories within a limited timeframe, and so on, but we don't have any sort of schedule | 12:28 |
Zara | so atm it's ad-hoc and I tend to do it when I have a moment/I'm procrastinating | 12:29 |
Zara | but that falls by the wayside when I get a lot ot review | 12:29 |
Zara | that kind of thing | 12:29 |
*** bethwhite has joined #storyboard | 12:34 | |
* SotK discovers he didn't write a docstring for the due date deletion endpoint D: | 12:38 | |
Zara | :0 | 12:42 |
Zara | the pitfalls of my generally just testing behaviour.... | 12:43 |
Zara | oh! that reminds me! I meant to tell you off! because I realised it's due_date_permissions but due_dates | 12:44 |
Zara | everything else refers to 'dates', that's the only 'date' | 12:44 |
SotK | because everything else can have multiple due dates, but due dates can only have one set of permissions | 12:45 |
SotK | (was my logic anyway) | 12:45 |
SotK | I don't know if I typed that the right way round | 12:45 |
Zara | ahh, I still think it's confusing to have due_dates and due_date_foo , but it's reasonable... I just know I'd start off by trying to access it with the same word | 12:47 |
Zara | (it catches me out with stories/story and projects/project a bunch) | 12:47 |
SotK | (all the others I've made are "singular_plural" too I think) | 12:47 |
SotK | I think its because I think of it as "relationship between a story and its due dates" | 12:48 |
persia | Despite it hampering text searches, I like the convention of using singular_singular, singular_plural, and plural_plural to hint at the nature of the relationship in the code. | 12:49 |
Zara | yeah, looking at it now, it's consistent with the rest... still think it's a pest in general. :P grr | 12:49 |
persia | Clearly the best solution is to write all code in a language with strictly regular noun forms and append-only declension semantics. | 12:50 |
Zara | :) | 12:51 |
* Zara assigns it to persia, have fun! :D | 12:52 | |
* persia considers the balance between code being searchable or being written in the world's most common second language, and decides that accessibility to humans is better than accessibility to computers in this case. | 12:53 | |
Zara | I see the reasoning for it anyway, so thanks for explaining. I'm fine with it staying that way... I'll just accept that I'll always find it a bit annoying. | 12:53 |
Zara | btw, I noticed it because we wanted to name our cactus, couldn't think of anything, and I had the storyboard schema to hand, as you do. so our mouldy cactus is now named due_date_permissions. | 12:56 |
SotK | :D | 12:57 |
Zara | I'll take a pic sometime. | 12:58 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Add docstring for due dates DELETE endpoint https://review.openstack.org/307806 | 13:08 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Update API docs to include worklists, boards, and due dates https://review.openstack.org/307807 | 13:08 |
*** b3rnard0_away is now known as b3rnard0\ | 13:08 | |
*** b3rnard0\ is now known as b3rnard0 | 13:09 | |
Zara | things in the check pipeline currently say 3hrsish | 13:09 |
Zara | just looked b/c I want to be a bit cautious with testing the api against anything other than what will be in master at the time of merge. | 13:10 |
Zara | well, at least, I want to make sure that one is tested | 13:13 |
persia | I am very excited about landing API bits, because any work on the python client depends on those. | 13:13 |
Zara | :) yeah, my caution is due to the fact that the problems that come where the api and ui don't match up are very disruptive (lots of error messages, inability to create new stories etc, search completely breaking, that kind of thing) | 13:15 |
Zara | so I tend to be slower on api things, even though they're generally more interesting. | 13:16 |
Zara | and even then I miss stuff, like the bug from three weeks ago that I found yesterday... | 13:17 |
Zara | (+ I'm generally boring and cautious and prefer bugfixes to new features, because it's what I care about more as a user, though that's tangential) | 13:19 |
persia | +1 on removing user visible disruption vs. adding new activities. | 13:20 |
*** openstackstatus has joined #storyboard | 13:38 | |
*** ChanServ sets mode: +v openstackstatus | 13:38 | |
-openstackstatus- NOTICE: We have recovered one of our cloud providers, but there is a huge backlog of jobs to process. Please have patience until your jobs are processed | 13:41 | |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Add offset/limit pagination to subscription events https://review.openstack.org/307847 | 14:26 |
Zara | argh all the patches | 14:31 |
* SotK is out of control | 14:32 | |
Zara | ;_; I'm sorry I'm so distracted today... | 15:11 |
Zara | if it's this warm in texas, I can't promise I'll be able to concentrate on anything :0 | 15:11 |
SotK | it'll probably be warmer | 15:11 |
SotK | at least outside | 15:11 |
Zara | +5 for storyboard pool party then | 15:11 |
Zara | huh, the patches have moved down the queue instead of up | 15:13 |
Zara | looks like I'll just have to test with master and waiting changes, annoying. | 15:30 |
*** fay_ has quit IRC | 15:31 | |
Zara | heading off for a bit, will be back for infra meeting... and hopefully to do some review before that | 16:10 |
Zara | and some triage, probably | 16:10 |
*** anteaya has quit IRC | 16:20 | |
openstackgerrit | Merged openstack-infra/storyboard: Allow filtering of worklists and boards by story or task https://review.openstack.org/288910 | 16:22 |
*** fay_ has joined #storyboard | 16:35 | |
Zara | hm, guessing that merged fast as it was already verified, and it's the pre-gate verification that's taking time | 16:39 |
* SotK expects that is why | 16:53 | |
openstackgerrit | Merged openstack-infra/storyboard-webclient: Show a modal when editing worklists in a board https://review.openstack.org/306400 | 17:05 |
Zara | hahaha, finally | 17:05 |
*** b3rnard0 is now known as b3rnard0_away | 17:07 | |
*** bethwhite has quit IRC | 17:10 | |
*** anteaya has joined #storyboard | 17:23 | |
anteaya | Zara: have you seen this etherpad yet? https://etherpad.openstack.org/p/newton-infra-community-task-tracking | 17:23 |
Zara | anteaya: ah, yes, I added the yellow-highlighted text. if there's an issue with it I can remove it | 17:24 |
anteaya | no no no, that is great thank you | 17:25 |
anteaya | add some links to storyboard | 17:26 |
pleia2 | that was the one etherpad I didn't have to create :) (thanks Zara!) | 17:26 |
anteaya | and various links for dashboards and other views | 17:26 |
anteaya | so when folks prepare they can take a look | 17:26 |
anteaya | also link to pleia2's summary email of the infra bug day | 17:26 |
anteaya | as I think that is really useful as a production use case of storyboard | 17:26 |
anteaya | those are my suggestions | 17:27 |
*** mrmartin has joined #storyboard | 17:31 | |
Zara | anteaya: thank you, will do! :) | 17:32 |
Zara | pleia2: yay, thanks! :) | 17:32 |
anteaya | Zara: awesome, thank you | 17:35 |
*** b3rnard0_away is now known as b3rnard0 | 18:54 | |
Zara | howwww is it already 8pm | 19:01 |
anteaya | Zara: you are on that side of the world | 19:02 |
persia | My desktop clock claims it is between 8am and 9am, depending on where one sits. | 19:07 |
persia | To make sure I'm following the discussion, is the plan to do a build of the webclient for every gerrit candidate, and then point those at a "dev" API server that runs trunk so that people can look at client changes easily? | 19:20 |
persia | (presumably by using some secret special per-candidate URI) | 19:20 |
Zara | I think so | 19:26 |
* Zara looks for example | 19:26 | |
Zara | https://review.openstack.org/#/c/306400/ okay, so there, one of the tests is 'js-draft | 19:27 |
Zara | well, gate-storyboard-webclient-js-draft | 19:27 |
Zara | if you click on it... | 19:27 |
SotK | huh, TIL | 19:27 |
persia | Oh, nifty. | 19:29 |
Zara | yeah, that's what my nonsensical ramble was this morning | 19:29 |
Zara | I thought all the tests were doing that instead of pointing to logs | 19:29 |
Zara | then realised 'OH THAT'S WHAT PEOPLE MEANT BY JS-DRAFT BUILDS' | 19:29 |
Zara | lightbulb | 19:29 |
Zara | so yeah, it's using the production api | 19:29 |
persia | Which then allows unreviewed javascript to run as a production user, which may be undesireable. I understand now. | 19:30 |
persia | Thanks for the explanation. | 19:31 |
pedroalvarez | Doubleu tee eff | 19:33 |
pedroalvarez | It's a great idea though, but using prod API.. :) | 19:34 |
Zara | yeah, I wish I'd understood what was going on before today... | 19:37 |
Zara | though I don't think many people are aware of it, so it's hidden-ness has probably stopped it from being abused | 19:37 |
Zara | *its | 19:55 |
Zara | ugh | 19:55 |
persia | Right, but now informed people (including most reviewers) will avoid those links as dangerous, making them less useful until the alternate solution is in place (but there is a plan for that, which is good) | 20:10 |
*** mrmartin has quit IRC | 20:53 | |
*** persia has quit IRC | 22:46 | |
*** thrace has quit IRC | 22:47 | |
*** persia has joined #storyboard | 23:04 | |
*** thrace has joined #storyboard | 23:06 | |
openstackgerrit | Merged openstack-infra/storyboard: Add offset/limit pagination to subscription events https://review.openstack.org/307847 | 23:26 |
*** pleia2 has quit IRC | 23:43 | |
*** pleia2 has joined #storyboard | 23:43 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!