*** openstack has joined #storyboard | 05:58 | |
zaro | anteaya: not sure why your setup didn’t work, i got it to work from my local gerrit work with sb-dev.o.o https://storyboard-dev.openstack.org/#!/story/7 | 06:05 |
---|---|---|
*** perryl_ is now known as perryl | 06:43 | |
*** fay has joined #storyboard | 07:35 | |
*** fay is now known as Guest21566 | 07:35 | |
*** Guest21566 is now known as faybrocklebank | 07:35 | |
*** bethwhite has joined #storyboard | 08:52 | |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: WIP: Remove pagination for timeline events https://review.openstack.org/327682 | 09:40 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Rework timeline events into a timeline https://review.openstack.org/327231 | 09:40 |
Zara | :) | 09:40 |
*** jtomasek_ has joined #storyboard | 10:30 | |
*** jtomasek_ has quit IRC | 10:59 | |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add the ability to permalink to a comment https://review.openstack.org/289078 | 11:32 |
Zara | \o/ | 11:36 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Make task notes button clearer https://review.openstack.org/325292 | 11:44 |
Zara | today's storyboard musical interlude comes courtesy of Django Reinhardt, after whom the Django framework is named. we don't use that framework on this project, but that won't stop me linking the music! https://www.youtube.com/watch?v=Hq0tPjdfHME | 11:54 |
*** bethwhite has quit IRC | 12:43 | |
anteaya | zaro: well that is excellent news, thank you | 13:20 |
anteaya | zaro: I care less about my own failings and more that we can get this on the review-dev server, are you willing to propose a patch? | 13:21 |
zaro | anteaya: sure, but we need to know the use case first. | 14:35 |
zaro | who wanted this? maybe i should talk with them first | 14:35 |
*** jamesmcarthur has joined #storyboard | 14:42 | |
*** bethwhite has joined #storyboard | 15:00 | |
SotK | exciting working comment permalink: http://docs-draft.openstack.org/78/289078/2/check/gate-storyboard-webclient-js-draft/198dc0c//dist/?#!/story/11#comment-4 | 15:11 |
pedroalvarez | really nice | 15:16 |
pedroalvarez | ah, I see, the patch is after the "remove pagination" patches | 15:18 |
SotK | yeah | 15:19 |
SotK | hmm, long timeline events look kinda weird on a small screen | 15:19 |
*** openstackgerrit has quit IRC | 15:34 | |
*** openstackgerrit has joined #storyboard | 15:34 | |
dmsimard | SotK: I get an endless spinning wheel on that link | 15:39 |
dmsimard | brb | 15:39 |
pedroalvarez | I sometimes face the same problem. After loggin in storyboard-dev.openstack.org the link works for me | 15:41 |
pedroalvarez | not sure if that is the best workaround :/ | 15:41 |
SotK | yeah, storyboard-dev and docs-draft don't seem to play entirely nicely | 15:42 |
dmsimard | SotK: some sort of highlight on which comment was permalinked would be nice | 16:03 |
dmsimard | since the page doesn't scroll all the way down, you can't really tell which event was linked to | 16:04 |
dmsimard | kind of like this: http://logs.openstack.org/92/325292/2/check/gate-storyboard-webclient-npm-run-lint/1bbd475/console.html#_2016-06-16_11_53_17_040 | 16:04 |
SotK | it would scroll all the way down if there was enough more content to be displayed, but there weren't many comments on that story | 16:08 |
SotK | I agree highlighting is a good idea though, I'll add something | 16:08 |
*** jamesmcarthur has quit IRC | 17:54 | |
*** bethwhite has quit IRC | 18:14 | |
*** jamesmcarthur has joined #storyboard | 18:50 | |
*** openstackstatus has joined #storyboard | 20:20 | |
*** ChanServ sets mode: +v openstackstatus | 20:20 | |
persia | I don't understand how buck processes version-properties enough to review https://review.openstack.org/330796, but others may be interested | 22:06 |
anteaya | zaro: I want this | 22:19 |
anteaya | zaro: I want storyboard to know about gerrit changes | 22:20 |
anteaya | zaro: other folks want this | 22:20 |
anteaya | zaro: the way launchpad bugs are aware of a patch that is offered up to fix that bug? that is what folks want | 22:20 |
anteaya | zaro: if you can get this on the review-dev server by next Tuesday then folks can play with it during the storyboard bug sprint next Wednesday and Thursday and we can get feedback on functionality | 22:21 |
anteaya | zaro: the point is that the plugin can repor on a storyboard story which is all I wanted to see before it goes in the dev servers and so we can get more feedback | 22:22 |
*** jamesmcarthur has quit IRC | 22:30 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!