| *** alexismonville has quit IRC | 01:16 | |
| *** alexismonville has joined #storyboard | 01:33 | |
| *** alexismonville has quit IRC | 01:45 | |
| *** jmccrory is now known as jmccrory_away_th | 04:20 | |
| *** jmccrory_away_th is now known as jmccrory_away | 04:20 | |
| *** jtomasek has quit IRC | 07:52 | |
| Zara | morning, storyboard! | 09:25 |
|---|---|---|
| Zara | I miss anything exciting during my holiday? | 09:26 |
| pedroalvarez | we finished storyboard! | 09:27 |
| Zara | omg! nice work! :D | 09:27 |
| pedroalvarez | hah | 09:27 |
| Zara | sounds like I was really slowing things down | 09:28 |
| Zara | guess I can just go to bed now | 09:28 |
| Zara | nice | 09:28 |
| Zara | while on holiday, I found a piano piece called 'storyboard', so we now have a theme tune! (and no, I did not search for things called 'storyboard'; I found it by accident!) https://www.youtube.com/watch?v=zK8IObXNF-o | 09:33 |
| openstackgerrit | Merged openstack-infra/storyboard: Add example commands for the Project api https://review.openstack.org/337730 | 09:35 |
| Zara | oh, I think https://review.openstack.org/#/c/325294/ needs a rebase, too | 09:58 |
| dabukalam | odyssey4me: just saw this, was on holiday. Hope all is well. Have you had any luck with storyboard? | 10:11 |
| Zara | commit message for https://review.openstack.org/#/c/333418/ refers to authors, but with superusers patch merged, I think it just applies to superusers. I think it should be authors or superusers... but that's a matter for a different patch (and tbh I should've said that in review for the superusers-editing patch) | 10:21 |
| *** alexismonville has joined #storyboard | 10:47 | |
| *** jtomasek_ has joined #storyboard | 11:22 | |
| Zara | https://review.openstack.org/#/c/335458/ awaits reviews | 11:35 |
| pedroalvarez | that one was quick to review | 11:37 |
| Zara | :) | 11:38 |
| Zara | slowly working through my queue... | 11:38 |
| *** jtomasek_ has quit IRC | 11:44 | |
| SotK | hmm, which superusers patch? | 11:56 |
| Zara | the one that changes editing of comments so only superusers can do it | 11:56 |
| SotK | that was changing it so only superusers can delete comments, it didn't change anything about editing | 11:59 |
| Zara | ohhh, I misread, sorry | 12:02 |
| * Zara is best reviewer | 12:02 | |
| Zara | they were paired together in other patches, so must've assumed; sorry for nosie | 12:03 |
| Zara | erm, noise | 12:03 |
| Zara | argh I forgot to turn my email worker on over the weekend jic | 12:04 |
| Zara | gah, failed in the gate | 12:10 |
| * Zara rechecks | 12:12 | |
| Zara | fdsjfldsjfldsjflds spent a while testing, then realised was on wrong branch | 12:13 |
| Zara | oh, rebase needed here: https://review.openstack.org/#/c/331748/ | 12:14 |
| Zara | I thought that was merged, sorry; woulda poked earlier | 12:15 |
| Zara | hm, just noticed that the 'edit' and 'subscribe' buttons are bigger for worklists than for anything else | 12:27 |
| Zara | I think they just need to be in <small> tags | 12:30 |
| Zara | it might just be worth doing as part of the subscription-button-for-worklists patch, since otherwise I can send something but you'll have to rebase for it and apply it to stars, and that patch needs a tweak anyway. | 12:31 |
| SotK | I'll do it when I fix that patch then | 12:37 |
| Zara | thank you :) | 12:37 |
| Zara | and sorry I didn't notice the button-when-logged-out thing earlier. | 12:38 |
| Zara | (aw, poor https://review.openstack.org/#/c/307712/ ) | 12:41 |
| *** alexismonville has quit IRC | 12:51 | |
| openstackgerrit | Merged openstack-infra/storyboard: Allow worklists to be filtered by subscriber_id https://review.openstack.org/335458 | 12:53 |
| *** alexismonville has joined #storyboard | 12:56 | |
| Zara | \o/ | 12:59 |
| Zara | so I'm looking at https://review.openstack.org/#/c/339286/ ; I have very little python anyway, but I've noticed some idioms have been changed that match those I've seen in code submitted recently, and want to find out how comfortable people are with it. | 13:34 |
| Zara | since I get the impression we're used to ye olde python round here. | 13:34 |
| *** alexismonville has quit IRC | 13:47 | |
| anteaya | hello | 13:52 |
| anteaya | welcome back Zara | 13:52 |
| anteaya | thanks for merging that patch SotK | 13:52 |
| Zara | hi! :) | 13:56 |
| *** alexismonville has joined #storyboard | 13:58 | |
| anteaya | how was you time away? | 13:59 |
| Zara | I slept a bunch. :) how are you? | 13:59 |
| anteaya | good thanks | 14:00 |
| anteaya | sleeping is good | 14:00 |
| anteaya | it is my favourite hobby | 14:00 |
| *** alexismonville has quit IRC | 14:02 | |
| Zara | :D | 14:03 |
| Zara | dmsimard: oh yeah, meant to say before I went on holiday, then forgot-- thanks for the kind words on the mailing list! :) | 14:04 |
| anteaya | so I'm going to continue working on https://review.openstack.org/#/q/topic:expand-api-docs+status:open this week | 14:11 |
| anteaya | I will share that I believe the Tags api is showing some unexpected behaviour: https://review.openstack.org/#/c/338532/ | 14:12 |
| anteaya | I have left notes in that patch | 14:12 |
| anteaya | if anyone has any time to take a peek at what the Tags api is doing, I'd be grateful for the conversation | 14:12 |
| pedroalvarez | anteaya: looking at yout comments in https://review.openstack.org/#/c/338532/1/storyboard/api/v1/tags.py | 14:16 |
| pedroalvarez | for creating multiple tags, have you tried to use a list? | 14:17 |
| pedroalvarez | param tags (line 98) says that it's a list | 14:17 |
| pedroalvarez | I'm going go try it, one sec :) | 14:17 |
| anteaya | sure | 14:19 |
| anteaya | I hope you have better success that I | 14:20 |
| anteaya | I tried several things last week, my commands are in the inline comments | 14:20 |
| pedroalvarez | haha, funny "The Story 19 already has a tag story_id" | 14:20 |
| anteaya | I believe I tried a list | 14:20 |
| anteaya | yes it does | 14:20 |
| anteaya | since with I give it the param: story_id:19 it creates a tag story_id | 14:21 |
| anteaya | which I didn't want | 14:21 |
| anteaya | and if I give it a list, is refuses to take it since ti is malformed json | 14:21 |
| anteaya | and if I don't include story_id:id then it says it doesnt' ahve a story_id | 14:21 |
| anteaya | even though the documentation says you can create a tag that isn't attached to a story | 14:22 |
| anteaya | I can't figure out how to do so | 14:22 |
| pedroalvarez | it's worrying, because it actually uses that "19" to figure out where to put the tag | 14:23 |
| anteaya | it is worrying | 14:23 |
| anteaya | thanks I'm glad you have reached the same conclusion I did | 14:23 |
| anteaya | so any tags created using the api currently will also have story_id in the set | 14:24 |
| pedroalvarez | I believe that endpoint is not used from the API | 14:24 |
| pedroalvarez | s/API/webclient/ | 14:24 |
| anteaya | oh | 14:24 |
| anteaya | that might explain why this behaviour is news | 14:24 |
| anteaya | it is possible noone has tried to use it before | 14:25 |
| *** jamesmcarthur has joined #storyboard | 14:30 | |
| *** dabukalam has quit IRC | 14:45 | |
| *** dabukalam has joined #storyboard | 14:46 | |
| anteaya | can anyone see a worklist at https://storyboard-dev.openstack.org/#!/worklist/30 | 14:52 |
| anteaya | the api says it is archived but I created it and can still navigate to it | 14:53 |
| SotK | yes, archived worklists can still be viewed, they just don't show up in search results by default | 14:54 |
| SotK | (and shouldn't show up on the dashboard either) | 14:54 |
| anteaya | ah okay, so that is kind of different than I would expect from a DELETE action | 14:55 |
| anteaya | I think I should add those bits to the api docs | 14:56 |
| anteaya | else we will just have questions about it | 14:56 |
| SotK | yeah, perhaps it would be better as part of a PUT in hindsight | 15:04 |
| anteaya | I've added some explaination, lets see if that is sufficent for now | 15:10 |
| * SotK leaves comments on the tags patch | 15:27 | |
| Zara | boards page now has a skeleton of search, although it doesn't actually work yet | 15:39 |
| Zara | will push shortly | 15:39 |
| anteaya | SotK: thanks for the comments on the tags patch | 15:43 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: WIP 'All Boards and Worklists' Page https://review.openstack.org/279753 | 15:44 |
| Zara | I've +1'd the requirements patch but not +A'd it myself, since I don't think I have enough python background to make that call. https://review.openstack.org/#/c/339286/ | 17:15 |
| *** mrmartin has joined #storyboard | 17:15 | |
| Zara | and with that, I'm off for the evening. :) | 17:15 |
| *** mrmartin has quit IRC | 17:18 | |
| anteaya | Zara: SotK who would you like to merge it? | 17:37 |
| anteaya | can I ask pleia2 to review https://review.openstack.org/#/c/339286/ ? | 17:37 |
| pleia2 | tsk, this is what I get for crawling out from under my pile 'o email ;) | 17:37 |
| anteaya | so glad you are here \o/ | 17:38 |
| anteaya | :) | 17:38 |
| pleia2 | lol | 17:38 |
| anteaya | you can't stay hidden under email all day | 17:38 |
| pleia2 | give me 15 minutes, just want to finish up a couple final emails | 17:38 |
| anteaya | yup, thanks | 17:38 |
| * SotK is happy to merge it now | 17:45 | |
| anteaya | thank you | 17:54 |
| *** jamesmcarthur has quit IRC | 17:56 | |
| anteaya | SotK: thank you | 18:11 |
| *** alexismonville has joined #storyboard | 18:18 | |
| *** alexismonville has quit IRC | 18:29 | |
| openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the Worklists api https://review.openstack.org/340506 | 18:29 |
| pleia2 | well, it got two +As :) | 18:31 |
| pleia2 | (was reviewing and didn't notice SotK's approval) | 18:31 |
| openstackgerrit | Merged openstack-infra/storyboard: Use a common requirements file https://review.openstack.org/339286 | 18:44 |
| openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the Tags api https://review.openstack.org/338532 | 18:47 |
| anteaya | two +A's are twice as good, thank you | 18:51 |
| pleia2 | hehe | 18:52 |
| *** jamesmcarthur has joined #storyboard | 19:03 | |
| openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the Worklists api https://review.openstack.org/340506 | 19:16 |
| anteaya | SotK: I know it is late for you but are you around at all to discuss the tags api? | 19:21 |
| anteaya | I can't seem to get the PUT command to work as you think it should | 19:21 |
| anteaya | I do appreciate your reviews, thank you | 19:22 |
| *** jamesmcarthur has quit IRC | 19:39 | |
| *** jamesmcarthur has joined #storyboard | 19:41 | |
| *** jamesmcarthur has quit IRC | 21:18 | |
| *** jamesmcarthur has joined #storyboard | 21:19 | |
| *** jamesmcarthur has quit IRC | 21:19 | |
| *** jamesmcarthur has joined #storyboard | 21:53 | |
| *** jamesmcarthur has quit IRC | 21:57 | |
| SotK | anteaya: what happens when you try to run that command? | 22:16 |
| anteaya | I posted the output in the patch | 22:23 |
| anteaya | SotK: https://review.openstack.org/#/c/338532/1/storyboard/api/v1/tags.py | 22:23 |
| anteaya | tried this command: | 22:24 |
| anteaya | curl --insecure https://storyboard-dev.openstack.org/api/v1/tags/19 -X PUT -H 'Authorization: Bearer 4f5a02b4-2946-4df5-a4c5-5f9fbe047efe' -H 'Content-Type: application/json;charset=UTF-8' --data-binary '{"taga","tagb"}' | 22:24 |
| anteaya | and got this error: | 22:24 |
| anteaya | {"debuginfo": null, "faultcode": "Client", "faultstring": "Request is not in valid JSON format"} | 22:24 |
| *** jamesmcarthur has joined #storyboard | 22:27 | |
| anteaya | I get the same error with /stories/19/tags | 22:31 |
| anteaya | curl --insecure https://storyboard-dev.openstack.org/api/v1/stories/19/tags -X PUT -H 'Authorization: Bearer 4f5a02b4-2946-4df5-a4c5-5f9fbe047efe' -H 'Content-Type: application/json;charset=UTF-8' --data-binary '{"taga", "tagb"}' | 22:31 |
| anteaya | {"debuginfo": null, "faultcode": "Client", "faultstring": "Request is not in valid JSON format"} | 22:31 |
| *** jamesmcarthur has quit IRC | 22:36 | |
| *** jamesmcarthur has joined #storyboard | 22:38 | |
| *** jamesmcarthur has quit IRC | 22:45 | |
| *** jamesmcarthur has joined #storyboard | 22:47 | |
| *** jamesmcarthur has quit IRC | 22:55 | |
| *** jamesmcarthur has joined #storyboard | 22:57 | |
| *** jamesmcarthur has quit IRC | 23:01 | |
| anteaya | SotK: ^^ | 23:03 |
| *** jamesmcarthur has joined #storyboard | 23:05 | |
| *** jamesmcarthur has quit IRC | 23:10 | |
| *** jamesmcarthur has joined #storyboard | 23:15 | |
| *** jamesmcarthur has quit IRC | 23:25 | |
| *** jamesmcarthur has joined #storyboard | 23:25 | |
| *** jamesmcarthur has quit IRC | 23:27 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!