*** davidlenwell has quit IRC | 07:22 | |
*** davidlenwell has joined #storyboard | 07:34 | |
Zara | morning, storyboard | 09:10 |
---|---|---|
SotK | morning! | 09:10 |
Zara | how are people doing? | 09:44 |
SotK | pretty good thanks | 09:46 |
SotK | how're you? | 09:46 |
Zara | I'm still waking up... but I learned about an unusual type of chicken yesterday | 09:47 |
Zara | actual animals: http://photorator.com/photos/images/silkie-chickens--30013.jpg | 09:47 |
SotK | :D silkies are great looking creatures | 09:48 |
Zara | everyone else has heard of them! clearly I've been disadvantaged growing up in a city | 09:49 |
Zara | before this, my favourite chicken was a buff orpington (it looks like a normal chicken, except it's the size of a toddler) | 09:49 |
Zara | but I have upgraded | 09:49 |
faybrocklebank | I also know nothing about chicken breeds but that one is ace | 09:51 |
*** tlbr has quit IRC | 09:52 | |
*** tlbr has joined #storyboard | 09:53 | |
*** tlbr has quit IRC | 09:53 | |
Zara | :D | 09:53 |
*** tlbr has joined #storyboard | 09:54 | |
*** tlbr has quit IRC | 09:54 | |
*** tlbr has joined #storyboard | 09:56 | |
*** tlbr is now known as Guest45466 | 09:56 | |
*** Guest45466 has quit IRC | 10:00 | |
*** tlbr_ has joined #storyboard | 10:13 | |
Zara | oh, the linter doesn't like the complex priorities ui in its current form, btw | 10:16 |
Zara | 2016-07-28 19:27:55.219859 | src/app/stories/controller/story_detail_controller.js | 10:16 |
Zara | 2016-07-28 19:27:55.219890 | 80:0 error Line 80 exceeds the maximum line length of 80 max-len | 10:16 |
*** tlbr_ has quit IRC | 10:17 | |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Complex priorities UI in stories https://review.openstack.org/312666 | 10:23 |
Zara | okay, I think it has all the relevant information now. :) though, gah, having played around with it, I think it should display 1 thing per worklist by default, but have a clickable way to expand to the full list. otherwise it pushes stories a long way down. (my test is here: http://docs-draft.openstack.org/66/312666/17/check/gate-storyboard-webclient-js-draft/2ca0a06//dist/#!/story/32 ; I put all the task | 10:29 |
Zara | s from it in a subscribed worklist, http://docs-draft.openstack.org/66/312666/17/check/gate-storyboard-webclient-js-draft/2ca0a06//dist/#!/worklist/41) | 10:29 |
Zara | I think that's the *last* thing. | 10:30 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Complex priorities UI in stories https://review.openstack.org/312666 | 10:56 |
*** Guest5363 has joined #storyboard | 11:36 | |
*** Guest5363 has quit IRC | 11:36 | |
*** tlbr_ has joined #storyboard | 12:05 | |
*** tlbr_ has quit IRC | 12:09 | |
Zara | oh huh, so tags.get(108) gets the tag with id 108, but tags.update(id=108) updates the tags for story 108 | 12:26 |
Zara | (oh, and tags.get(id=108) also gets tag with id 108) | 12:27 |
Zara | well that explains why I've been confused. | 12:28 |
*** Guest41883 has joined #storyboard | 12:35 | |
Zara | aaand it gets weirder | 12:35 |
Zara | I think something's back-to-front... | 12:36 |
Zara | so if I want to add a tag, 'LHF', to story 170, this is the syntax: `storyboard.tags.update(id=170, LHF='tag_name')` | 12:36 |
Zara | it doesn't have to say 'tag_name' in the string but there does need to be some string there | 12:36 |
Zara | so yeah, for some reason it takes the key as the tag name value | 12:37 |
Zara | if I just have (id=170, 'blah'), I get errors, same if I swap those around, try 'blah' sans quotes.... | 12:38 |
Zara | that syntax will create a new tag or append an existing one | 12:39 |
Zara | and it seems totally bizarre to me. | 12:39 |
*** Guest41883 has quit IRC | 12:40 | |
*** tlbr_ has joined #storyboard | 12:48 | |
Zara | also, I suspect it'll be better to have task titles in the complex priorities 'more...' modal (since it's harder to scroll to see task numbers with it open), but I'm fine with iterating on that. this looks like a good starting point! :) I'm going to look a bit more closely now. | 12:52 |
*** tlbr_ has quit IRC | 12:52 | |
Zara | anyway, if anyone has any thoughts on tag-stuff above, I'd appreciate it, since I'm not really sure what it *should* look like. I'd imagine storyboard.tags.update(story_id=170, title='LHF') would be more the expected sort of thing, but I don't really know if it's weird or not (or if it matters that much, if it is weird but is documented) | 13:09 |
SotK | I suspect this is related to the weirdness in the tags api that was tripping anteaya up when writing the api docs too | 13:10 |
Zara | yeah, I vaguely remember it taking the story_id from somewhere unexpectedly | 13:10 |
Zara | (also, I couldn't find any way of updating a tag for a story via storyboard.stories..., but maybe there is and I just didn't know the syntax) | 13:12 |
Zara | but yeah, that's how I ended up trying it that way round | 13:13 |
SotK | hmm, what would "updating a tag for a story" actually entail? | 13:19 |
Zara | sorry, phrased that badly, I meant 'adding a tag to a story' | 13:19 |
*** tlbr has joined #storyboard | 13:19 | |
Zara | either an existing one or making a new one | 13:20 |
Zara | *tag | 13:20 |
Zara | fffff I can't make sense today | 13:20 |
*** tlbr is now known as Guest28658 | 13:20 | |
Zara | so yeah, adding a tag *to a specific story* vs 'creating a new tag' or 'changing the title of a tag with a certain id' | 13:20 |
Zara | (I couldn't actually find any way of doing the latter) | 13:20 |
SotK | I don't think there is a way | 13:21 |
Zara | yeah. I doubt it matters. just confused me that storyboard.tags.update() behaves so differently to all other update() things | 13:22 |
Zara | I decided to start with getting familiar with that again, since 1) it'll be used a lot and 2) I figured it'd offer a good example for updating things like stuff in worklists | 13:23 |
Zara | but since it's weird, maybe not xD | 13:23 |
*** Guest28658 has quit IRC | 13:24 | |
Zara | another bad thing about it working like this is that it means the client constrains formatting for tags, since it applies rules for keywords (I think? I get 'keyword can't be an expression' if I put a hyphen in the tag name) | 13:29 |
SotK | yeah, I think that problem is because the API expects the body of that request to be a list of tag names, and the client only knows to do "make a dict of the form {key: value} from the keyword arguments" | 13:31 |
Zara | ahhh | 13:32 |
Zara | I guess that's fixable in the client, then | 13:33 |
Zara | I added copious task notes to https://storyboard.openstack.org/#!/story/98 | 13:40 |
Zara | every time I read my storyboard emails, I smile. those poor little email templates! so ugly... but functional <3 | 13:45 |
Zara | my favourite bit is the 'I don't know how to say what kind of thing changed but I can point out what changed and you can work it out' | 13:46 |
Zara | probably the lowest of low-hanging fruit | 13:46 |
pedroalvarez | let's create colorful html templates ! | 13:47 |
* pedroalvarez runs away | 13:47 | |
Zara | >:D | 13:47 |
pedroalvarez | I would really love that for story descriptions (and maybe task notes now) it only sends you a git-diff like summary | 13:47 |
pedroalvarez | sorry, love bikeshedding | 13:48 |
Zara | hahaha | 13:48 |
Zara | yeah, this is what I get for task notes atm: http://paste.openstack.org/show/543903/ | 13:48 |
Zara | so at the bottom is our current diff-like thing (it says 'this is what's here now, this is what was there before') | 13:49 |
pedroalvarez | yup | 13:49 |
Zara | but it's not pretty or obvious | 13:49 |
Zara | really it should go "type of change: 'task notes added', change: $new_thing, $old_thing" | 13:51 |
Zara | instead of "type of change: $new thing, prior to change: $old thing" | 13:51 |
Zara | but oh well | 13:52 |
pedroalvarez | woo difflib rules | 13:53 |
Zara | heehee | 13:53 |
Zara | after googling difflib just then, looks like it's probably simple enough to do, though I've never looked at difflib | 13:54 |
pedroalvarez | little example: http://paste.openstack.org/show/543905/ | 14:07 |
pedroalvarez | with the reslt included :) | 14:07 |
Zara | tugutugu_title :D | 14:10 |
pedroalvarez | note that I had to introuce some '\n' in the text to make the diff usable | 14:11 |
pedroalvarez | hopefully, storyboard users, if this feature is implemented, would learn to do that to make emails more useful | 14:12 |
Zara | ah, I suspect people wouldn't generally do that, so it would have to be automated afterward somehow. | 14:14 |
*** tlbr_ has joined #storyboard | 14:33 | |
*** tlbr_ has quit IRC | 14:34 | |
*** tlbr_ has joined #storyboard | 14:50 | |
*** tlbr_ has quit IRC | 14:53 | |
anteaya | yes Zara, your tag experience sounds like my tag experience | 15:14 |
anteaya | regarding emails, many folks in openstack recieve emails as text only | 15:14 |
anteaya | so if you want to spend time in html emails note that folks will want to select to recieve text only emails | 15:15 |
Zara | I think pedro was joking :) | 15:16 |
Zara | as far as I know, none of us want to do that! :D | 15:16 |
Zara | so fear not :) | 15:16 |
pedroalvarez | hehe I was joking, yes | 15:17 |
anteaya | ah okay | 15:19 |
anteaya | my morning bleary eyes missed the joking bit | 15:20 |
anteaya | sorry about that | 15:20 |
Zara | heh, I'm sure people have proposed it for projects in earnest before | 15:20 |
Zara | so I think it's good to be cautious! :) | 15:21 |
*** Guest79767 has joined #storyboard | 15:29 | |
*** Guest79767 has quit IRC | 15:34 | |
Zara | very vague plans in the works for a js meetup so that our js things aren't from the 17th century. | 15:36 |
*** tlbr_ has joined #storyboard | 15:40 | |
*** tlbr_ has quit IRC | 15:45 | |
Zara | I've poked about gerrit integration patches, but I think people are pretty busy today | 15:56 |
Zara | (there's no massive urgency to it, I just know it's a big chunk of work, and the longer it waits the higher the risk of merge conflicts and things grinding to a halt, so I'm hoping we can get something up and running soon) | 15:59 |
*** Guest30197 has joined #storyboard | 16:28 | |
*** Guest30197 has quit IRC | 16:33 | |
*** tlbr_ has joined #storyboard | 16:40 | |
openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the Teams api https://review.openstack.org/339123 | 16:40 |
Zara | \o/ | 16:42 |
*** tlbr_ has quit IRC | 16:44 | |
Zara | I should probably have more input for POSTs and PUTs and things next week, but happy to +1 for now and merge if it gets more reviews before that (I think SotK has gone home for the night, so I'd expect Monday for that at the earliest) | 16:44 |
Zara | anteaya: just saw your new comment on the patch; I think the problem is the trailing slash in the command you used | 16:48 |
Zara | I just tried it with and without the trailing slash and it worked without | 16:48 |
anteaya | ah thank you | 16:48 |
* anteaya also tries without the trailing slash | 16:48 | |
anteaya | so it does, thanks | 16:49 |
Zara | I hope it works! :D | 16:49 |
Zara | yay | 16:49 |
anteaya | it does so | 16:49 |
Zara | haha I'm too slow | 16:49 |
anteaya | should it also work with the trailing slash? | 16:49 |
Zara | I don't know what the best practice should be. I think we may want to note somewhere that the examples won't work with trailing slashes | 16:50 |
Zara | if it shouldn't be changed | 16:50 |
anteaya | ummm, hmmm | 16:50 |
anteaya | I don't know a lot about apis | 16:50 |
anteaya | but I think annegentle does | 16:51 |
anteaya | I think I will ask on -dev and see if anne has any best practice suggestions | 16:51 |
Zara | okay, thank you. :) there may be historical reasons why it is the way it is, but not my area, and it's nearly the end of my day, so sorry I can't be more help. | 16:52 |
Zara | + it's useful to be aware of it, so thanks for shedding light on it | 16:53 |
anteaya | no I understand | 16:55 |
anteaya | thank you for seeing it | 16:55 |
Zara | :) (on a related note, at some point I really want to find out why stories.get_all() (or browsing to api/v1/stories) doesn't work for storyboard.openstack.org. it works for dev and it works for other instances, so I think it's something in the storyboard database that's confusing things.) | 16:56 |
Zara | atm it's bad news for scripts that want to analyse all stories to see if they fulfil some criteria | 16:57 |
Zara | https://storyboard.openstack.org/api/v1/stories for the curious | 16:57 |
* Zara closes about 30 tabs, 'night, all! :D | 17:03 | |
anteaya | night | 17:08 |
anteaya | oh my | 17:09 |
anteaya | yes I can see that api request being a popular script starting point | 17:09 |
anteaya | so it looks like I will try again next week to see if I can get some guidance on how the api should handle trailing slashes | 17:15 |
anteaya | so far we have some thoughts on -dev but no consensous | 17:15 |
*** tlbr_ has joined #storyboard | 17:25 | |
*** tlbr_ has quit IRC | 17:30 | |
*** tlbr has joined #storyboard | 19:00 | |
*** tlbr is now known as Guest84124 | 19:00 | |
*** Guest84124 has quit IRC | 19:04 | |
*** tlbr has joined #storyboard | 19:42 | |
*** tlbr is now known as Guest79100 | 19:42 | |
*** Guest79100 has quit IRC | 19:51 | |
*** Guest97891 has joined #storyboard | 21:32 | |
*** Guest97891 has quit IRC | 21:39 | |
*** tlbr_ has joined #storyboard | 21:46 | |
*** tlbr_ has quit IRC | 21:47 | |
*** tlbr_ has joined #storyboard | 22:00 | |
*** tlbr_ has quit IRC | 22:04 | |
*** Guest13477 has joined #storyboard | 22:14 | |
*** Guest13477 has quit IRC | 22:19 | |
*** tlbr_ has joined #storyboard | 22:24 | |
*** tlbr_ has quit IRC | 22:29 | |
*** tlbr_ has joined #storyboard | 22:35 | |
*** tlbr_ has quit IRC | 22:40 | |
*** Guest59655 has joined #storyboard | 22:56 | |
*** Guest59655 has quit IRC | 23:02 | |
*** tlbr_ has joined #storyboard | 23:22 | |
*** tlbr_ has quit IRC | 23:27 | |
*** tlbr has joined #storyboard | 23:34 | |
*** tlbr is now known as Guest16207 | 23:34 | |
*** Guest16207 has quit IRC | 23:38 | |
*** tlbr_ has joined #storyboard | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!