| *** aswadr_ has joined #storyboard | 05:22 | |
| *** jtomasek has joined #storyboard | 05:28 | |
| *** dabukalam has quit IRC | 05:39 | |
| *** dabukalam has joined #storyboard | 05:39 | |
| *** matthewbodkin has joined #storyboard | 07:50 | |
| *** bethwhite_ has joined #storyboard | 08:32 | |
| Zara | I spy an integrated gerrit! | 08:43 |
|---|---|---|
| pedroalvarez | woot :) | 08:44 |
| Zara | on saturday, no less! I assume nobody's awake yet but I'll go thank people in a few hours... =D | 08:45 |
| SotK | I spy an emails bug that I was vaguely expecting :( | 09:25 |
| Zara | I wondered about that, then decided maybe it shouldn't count as a bug | 09:26 |
| Zara | since it directs people to the review | 09:27 |
| Zara | but eh, idk | 09:27 |
| SotK | true, but ` | 09:27 |
| SotK | `URL: None#!/story/2000012` looks silly | 09:27 |
| Zara | haha | 09:27 |
| * SotK grumbles at pasting | 09:27 | |
| Zara | I thought you were just making a bizarre non-sequitur for a sec | 09:28 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Move other-requirements.txt to bindep.txt https://review.openstack.org/354866 | 10:04 |
| *** openstackgerrit has quit IRC | 11:03 | |
| *** openstackgerrit has joined #storyboard | 11:04 | |
| openstackgerrit | Merged openstack-infra/storyboard: Add example commands for the Teams api https://review.openstack.org/339123 | 11:15 |
| Zara | at last! | 11:31 |
| *** openstackstatus has quit IRC | 11:36 | |
| *** openstackstatus has joined #storyboard | 11:39 | |
| *** ChanServ sets mode: +v openstackstatus | 11:39 | |
| *** alexismonville has joined #storyboard | 11:51 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Send notifications to subscribers for worklists https://review.openstack.org/354730 | 12:55 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Make it possible to get worklist/board timeline events via the API https://review.openstack.org/354729 | 12:55 |
| Zara | gah, looking at 'send notifications...' atm | 12:55 |
| * SotK was fixing the tests | 12:55 | |
| Zara | (just noticed that there's no email template for removing a worklist item, and nothing's showing up in my recent events) | 12:55 |
| Zara | (if you're curious) | 12:55 |
| Zara | (that's any worklist recent events.) | 12:56 |
| SotK | I meant to send that an hour ago, forgot `git review` asks for confirmation if you submit more than one change at the same time | 12:57 |
| Zara | heh | 12:57 |
| Zara | changing card position and adding cards work as expected | 12:59 |
| Zara | not sure why card position is noted when adding them, since it'll always be 'bottom of the list', but I guess someone might need the list length for something? | 12:59 |
| *** alexismonville has quit IRC | 13:01 | |
| Zara | (recent events do work for non-worklist things, just not any worklist things) | 13:01 |
| *** alexismonville has joined #storyboard | 13:03 | |
| SotK | yeah, you'll need to either apply the webclient patch and change your preferences to turn on worklist notifications, or do | 13:03 |
| SotK | `insert into user_preferences (`user_id`, `key`, `type`, `value`) values(1,'receive_notifications_worklists','string','true');` | 13:03 |
| Zara | I have turned them on | 13:04 |
| Zara | they seem to be fine for emails, but not for recent events | 13:05 |
| SotK | hmm | 13:05 |
| Zara | these templates are pretty :) | 13:12 |
| Zara | I keep getting this error: 2016-08-22 13:00:40.344 25746 ERROR storyboard.plugin.email.workers [-] Cannot schedule email: 'dict object' has no attribute 'item_type' | 13:14 |
| Zara | but I am getting emails | 13:14 |
| Zara | so hm. | 13:14 |
| Zara | I think that might have been for the 'delete' one actually | 13:15 |
| Zara | since apparently it was a few mins ago (my vm clock is utc) | 13:15 |
| Zara | adding and removing filter and permission things seem to work fine. | 13:16 |
| SotK | yeah, thats the delete one failing | 13:16 |
| * SotK is fixing :) | 13:17 | |
| Zara | heh | 13:17 |
| Zara | I debated the worth of sending 'this works' updates but I figure it's more comforting than only 'this doesn't work' updates | 13:17 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Send notifications to subscribers for worklists https://review.openstack.org/354730 | 13:20 |
| Zara | although, permissions change templates describe everyone as 'user' instead of 'owner' or 'user' | 13:23 |
| SotK | webclient template or email template? | 13:26 |
| Zara | email, still nothing in the webclient | 13:29 |
| Zara | it says 'users added:' or 'users removed:' in all cases. it sends it when an owner changes, but the wording is the same for users and owners. | 13:30 |
| SotK | ehhh, overloading of the word users was a bad plan | 13:31 |
| Zara | :) you should include the task id on the next rework dohohohoho | 13:36 |
| SotK | in the email templates? | 13:40 |
| Zara | in the commit message so we can watch the gerrit plugin at work | 13:43 |
| Zara | and bask in its glory etc etc etc | 13:43 |
| SotK | ok | 13:44 |
| SotK | I added them to the templates too in case they're useful | 13:44 |
| Zara | heh | 13:45 |
| Zara | (huh, I got another error with my worker but I'm not sure what I was doing. looks like the old 'expecting a story' thing, so suggests something hasn't been updated for new timeline events style yet) | 13:46 |
| Zara | looks like some form of PUT for permissions | 13:47 |
| Zara | ah, i think unprivatizing a story | 13:48 |
| Zara | *worklist | 13:48 |
| Zara | I still get the email | 13:49 |
| Zara | http://paste.openstack.org/show/562211/ is the error | 13:50 |
| Zara | hm, tried to reproduce, couldn't. | 13:51 |
| SotK | seems like some kind of weird race condition | 13:53 |
| Zara | ah, I think it happens if you don't refresh the page between changing the is-private boolean, possibly | 13:53 |
| Zara | though only when setting to 'false' | 13:53 |
| SotK | that error suggests that the timeline event itself was never created | 13:53 |
| * SotK fails to reproduce it | 13:53 | |
| SotK | (but you received the email, so it must've been created) | 13:54 |
| Zara | I can't reproduce it consistently, so the non-refresh might have been coincidental | 13:55 |
| Zara | so yeah, looking more race conditiony | 13:56 |
| Zara | it only seems to affect the 'private' bool; I haven't reproduced at all with the automatic one. | 13:57 |
| * SotK can't reproduce it with anything | 13:57 | |
| Zara | (now also had it while setting a list *to* private) | 13:57 |
| Zara | huh | 13:57 |
| Zara | this is on an automatic worklist, idk if that would make a difference | 13:58 |
| Zara | the worklist has one filter. it has a user and an owner, who are both the same person (me!) | 13:58 |
| Zara | oh, oops, two filters | 13:59 |
| Zara | it finds 11 items | 13:59 |
| SotK | aha, I reproduced it | 14:02 |
| Zara | \o/ | 14:03 |
| Zara | might be to do with the speed of changing to/from private... | 14:03 |
| Zara | that's my last guess. | 14:03 |
| SotK | that shouldn't be any slower than changing any other attribute | 14:05 |
| Zara | maybe it's just that I've focussed on that one more, haven't seen it with anything else yet though | 14:13 |
| Zara | archiving seems fine, anyhow | 14:22 |
| Zara | creating a new worklist is a bit exciting, in that it sends a separate email for each card added. | 14:26 |
| Zara | (that's not necessarily creating a new one, I just figure that's the time when people are most likely to add big lump of cards to a worklist) | 14:27 |
| SotK | yes, which is why I intend to never turn on the notifications for myself on storyboard.openstack.org :D | 14:27 |
| Zara | :P really, it should send one email for all items that are added at the same time, but I don't see an easy way to do it | 14:28 |
| SotK | there isn't one, since they are all added in separate requests | 14:29 |
| SotK | I'm sure its possible, but there is not an easy way | 14:29 |
| Zara | yup. | 14:29 |
| Zara | I think you'd need another step between requests and sending | 14:30 |
| Zara | that way lies digest notifications and things | 14:30 |
| SotK | yep, or allow a way to bulk-add cards in a single request | 14:30 |
| *** bethwhite_ has quit IRC | 14:52 | |
| *** bethwhite_ has joined #storyboard | 14:56 | |
| persia | I prefer one notification per event: that can be filtered or processed client-side more easily. | 15:46 |
| *** tlbr_ has quit IRC | 16:04 | |
| *** tlbr has joined #storyboard | 16:13 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Send notifications to subscribers for worklists https://review.openstack.org/354730 | 16:15 |
| Zara | oh, those comments look nice | 16:29 |
| Zara | thanks | 16:29 |
| Zara | those look better at a glance, should check more thoroughly tomorrow morning | 16:30 |
| Zara | though I still hope for task id in the commit just for the excitement that brings to my day | 16:32 |
| *** matthewbodkin has quit IRC | 16:36 | |
| *** jmccrory_away is now known as jmccrory | 16:37 | |
| Zara | arghhh backkk buttton js drafffft | 16:54 |
| Zara | oh well I was going to +A but gerrit doesn't like me right now | 16:58 |
| Zara | it came back | 17:01 |
| Zara | my brain is zapped | 17:01 |
| Zara | night, all | 17:01 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Add Worklists and Boards to About Page https://review.openstack.org/355912 | 17:10 |
| SotK | oh sorry, I forgot about that | 18:43 |
| SotK | (the task id thing) | 18:43 |
| *** alexismonville has quit IRC | 19:06 | |
| *** alexismonville has joined #storyboard | 19:06 | |
| *** alexismonville has quit IRC | 19:07 | |
| *** alexismonville has joined #storyboard | 19:08 | |
| *** alexismonville has quit IRC | 21:12 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!