*** alexismonville has joined #storyboard | 00:41 | |
*** alexismonville has quit IRC | 01:44 | |
*** aswadr_ has joined #storyboard | 03:17 | |
*** fay has joined #storyboard | 07:10 | |
*** fay is now known as faybrocklebank | 07:10 | |
*** bethwhite_ has joined #storyboard | 07:50 | |
*** matthewbodkin has joined #storyboard | 07:55 | |
Zara | morning, storyboard! | 10:15 |
---|---|---|
SotK | morning! | 10:16 |
matthewbodkin | morning | 10:16 |
Zara | yesterday I discovered that 'men furry hats' is the best image search | 10:18 |
Zara | I pass this wisdom on to all in this channel, that ye may use it as ye see fit | 10:18 |
*** jtomasek_ is now known as jtomasek | 11:13 | |
Zara | can't seem to break worklist notifications | 11:56 |
persia | Is that a call for help? | 11:57 |
persia | :) | 11:57 |
Zara | :) I'm gonna +2. will hold off +A until I've double-checked the endpoint patch | 11:58 |
*** bethwhite_ has quit IRC | 12:15 | |
*** bethwhite_ has joined #storyboard | 12:15 | |
Zara | I think https://storyboard.openstack.org/#!/board/14 is due a spring clean | 13:00 |
*** openstackgerrit has quit IRC | 13:26 | |
*** openstackgerrit has joined #storyboard | 13:27 | |
SotK | openstackgerrit is asleep again I see | 13:37 |
Zara | aw | 13:37 |
* SotK sent https://review.openstack.org/#/c/359894/ | 13:37 | |
SotK | and more importantly but dependent on that first one: https://review.openstack.org/#/c/359895/ | 13:37 |
SotK | swift reviews would be much appreciated | 13:38 |
* Zara will get on it | 13:38 | |
* SotK rebases https://review.openstack.org/354729 and https://review.openstack.org/354730 on top of those | 13:47 | |
* SotK smiles at https://storyboard.openstack.org/#!/story/2000644#comment-7541 | 13:48 | |
Zara | :) | 13:50 |
openstackgerrit | Merged openstack-infra/storyboard-webclient: Add a margin to the bottom of all pages https://review.openstack.org/359119 | 14:04 |
Zara | \o/ | 14:05 |
Zara | heh, looks like tasks are the only thing that aren't cached | 14:07 |
SotK | in what context? | 14:09 |
Zara | just checked logging out and accessing a private story | 14:14 |
Zara | got a bit freaked out because it was still displayed, then realised it was just the cache | 14:14 |
Zara | but the task list said 'no tasks' | 14:14 |
Zara | so that bit was checking | 14:14 |
SotK | heh | 14:14 |
Zara | haven't succeded in breaking the first | 14:23 |
SotK | good | 14:26 |
Zara | I mainly checked that things expected to be private were private everywhere | 14:27 |
Zara | did create a story jic there was anything odd when things moved around but I didn't go extra | 14:27 |
* SotK notes that it is the meeting in #openstack-meeting in 10 minutes time | 14:50 | |
SotK | agenda is here, feel free to modify it: https://wiki.openstack.org/wiki/Meetings/StoryBoard#Agenda_for_next_meeting | 14:51 |
Zara | thanks | 14:54 |
Zara | hah, that looks about right, I've been reviewing non-stop this week | 14:59 |
* SotK tries to figure out this test failure | 15:53 | |
pleia2 | Zara: great email \o/ | 15:56 |
Zara | pleia2: aw, thank you! :D | 15:58 |
Zara | I'm so happy about gerrit things, tralalala~ | 15:59 |
pleia2 | me too | 16:04 |
Zara | :) I'll probably just spend the entire summit running around barcelona telling strangers who have nothing to do with openstack that gerrit now talks to storyboard. | 16:07 |
*** matthewbodkin has quit IRC | 16:15 | |
*** faybrocklebank has quit IRC | 16:22 | |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Hide timeline events and comments of private stories https://review.openstack.org/359895 | 16:23 |
* SotK doubts that will actually fix the tests, but they keep timing out when I attempt to run them locally | 16:24 | |
Zara | :( | 16:25 |
zaro | Zara: any wacko problems crept up yet? | 16:33 |
zaro | with its-storyboard i mean | 16:33 |
Zara | not seen anything strange yet! but that has reminded me that we've realised it can't update private stories as it needs to supply auth in the GET to do that (so if we add openstack-gerrit to the story users, it'll be on the ACL) | 16:34 |
Zara | we think it should be a small change | 16:35 |
Zara | ie: just a case of adding a header like it does for POST and PUT | 16:36 |
Zara | but right now the way it's behaving is the way we'd expect it to behave, so \o/ | 16:37 |
zaro | coolio, you plan on updating openstack-infra docs to let people know about 'task:xxx' and how it works? | 16:38 |
Zara | sure, I wasn't sure of the best place to put it but I made a task for it in the story as a start... | 16:39 |
Zara | where are users most likely to look for commit message syntax things? I guess wherever lp things are documented... | 16:39 |
Zara | ah okay http://docs.openstack.org/infra/manual/developers.html#working-on-bugs looks like the place | 16:40 |
Zara | I'll have to restrain myself from just writing 'STORYBOARD STORYBOARD STORYBOARD STORYBOARD' over that section | 16:40 |
Zara | eep, I always get panicked when I misspell a git command without realising and then get a dramatic error message | 17:04 |
openstackgerrit | Merged openstack-infra/storyboard: Put the logic for hiding private things in storyboard/db/api/base.py https://review.openstack.org/359894 | 17:11 |
*** bethwhite_ has quit IRC | 17:18 | |
*** aswadr_ has quit IRC | 17:51 | |
Zara | gah, comments are hidden from owners too | 17:59 |
Zara | only when browsing to api though | 17:59 |
Zara | oh huh, all api browses to private things | 18:00 |
Zara | the ui seems to behave | 18:00 |
Zara | ??????????????????????? | 18:00 |
persia | Maybe trace the API calls made by the UI? | 18:01 |
Zara | (this is on https://review.openstack.org/#/c/359895/2 ) | 18:01 |
SotK | browsing in browser or with curl? | 18:03 |
Zara | 127.0.0.1 - - [24/Aug/2016 18:02:36] "GET /v1/stories/180 HTTP/1.1" 404 103 | 18:03 |
Zara | 127.0.0.1 - - [24/Aug/2016 18:03:06] "GET /v1/systeminfo HTTP/1.1" 200 20 | 18:03 |
Zara | 127.0.0.1 - - [24/Aug/2016 18:03:07] "GET /v1/stories/180 HTTP/1.1" 200 746 | 18:03 |
Zara | in browser | 18:03 |
Zara | first is api browse, second is via ui | 18:03 |
SotK | you won't have the auth header set in browser unless you've done something special | 18:04 |
Zara | ohhhh | 18:04 |
Zara | okay that's fine then | 18:04 |
Zara | suggests it's doing the right thing :P | 18:04 |
* SotK was hopeful you'd stumbled on the cause of the test failure | 18:05 | |
Zara | I'm sorry! | 18:05 |
Zara | instead I just rediscovered a behaviour I already knew about but had forgotten about | 18:05 |
Zara | (since previously I've only hit it when trying to list access tokens, so it didn't jog my memory) | 18:06 |
Zara | since the tests aren't displaying the old results in gerrit I also can't look at the logs for ideas over there | 18:06 |
zaro | Zara: that may change with new plugin i'm writing | 18:08 |
Zara | ooh, exciting | 18:10 |
zaro | sample here: http://138.68.20.113:8080/#/c/2/2 | 18:12 |
Zara | ah, the 'show all reports' bit? | 18:14 |
zaro | Zara: that's part of it. select a different patchset and you'll see a different list of results. results are saved per patchset | 18:17 |
Zara | ah, okay | 18:21 |
persia | zaro: that is *really* cool. | 18:25 |
zaro | you think you might use persia? | 18:26 |
zaro | use/use it | 18:27 |
persia | zaro: for javascript UIs with docs-draft I will definitely use it, because it lets one see what changed between revisions of a patch. | 18:27 |
*** krotscheck has joined #storyboard | 18:27 | |
zaro | persia: javascript UI? is that a project on openstack's Gerrit? | 18:28 |
persia | zaro: examples are storyboard-webclient ironic-ui, etc. | 18:29 |
* persia suspects krotscheck has a complete list | 18:29 | |
krotscheck | fuel-ui, openstack-health, ironic-webclient, tripleo.... | 18:30 |
zaro | persia: ahh yah, that's openstack's Gerrit. i was asking whether you guys run some other gerrit where you think that gerrit feature would be useful | 18:30 |
persia | I regularly recommend gerrit for other projects, but have more trouble convincing people to use zuul, etc., so I usually see tests not shown properly in gerrit, sadly. | 18:31 |
zaro | persia: that feature has an accompanying jenkins plugin as well: https://github.com/zaro0508/verify-status-reporter | 18:33 |
zaro | use it without zuul if you like | 18:33 |
persia | I don't like :) but I will try that, and maybe make some recommendations. | 18:37 |
zaro | persia: soon i will stand up a test jenkins server to work with the above gerrit server to show the entire loop. you can just look there to see how it all works. | 18:40 |
persia | That makes it easier. Thanks :) | 18:42 |
*** alexismonville has joined #storyboard | 19:55 | |
*** alexismonville has quit IRC | 20:16 | |
*** alexismonville has joined #storyboard | 22:25 | |
zaro | persia: try again, reply on a change with 'recheck' and see it go. http://138.68.20.113:8080 | 22:31 |
*** alexismonville has quit IRC | 22:39 | |
*** zigo has quit IRC | 22:56 | |
*** zigo has joined #storyboard | 22:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!