*** matthewbodkin has joined #storyboard | 07:54 | |
*** bethwhite_ has joined #storyboard | 08:47 | |
*** matthewbodkin has quit IRC | 08:53 | |
*** matthewbodkin has joined #storyboard | 08:57 | |
matthewbodkin | so guys what would be the best way to continue contributing from home? :) | 09:47 |
---|---|---|
Zara | ooh, nice! :D as in how to do it, or what sort of things would be best to work on? | 09:56 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Rework the task list layout https://review.openstack.org/357306 | 09:57 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add a way to add tasks to worklists from the story view https://review.openstack.org/366899 | 09:57 |
matthewbodkin | how you guys would do it | 09:57 |
Zara | most of it should be the same; to have your own test instance, you'd want to set up storyboard in a virtual machine on your own computer. (which sounds complicated but should be fairlyyyy straightforward) | 09:57 |
Zara | so I would start by making a vm with an ubuntu trusty image (downloadable online) and then installing storyboard on it in the same way you did a few weeks ago | 09:58 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Complex priorities UI in stories https://review.openstack.org/312666 | 09:58 |
Zara | if your laptop's windows, virtualbox should be fairly straightforward | 09:59 |
Zara | s/laptop/computer | 09:59 |
SotK | +1 for virtualbox if windows | 09:59 |
Zara | you might have to enable some stuff in BIOS but it's easily googlable, and then you get to say 'I know how to set up virtual machines'. :P | 10:00 |
matthewbodkin | okay great, I could do that, thanks :D | 10:01 |
Zara | on my work laptop, I've historically used some combination of kvm and virtual machine manager. the ui for that is harder and has everything in reverse positions to virtualbox; there's a tutorial up somewhere online that I adjusted when I did it the first time; it'll be about two years old by now | 10:02 |
Zara | so might be out of date... and is generally the harder route | 10:02 |
persia | One advantage to that route is that one can use `virsh(1)` to manage the machines, which doesn't work as well for virtualbox (lack of good libvirt support, last I checked) | 10:05 |
matthewbodkin | okay I'll keep that in mind | 10:05 |
Zara | + feel free to ask questions in here, it's easier to help as you go along.there are probably irc channels for whatever technology you use; I've never visited them myself so I don't know the culture. | 10:05 |
matthewbodkin | I'll make sure I try to stay in touch :) | 10:07 |
Zara | :) | 10:08 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add a way to add tasks to worklists from the story view https://review.openstack.org/366899 | 10:10 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Complex priorities UI in stories https://review.openstack.org/312666 | 10:10 |
Zara | all the patches... @_@ | 10:14 |
Zara | heh, part of me liked 'maybeRemoveTaskProject' | 10:22 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add recent events templates for worklist notifications https://review.openstack.org/356441 | 10:22 |
SotK | I realised the name didn't make much sense | 10:22 |
SotK | since its not actually anything to do with tasks anymore (I think it was at one point of my implementation) | 10:23 |
SotK | well it is, but not some specific task | 10:23 |
Zara | the 'maybe' was my favourite bit | 10:23 |
Zara | I get what it was getting at but I liked the implication that it might remove or not remove arbitrarily | 10:24 |
Zara | and people would have to kindly ask the function if it minded terribly if it would remove the thing | 10:24 |
Zara | you can probably tell I didn't sleep well. | 10:24 |
Zara | anyway, I had a mental image of a really passive-aggressive function that, when asked to do anything, would just go 'maybe', and it made me happy :) | 10:26 |
SotK | :D | 10:27 |
*** matthewbodkin has quit IRC | 11:28 | |
*** alexismonville has joined #storyboard | 11:29 | |
*** alexismonville has quit IRC | 11:34 | |
Zara | I'm noting things in the review thread but they can easily be a reference for 'things for me to patch in a followup' | 11:37 |
Zara | I think I'm happy to merge the rework as-is, just mentioning stuff in case it's easier to fix at this point. | 11:37 |
Zara | eg: I'd rather not have the buttons unaligned for the week it might take me to get reviews on something else, but I also don't want to hold it up based on 'these buttons are slightly to-the-left' | 11:38 |
persia | There's enough important functionality in this series, that I think it makes more sense to err on the side of delivering it, and cleaning up the minor aesthetic bits later. | 11:43 |
*** alexismonville has joined #storyboard | 11:46 | |
* SotK will send a fix now, it is only small | 11:48 | |
Zara | thanks. I know I can sound fussy; I think small stuff can make a big difference to perception (unfortunately!), and people don't take time to look at the functionality without it. | 11:49 |
persia | sadly true | 11:57 |
*** matthewbodkin has joined #storyboard | 12:05 | |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Rework the task list layout https://review.openstack.org/357306 | 12:21 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add a way to add tasks to worklists from the story view https://review.openstack.org/366899 | 12:21 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Complex priorities UI in stories https://review.openstack.org/312666 | 12:24 |
openstackgerrit | Merged openstack-infra/storyboard-webclient: Rework the task list layout https://review.openstack.org/357306 | 14:35 |
*** alexismonville has quit IRC | 15:06 | |
*** matthewbodkin has quit IRC | 15:09 | |
*** openstackgerrit has quit IRC | 15:49 | |
*** openstackgerrit has joined #storyboard | 15:49 | |
-openstackstatus- NOTICE: New setuptools release appears to have a circular import which is breaking many jobs - check for ImportError: cannot import name monkey. | 15:55 | |
*** ChanServ changes topic to "New setuptools release appears to have a circular import which is breaking many jobs - check for ImportError: cannot import name monkey." | 15:55 | |
Zara | I wondered why everyone was talking about a monkey in #infra | 16:06 |
*** alexismonville has joined #storyboard | 16:28 | |
*** alexismonville has quit IRC | 16:44 | |
*** ChanServ changes topic to "StoryBoard - A task tracker for OpenStack development needs :: http://storyboard.openstack.org/ :: https://wiki.openstack.org/wiki/StoryBoard" | 16:59 | |
-openstackstatus- NOTICE: setuptools 27.1.2 addresses the circular import | 16:59 | |
*** bethwhite_ has quit IRC | 17:19 | |
*** alexismonville has joined #storyboard | 17:46 | |
openstackgerrit | Merged openstack-infra/storyboard-webclient: Add a way to add tasks to worklists from the story view https://review.openstack.org/366899 | 18:20 |
openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Hide edit buttons for logged-out users https://review.openstack.org/368176 | 18:34 |
Zara | ;) | 18:35 |
Zara | we always miss something | 18:35 |
SotK | oops :) | 18:35 |
Zara | GAH noticed another thing | 18:47 |
Zara | I have no idea why though | 18:57 |
Zara | task titles are repeating for logged-out users | 18:57 |
SotK | o.O | 18:59 |
SotK | I must've broken something in src/app/util/templates/user_typeahead.html | 18:59 |
Zara | hm, two project cubes for the second project, too | 19:03 |
Zara | now I'm wondering if it's repeating the wrong thing | 19:03 |
Zara | and maybe <div ng-repeat="name in projectNames"> | 19:03 |
Zara | is doing something exciting. | 19:03 |
* Zara tries associating more projects with that story | 19:04 | |
Zara | nah still two cubes when 'affects other project' is clicked. everything there looks a bit exciting tho | 19:06 |
Zara | (my patch hides that button but I figured it might hold a clue) | 19:06 |
SotK | probably a similar mistake in the project typeahead | 19:07 |
Zara | buh | 19:08 |
Zara | hm, I wonder if the presence of <span ng-if="!enabled && inputText"> | 19:11 |
Zara | {{inputText}} | 19:11 |
Zara | </span> | 19:11 |
Zara | and then also task.title is making it display both | 19:12 |
Zara | yeah, removing that bit seems to fix it | 19:16 |
Zara | I'll send it as an update on the same change so it's fixing logged-out behaviour more generally | 19:18 |
Zara | (since I also missed the button that made me notice it in the first place :)) | 19:19 |
openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Fix behaviour for logged-out users https://review.openstack.org/368176 | 19:22 |
Zara | that fixes the duplication and hopefully hides all the buttons | 19:28 |
Zara | it'd be nice to keep at least some of them but use the 'please log in' modal but that's much more work, so this is better for now | 19:28 |
Zara | I am falling asleep. I think complex priorities are nearly ready to go but I want to test them properly (for this sort of thing) and I'm falling asleep right now. | 19:32 |
Zara | so sleepy I said that twice by accident | 19:32 |
*** alexismonville has quit IRC | 20:39 | |
*** openstackstatus has quit IRC | 20:57 | |
*** openstackstatus has joined #storyboard | 21:00 | |
*** ChanServ sets mode: +v openstackstatus | 21:00 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!