*** aswadr_ has joined #storyboard | 06:34 | |
*** wendar has quit IRC | 07:15 | |
*** wendar has joined #storyboard | 07:15 | |
*** fay_ has joined #storyboard | 07:23 | |
*** jtomasek has joined #storyboard | 07:25 | |
Zara | possibly of interest for custom dashboards (at a glance, would be worth checkign licensing things): http://packery.metafizzy.co/ | 09:52 |
---|---|---|
Zara | *checking | 09:52 |
SotK | shiny | 09:53 |
Zara | seems to be jquery and I can never remember off the top of my head which gpl license the apache license is compatible with | 09:54 |
Zara | (because I can never remember off the top of my head which gpl is which) | 09:54 |
Zara | looks like it is compatible | 09:55 |
SotK | wrong way around aiui | 09:56 |
SotK | (apache v2 is compatible with gplv3, but gplv3 things shouldn't be linked into apache v2 things) | 09:57 |
SotK | though IANAL | 09:57 |
Zara | hm, I didn't realise the way round made a difference, I thought it just worked both ways (I ain't no expert either) | 09:58 |
SotK | http://www.apache.org/licenses/GPL-compatibility.html | 09:59 |
Zara | hah, and then the third paragraph goes 'but wait!' | 10:00 |
persia | I always imagine the way-ness in similar terms to a food chain: GPL eats Apache eats BSD eats MIT eats ISC, and so forth. | 10:00 |
Zara | 'This licensing incompatibility applies only when some Apache project software becomes a derivative work of some GPLv3 software, because then the Apache software would have to be distributed under GPLv3. This would be incompatible with ASF's requirement that all Apache software must be distributed under the Apache License 2.0.' | 10:01 |
Zara | but then no definition of what they consider 'a derivative work' | 10:01 |
Zara | probaly don't want to commit there. | 10:01 |
Zara | *probably | 10:01 |
persia | A predatory license will eat almost anything, but if you want your non-predatory licensed code to survive, you have to be careful about putting it in the same software with other things. | 10:01 |
SotK | Zara: the 4th paragraph explains the derivative work thing | 10:03 |
persia | Ah, and that indicates I'm wrong: GPL can't eat Apache without indigestion (software that cannot be distributed) | 10:03 |
Zara | heh, it looks like they completely disagree on what constitutes a derivative work but don't trust themselves to win a court battle | 10:03 |
persia | https://www.gnu.org/licenses/license-list.en.html#apache2 is the other side of the discussion | 10:06 |
Zara | haha | 10:06 |
Zara | yeah, the first place I looked just said they were compatible | 10:07 |
Zara | of *course* everyone would disagree on it. | 10:07 |
persia | It depends on what you want to do with the software. If you don't need to distribute, they are. This isn't true for all the code one might have on one's computer. | 10:08 |
persia | Well, also I suppose it depends on what infrastructure you want to use. Software including Apache2 and GPLv3 sources is GPLv3, which means the ASF won't accept hosting of it, but github might. | 10:09 |
*** alexismonville has joined #storyboard | 11:27 | |
*** alexismonville has quit IRC | 11:31 | |
*** openstackgerrit has quit IRC | 11:34 | |
*** openstackgerrit has joined #storyboard | 11:34 | |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Allow permissions to be set for teams on stories https://review.openstack.org/368917 | 12:10 |
Zara | \o/ | 12:10 |
SotK | now with all the weird behaviour I could find made less weird | 12:11 |
Zara | hehe | 12:11 |
SotK | (and it also now doesn't allow you to accidentally remove all permissions from a story) | 12:11 |
Zara | hahaha | 12:11 |
Zara | that looks like the sort of patch which inevitably does something odd, will test now | 12:11 |
* Zara crosses fingers | 12:12 | |
SotK | I can't remember if that was a bug in the old version or a bug halfway through reworking | 12:12 |
Zara | I remember we talked about avoiding that case ages ago | 12:12 |
Zara | but idk whether the code allowed it in the api, just not the ui | 12:12 |
Zara | I could hunt for logs but I don't think it's worth it | 12:12 |
SotK | I'm pretty sure it was a bug when I was reworking tbh | 12:12 |
Zara | :) | 12:13 |
Zara | heh, the placement of the worklists list on a story detail page is a little odd with the private banner. can't see any way to improve it, will mull it over in the background | 12:18 |
Zara | search breaks | 12:24 |
Zara | 500: GET /api/v1/stories/search: id | 12:24 |
Zara | 500: GET /api/v1/tasks/search: (InternalError) (1054, u"Unknown column 'tasks.title' in 'where clause'") | 12:24 |
Zara | http://paste.openstack.org/show/576126/ | 12:24 |
Zara | it works on master, so definitely that patch | 12:25 |
Zara | will paste full traceback | 12:27 |
Zara | http://paste.openstack.org/show/576129/ | 12:27 |
* Zara gives a thumbs-up and backflips away B) | 12:28 | |
Zara | those are issues in revision 4, anyway, so it's not the most recent changes that have caused it | 12:38 |
Zara | oh, the first thing is similar to the thing from before so guessing that just needs to change to the same thing for search | 12:39 |
Zara | well that's a great sentence but I know what I mean, will check | 12:40 |
Zara | yeah, that fixes one of them | 12:41 |
Zara | though the other makes me wonder if it doesn't like a query like this | 12:42 |
Zara | anyway, I changed line 74 in api/v1/search/sqlalchemy_impl.py | 12:44 |
Zara | from models.StorySummary.id == subquery.c.id) to models.StorySummary.id == subquery.c.stories_id) | 12:44 |
Zara | which got rid of the error that looked like the ones from earlier. | 12:44 |
Zara | but that still leaves the big one | 12:45 |
*** jtomasek has quit IRC | 12:46 | |
Zara | (and I'm mostly pattern matching since I don't properly understand the python-sqlalchemy-mysql conversation) | 12:46 |
Zara | it says it wants a stories_id, I'll give it a stories_id... | 12:47 |
*** dabukalam_ is now known as dabukalam | 12:48 | |
*** bethwhite_ has quit IRC | 12:55 | |
*** bethwhite_ has joined #storyboard | 12:56 | |
SotK | what a hideous query | 13:07 |
Zara | I thought it was almost beautiful in its hideousness | 13:09 |
Zara | maybe I'll search repeatedly just so I get lots of them | 13:09 |
Zara | sorry I found this! | 13:09 |
Zara | and all the tests pass happily... :/ | 13:11 |
Zara | a test for 'did search report a 400, 401 or 500 error when matching a string' would be a good one, tbh; that often uncovers odd api things and so it's something I always check | 13:13 |
Zara | though it won't pick up the same thing I check at the same time, ie: did search find any results at all [for something I know is in the instance] | 13:14 |
Zara | *the same thing -> on something | 13:14 |
Zara | reminder that the storyboard meeting is at 15:00 UTC-- and the infra bugsquash after that! | 13:23 |
Zara | (I'm writing up a mini explanation of complex priorities right now) | 13:36 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Allow permissions to be set for teams on stories https://review.openstack.org/368917 | 13:43 |
Zara | yay, will take a look | 13:44 |
Zara | ugh, can never remember-- am I right in thinking owners and users can add items to a worklist? | 13:45 |
Zara | fairly sure users just can't change the direct attributes | 13:45 |
SotK | correct | 13:46 |
Zara | \o/ | 13:46 |
Zara | yay I remembered something. | 13:46 |
SotK | owners can change the permissions, title, archivedness, as well as moving/adding/removing cards like users can | 13:47 |
SotK | oh, and automaticness and filters | 13:47 |
Zara | okay, that matches my understanding. | 13:47 |
Zara | hm, I'm still getting the same error (or a very similar one) | 13:59 |
* Zara actually looks at the code | 13:59 | |
Zara | oh I guess it's just the id bit so far | 13:59 |
Zara | http://paste.openstack.org/show/576184/ | 14:01 |
SotK | oh, tasks too, oops | 14:02 |
Zara | i am the bugfinder, i eat all the bugs, munch munch munch | 14:03 |
Zara | add teams, they said, it'll be fun, they said | 14:05 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Allow permissions to be set for teams on stories https://review.openstack.org/368917 | 14:11 |
Zara | 7 iterations already | 14:32 |
SotK | :) | 14:32 |
*** bethwhite_ has quit IRC | 14:37 | |
Zara | storyboard meeting in 8 minutes! | 14:52 |
SotK | woo :D | 14:52 |
Zara | wow, that's the most enthusiastic anyone has ever been! | 14:54 |
Zara | you win a prize! | 14:54 |
pleia2 | hehe | 14:55 |
Zara | SotK: your prize is this post: https://www.thedodo.com/dapper-donkeys-guaranteed-to-m-727854881.html | 14:58 |
SotK | donkeys are the best :D | 14:59 |
persia | On the screen-size variation for complex priority display: for me, it is at the top right when the screen is wide, between the description and the tasks when the screen is medium-sized, and completely absent when the screen is narrow (and the sidebar moves to the right). | 15:37 |
Zara | oh, pep8 was unhappy with the teams patch | 15:48 |
*** bethwhite_ has joined #storyboard | 15:53 | |
*** alexismonville has joined #storyboard | 16:02 | |
*** fay_ has quit IRC | 16:11 | |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Allow teams to be added to the permission list for private stories https://review.openstack.org/370287 | 16:37 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Allow teams to be added to the permission list for private stories https://review.openstack.org/370287 | 16:38 |
persia | When one lists the stories for a project, does that show stories that are active in general, or stories that have active tasks against that project? | 16:42 |
pedroalvarez | iirc they appear in different tabs | 16:43 |
pedroalvarez | active, merged, and invalid | 16:43 |
Zara | yep | 16:43 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Allow permissions to be set for teams on stories https://review.openstack.org/368917 | 16:44 |
pedroalvarez | but persia's question is still valid | 16:44 |
persia | I think it might be the former, which could be irritating for cross-project efforts, because it means that folk end up seeing lots of things to do against their project where they can't do anything. | 16:44 |
persia | On the other hand, this might be a feature, to encourage folk to be more engaged in cross-project development to make those stories drop off the list. | 16:44 |
SotK | it is the former | 16:45 |
Zara | iirc it's stories with active tasks but where the task might not be against that project | 16:45 |
Zara | so yeah | 16:45 |
Zara | there will be a task somewhere in the story against that project | 16:45 |
Zara | but it doesn't have to be the active one | 16:45 |
Zara | and yeah, I thought it was a planned thing for cross-project efforts | 16:45 |
persia | pedroalvarez: The thing that made me look is https://storyboard.openstack.org/#!/project/708, where there is an "Active" story, but all the tasks for project 708 are "merged". | 16:46 |
persia | If it's intentional, to encourage cross-project work, then it makes sense to leave it alone, but it may also be good to start training folk to look at lists of stories for multiple projects, rather than lists of projects and stories in each project, to reduce duplication. | 16:48 |
pedroalvarez | changing it makes sense to me | 16:49 |
Zara | I think the reason people are working by project is to avoid duplicating work | 16:50 |
Zara | so there'd need to be another way to group lists of stories for triage | 16:50 |
persia | Right, but with this cross-project optimisation, working by project increases duplication of work. | 16:50 |
persia | pedroalvarez: Doesn't that discourage cross-project work? | 16:52 |
* SotK wonders when the page size changing control disappeared | 16:53 | |
Zara | oh dear | 16:53 |
pedroalvarez | not sure, if you can see the story there, means that your project has finished with it | 16:53 |
persia | pedroalvarez: Yes, but it doesn't mean the problem is solved/requirement is met. I'm being convinced that it makes for a better world if nobody is encouraged to do things like set to "invalid" as "not-my-problem": it stays one's problem until the issue is resolved. | 16:56 |
persia | (but this does mean that a lot of workflows need to be reconsidered...) | 16:57 |
Zara | we still have a thing in a result-set-pager class; maybe pushed off the page? | 16:58 |
Zara | s/class/tags | 16:58 |
SotK | nope, its not rendering at all for some reason afaict | 16:59 |
persia | git-bisect? | 17:00 |
Zara | and we still have the arrows | 17:00 |
Zara | <span ng-if="!!onPageSize" class="btn-group" dropdown> | 17:00 |
Zara | <div> | 17:00 |
Zara | <button class="btn btn-xs btn-default" | 17:00 |
Zara | dropdown-toggle> | 17:00 |
Zara | <i class="fa fa-gear"></i> | 17:00 |
Zara | </button> | 17:00 |
Zara | </div> | 17:00 |
Zara | <ul class="dropdown-menu dropdown-menu-right" role="menu"> | 17:00 |
Zara | <li class="dropdown-header"># of results</li> | 17:00 |
Zara | <li ng-repeat="size in [10,25,50,100]" | 17:00 |
Zara | ng-class="{'active': size == limit}"> | 17:00 |
Zara | <a ng-click="pageSize({'type':listType, 'pageSize':size})">{{size}}</a> | 17:00 |
Zara | </li> | 17:00 |
Zara | </ul> | 17:00 |
Zara | </span> | 17:01 |
Zara | is the bit that seems to not be rendering | 17:01 |
SotK | it was complex priorities :) | 17:01 |
Zara | was about to say maybe it's !onPageSize for some reason? | 17:01 |
Zara | yay | 17:01 |
SotK | now to remember why | 17:01 |
SotK | pretty sure it got left in from a previous implementation of the UI | 17:06 |
SotK | 18:06:45 < openstackgerrit> Adam Coldrick proposed openstack-infra/storyboard-webclient: Reinstate the page size modification control in | 17:06 |
SotK | result-set-pager https://review.openstack.org/370310 | 17:06 |
Zara | haha | 17:07 |
Zara | wait what how is it already 6:06 | 17:07 |
Zara | huh, I just tried removing onpagesize in my instance and it didn't seem to make a difference | 17:08 |
Zara | but I can test anyway | 17:08 |
SotK | (that fix will also fix clarkb's issue, since that page uses a different preference (some people expressed desire for different lists to have different lengths without clicking all the time)) | 17:11 |
Zara | okay | 17:11 |
*** bethwhite_ has quit IRC | 17:26 | |
*** aswadr_ has quit IRC | 19:32 | |
*** alexismonville has quit IRC | 19:52 | |
*** alexismonville has joined #storyboard | 19:52 | |
*** alexismonville has quit IRC | 20:12 | |
*** alexismonville has joined #storyboard | 20:16 | |
*** alexismonville has quit IRC | 20:46 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!