*** krotscheck has quit IRC | 02:32 | |
*** pleia2 has quit IRC | 02:34 | |
*** pleia2 has joined #storyboard | 02:34 | |
*** krotscheck has joined #storyboard | 02:35 | |
*** jtomasek has joined #storyboard | 05:38 | |
*** jtomasek has quit IRC | 05:49 | |
*** jtomasek has joined #storyboard | 07:02 | |
Zara | morning, storyboard! | 08:00 |
---|---|---|
openstackgerrit | Michael Still proposed openstack-infra/python-storyboardclient: Remove o/c/local.py and o/c/log.py https://review.openstack.org/391364 | 08:04 |
Zara | \o/ | 08:12 |
*** bethwhite has joined #storyboard | 08:14 | |
openstackgerrit | Merged openstack-infra/storyboard: Fix modification of private stories https://review.openstack.org/391310 | 08:19 |
Zara | we need another +1 on the 'remove local.py' patch above before we can merge it | 08:20 |
* persia keeps getting server unavaiable messages this morning :( | 08:21 | |
Zara | :( | 08:23 |
Zara | I'm not great with faces, but I'm fairly sure the author of that patch is the original author of the oslo local.py code, and these days regrets it and wants to remove all trace of it from the internet | 08:23 |
Zara | so even if it weren't a TC goal, I'd want to help there :) | 08:24 |
openstackgerrit | Michael Still proposed openstack-infra/storyboard: Remove o/c/local.py and o/c/log.py https://review.openstack.org/391369 | 08:24 |
openstackgerrit | Michael Still proposed openstack-infra/storyboard: Remove o/c/local.py and o/c/log.py https://review.openstack.org/391369 | 08:25 |
*** jtomasek has quit IRC | 08:38 | |
persia | Was the intent of 371620 to have examples for common review, or to land them for consumers of the library? | 09:18 |
Zara | the latter, I think; they're meant to just serve as examples but I thought they'd be more useful as docs in the client itself than at a gerrit link | 09:20 |
Zara | though I've waved my arms around about them a few times, so maybe people aren't fussed | 09:21 |
Zara | (sorry was afk and about to be afk again for a bit, will then look at second local.py patch) | 09:22 |
persia | It is to allow us to step away from keyboards and/or disconnect devices that IRC bouncers exist :) | 09:26 |
Zara | :) am connected once more | 09:59 |
Zara | thanks for reviewing the local.py patches | 10:00 |
openstackgerrit | Merged openstack-infra/python-storyboardclient: Remove o/c/local.py and o/c/log.py https://review.openstack.org/391364 | 10:04 |
persia | Simple, obvious, self-contained patches are my favourite to review :) | 10:14 |
Zara | :) | 10:14 |
* Zara is relocating to lunch/awards place | 10:14 | |
Zara | oh, turns out it's on the same floor and I can't go in the room yet anyway | 10:19 |
Zara | best relocation ever | 10:20 |
Zara | please can some kind soul(s) review https://review.openstack.org/#/c/373212/ | 10:24 |
Zara | the button alignment upsets me every time I see it | 10:24 |
openstackgerrit | Merged openstack-infra/storyboard: Remove o/c/local.py and o/c/log.py https://review.openstack.org/391369 | 10:27 |
openstackgerrit | Merged openstack-infra/storyboard: Allow permissions to be set for teams on stories https://review.openstack.org/368917 | 10:35 |
openstackgerrit | Michael Still proposed openstack-infra/python-storyboardclient: Remove incubated uuidutils. https://review.openstack.org/391448 | 12:30 |
openstackgerrit | Michael Still proposed openstack-infra/storyboard: Remove unused oslo incubated fixtures, and deps https://review.openstack.org/391457 | 12:48 |
persia | I remember there being some storyboard-specific hacks to openstack-common at some point. Did all those get cleaned away? | 12:51 |
SotK | I think they are only in python-storyboardclient | 12:51 |
* persia may also have a faulty memory, in which case recall correction would be alternately appreciated | 12:51 | |
Zara | the tests currently expect to import from openstack-common | 13:29 |
Zara | have left a note in review | 13:29 |
Zara | oh yeah, I want this logged for posterity: | 13:32 |
Zara | 00:02 * SotK is basicaly propping his laptop up on his hands, typgin is hard | 13:32 |
Zara | ^ SotK after half a bottle of wine last night. | 13:32 |
SotK | :D | 13:32 |
SotK | my desk was really uncomfortable tbf | 13:32 |
openstackgerrit | Michael Still proposed openstack-infra/storyboard: Remove unused oslo incubated fixtures, and deps https://review.openstack.org/391457 | 13:34 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Add filters to the /v1/tasks/search endpoint https://review.openstack.org/390983 | 14:27 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Add filters to the /v1/stories/search endpoint https://review.openstack.org/389997 | 14:27 |
openstackgerrit | Merged openstack-infra/storyboard: Remove unused oslo incubated fixtures, and deps https://review.openstack.org/391457 | 15:15 |
SotK | please can someone review https://review.openstack.org/#/c/373467/2 ? | 15:40 |
SotK | I need this patch in my life | 15:40 |
Zara | hahahaha | 15:40 |
Zara | believe it or not, he has consumed no wine today. | 15:41 |
SotK | pedroalvarez: \o/ thanks | 15:45 |
SotK | any chance of review on https://review.openstack.org/#/c/373212/ also please? | 15:48 |
pedroalvarez | I wasn't sure about that one, but happy with it if you are :) | 15:50 |
Zara | yeah, I don't think it's perfect but I think it's nicer than what came before it | 15:51 |
Zara | I agree with adam's concern about it | 15:51 |
openstackgerrit | Merged openstack-infra/storyboard-webclient: Give certain lists a border https://review.openstack.org/373467 | 15:52 |
SotK | \o/ | 15:52 |
SotK | ~o~ | 15:52 |
SotK | \o/ | 15:52 |
Zara | he's dancing b/c of the aircon in this room | 15:53 |
pedroalvarez | :) | 16:05 |
pedroalvarez | ready for zuul to digest | 16:06 |
*** zigo has quit IRC | 16:40 | |
*** fungi has quit IRC | 16:41 | |
*** zigo has joined #storyboard | 16:45 | |
*** fungi has joined #storyboard | 16:46 | |
*** bethwhite has quit IRC | 16:48 | |
*** alexismonville has joined #storyboard | 17:28 | |
*** alexismonville has quit IRC | 17:32 | |
* SotK feeds zuul | 19:37 | |
openstackgerrit | Merged openstack-infra/storyboard-webclient: Put task notes in a box https://review.openstack.org/373212 | 19:38 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!