| *** zara_the_lemur__ has quit IRC | 07:05 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Add filters to the /v1/tasks/search endpoint https://review.openstack.org/390983 | 11:16 |
|---|---|---|
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Add filters to the /v1/stories/search endpoint https://review.openstack.org/389997 | 11:16 |
| *** alexismonville has joined #storyboard | 12:54 | |
| *** alexismonville has quit IRC | 12:54 | |
| *** zara_the_lemur__ has joined #storyboard | 13:18 | |
| *** dmsimard|pto is now known as dmsimard | 13:35 | |
| dmsimard | zara_the_lemur__, SotK, SpamapS: sorry for not following up yesterday (re: can't create a story, save changes greyed out) | 13:35 |
| dmsimard | I ended up figuring the issue out just now, figured I'd let you know what it was. It's more obvious in this screenshot: http://i.imgur.com/eSYPKBu.png | 13:36 |
| dmsimard | See how my browser suggests an autocompletion for the field ? If I click the autocompletion, it'll put openstack/ara but StoryBoard doesn't pick it up. If I click openstack/ara underneath the autocompletion (the autocompletion provided by StoryBoard, not my browser) it'll work. | 13:37 |
| zara_the_lemur__ | huh, so it was the project dropdown, though that looks unusual; is your browser configured to autosuggest things itself? | 13:37 |
| zara_the_lemur__ | oh snap | 13:37 |
| zara_the_lemur__ | yeah | 13:37 |
| zara_the_lemur__ | that's interesting; I didn't know people's browsers did that | 13:37 |
| zara_the_lemur__ | and we have a lot of dropdowns, so very good to be aware of | 13:37 |
| dmsimard | There's a field setting to ensure the browser doesn't try to autocomplete it iirc | 13:37 |
| dmsimard | http://www.w3schools.com/tags/att_input_autocomplete.asp autocomplete=off | 13:38 |
| dmsimard | zara_the_lemur__: should I file a formal bug about this? :) | 13:38 |
| zara_the_lemur__ | please do! :) especially since you've found a way we might be able to fix it! | 13:39 |
| dmsimard | https://storyboard.openstack.org/#!/story/2000818 | 13:45 |
| zara_the_lemur__ | thank you :) those screenshots are great, btw | 13:50 |
| dmsimard | so I was going to submit a patch for some fields | 13:53 |
| dmsimard | but I realize that users might expect their browser suggestions too. | 13:53 |
| dmsimard | should we really blanket patch that and remove autocomplete on all those autocompletion fields? : | 13:53 |
| dmsimard | :/ | 13:53 |
| openstackgerrit | David Moreau Simard proposed openstack-infra/storyboard-webclient: Inhibit browser autocomplete when selecting a project https://review.openstack.org/406471 | 14:04 |
| persia | I think blanket-patch is the right workaround for now. The right answer is to change the framework we're using for autocomplete to somehow be compatible with browser implementations. | 14:04 |
| persia | (and then update the version of the framework used in storyboard, to consume the upstream fix) | 14:05 |
| dmsimard | I've sent a patch just for some of the project fields I found, there's obviously quite a lot of fields and since I'm not familiar with the code there might be a better way around this | 14:07 |
| dmsimard | Just to see if it at least works | 14:07 |
| zara_the_lemur__ | cool, it should show up on the draft build in a bit for testing | 14:15 |
| zara_the_lemur__ | the best place for the patch is prrrrobably in the template for the project typeahead directive: https://git.openstack.org/cgit/openstack-infra/storyboard-webclient/tree/src/app/util/template/project_typeahead.html | 14:16 |
| zara_the_lemur__ | but I haven't tried that out yet | 14:16 |
| zara_the_lemur__ | or if not that one specifically, one of these: (maybe input inline?) https://git.openstack.org/cgit/openstack-infra/storyboard-webclient/tree/src/app/util/template | 14:17 |
| zara_the_lemur__ | that'd change it globally across storyboard | 14:17 |
| SotK | ahhh, I've had that issue with search criteria in the past I think, never in that text box though | 17:05 |
| SotK | easiest fix will be to add autocomplete="off" to all of our things which are typeaheads | 17:06 |
| fungi | what's the translation story for the webclient? i'm assuming the underlying framework is similar enough to horizon that it can share the same translation import/export infrastructure we have there? | 19:09 |
| fungi | the i18n team is interested in the possibility of supporting localized interfaces, particularly for translators who want to create stories/tasks about translation-related issues | 19:10 |
| fungi | i know in general we'd want to encourage defect reports be filed in english of course, for broader searchability and to make it more likely they'd get answers | 19:11 |
| zara_the_lemur__ | I actually don't know anything about it. based on what I've heard from people who worked on both horizon and storyboard,it sounded like the webclient was quite different to horizon (though there was an effort to move horizon more toward angularjs, which would make it more like the storyboard webclient; I don't know how that's doing since I wasn't involved at | 19:53 |
| zara_the_lemur__ | all personally) betherly or krotscheck would know more on this one. | 19:53 |
| zara_the_lemur__ | iirc horizon is or was a mix of django templates and angularjs; the storyboard webclient is no django and just angularjs, if that's helpful at all | 19:54 |
| krotscheck | fungi: That was too long ago for me to remember. I'd look at the package.json file to see if there's any i18n references there. | 20:54 |
| fungi | thanks zara_the_lemur__ and krotscheck! | 21:05 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
