zara_the_lemur__ | heh, things like the 'select a project' and 'assign a user' bar will make api calls, of course | 00:25 |
---|---|---|
zara_the_lemur__ | that's nicer; means there's a smaller chance of a user clicking 'save' and it not saving their story (except for reallllyyy weird edge cases) | 00:26 |
zara_the_lemur__ | though we may get occasional reports of 'I tried to select a project and it logged me out' | 00:26 |
zara_the_lemur__ | should be super rare but have left a comment in gerrit to the effect of 'we shouldn't redirect to a login page, but we should probably have a notification saying 'you have been logged out' | 00:27 |
zara_the_lemur__ | how it actually knows to display that, I'm not sure... | 00:27 |
zara_the_lemur__ | (I'm assuming the refresh gets rid of the state that would say 'we just logged them out') | 00:29 |
*** jamesmca_ has joined #storyboard | 02:09 | |
*** jamesmca_ has quit IRC | 02:14 | |
*** jamesmca_ has joined #storyboard | 04:10 | |
*** jamesmca_ has quit IRC | 04:15 | |
*** diablo_rojo has quit IRC | 04:34 | |
*** jamesmca_ has joined #storyboard | 06:10 | |
*** jamesmca_ has quit IRC | 06:15 | |
*** jamesmca_ has joined #storyboard | 07:43 | |
*** jamesmca_ has quit IRC | 07:48 | |
SotK | it strikes me as I frantically leave the house that the same thing could happen with the current implementation, though I think the story content probably doesn't get refreshed away currently | 08:11 |
SotK | maybe we can make it even nicer sometime by saving the half-finished story in the browser local storage to be (optionally) restored later | 08:12 |
*** bethwhite has joined #storyboard | 09:30 | |
* Zara isn't sure what you mean by 'doesn't get refreshed' there (I tried creating a new one and it does redirect if you select a project for its tasks after the token has expired) | 10:26 | |
Zara | (that was last night) | 10:26 |
Zara | re: notification, my thought was that the notification itself would be refreshed away when the page refreshed | 10:27 |
Zara | I like the idea of using local storage | 10:27 |
Zara | though wonder if we'll hit 'hey this didn't update but there were changes' cache issues | 10:28 |
* Zara submerges again | 10:28 | |
SotK | I was talking about the current situation without the patch applied for "doesn't get refreshed" | 10:30 |
Zara | oh, right | 10:30 |
Zara | , indeed | 10:31 |
SotK | I'm not sure where you were concerned about the cache issues? | 10:43 |
* Zara meant that if the half-finished story was saved to local storage, in order to display that, we'd have to display the locally saved version of a page aiui | 10:44 | |
Zara | so I'm wondering if the page could be updated between the user saving an old version and looking at it in that scenario | 10:45 |
Zara | and what they would expect to see | 10:45 |
Zara | (maybe fine for creating a new story, more complex for adding tasks or something?) | 10:45 |
* SotK was envisioning saving just the story object, and then if there is something there when viewing the relevant page having a button to "restore your previous work" or something like that | 10:46 | |
Zara | ahhh, right | 10:46 |
Zara | eventually we'll get to git-backed ;) | 10:47 |
SotK | :) | 10:47 |
*** openstackgerrit has quit IRC | 10:48 | |
*** diablo_rojo has joined #storyboard | 14:18 | |
*** gomarivera_ has joined #storyboard | 15:18 | |
*** jamesmca_ has joined #storyboard | 15:22 | |
*** openstackgerrit has joined #storyboard | 15:26 | |
openstackgerrit | Merged openstack-infra/storyboard-webclient master: Handle expired refresh tokens by reloading the page https://review.openstack.org/463453 | 15:26 |
SotK | at last! | 15:26 |
SotK | thanks for the reviews :) | 15:26 |
*** gomarivera_ has quit IRC | 15:29 | |
Zara | np, that bug is my nemesis | 15:30 |
*** jamesmca_ has quit IRC | 15:45 | |
*** gomarivera_ has joined #storyboard | 16:03 | |
*** jamesmca_ has joined #storyboard | 16:09 | |
*** gomarivera_ has quit IRC | 17:05 | |
zara_the_lemur__ | so much post-summit spam | 17:28 |
diablo_rojo | zara_the_lemur__, gotta set up a dummy email and switch to that one after the summit starts | 18:02 |
zara_the_lemur__ | yeahh... | 18:04 |
zara_the_lemur__ | the same vendor has emailed me 3 times in a day; they boasted about selling a competitor to OpenStack at their booth, and seem to believe I work for AMEX for some reason | 18:05 |
diablo_rojo | Interesting.. | 18:23 |
diablo_rojo | THough also obnoxious | 18:23 |
*** jamesmca_ has quit IRC | 18:29 | |
zara_the_lemur__ | yeah (also 'competitor' isn't my spin on it or anything; they outright said that at their booth , 'we don't actually do openstack, we make a competitor') | 18:32 |
zara_the_lemur__ | then they gave me a raffle ticket that clashed with the timing of our talk | 18:32 |
*** jamesmca_ has joined #storyboard | 18:33 | |
zara_the_lemur__ | we decided it was best not to mention that and just ran away asap | 18:33 |
zara_the_lemur__ | (that we were talking, that is) | 18:34 |
diablo_rojo | Which raffle was that? The one for the nintendo switch? | 18:40 |
zara_the_lemur__ | I can't remember what the prize was | 18:41 |
zara_the_lemur__ | I always seem to pick up a ton of tickets and never make it to the drawings | 18:41 |
zara_the_lemur__ | half the time I don't want the prizes and I just pick a ticket to be polite xD | 18:41 |
*** jamesmca_ has quit IRC | 20:06 | |
*** jamesmca_ has joined #storyboard | 20:34 | |
*** jamesmca_ has quit IRC | 21:23 | |
*** jamesmca_ has joined #storyboard | 21:55 | |
*** jamesmca_ has quit IRC | 21:59 | |
*** diablo_rojo has quit IRC | 22:27 | |
*** jamesmca_ has joined #storyboard | 23:05 | |
*** jamesmca_ has quit IRC | 23:15 | |
*** jamesmca_ has joined #storyboard | 23:15 | |
*** jamesmca_ has quit IRC | 23:25 | |
*** jamesmca_ has joined #storyboard | 23:42 | |
*** jamesmca_ has quit IRC | 23:47 | |
*** jamesmca_ has joined #storyboard | 23:48 | |
*** jamesmca_ has quit IRC | 23:50 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!