| *** mordred has quit IRC | 01:49 | |
| *** jamesmcarthur has joined #storyboard | 01:55 | |
| *** jamesmcarthur has quit IRC | 02:00 | |
| *** mordred has joined #storyboard | 02:07 | |
| *** noama has joined #storyboard | 03:34 | |
| *** diablo_rojo has quit IRC | 04:37 | |
| *** lifeless has joined #storyboard | 05:16 | |
| *** strigazi has quit IRC | 05:17 | |
| *** strigazi has joined #storyboard | 05:19 | |
| *** strigazi_ has joined #storyboard | 05:24 | |
| *** strigazi has quit IRC | 05:27 | |
| *** udesale has joined #storyboard | 05:44 | |
| *** openstackgerrit has quit IRC | 06:04 | |
| *** noam has joined #storyboard | 07:01 | |
| *** noama has quit IRC | 07:04 | |
| *** florianf has joined #storyboard | 07:24 | |
| *** florianf has quit IRC | 07:25 | |
| *** tosky has joined #storyboard | 07:41 | |
| *** noam__ has joined #storyboard | 07:45 | |
| *** noam has quit IRC | 07:46 | |
| SotK | thanks dhellmann! | 07:51 |
|---|---|---|
| *** jamesmcarthur has joined #storyboard | 08:03 | |
| *** jpich has joined #storyboard | 08:05 | |
| *** jamesmcarthur has quit IRC | 08:08 | |
| *** noam__ has quit IRC | 08:13 | |
| *** lifeless has quit IRC | 09:16 | |
| *** dtantsur|afk is now known as dtantsur | 09:18 | |
| *** strigazi_ is now known as strigazi | 09:47 | |
| *** udesale has quit IRC | 11:33 | |
| dhellmann | woot! | 12:33 |
| *** dtantsur is now known as dtantsur|brb | 13:22 | |
| *** frickler has quit IRC | 13:26 | |
| *** frickler has joined #storyboard | 13:26 | |
| *** udesale has joined #storyboard | 13:31 | |
| SotK | oh, I wonder if the pecan dev server unquotes the path before splitting it to pass to the _route method of controllers | 14:07 |
| SotK | in answer to my wondering from last night | 14:07 |
| *** jamesmcarthur_ has joined #storyboard | 14:12 | |
| *** dtantsur|brb is now known as dtantsur | 14:45 | |
| fungi | hrm, maybe. i played around with all manner of possible hacks in _route() last night, to no avail | 14:52 |
| fungi | i found plenty of ways to completely break the projects method, but none to properly unquote the project argument | 14:53 |
| fungi | SotK: you have ssh/sudo access on storyboard-dev... editing /usr/local/lib/python2.7/dist-packages/storyboard/api/v1/projects.py in place and then doing a `sudo service apache2 restart` should allow you to evaluate it if you get a chance | 14:54 |
| fungi | i was testing like `wget --no-check-certificate -qO- https://storyboard-dev.openstack.org/api/v1/projects/openstack%2Fpatrole` | 14:55 |
| *** jamesmca_ has joined #storyboard | 15:12 | |
| *** udesale has quit IRC | 16:09 | |
| *** jpich has quit IRC | 16:28 | |
| *** jamesmca_ has quit IRC | 16:28 | |
| *** jamesmca_ has joined #storyboard | 16:29 | |
| *** jamesmca_ has quit IRC | 16:34 | |
| *** dtantsur is now known as dtantsur|afk | 17:15 | |
| *** jamesmcarthur_ has quit IRC | 19:01 | |
| *** jamesmcarthur has joined #storyboard | 19:56 | |
| *** jamesmcarthur has quit IRC | 20:17 | |
| *** noama has joined #storyboard | 20:18 | |
| *** jamesmcarthur has joined #storyboard | 20:34 | |
| dhellmann | is it possible to specify that a task applies to a certain branch? I feel like I saw something about that in the schema... | 20:44 |
| dhellmann | fungi, SotK : why are you quoting the / in the URL there? | 20:45 |
| dhellmann | oh, that's an API link | 20:45 |
| dhellmann | I guess people are less likely to type those in by hand | 20:46 |
| fungi | dhellmann: you can supply non-escaped shashes in project names directly to the api and it handles that fine | 20:50 |
| dhellmann | oh, ok, good | 20:50 |
| fungi | problem is storyboard-webclient wants to do url escaping on parameters which are piped through it | 20:50 |
| fungi | so the current idea is to have the api also support unescaping those if necessary | 20:51 |
| dhellmann | is it doing that itself, or is that done by some library it uses? | 20:51 |
| fungi | but something's not quite right (yet) with the implementation there | 20:51 |
| fungi | good question, i'm not quite sure what causes the initial escaping. could be apache itself even? | 20:51 |
| fungi | i guess i could look at the apache access log to find out. checking | 20:52 |
| fungi | 2001:470:e0d6:0:96de:80ff:feec:f9e7 - - [26/Jun/2018:20:53:48 +0000] "GET /api/v1/projects/openstack%2Fpatrole HTTP/1.1" 404 732 "https://storyboard.openstack.org/" "Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0" | 20:54 |
| fungi | so i guess the api is encapsulating there | 20:54 |
| fungi | er, i mean the webclient is encapsulating | 20:54 |
| fungi | when hitting the api endpoint | 20:55 |
| dhellmann | I wonder if we could just make it stop doing that in this case | 20:55 |
| dhellmann | maybe that's a bad idea from a security standpoint | 20:56 |
| persia | Given the amount of fussing that was involved in trying to get everything to be quoted in the past, it probably makes sense to carefully dequote those few strings where "dangerous" characters may appear. | 21:22 |
| *** noama has quit IRC | 21:28 | |
| fungi | yeah, i'm okay with the current approach if we can figure out all the right places where we need unquoting. apparently https://review.openstack.org/577081 just wasn't quite enough | 21:28 |
| *** lifeless has joined #storyboard | 21:38 | |
| *** jamesmcarthur has quit IRC | 21:54 | |
| *** tosky has quit IRC | 23:08 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!