diablo_rojo | persia, so multiple things being archived at 9999 at once? | 00:22 |
---|---|---|
* diablo_rojo read the sentence several times and couldn't figure it out for some reason | 00:22 | |
persia | I can't see any code that prevents that, yes. | 00:23 |
persia | But I might not have followed the code correctly, etc. | 00:23 |
diablo_rojo | When everything gets moved up when an item is taken out it should end up putting the next item at 9999 and the previous item will move to 9998? | 00:25 |
diablo_rojo | I think? | 00:25 |
diablo_rojo | I will have to go back through the code again. | 00:26 |
persia | My read of the code was: something is added @ 9999 | 00:27 |
persia | Something else is added @ 9999 | 00:28 |
persia | I didn't see anything that pushed it to 9998 *unless* something was reordered. | 00:28 |
*** jamesmcarthur has quit IRC | 00:28 | |
persia | But yeah, if you don't see it, feel free to overrride my concern. | 00:28 |
* persia doesn't have any particular agenda behind this opinion, but is rather worred there is a potential corner-case bug in the code | 00:29 | |
persia | (with "rather" above being a synonym for "instead" and not an intensifier) | 00:29 |
*** jamesmcarthur has joined #storyboard | 00:29 | |
* persia goes to do something that triggers less semantic confusion | 00:29 | |
*** jamesmcarthur has quit IRC | 00:34 | |
diablo_rojo | No worries. I'll look at it again tomorrow. Maybe my brain has just given up for the day. | 00:35 |
*** jamesmcarthur has joined #storyboard | 00:55 | |
*** jamesmcarthur has quit IRC | 00:59 | |
*** diablo_rojo has quit IRC | 01:05 | |
*** jamesmcarthur has joined #storyboard | 01:28 | |
*** jamesmcarthur has quit IRC | 04:57 | |
*** jamesmcarthur has joined #storyboard | 05:01 | |
*** jamesmcarthur has quit IRC | 05:06 | |
*** udesale has joined #storyboard | 05:09 | |
*** jamesmcarthur has joined #storyboard | 06:29 | |
*** jamesmcarthur has quit IRC | 06:34 | |
*** jtomasek has joined #storyboard | 06:44 | |
*** jamesmcarthur has joined #storyboard | 07:07 | |
*** jamesmcarthur has quit IRC | 07:11 | |
*** jamesmcarthur has joined #storyboard | 07:29 | |
*** jamesmcarthur has quit IRC | 07:34 | |
*** tosky has joined #storyboard | 07:50 | |
*** jamesmcarthur has joined #storyboard | 07:56 | |
*** jpich has joined #storyboard | 07:58 | |
*** jamesmcarthur has quit IRC | 08:01 | |
SotK | persia read it correctly, items are added in position 99999 (which is the same position all deleted/"archived" cards get moved to) | 08:34 |
SotK | they're then moved into the correct place by "move_item" | 08:35 |
SotK | its possible for two requests to be almost clashing and the position of a new card to temporarily become 100000, but it doesn't really matter since it should be eventually consistent in all cases where there are less than 99998 unarchived cards in the list when adding a new card unless I'm logically missing something | 08:39 |
SotK | and if you have 100000 cards in your worklist more things will break than just ordering | 08:40 |
SotK | re-reading the above, adding something at position 99999 deliberately will also make that card's position get wonky when more things are added, you're right, we probably should cap attempts to add a card too far outside the existing bounds | 08:56 |
*** tosky has quit IRC | 09:02 | |
*** tosky has joined #storyboard | 09:03 | |
*** jtomasek has quit IRC | 09:56 | |
*** jamesmcarthur has joined #storyboard | 10:12 | |
*** jamesmcarthur has quit IRC | 10:16 | |
*** dtantsur|afk is now known as dtantsur | 10:57 | |
*** udesale has quit IRC | 11:32 | |
*** EmilienM is now known as EvilienM | 12:00 | |
*** jamesmcarthur has joined #storyboard | 12:45 | |
*** jaosorior has quit IRC | 13:00 | |
*** jamesmcarthur has quit IRC | 14:18 | |
*** jamesmcarthur has joined #storyboard | 14:18 | |
*** jamesmcarthur has quit IRC | 14:38 | |
*** jamesmcarthur has joined #storyboard | 14:38 | |
*** jamesmcarthur has quit IRC | 14:41 | |
*** jamesmcarthur has joined #storyboard | 14:42 | |
*** jamesmcarthur has quit IRC | 14:46 | |
*** jamesmcarthur has joined #storyboard | 14:55 | |
*** jamesmcarthur has quit IRC | 14:59 | |
*** jamesmcarthur has joined #storyboard | 15:00 | |
*** ianychoi has quit IRC | 16:39 | |
*** ianychoi has joined #storyboard | 16:44 | |
*** dtantsur is now known as dtantsur|afk | 16:45 | |
*** jpich has quit IRC | 16:52 | |
*** jtomasek has joined #storyboard | 17:24 | |
*** jamesmcarthur has quit IRC | 17:48 | |
*** diablo_rojo has joined #storyboard | 17:52 | |
*** TheJulia is now known as needssleep | 18:02 | |
*** EvilienM is now known as EmilienM | 22:20 | |
*** jamesmcarthur has joined #storyboard | 22:36 | |
*** jamesmcarthur has quit IRC | 22:40 | |
*** tosky has quit IRC | 22:42 | |
*** jamesmcarthur has joined #storyboard | 23:34 | |
*** jamesmcarthur has quit IRC | 23:39 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!