| *** dangtrinhnt has joined #storyboard | 00:18 | |
| *** jamesmcarthur has quit IRC | 00:26 | |
| *** jamesmcarthur has joined #storyboard | 00:27 | |
| *** jamesmcarthur has quit IRC | 00:30 | |
| *** jamesmcarthur has joined #storyboard | 00:30 | |
| *** ianychoi has joined #storyboard | 00:31 | |
| *** jamesmcarthur has quit IRC | 00:55 | |
| *** jamesmcarthur has joined #storyboard | 00:55 | |
| *** jamesmcarthur has quit IRC | 00:59 | |
| *** ianychoi has quit IRC | 01:16 | |
| *** ianychoi has joined #storyboard | 01:16 | |
| *** openstackgerrit has quit IRC | 01:37 | |
| *** mugsie has quit IRC | 01:37 | |
| *** dabukalam has quit IRC | 01:37 | |
| *** jmccrory has quit IRC | 01:37 | |
| *** aspiers has quit IRC | 01:37 | |
| *** thrace has quit IRC | 01:37 | |
| *** johnsom has quit IRC | 01:37 | |
| *** persia has quit IRC | 01:37 | |
| *** gmann has quit IRC | 01:37 | |
| *** gouthamr has quit IRC | 01:37 | |
| *** ssbarnea_ has quit IRC | 01:37 | |
| *** pleia2 has quit IRC | 01:37 | |
| *** dtantsur|afk has quit IRC | 01:37 | |
| *** hogepodge has quit IRC | 01:37 | |
| *** EmilienM has quit IRC | 01:37 | |
| *** dhellmann has quit IRC | 01:37 | |
| *** Zara has quit IRC | 01:37 | |
| *** fungi has quit IRC | 01:37 | |
| *** ttx has quit IRC | 01:37 | |
| *** ironfoot has quit IRC | 01:37 | |
| *** NikitaKonovalov has quit IRC | 01:37 | |
| *** chason has quit IRC | 01:37 | |
| *** TheJulia has quit IRC | 01:37 | |
| *** mordred has quit IRC | 01:37 | |
| *** jaosorior has quit IRC | 01:37 | |
| *** tsmith2 has quit IRC | 01:37 | |
| *** kei-ichi has quit IRC | 01:37 | |
| *** ianychoi has quit IRC | 01:37 | |
| *** dangtrinhnt has quit IRC | 01:37 | |
| *** ianw has quit IRC | 01:37 | |
| *** robcresswell has quit IRC | 01:37 | |
| *** SotK has quit IRC | 01:37 | |
| *** ChanServ has quit IRC | 01:37 | |
| *** ianw has joined #storyboard | 01:43 | |
| *** mugsie has joined #storyboard | 01:43 | |
| *** dangtrinhnt has joined #storyboard | 01:43 | |
| *** ianychoi has joined #storyboard | 01:43 | |
| *** persia has joined #storyboard | 01:44 | |
| *** gmann has joined #storyboard | 01:44 | |
| *** fungi has joined #storyboard | 01:44 | |
| *** ttx has joined #storyboard | 01:44 | |
| *** gouthamr has joined #storyboard | 01:44 | |
| *** ssbarnea_ has joined #storyboard | 01:44 | |
| *** pleia2 has joined #storyboard | 01:44 | |
| *** openstackgerrit has joined #storyboard | 01:44 | |
| *** robcresswell has joined #storyboard | 01:45 | |
| *** SotK has joined #storyboard | 01:45 | |
| *** dtantsur|afk has joined #storyboard | 01:45 | |
| *** hogepodge has joined #storyboard | 01:45 | |
| *** EmilienM has joined #storyboard | 01:45 | |
| *** dabukalam has joined #storyboard | 01:45 | |
| *** chason has joined #storyboard | 01:46 | |
| *** NikitaKonovalov has joined #storyboard | 01:46 | |
| *** TheJulia has joined #storyboard | 01:46 | |
| *** mordred has joined #storyboard | 01:46 | |
| *** ironfoot has joined #storyboard | 01:46 | |
| *** dhellmann has joined #storyboard | 01:46 | |
| *** Zara has joined #storyboard | 01:46 | |
| *** jaosorior has joined #storyboard | 01:46 | |
| *** tsmith2 has joined #storyboard | 01:46 | |
| *** kei-ichi has joined #storyboard | 01:46 | |
| *** ChanServ has joined #storyboard | 01:47 | |
| *** card.freenode.net sets mode: +o ChanServ | 01:47 | |
| *** jamesmcarthur has joined #storyboard | 01:49 | |
| *** thrace has joined #storyboard | 01:49 | |
| *** aspiers has joined #storyboard | 02:09 | |
| openstackgerrit | 98k proposed openstack-infra/python-storyboardclient master: Don't quote {posargs} in tox.ini https://review.openstack.org/609176 | 02:24 |
|---|---|---|
| *** jamesmcarthur has quit IRC | 03:29 | |
| *** jamesmcarthur has joined #storyboard | 03:30 | |
| *** jamesmcarthur has quit IRC | 03:34 | |
| *** udesale has joined #storyboard | 03:52 | |
| *** jamesmcarthur has joined #storyboard | 03:59 | |
| *** jamesmcarthur has quit IRC | 04:21 | |
| *** jamesmcarthur has joined #storyboard | 04:28 | |
| *** jamesmcarthur has quit IRC | 04:45 | |
| *** jamesmcarthur has joined #storyboard | 04:48 | |
| *** jamesmcarthur has quit IRC | 05:10 | |
| *** jamesmcarthur has joined #storyboard | 05:17 | |
| *** jamesmcarthur has quit IRC | 05:30 | |
| *** jtomasek has joined #storyboard | 05:32 | |
| *** jamesmcarthur has joined #storyboard | 05:38 | |
| *** jamesmcarthur has quit IRC | 05:43 | |
| *** diablo_rojo has joined #storyboard | 05:43 | |
| *** jamesmcarthur has joined #storyboard | 05:45 | |
| *** jamesmcarthur has quit IRC | 05:58 | |
| *** jamesmcarthur has joined #storyboard | 05:59 | |
| *** jamesmcarthur has quit IRC | 06:07 | |
| *** diablo_rojo has quit IRC | 06:10 | |
| *** jamesmcarthur has joined #storyboard | 06:15 | |
| *** jamesmcarthur has quit IRC | 06:20 | |
| *** jamesmcarthur has joined #storyboard | 06:39 | |
| *** jamesmcarthur has quit IRC | 06:43 | |
| *** thrace has quit IRC | 07:08 | |
| *** mugsie has quit IRC | 07:08 | |
| *** thrace has joined #storyboard | 07:10 | |
| *** jamesmcarthur has joined #storyboard | 07:15 | |
| *** jamesmcarthur has quit IRC | 07:20 | |
| *** jpich has joined #storyboard | 07:21 | |
| *** thrace has quit IRC | 07:34 | |
| *** thrace has joined #storyboard | 07:36 | |
| *** jamesmcarthur has joined #storyboard | 07:36 | |
| *** jamesmcarthur has quit IRC | 07:41 | |
| *** tosky has joined #storyboard | 07:42 | |
| *** jamesmcarthur has joined #storyboard | 07:57 | |
| *** jamesmcarthur has quit IRC | 08:01 | |
| *** jamesmcarthur has joined #storyboard | 08:18 | |
| *** jamesmcarthur has quit IRC | 08:22 | |
| *** jamesmcarthur has joined #storyboard | 08:38 | |
| *** jamesmcarthur has quit IRC | 08:42 | |
| *** jamesmcarthur has joined #storyboard | 08:59 | |
| *** jamesmcarthur has quit IRC | 09:04 | |
| *** jpich has quit IRC | 09:16 | |
| *** jpich has joined #storyboard | 09:17 | |
| *** jamesmcarthur has joined #storyboard | 09:20 | |
| *** jamesmcarthur has quit IRC | 09:24 | |
| *** jpich has quit IRC | 09:36 | |
| *** jpich has joined #storyboard | 09:36 | |
| *** jamesmcarthur has joined #storyboard | 09:40 | |
| *** jamesmcarthur has quit IRC | 09:45 | |
| *** jamesmcarthur has joined #storyboard | 10:01 | |
| *** jamesmcarthur has quit IRC | 10:06 | |
| *** jamesmcarthur has joined #storyboard | 10:42 | |
| *** jamesmcarthur has quit IRC | 10:47 | |
| *** jamesmcarthur has joined #storyboard | 11:03 | |
| *** jamesmcarthur has quit IRC | 11:08 | |
| *** udesale has quit IRC | 11:11 | |
| *** dtantsur|afk is now known as dtantsur | 11:16 | |
| *** jamesmcarthur has joined #storyboard | 11:24 | |
| *** jamesmcarthur has quit IRC | 11:28 | |
| *** jpich has quit IRC | 11:40 | |
| *** jpich has joined #storyboard | 11:41 | |
| *** jamesmcarthur has joined #storyboard | 11:45 | |
| *** jamesmcarthur has quit IRC | 11:49 | |
| *** diablo_rojo has joined #storyboard | 12:15 | |
| *** jamesmcarthur has joined #storyboard | 12:24 | |
| *** jamesmcarthur has quit IRC | 12:29 | |
| *** jamesmcarthur has joined #storyboard | 12:45 | |
| *** udesale has joined #storyboard | 12:45 | |
| *** jamesmcarthur has quit IRC | 12:49 | |
| *** jamesmcarthur has joined #storyboard | 12:57 | |
| *** diablo_rojo has quit IRC | 13:48 | |
| *** diablo_rojo has joined #storyboard | 14:13 | |
| *** dtantsur is now known as dtantsur|brb | 14:13 | |
| *** SotK has quit IRC | 14:27 | |
| *** johnsom has joined #storyboard | 14:31 | |
| *** clarkb has joined #storyboard | 14:44 | |
| *** SotK has joined #storyboard | 15:24 | |
| *** jamesmcarthur has quit IRC | 15:29 | |
| *** jamesmcarthur has joined #storyboard | 15:30 | |
| *** jamesmcarthur has quit IRC | 15:36 | |
| *** jamesmcarthur has joined #storyboard | 15:36 | |
| *** udesale has quit IRC | 15:57 | |
| *** diablo_rojo has quit IRC | 16:05 | |
| *** dtantsur|brb is now known as dtantsur | 16:15 | |
| *** jpich has quit IRC | 16:33 | |
| *** jamesmcarthur has quit IRC | 16:44 | |
| *** dtantsur is now known as dtantsur|afk | 17:34 | |
| fungi | SotK: i'm guessing no meeting this week. haven't seen any mention in here and diablo_rojo is likely busy with openstackdays nordic right now | 19:08 |
| *** jamesmcarthur has joined #storyboard | 20:00 | |
| *** fatema_ has joined #storyboard | 20:32 | |
| fatema_ | Hello | 20:32 |
| *** diablo_rojo_phon has joined #storyboard | 20:32 | |
| fatema_ | SotK, I was wondering about the patch that has security issue, I doubt that I pass the parameters wrongfully to "api_base.filter_private_stories" | 20:42 |
| fungi | fatema_: which patch? | 20:54 |
| fatema_ | https://review.openstack.org/#/c/591092/2 | 20:55 |
| fatema_ | fungi, ^^ | 20:55 |
| fungi | thanks! i'll take a look | 20:56 |
| fungi | fatema_: i could be misunderstanding, but i think SotK was suggesting that by only calling api_base.filter_private_stories() when 'comment' not in kwargs you could end up leaking comments for private stories | 21:04 |
| fatema_ | the problem with the patch isn't only pep8, The output of it is not as expected right now. | 21:05 |
| fungi | but further, that fixing it isn't straightforward since the data model doesn't currently declare any direct relationship between stories and comments | 21:05 |
| fungi | fatema_: yeah, i didn't mean to indicate there weren't other issues with the patch besides the stray whitespace there, just pointing it out while skimming | 21:06 |
| *** fatema_ has quit IRC | 21:11 | |
| *** fatema_ has joined #storyboard | 21:28 | |
| *** diablo_rojo has joined #storyboard | 22:14 | |
| *** tosky has quit IRC | 22:19 | |
| *** diablo_rojo has quit IRC | 22:33 | |
| *** jtomasek has quit IRC | 22:36 | |
| fatema_ | fungi, exactly it isn't straightforward that's why there is the join lines | 22:37 |
| fungi | right, i think the point is that we need to make sure not to return any comments in private stories for which the user is not authorized | 22:39 |
| *** fatema_ has quit IRC | 22:50 | |
| *** jamesmcarthur has quit IRC | 23:17 | |
| *** jamesmcarthur has joined #storyboard | 23:17 | |
| *** jamesmcarthur has quit IRC | 23:22 | |
| *** jamesmcarthur has joined #storyboard | 23:26 | |
| *** jamesmcarthur has quit IRC | 23:30 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!