*** ironfoot has joined #storyboard | 00:12 | |
*** ironfoot has quit IRC | 00:24 | |
*** ironfoot has joined #storyboard | 00:27 | |
*** ironfoot has quit IRC | 00:31 | |
*** tosky has quit IRC | 00:32 | |
*** ironfoot has joined #storyboard | 00:32 | |
*** diablo_rojo has quit IRC | 03:45 | |
*** udesale has joined #storyboard | 04:05 | |
*** udesale has quit IRC | 04:15 | |
*** udesale has joined #storyboard | 04:16 | |
*** udesale has quit IRC | 04:26 | |
*** udesale has joined #storyboard | 06:05 | |
*** udesale has quit IRC | 06:12 | |
*** udesale has joined #storyboard | 06:13 | |
*** udesale has quit IRC | 06:33 | |
*** udesale has joined #storyboard | 06:33 | |
*** diablo_rojo has joined #storyboard | 06:46 | |
*** jpich has joined #storyboard | 08:38 | |
*** tosky has joined #storyboard | 08:44 | |
*** dtantsur|afk is now known as dtantsur | 08:56 | |
*** diablo_rojo has quit IRC | 09:26 | |
*** jaosorior has joined #storyboard | 10:09 | |
*** udesale has quit IRC | 10:25 | |
*** udesale has joined #storyboard | 10:35 | |
*** jtomasek has quit IRC | 10:40 | |
*** jtomasek has joined #storyboard | 10:40 | |
*** jtomasek has joined #storyboard | 10:41 | |
*** udesale has quit IRC | 11:01 | |
*** openstackgerrit has quit IRC | 11:22 | |
*** udesale has joined #storyboard | 11:36 | |
*** udesale has quit IRC | 13:36 | |
*** udesale has joined #storyboard | 13:36 | |
*** udesale has quit IRC | 17:04 | |
*** jpich has quit IRC | 17:09 | |
*** dtantsur is now known as dtantsur|afk | 17:28 | |
*** dtantsur|afk has quit IRC | 17:36 | |
*** jamesmcarthur has joined #storyboard | 17:40 | |
*** diablo_rojo has joined #storyboard | 18:12 | |
*** jamesmcarthur has quit IRC | 18:18 | |
*** jamesmcarthur has joined #storyboard | 18:19 | |
*** jamesmcarthur has quit IRC | 18:20 | |
*** jamesmcarthur has joined #storyboard | 18:21 | |
*** jamesmcarthur has quit IRC | 19:00 | |
*** jamesmcarthur has joined #storyboard | 19:01 | |
*** jamesmcarthur has quit IRC | 20:35 | |
*** jamesmcarthur has joined #storyboard | 20:37 | |
*** jamesmcarthur has quit IRC | 20:45 | |
*** jamesmcarthur has joined #storyboard | 20:46 | |
fungi | just a heads up, i've discovered that openid functionality in storyboard doesn't work for us with oauthlib 3.0.0, but is working fine with 1.1.1 | 21:13 |
---|---|---|
fungi | on returning from the provider, "InvalidRedirectURIError: (invalid_request) Invalid redirect URI." is raised in oauthlib.oauth2.rfc6749.grant_types.base._handle_redirects() | 21:14 |
fungi | downgrading oauthlib to 1.1.1 seems to have solved it, but i haven't dug deeper yet | 21:14 |
diablo_rojo | thanks for the heads up fungi | 21:15 |
diablo_rojo | Looks like everything I +2+Wed yesterday that had previously been passing Zuul is now failing | 21:15 |
fungi | that's super fun | 21:16 |
diablo_rojo | Yeah. Thrilling. | 21:16 |
fungi | got an example failure? | 21:16 |
diablo_rojo | https://review.openstack.org/#/c/621045/ | 21:16 |
diablo_rojo | py27 and py35 had been passing and now are not | 21:16 |
diablo_rojo | which is weird. | 21:17 |
diablo_rojo | given the change | 21:17 |
* diablo_rojo digs into logs now | 21:17 | |
fungi | oauth failures | 21:18 |
diablo_rojo | Yeah looks like | 21:18 |
diablo_rojo | So... going back to 1.1.1 should make it so that all passes? | 21:19 |
fungi | dunno if this is related (yet) | 21:19 |
fungi | oauthlib 3.0.0 was released 2019-01-08 so if the successful runs were all at least a week old, then maybe? https://pypi.org/project/oauthlib/#history | 21:20 |
fungi | first new release of oauthlib in ~8 months, and it's a major version bump | 21:20 |
diablo_rojo | Yeah they almost definitely were | 21:20 |
diablo_rojo | Yeah looks like the current failures are using 3.0.0 | 21:20 |
diablo_rojo | Nov 29th was when they succeeded | 21:21 |
fungi | https://github.com/oauthlib/oauthlib/blob/master/CHANGELOG.rst | 21:21 |
diablo_rojo | so definitely more than a week old | 21:21 |
*** jamesmcarthur has quit IRC | 21:31 | |
*** jamesmcarthur has joined #storyboard | 21:33 | |
fungi | the https://github.com/oauthlib/oauthlib/issues/445 fix might be what's biting us | 21:37 |
*** jamesmcarthur has quit IRC | 21:38 | |
fungi | that was called out in the changelog for 3.0.0 anyway | 21:38 |
fungi | oh, though that's in the provider implementation, not the client | 21:39 |
*** jamesmcarthur has joined #storyboard | 21:40 | |
fungi | i'm going to test with 2.1.0 on the new dev server to see if that also works as intended | 21:41 |
fungi | yeah, seems to be fine, so pinning oauthlib<3 for right now is probably prudent while we work out what's regressed and whether it's something we've been doing wrong all along or an actual bug in the lib | 21:42 |
*** jamesmcarthur has quit IRC | 21:42 | |
*** jamesmcarthur has joined #storyboard | 21:43 | |
diablo_rojo | fungi, you get the patch up and I will +2 +W | 21:44 |
fungi | cool, sorry had to pop out to pick up chinese, will do now | 22:01 |
*** openstackgerrit has joined #storyboard | 22:06 | |
openstackgerrit | Jeremy Stanley proposed openstack-infra/storyboard master: Pin oauthlib<3 for now https://review.openstack.org/631079 | 22:06 |
fungi | diablo_rojo: ^ | 22:06 |
diablo_rojo | fungi, I'm on it. | 22:09 |
*** jamesmcarthur has quit IRC | 22:09 | |
fungi | they probably don't know about problems with that release because all those <3 pins are just interpreted as heart emoticons and they wonder why everyone suddenly started to express their undying love for oauthlib | 22:11 |
*** jamesmcarthur has joined #storyboard | 22:15 | |
diablo_rojo | All you need is love. | 22:21 |
*** jamesmcarthur has quit IRC | 22:24 | |
*** jamesmcarthur has joined #storyboard | 22:25 | |
*** jamesmcarthur has quit IRC | 22:30 | |
fungi | diablo_rojo: looks like the tox-py27 job passed in check for that change already, so you can recheck those other changes after this merges or rebase them onto it if you're impatient | 22:31 |
fungi | tox-py35 just succeeded too, so now we're down to tox-cover which was failing before the pin | 22:31 |
*** jamesmcarthur has joined #storyboard | 22:32 | |
*** jamesmcarthur has quit IRC | 22:34 | |
diablo_rojo | I'll probably just wait and recheck again after it merges. | 22:35 |
fungi | shouldn't be long | 22:35 |
* diablo_rojo watches zuul | 22:38 | |
*** jamesmcarthur has joined #storyboard | 22:38 | |
*** jamesmcarthur has quit IRC | 22:41 | |
*** jamesmcarthur has joined #storyboard | 22:43 | |
diablo_rojo | Almost there! | 22:49 |
*** jtomasek has quit IRC | 23:01 | |
*** jamesmcarthur has quit IRC | 23:13 | |
*** jamesmcarthur has joined #storyboard | 23:14 | |
*** jamesmcarthur has quit IRC | 23:33 | |
*** jamesmcarthur has joined #storyboard | 23:34 | |
*** jamesmcarthur has quit IRC | 23:40 | |
openstackgerrit | Merged openstack-infra/storyboard master: Pin oauthlib<3 for now https://review.openstack.org/631079 | 23:49 |
diablo_rojo | I rechecked everything that is stuck. | 23:53 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!