*** tosky has quit IRC | 00:02 | |
*** jamesmcarthur has joined #storyboard | 00:47 | |
*** jamesmcarthur has quit IRC | 01:01 | |
*** jamesmcarthur has joined #storyboard | 01:02 | |
*** whoami-rajat has joined #storyboard | 02:01 | |
*** jamesmcarthur has quit IRC | 02:18 | |
*** jamesmcarthur has joined #storyboard | 02:20 | |
*** jamesmcarthur has quit IRC | 02:25 | |
*** jamesmcarthur has joined #storyboard | 02:55 | |
*** jamesmcarthur has quit IRC | 03:01 | |
*** jamesmcarthur has joined #storyboard | 04:46 | |
*** ivy has quit IRC | 05:05 | |
*** jamesmcarthur has quit IRC | 05:19 | |
*** udesale has joined #storyboard | 05:42 | |
*** kshitija has joined #storyboard | 06:23 | |
*** kshitija has quit IRC | 06:45 | |
*** jamesmcarthur has joined #storyboard | 06:49 | |
*** jtomasek has joined #storyboard | 06:53 | |
*** jamesmcarthur has quit IRC | 06:54 | |
*** kshitija has joined #storyboard | 07:00 | |
*** lakshmi_p has joined #storyboard | 07:38 | |
lakshmi_p | Hello :) I'm Lakshmi, I got here through the Outreachy program. I'm looking forward to work with you guys and know you all :) | 07:42 |
---|---|---|
*** lakshmi_p has quit IRC | 07:49 | |
*** jamesmcarthur has joined #storyboard | 07:51 | |
*** lakshmi has joined #storyboard | 07:51 | |
*** lakshmi has quit IRC | 07:54 | |
*** lakshmi has joined #storyboard | 07:54 | |
*** jamesmcarthur has quit IRC | 07:55 | |
*** zbr|ssbarnea has joined #storyboard | 08:22 | |
*** zbr|ssbarnea is now known as zbr | 08:22 | |
*** tosky has joined #storyboard | 08:41 | |
*** jamesmcarthur has joined #storyboard | 08:51 | |
*** jamesmcarthur has quit IRC | 08:56 | |
*** jpich has joined #storyboard | 09:04 | |
cmoura | Hi folks. I'm working on #28146 and I want to test the migration process from launchpad to storyboard. But, I'm getting an error when I'm trying to run the migration. Here: https://pastebin.com/6HJFXShr | 09:34 |
jaosorior | hey folks! could I get a review for this https://review.rdoproject.org/r/#/c/19016/ ? | 09:36 |
jaosorior | d'oh! wrong channel | 09:36 |
*** rluders has joined #storyboard | 09:36 | |
SotK | cmoura: oh, looks like the openid library we use doesn't support python3 :( | 09:42 |
SotK | https://pypi.org/project/python3-openid/ appears to exist, you could try replacing python-openid with python3-openid in our requirements.txt and retrying | 09:43 |
SotK | (you'll also need to do `rm -rf .tox/venv` to force tox to regenerate the virtualenv with the new dependency) | 09:44 |
cmoura | SotK, Thanks :) | 09:47 |
*** rijukhatri has joined #storyboard | 09:50 | |
*** jamesmcarthur has joined #storyboard | 09:52 | |
*** jamesmcarthur has quit IRC | 09:57 | |
rijukhatri | Hi there! | 10:35 |
rijukhatri | I'm new to openstack, and was trying to setup the storyboard project locally on my mac, following the guide https://docs.openstack.org/infra/storyboard/install/development.html | 10:36 |
rijukhatri | But I'm kinda stuck. It'd be great if someone could help me out here | 10:37 |
SotK | hi! | 10:37 |
SotK | what issues are you having? | 10:37 |
rijukhatri | The instructions here are for linux it seems, and when I try to install the packages using brew - it can't find them | 10:39 |
SotK | yeah, the instructions are for linux, but other than the package installation bits they should work on Mac too I think | 10:42 |
SotK | as for the packages, https://gist.github.com/nrollr/3f57fc15ded7dddddcc4e82fe137b58e looks like it should be sufficient for the mysql part | 10:42 |
SotK | and I think that `brew install python` should get you a sufficient version of python | 10:43 |
SotK | that should install pip too, so there's no need for the separate install of python-pip | 10:44 |
cmoura | SotK, I found one bug in migrate/launchpad/reader.py at line 42. but I fixed it. ;) So far so good the migration is running | 10:44 |
*** lakshmi_p has joined #storyboard | 10:44 | |
*** lakshmi has quit IRC | 10:44 | |
rijukhatri | Yes I've got python and mysql, but what about libpq-dev and libmysqlclient-dev? | 10:45 |
SotK | rijukhatri: they aren't actually needed (libmysqlclient-dev is a dependency of the ubuntu mysql packages and libpq-dev is for postgresql which we no longer support) | 10:47 |
SotK | there's a patch to update those docs to be more accurate here: https://review.openstack.org/#/c/633354/ | 10:47 |
rijukhatri | oh alright! thanks ! | 10:48 |
SotK | cmoura: feel free to send a patch to Gerrit with the dependency update and bugfix then (since I assume the bugfix was also related to using python3 rather than python2) :) | 10:49 |
*** udesale has quit IRC | 10:53 | |
*** lakshmi_p has quit IRC | 11:20 | |
*** lakshmi has joined #storyboard | 11:22 | |
*** rijukhatri has quit IRC | 11:43 | |
*** jamesmcarthur has joined #storyboard | 11:54 | |
*** lakshmi has quit IRC | 11:58 | |
*** jamesmcarthur has quit IRC | 11:59 | |
*** kenellysra has joined #storyboard | 12:01 | |
*** kenellysra has quit IRC | 12:02 | |
*** kenysra has joined #storyboard | 12:04 | |
*** kenysra has quit IRC | 12:05 | |
*** udesale has joined #storyboard | 12:26 | |
*** jamesmcarthur has joined #storyboard | 12:55 | |
*** jamesmcarthur has quit IRC | 12:59 | |
*** rijukhatri has joined #storyboard | 13:01 | |
*** kshitija has quit IRC | 13:35 | |
*** kshitija has joined #storyboard | 13:40 | |
*** jamesmcarthur has joined #storyboard | 13:48 | |
cmoura | So, in test "sudo tox" I had this error: https://pastebin.com/LnrNsTVA | 13:59 |
*** mkarray has quit IRC | 14:07 | |
*** jamesmcarthur has quit IRC | 14:14 | |
*** mkarray has joined #storyboard | 14:19 | |
cmoura | Can I do the commit with this error? because I think this won't relation with my alteration. | 14:32 |
*** jamesmcarthur has joined #storyboard | 15:03 | |
*** lakshmi has joined #storyboard | 15:06 | |
openstackgerrit | Camila Moura proposed openstack-infra/storyboard master: Fixes the dependencies for Python 3 https://review.openstack.org/639715 | 15:45 |
openstackgerrit | Camila Moura proposed openstack-infra/storyboard master: Fixes LauchpadReader iterator https://review.openstack.org/639716 | 15:45 |
openstackgerrit | Merged openstack-infra/storyboard master: Update development installation documentation https://review.openstack.org/633354 | 16:04 |
openstackgerrit | Camila Moura proposed openstack-infra/storyboard master: Fixes the dependencies for Python 3 https://review.openstack.org/639716 | 16:08 |
*** udesale has quit IRC | 16:10 | |
*** gouthamr has quit IRC | 16:48 | |
*** gouthamr has joined #storyboard | 16:50 | |
*** rijukhatri has quit IRC | 16:57 | |
*** jamesmcarthur_ has joined #storyboard | 17:14 | |
*** jamesmcarthur has quit IRC | 17:17 | |
*** jpich has quit IRC | 17:30 | |
*** kshitija has quit IRC | 17:32 | |
*** kenysra has joined #storyboard | 17:33 | |
*** kenysra has quit IRC | 17:33 | |
*** rijukhatri has joined #storyboard | 17:34 | |
mordred | SotK, fungi: remote: https://review.openstack.org/639760 WIP Add support for generating form-post signatures | 17:45 |
fungi | thanks!!! | 17:45 |
mordred | I still need to add tests, but that should be the code needed to generate the hmac signature. then, the storyboard api can return the signature/timestamp to the user in the API call instead of the token | 17:46 |
mordred | and the webclient can FORM post to the url | 17:46 |
mordred | as per the instructions on the linked swift docs page | 17:46 |
mordred | but that way we'll ensure if anybody uses the API directly, we'll only be giving them expriable access to upload files to a specific location | 17:47 |
mordred | fungi: also - the 'key' is just an arbitrary shared secret, and it can be re-read from swift if a user has access - so I'm thinking I'm going to update that method to not require passing the key in, but instead to just read if from the swift metadata. that way we don't need to have storyboard need a copy of the key in its own config | 17:49 |
fungi | that'll help | 17:50 |
*** ivy has joined #storyboard | 17:53 | |
SotK | nice, that looks like it should make things really neat on the webclient side, thanks | 18:01 |
*** rijukhatri has quit IRC | 18:07 | |
mordred | \o/ | 18:08 |
mordred | now just have to actually test it | 18:09 |
*** lakshmi has quit IRC | 18:10 | |
*** jtomasek has quit IRC | 18:15 | |
*** pooja_agarwal has joined #storyboard | 18:43 | |
fungi | are we holding a meeting today? | 19:00 |
fungi | per discussion in #openstack-infra i've created a story for "Add activity indicator to new worklist modal" https://storyboard.openstack.org/#!/story/2005104 | 19:01 |
SotK | I can run one if people want one | 19:02 |
fungi | still not 100% sure i get the steps which led to prometheanfire's 500 error when removing criteria from an automatic worklist during creation... i was unable to reproduce it myself | 19:02 |
SotK | I don't think I have anything that desperately needs a meeting | 19:02 |
SotK | (sorry, I lost track of time reading sqlalchemy docs) | 19:02 |
fungi | nor do i. i did get through reviewing your api-side series of changes for the attachments implementation | 19:03 |
clarkb | as anyone looked at the local unittest setup story (re cmoura and ivy's questions?) | 19:03 |
fungi | worth noting mordred pointed out a concern with the way credentials were being handled and has worked up an alternative solution to that using swift tempurls | 19:03 |
clarkb | I'm assuming the setup script(s) work to some degree because we must ci with them, but we may be missing setup steups? | 19:04 |
fungi | clarkb: i approved (i think i did anyway) SotK's dev environment setup documentation updates from a few weeks ago earlier today | 19:04 |
clarkb | ah ok | 19:04 |
fungi | https://review.openstack.org/633354 Update development installation documentation | 19:04 |
fungi | not sure if that covers it all though | 19:05 |
clarkb | cmoura: ^ can you check if that gets your tests running? | 19:05 |
diablo_rojo | SotK, fungi meeting time? | 19:05 |
fungi | diablo_rojo: we were just debating the merits of holding a formal meeting today or not | 19:05 |
fungi | so... you're just in time for that anyway! ;) | 19:06 |
SotK | that patch doesn't cover getting the tests set up | 19:06 |
* diablo_rojo should read the scrollback lol | 19:06 | |
clarkb | SotK: ah its just setting up the service from scratch? | 19:06 |
fungi | are we in agreement on no meeting this week then? i'll say something in #openstack-meeting if so | 19:10 |
SotK | yeah, to run the tests you either need to add a database account with the credentials we have hardcoded (openstack_citest:openstack_citest iirc) or set the STORYBOARD_TEST_DB environment variable to contain the correct connection string | 19:11 |
fungi | clarkb: one of my initial concerns is that we seem to have been instructing people to `sudo tox ...` which doesn't seem like it ought to be necessary if we have some separate setup script for the root parts | 19:11 |
clarkb | fungi: git grep 'sudo tox' returns no results | 19:12 |
clarkb | so not sure where we are doing that | 19:12 |
SotK | yeah that sudo was definitely unnecessary, I'm not sure what Zara and I were doing that made it seem required when we were first setting up our environments | 19:12 |
fungi | the aforementioned change removed it | 19:12 |
clarkb | ah | 19:12 |
clarkb | I would expect sudo tools/test-setup.sh && tox -re py27 to work | 19:13 |
clarkb | or something really similar to that so probably just a matter of making that work out side the CI environment | 19:13 |
fungi | and also `tox -e bindep` followed by installing whatever system packages it says are missing | 19:14 |
SotK | the tools/install_test_backend.sh script should set up the required account in mysql, but it also does a bunch of other stuff | 19:14 |
openstackgerrit | James E. Blair proposed openstack/boartty master: Fix opening a story by ID https://review.openstack.org/639807 | 20:17 |
openstackgerrit | James E. Blair proposed openstack/boartty master: Increase width of task number column in story view https://review.openstack.org/639808 | 20:20 |
*** jamesmcarthur_ has quit IRC | 20:20 | |
openstackgerrit | Merged openstack/boartty master: Fix opening a story by ID https://review.openstack.org/639807 | 20:25 |
openstackgerrit | Merged openstack/boartty master: Increase width of task number column in story view https://review.openstack.org/639808 | 20:25 |
openstackgerrit | Merged openstack/boartty master: Change openstack-dev to openstack-discuss https://review.openstack.org/621938 | 20:33 |
*** tosky has quit IRC | 20:36 | |
*** agarwalpooja has joined #storyboard | 20:43 | |
*** jamesmcarthur has joined #storyboard | 20:57 | |
*** jaosorior has quit IRC | 21:08 | |
*** ivy has quit IRC | 21:17 | |
*** jamesmcarthur has quit IRC | 21:24 | |
*** jamesmcarthur has joined #storyboard | 21:24 | |
*** pooja_agarwal has quit IRC | 22:04 | |
*** mkarray has quit IRC | 22:21 | |
*** jamesmcarthur has quit IRC | 22:36 | |
*** jamesmcarthur has joined #storyboard | 22:36 | |
clarkb | Ok I seem to have the unittests running. My process was to get an ubuntu "server", install git python3 python3-dev python3-pip, pip3 install tox, tox -ebindep, copy the output of that and apt-get install that. Then because I was in a container poking at things I had to manually start mysql and postgres due to no proper init. Then run storyboard/tools/test-setup.sh. Then tox -epy36 seems to work | 23:19 |
clarkb | however every test case takes about 2 minutes locally | 23:19 |
clarkb | and top shows mysql is the most busy process during the tests. I'm guessing we are doing some fairly non trivial db migrations every test case? | 23:19 |
clarkb | that si a fair bit slower than our test nodes, but not completely unexpected since this is my slow local machine | 23:20 |
clarkb | also there is a lot of stdout/stderr getting logged which is a bit annoying. Maybe we can clean that up | 23:23 |
clarkb | so if ivy returns the issue with no output may be that the tests take a long time on $hardware | 23:23 |
clarkb | but also tools/test-setup.sh does seem tow ork if you install things with bindep first (and optionally start mysql and postgresql if running in an env with an init) | 23:23 |
*** jamesmcarthur has quit IRC | 23:55 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!