| *** jamesmcarthur has quit IRC | 00:10 | |
| *** jamesmcarthur has joined #storyboard | 00:14 | |
| diablo_rojo | fungi, is storyboard really slow for you atm? | 00:24 |
|---|---|---|
| fungi | doesn't seem so | 00:26 |
| *** jamesmcarthur has quit IRC | 00:27 | |
| diablo_rojo | Huh. It is for me and dustinc over in openstack-dev noted the slowness too | 00:27 |
| diablo_rojo | Oh its better now | 00:27 |
| *** whoami-rajat has joined #storyboard | 00:51 | |
| *** jamesmcarthur has joined #storyboard | 01:23 | |
| *** zbr has quit IRC | 01:34 | |
| clarkb | backups happen at 0000utc | 01:35 |
| dangtrinhnt | diablo_rojo, is there any way I can link any new/update of stories to our project irc channel? | 01:58 |
| *** jamesmcarthur has quit IRC | 02:22 | |
| *** jamesmcarthur has joined #storyboard | 02:23 | |
| fungi | dangtrinhnt: not yet as far as i know. i suspect having the api service expose an event stream externally would be a necessary prerequisite | 02:39 |
| fungi | there's some preliminary functionality laid for that, i think, but it was never fully fleshed out | 02:39 |
| dangtrinhnt | fungi, thanks. Those info are pretty helpful. | 02:40 |
| *** jamesmcarthur has quit IRC | 02:53 | |
| *** jamesmcarthur has joined #storyboard | 02:53 | |
| *** diablo_rojo has quit IRC | 03:26 | |
| *** jamesmcarthur has quit IRC | 03:27 | |
| *** scherbatsky has joined #storyboard | 03:36 | |
| *** udesale has joined #storyboard | 04:17 | |
| *** udesale has quit IRC | 05:16 | |
| *** udesale has joined #storyboard | 05:17 | |
| *** udesale has quit IRC | 05:51 | |
| *** scherbatsky has quit IRC | 06:00 | |
| *** udesale has joined #storyboard | 06:11 | |
| *** brenda_ has joined #storyboard | 06:34 | |
| brenda_ | SotK, diablo_rojo_phon , fungi Hello, I’m stuck in how to claim a task ! | 06:48 |
| brenda_ | I have tried to find my name in the search bar but with no success, I’m not even sure if this is the way to claim a task. | 06:48 |
| brenda_ | What should i do? Please note that my account name is br (the name that appears on the top right corner) | 06:49 |
| *** brenda_ has quit IRC | 06:50 | |
| *** diablo_rojo has joined #storyboard | 06:52 | |
| diablo_rojo | brenda_ You should find a story you are interested in that has tasks that aren't assigned to people and click on the assign text and search for your name there. Assuming you went through the whole contributor guide and set up your ubuntuone account and signed into storyboard you should be able to find your name. | 06:56 |
| diablo_rojo | The reason you couldnt find your name if you searched now, presumably it because you havent created stories or interacted with any yet. | 06:57 |
| *** tonyb is now known as tonyb_gone | 07:20 | |
| *** tonyb_gone is now known as tonyb | 07:21 | |
| *** jpich has joined #storyboard | 08:58 | |
| *** zbr has joined #storyboard | 09:05 | |
| *** dtantsur|afk is now known as dtantsur | 09:14 | |
| *** brenda_ has joined #storyboard | 10:06 | |
| *** diablo_rojo has quit IRC | 10:11 | |
| *** tosky has joined #storyboard | 11:17 | |
| openstackgerrit | Ankita Bansal proposed openstack-infra/storyboard-webclient master: Displayed tags should link to search view for the tag https://review.openstack.org/642262 | 11:22 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient master: Add a linter for our .scss files https://review.openstack.org/643025 | 11:52 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient master: Add a linter for HTML templates https://review.openstack.org/643032 | 12:17 |
| *** jamesmcarthur has joined #storyboard | 12:47 | |
| *** udesale has quit IRC | 13:16 | |
| *** udesale has joined #storyboard | 13:17 | |
| *** tosky has quit IRC | 13:22 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient master: Add a linter for HTML templates https://review.openstack.org/643032 | 13:26 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient master: Use the latest active LTS version (10) of Node.js for testing https://review.openstack.org/643046 | 13:26 |
| *** mkarray has joined #storyboard | 13:36 | |
| *** jamesmcarthur has quit IRC | 13:41 | |
| *** jamesmcarthur has joined #storyboard | 14:00 | |
| *** jamesmcarthur has quit IRC | 14:00 | |
| *** jamesmcarthur has joined #storyboard | 14:01 | |
| *** irclogbot_3 has quit IRC | 14:09 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient master: Update to a newer version (8) of Node.js for testing https://review.openstack.org/643046 | 14:10 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient master: Add a linter for HTML templates https://review.openstack.org/643032 | 14:10 |
| *** irclogbot_3 has joined #storyboard | 14:12 | |
| *** irclogbot_3 has quit IRC | 14:25 | |
| *** irclogbot_3 has joined #storyboard | 14:28 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient master: Update to a newer version (8) of Node.js for testing https://review.openstack.org/643046 | 14:30 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient master: Add a linter for HTML templates https://review.openstack.org/643032 | 14:30 |
| mkarray | It seems that many of the CRUD operations are returning the address of an object. ex) [<storyboard.db.models.User object at 0x7fd2f359ea50>] I'd like to know where these values are being dereferenced if this seems familiar to any of you | 14:33 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient master: Update to a newer version (8) of Node.js for testing https://review.openstack.org/643046 | 14:34 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient master: Add a linter for HTML templates https://review.openstack.org/643032 | 14:34 |
| SotK | mkarray: that looks like the output you'd see from passing a User database object to a print statement | 14:36 |
| *** jtomasek has quit IRC | 14:38 | |
| SotK | the database model objects are converted into something serializable in the various RestControllers in storyboard/api/v1/, for example https://opendev.org/openstack-infra/storyboard/src/branch/master/storyboard/api/v1/users.py#L113 | 14:38 |
| mkarray | Yes that's exactly the line of code I'm printing. | 14:38 |
| mkarray | Currently trying to figure out how I turn that return value into a json object | 14:39 |
| SotK | what do you need to convert to json for? | 14:43 |
| SotK | the api methods should all return wsme custom types | 14:43 |
| SotK | or lists of those | 14:43 |
| mkarray | I'm in the process of converting an email address into a user_id | 14:46 |
| mkarray | So my thinking was to receive the user object of the person associated with the email address then pull their id from that object | 14:47 |
| SotK | hm, what do you mean by "converting an email address into a user_id"? | 14:54 |
| mkarray | as a part of turning a search into a browser id, the backend should be able to take any unique identifier and complete the browse that the user actually intends to do. | 14:58 |
| mkarray | so assignee_id=mkarray@mail.com should turn into assignee_id=232 | 14:58 |
| mkarray | I intend to make it more broad than just emails and users, but it's my starting point | 14:59 |
| SotK | in that case you should be able to get the user database object, and get the id by doing something like `assignee_id = user.id` | 15:05 |
| SotK | all the fields of each model are accessible as attributes of the database model objects | 15:06 |
| SotK | however, I'm not certain what the actual benefit of the backend understanding that is, the same thing is already doable by getting the user using the users endpoint (eg. https://storyboard.openstack.org/api/v1/users?email=adam.coldrick@codethink.co.uk), then passing the ID of that user to whatever browse/search endpoint you need to use | 15:10 |
| mkarray | I plan to move it back into the front end once I've got a solid hold on what is going on | 15:13 |
| mkarray | thanks by the way your suggestion worked | 15:13 |
| *** scherbatsky has joined #storyboard | 15:26 | |
| *** irclogbot_3 has quit IRC | 15:36 | |
| *** irclogbot_3 has joined #storyboard | 15:39 | |
| *** irclogbot_3 has quit IRC | 15:49 | |
| *** irclogbot_3 has joined #storyboard | 15:51 | |
| *** irclogbot_3 has quit IRC | 15:52 | |
| *** irclogbot_3 has joined #storyboard | 15:56 | |
| openstackgerrit | Riju Khatri proposed openstack-infra/storyboard-webclient master: Enhance adding tags on story details page https://review.openstack.org/642643 | 16:00 |
| *** diablo_rojo has joined #storyboard | 16:01 | |
| *** jtomasek has joined #storyboard | 16:16 | |
| fungi | SotK: the primary benefit i see is it stops the webclient (or any client) having to perform additional lookups in such cases if the api is capable of taking multiple "equivalent" data types for a parameter as long as it can reliably resolve them on its own internally | 16:17 |
| fungi | gerrit does something similar, where any of its api calls which expect a user in a parameter allow you to provide a user id number, a username or a verified e-mail address associated with the account | 16:18 |
| fungi | similar to how any api calls which take a change as a parameter are able to accept either the change index number or an extended change identifier | 16:18 |
| fungi | it does make input validation in the api a more complex, but affords additional convenience for the client-side implementation | 16:20 |
| fungi | and in api-first applications, having more of the logic inside the api implementation drives toward simpler and more consistent clients | 16:22 |
| fungi | for this particular case, instead of duplicating the user identifier lookup logic in storyboard-webclient and boartty, they can both just loosen up whatever input validation they might have (if any) for relevant operations | 16:24 |
| *** udesale has quit IRC | 16:42 | |
| openstackgerrit | Riju Khatri proposed openstack-infra/storyboard-webclient master: Make task ordering in Story view selectable https://review.openstack.org/641930 | 16:50 |
| *** dtantsur is now known as dtantsur|afk | 17:15 | |
| *** jpich has quit IRC | 17:35 | |
| *** jamesmcarthur has quit IRC | 17:49 | |
| *** ianychoi has quit IRC | 17:55 | |
| SotK | fungi: good points, thanks | 17:57 |
| diablo_rojo | SotK, so I had an idea the other day, since we are apparently starting to run out of low hanging fruit, we could find a corner in Denver to sit in and triage and tag the shit out of storyboard stories | 18:04 |
| diablo_rojo | fungi, and anyone else are obviously invited too | 18:05 |
| fungi | that sounds like a useful thing to do in the infra ptg room | 18:05 |
| diablo_rojo | But I think we should sit down and go through everything. There are a lot of vague stories that exist from the beginning that could probably be closed and have new more focused stories opened for them | 18:05 |
| fungi | or as a break-out on to a hallway on an infra ptg day | 18:05 |
| diablo_rojo | fungi, yeah thats what I was thinking | 18:05 |
| fungi | i think it's a swell idea | 18:06 |
| fungi | it's not so much of a bug squash since we're not fixing them, more of a bug squish? ;) | 18:06 |
| diablo_rojo | Squish + Triage | 18:07 |
| diablo_rojo | Bring your flyswatters! | 18:07 |
| *** scherbatsky has quit IRC | 18:08 | |
| diablo_rojo | Kind of starting the conversation early, do we want to have a meeting today? | 18:08 |
| diablo_rojo | Or should we spend the time doing code reviews? | 18:08 |
| diablo_rojo | (I know there are a ton of them) | 18:08 |
| SotK | Bug squish sounds like a great idea | 18:13 |
| SotK | I don't have anything to discuss in a meeting really, other than noting that there are about a million patches out for review | 18:14 |
| SotK | So spending the time on review is probably a good plan | 18:14 |
| diablo_rojo | Sounds good to me. | 18:24 |
| diablo_rojo | I have like 9 patches open in different tabs that I will review today | 18:24 |
| mkarray | So how should I go through with committing my changes? What I've been working on would require similar changes in many different parts of the code. Should I upload piece by piece or just drop a big commit later on? | 18:46 |
| *** jamesmcarthur has joined #storyboard | 18:47 | |
| *** jtomasek has quit IRC | 18:48 | |
| *** gmann is now known as gmann_afk | 18:48 | |
| SotK | Piece by piece is best if it's possible | 18:52 |
| fungi | ideally stand-alone pieces which don't on their own break the client or api | 18:55 |
| fungi | but which together implement what you're seeking to accomplish | 18:55 |
| fungi | there are a few ways to go about that depending on the situation, from just hiding things behind a feature flag to stubbing out functions and filling them in later | 18:56 |
| fungi | as for the meeting, i don't have anything to bring up either | 18:57 |
| fungi | closest item is perhaps that we've confirmed vexxhost has a viable swift implementation we ought to be able to use for our attachments storage | 18:58 |
| SotK | Oh nice :D | 19:29 |
| *** olivier_nshimiye has joined #storyboard | 19:29 | |
| *** olivier_nshimiye has quit IRC | 19:30 | |
| openstackgerrit | Ankita Bansal proposed openstack-infra/storyboard-webclient master: Pagination error in active/merged/invalid stories in projects resolved. https://review.openstack.org/642224 | 19:38 |
| *** ankita-2798 has joined #storyboard | 19:43 | |
| openstackgerrit | Ankita Bansal proposed openstack-infra/storyboard-webclient master: Stars should be next to the name of the entity https://review.openstack.org/643153 | 20:17 |
| *** jamesmcarthur has quit IRC | 20:29 | |
| *** gmann_afk is now known as gmann | 20:41 | |
| mkarray | I may be confused about what functions are getting called where. But it seems like if I'm querying for stories on assignee_id's, there is a call to the get_one method in the Users class. | 20:59 |
| mkarray | This doesn't make sense to me because every story object already has a column for assignee_id, why does it need to make a search for Users? | 20:59 |
| mkarray | Why or Where would be sufficient for an answer :) | 21:00 |
| *** whoami-rajat has quit IRC | 21:11 | |
| *** mkarray has quit IRC | 21:21 | |
| *** ankita-2798 has quit IRC | 21:54 | |
| *** tosky has joined #storyboard | 21:56 | |
| *** lifeless has quit IRC | 22:27 | |
| *** lifeless has joined #storyboard | 22:27 | |
| *** ianychoi has joined #storyboard | 23:06 | |
| *** tosky has quit IRC | 23:23 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!