| SotK | wait | 00:07 |
|---|---|---|
| SotK | concern over, my brain was broken (and I missed a crucial part of the code until just now) | 00:08 |
| SotK | to summarise that confusion for future reference, https://opendev.org/openstack-infra/storyboard/src/branch/master/storyboard/plugin/email/workers.py#L353-L362 is totally broken and doesn't do what the comment says | 00:22 |
| SotK | receiving email for private stories you have permission to see is expected behaviour (and for some reason my brain had totally failed to take in "(who was also added to the story)") | 00:24 |
| SotK | the filtering to make sure that people without permission aren't notified actually happens in https://opendev.org/openstack-infra/storyboard/src/branch/master/storyboard/db/api/subscriptions.py#L138-L144 | 00:26 |
| SotK | however, there is a real bug in that code, since it doesn't take team permissions into account at all, which I now expect is where the confusion over private stories not sending email yet has come from | 00:26 |
| SotK | lesson learned: don't try to debug convoluted code on your phone whilst walking around town | 00:28 |
| Zara | :) | 00:29 |
| SotK | I'll send some patches to tidy up that first link and fix the lack of team permissions in the second at some point when its not midnight, but in the meantime I'm sheepishly going to sleep | 00:30 |
| Zara | it is half midnight | 00:30 |
| SotK | on the plus side my patch to fix the non-existent bug worked great and turned out pretty neat | 00:31 |
| *** tosky has quit IRC | 00:31 | |
| Zara | I'm only up because I wound up losing time setting up a vpn to watch university challenge; the final of the 2016 season was blocked | 00:31 |
| Zara | after 36 episodes; who does that? glad the pointless patch worked though :P | 00:33 |
| SotK | Heh, blocking just the final is cruel | 00:36 |
| Zara | ikr? and how is c4 gonna make £££ off it anyway? | 00:38 |
| *** jamesmcarthur has joined #storyboard | 01:21 | |
| *** jamesmcarthur has quit IRC | 01:25 | |
| *** jamesmcarthur has joined #storyboard | 04:08 | |
| *** whoami-rajat has joined #storyboard | 04:11 | |
| *** jamesmcarthur has quit IRC | 05:17 | |
| *** jamesmcarthur has joined #storyboard | 05:18 | |
| *** NCLanceman has joined #storyboard | 05:20 | |
| *** jamesmcarthur has quit IRC | 05:22 | |
| NCLanceman | I'm trying to migrate a Launchpad project to my test server and keep getting a ModuleNotFoundError for launchpadlib. I've reinstalled it every way I know how. Any idea what I'm doing wrong? | 05:25 |
| *** jamesmcarthur has joined #storyboard | 05:48 | |
| *** scherbatsky has joined #storyboard | 06:09 | |
| *** scherbatsky has left #storyboard | 06:10 | |
| *** scherbatsky has joined #storyboard | 06:11 | |
| openstackgerrit | Radwa S. Khattab proposed openstack-infra/storyboard-webclient master: Fixing Tasks Filtering in Project-Group using checkBoxes https://review.openstack.org/646937 | 06:34 |
| *** Rou has joined #storyboard | 07:45 | |
| *** fatema_ has quit IRC | 07:51 | |
| *** whoami-rajat has quit IRC | 08:00 | |
| *** ankita-2798 has joined #storyboard | 08:19 | |
| *** NCLanceman has quit IRC | 08:54 | |
| *** Rou__ has joined #storyboard | 09:03 | |
| *** Rou has quit IRC | 09:06 | |
| *** Rou has joined #storyboard | 09:13 | |
| *** Rou__ has quit IRC | 09:15 | |
| *** Rou has quit IRC | 09:25 | |
| *** Rou has joined #storyboard | 09:28 | |
| *** ankita-2798 has quit IRC | 10:10 | |
| *** cmoura has quit IRC | 10:20 | |
| *** cmoura has joined #storyboard | 10:21 | |
| *** whoami-rajat has joined #storyboard | 10:45 | |
| *** tosky has joined #storyboard | 10:47 | |
| *** Rou has quit IRC | 11:00 | |
| *** Rou has joined #storyboard | 11:06 | |
| *** scherbatsky has quit IRC | 11:06 | |
| *** lifeless has quit IRC | 11:16 | |
| *** lifeless has joined #storyboard | 11:16 | |
| *** scherbatsky has joined #storyboard | 12:39 | |
| *** scherbatsky has quit IRC | 12:49 | |
| *** Rou__ has joined #storyboard | 13:24 | |
| *** Rou has quit IRC | 13:26 | |
| *** Rou__ has quit IRC | 14:05 | |
| *** Rou has joined #storyboard | 14:15 | |
| *** scherbatsky has joined #storyboard | 14:17 | |
| *** Rou has quit IRC | 15:10 | |
| *** Rou has joined #storyboard | 15:15 | |
| *** whoami-rajat has quit IRC | 15:15 | |
| *** Rou has quit IRC | 15:19 | |
| *** Rou has joined #storyboard | 15:36 | |
| *** NCLanceman has joined #storyboard | 16:10 | |
| *** tosky has quit IRC | 16:41 | |
| *** NCLanceman has quit IRC | 17:07 | |
| *** Rou has quit IRC | 17:30 | |
| *** Rou has joined #storyboard | 17:40 | |
| *** Rou has quit IRC | 18:00 | |
| *** Rou has joined #storyboard | 18:03 | |
| *** jamesmcarthur has quit IRC | 18:21 | |
| *** jamesmcarthur_ has joined #storyboard | 18:21 | |
| *** jamesmcarthur_ has quit IRC | 18:36 | |
| *** whoami-rajat has joined #storyboard | 19:12 | |
| *** scherbatsky has quit IRC | 19:22 | |
| *** samueldmq has quit IRC | 19:31 | |
| *** jamesmcarthur has joined #storyboard | 20:18 | |
| *** Rou has quit IRC | 20:21 | |
| *** Rou__ has joined #storyboard | 20:21 | |
| *** Rou__ has quit IRC | 20:52 | |
| *** Rou__ has joined #storyboard | 20:58 | |
| *** Rou__ is now known as Rou | 20:58 | |
| *** jamesmcarthur has quit IRC | 22:22 | |
| *** Rou has quit IRC | 23:11 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!