| *** ianychoi has joined #storyboard | 00:01 | |
| *** whoami-rajat has joined #storyboard | 01:09 | |
| *** dangtrinhnt has quit IRC | 01:45 | |
| *** dangtrinhnt has joined #storyboard | 01:49 | |
| *** diablo_rojo has quit IRC | 02:00 | |
| *** irclogbot_0 has quit IRC | 03:01 | |
| *** irclogbot_1 has joined #storyboard | 03:03 | |
| *** udesale has joined #storyboard | 04:13 | |
| *** cmoura has quit IRC | 04:40 | |
| *** scherbatsky has quit IRC | 05:27 | |
| *** scherbatsky has joined #storyboard | 05:28 | |
| *** jtomasek has joined #storyboard | 05:39 | |
| *** whoami-rajat has quit IRC | 07:05 | |
| *** whoami-rajat has joined #storyboard | 07:06 | |
| *** jpich has joined #storyboard | 07:32 | |
| *** tosky has joined #storyboard | 07:43 | |
| *** dtantsur|afk is now known as dtantsur | 08:01 | |
| *** dtantsur is now known as dtantsur|brb | 08:59 | |
| *** udesale has quit IRC | 11:05 | |
| *** Rou_ has joined #storyboard | 12:08 | |
| *** Rou_ has quit IRC | 12:12 | |
| *** jamesmcarthur has joined #storyboard | 12:43 | |
| *** dtantsur|brb is now known as dtantsur | 12:51 | |
| *** Rou has joined #storyboard | 12:53 | |
| *** altlogbot_0 has joined #storyboard | 13:05 | |
| *** Rou has quit IRC | 13:07 | |
| *** Rou has joined #storyboard | 13:15 | |
| Rou | Hello :) | 13:15 |
|---|---|---|
| Rou | I wanna ask about something | 13:16 |
| Rou | I noticed some parameter sent to functions in the db/api called "session", saying that it is "DB session to use" | 13:17 |
| Rou | I don't get what this is | 13:17 |
| *** mkarray has joined #storyboard | 13:18 | |
| *** altlogbot_0 has quit IRC | 13:32 | |
| *** altlogbot_3 has joined #storyboard | 13:34 | |
| *** altlogbot_3 has quit IRC | 13:38 | |
| *** altlogbot_2 has joined #storyboard | 13:40 | |
| *** altlogbot_2 has quit IRC | 14:00 | |
| *** jamesmcarthur has quit IRC | 14:16 | |
| *** jamesmcarthur has joined #storyboard | 14:17 | |
| Rou | Anyone here? :( | 14:20 |
| *** altlogbot_3 has joined #storyboard | 14:27 | |
| *** altlogbot_3 has quit IRC | 14:29 | |
| *** altlogbot_3 has joined #storyboard | 14:31 | |
| *** altlogbot_3 has quit IRC | 14:33 | |
| *** altlogbot_2 has joined #storyboard | 14:49 | |
| *** altlogbot_2 has quit IRC | 14:51 | |
| *** altlogbot_3 has joined #storyboard | 14:54 | |
| *** altlogbot_3 has quit IRC | 14:55 | |
| *** altlogbot_2 has joined #storyboard | 15:00 | |
| *** tosky has quit IRC | 15:11 | |
| *** tosky has joined #storyboard | 15:12 | |
| *** jamesmcarthur has quit IRC | 15:27 | |
| *** Rou has quit IRC | 15:58 | |
| *** jamesmcarthur has joined #storyboard | 15:58 | |
| *** jamesmcarthur has quit IRC | 16:05 | |
| *** dtantsur is now known as dtantsur|afk | 16:12 | |
| *** jpich has quit IRC | 16:18 | |
| *** jamesmcarthur has joined #storyboard | 16:28 | |
| *** tosky has quit IRC | 16:38 | |
| *** jamesmcarthur has quit IRC | 16:44 | |
| *** jamesmcarthur has joined #storyboard | 16:51 | |
| *** jamesmcarthur has quit IRC | 17:05 | |
| *** jamesmcarthur has joined #storyboard | 17:29 | |
| *** jamesmcarthur has quit IRC | 17:51 | |
| *** diablo_rojo has joined #storyboard | 17:56 | |
| *** irclogbot_1 has quit IRC | 18:08 | |
| *** irclogbot_0 has joined #storyboard | 18:12 | |
| *** tosky has joined #storyboard | 18:18 | |
| *** jamesmcarthur has joined #storyboard | 18:50 | |
| *** whoami-rajat has quit IRC | 19:09 | |
| *** Rou has joined #storyboard | 19:13 | |
| Rou | Hello | 19:13 |
| Rou | diablo_rojo, hope you're free for a few minutes :) | 19:14 |
| diablo_rojo | Rou, hello | 19:14 |
| diablo_rojo | Yeah I'm around | 19:14 |
| Rou | I've been trying to see the reason behind the slow filtering of stories in projectGroup's pages | 19:15 |
| Rou | It is surely in the API side not the web-client | 19:16 |
| Rou | I found something odd though xD | 19:16 |
| Rou | I literally deleted a row in a file in the api that should raise an error upon filtering, but nothing at all happens | 19:16 |
| Rou | So I have no idea now how the web-client talks to the api on my device | 19:17 |
| Rou | Or how the connection is between them works? | 19:17 |
| Rou | I'm kinda lost in that part XD | 19:17 |
| diablo_rojo | Rou, can you link me to where you are poking at in the api? | 19:18 |
| Rou | storyboard/storyboard/db/api/stories.py | 19:19 |
| mkarray | Did you rerun the api instance? | 19:19 |
| diablo_rojo | Yeah if you dont restart the service I am guessing the change didnt get picked up | 19:20 |
| Rou | meaning? | 19:22 |
| Rou | I did follow the instructions in the documentation long ago | 19:22 |
| mkarray | You have to rerun the command that launched your api instance | 19:22 |
| Rou | and I do open the local server of both of them | 19:23 |
| Rou | the command starting with tox? | 19:23 |
| mkarray | For me it is: tox -e venv -- storyboard-api --config-file ./etc/storyboard.conf | 19:23 |
| Rou | yeah, I do it | 19:23 |
| Rou | and tox -egrunt_no_api -- serve in the web-client folder | 19:24 |
| Rou | I don't understand how was that even possible, if Storyboard does retrieve data from the database instance I have locally correct. I mean, it surely sends requests to the API to get the data, doesn't it? As far as I know... | 19:28 |
| mkarray | In my setup, my api fetches data from my local mysql database | 19:28 |
| mkarray | What piece of the code are you changing? Can you link it on github? | 19:29 |
| Rou | I deleted a header of the function lol | 19:29 |
| Rou | that will surely raise an error | 19:29 |
| Rou | Maybe mine does that as well .. from the local mysql database | 19:30 |
| Rou | I see the data in the database from phpmyadmin | 19:30 |
| fungi | i'm going to start test imports of the openstack telemetry team repositories into storyboard-dev.openstack.org in a few minutes, to make sure there are no surprises | 19:31 |
| Rou | mkarray, I was changing things in that file https://github.com/RadwaSK/storyboard/blob/master/storyboard/db/api/stories.py | 19:32 |
| fungi | i'll also exercise https://review.openstack.org/649065 in the process | 19:32 |
| mkarray | What line have you effected? | 19:35 |
| mkarray | (Thats a pretty broad file) | 19:35 |
| Rou | I commented line 176 | 19:37 |
| Rou | Just that line | 19:37 |
| Rou | And I think filtering stories in a project in project Groups does use this function | 19:38 |
| Rou | "_story_build_query" | 19:39 |
| mkarray | you commented out the function definition and the code recompiled? | 19:40 |
| Rou | huh | 19:41 |
| Rou | nope | 19:41 |
| Rou | I do have to recompile it after I change anything in it? | 19:41 |
| Rou | That seems rather reasonable actually XD | 19:41 |
| mkarray | yes that is why I asked if you were rerunning the tox command | 19:42 |
| *** jamesmcarthur has quit IRC | 19:42 | |
| fungi | depending on how it's installed (if it's installed into a virtualenv in "editable" mode that shouldn't be required) | 19:42 |
| fungi | though restarting any running services from that codebase is going to be required for sure | 19:42 |
| Rou | Ahh, you mean that I just should rerun the tox command after I change something in the code? | 19:43 |
| Rou | fungi, it makes perfect sense, I don't know how I didn't think about that lol | 19:44 |
| Rou | Another thing, I also noticed that I have an error (red-underlined words) in some of the imports in the project, like now I can see in importing pytz and sqlalchemy.orm | 19:44 |
| Rou | That doesn't seem right, I think... | 19:45 |
| fungi | presumably you're seeing this in an ide? i'm not really sure what it thinks it's checking there so hard to know what to tell you | 19:46 |
| Rou | I don't think it is an issue since it raises no error when running the tox command | 19:50 |
| fungi | likely your ide is merely confused (possible it isn't running in the same context where those dependencies are importable) | 19:52 |
| Rou | maybe | 19:54 |
| Rou | okay, now that is done, I have another things to ask about | 19:54 |
| Rou | Do you know what I'm workin on or should I explain first? | 19:54 |
| fungi | according to scrollback, slow filtering of stories, looks like maybe inefficient api query implementation? | 20:02 |
| fungi | (known problem, suspected cause, glad someone has time to dig into it so... thanks!) | 20:03 |
| Rou | I agree | 20:05 |
| Rou | However, it's rather complicated | 20:05 |
| Rou | Idk .. I totally understood how it works, after hours of digging XD | 20:05 |
| Rou | but, still, I think I will change much of the code to maybe make it more effecient | 20:05 |
| Rou | efficient* | 20:05 |
| Rou | however, if I do so, I'm not sure where it will ruin some calls from other functions or requests or whatever | 20:06 |
| Rou | also, how do I even test it to know? | 20:06 |
| Rou | The database instance I have only has like 3 stories or sth, it won't have that much data to know if it has gone faster or not | 20:07 |
| fungi | we have "unit" tests which are really more like integration tests because they do full database interactions | 20:07 |
| fungi | oh, performance tests with larger datasets? | 20:07 |
| *** diablo_rojo has quit IRC | 20:08 | |
| fungi | the other day someone said they used http://filldb.info/ to generate a usable dataset for sb load tests | 20:08 |
| Rou | hmmmm... | 20:09 |
| Rou | I'll check it | 20:09 |
| Rou | But sill, what shall I do about the messing much with the code? | 20:09 |
| fungi | i've looked into creating sanitized dumps of production data in the past, but given the intricacies of various rows associated with private stories it's not easy to redact | 20:09 |
| Rou | I don't understand | 20:09 |
| fungi | don't understand what? we're talking about a couple of different things here | 20:11 |
| fungi | as for how to go about submitting significant refactoring of the source code, that's best done in multiple smaller chunks if possible, to make them easier to review | 20:11 |
| Rou | lol .. sorry, I meant the last message you send "sanitized dumps of production data"? | 20:11 |
| Rou | different patches? | 20:12 |
| fungi | oh, you were saying your database has only a few stories so you didn't know how you were going to verify the performance improvements, and so i mentioned filldb.info as a possible way to create random data matching the sb db schema, and also that ni the past i had looked into ways to safely provide public copies of our production database for storyboard.openstack.org but concluded that was nontrivial | 20:13 |
| fungi | maybe we should focus on asking/answering one question at a time | 20:13 |
| fungi | (also i need to get these test imports for the telemetry team underway) | 20:14 |
| Rou | last message, what? XD | 20:15 |
| fungi | my earlier comments around 19:30z, i actually just popped in here to give folks a heads up that i'll be testing imports of the openstack telemetry bugs from launchpad.net to storyboard-dev.openstack.org (our persistent storyboard production-like testbed) in case anyone notices any impact | 20:18 |
| Rou | Aha | 20:19 |
| Rou | well, good luck xx | 20:19 |
| fungi | thanks! | 20:19 |
| Rou | Are you and mkarray too from the U.S.? | 20:19 |
| fungi | but also happy to answer further questions about storyboard if i know the answers | 20:20 |
| fungi | i live in the usa, yes. i do not know about mkarray | 20:20 |
| Rou | It explains the time. whenever I ask anything in mornings (in my time-zone) it is kinda a desert here, but now three replied to me XD | 20:21 |
| fungi | SotK is in an emea timezone, though i think he tends to be around more in his evenings | 20:22 |
| mkarray | I'm in Canada Eh | 20:22 |
| mkarray | EST | 20:22 |
| Rou | huh | 20:22 |
| Rou | Anyway, I will take one step at a time. I'll make the dummy db, start planning how I will optimize the query and maybe separate it into different patches as tasks to do. If I got stuck, I'll ask for sure. Thanks a lot for the help fungi, and mkarray,! :) | 20:23 |
| mkarray | No need for the thanks, anytime | 20:24 |
| fungi | thank you for looking into this! i know lots of us find the performance issues painful as the dataset and user volume scales up | 20:24 |
| Rou | I hope I do optimize it and increase its performance XD | 20:25 |
| fungi | me too, very much ;) | 20:25 |
| *** zbr has quit IRC | 20:37 | |
| *** Rou has quit IRC | 20:41 | |
| *** jtomasek has quit IRC | 21:14 | |
| *** jamesmcarthur has joined #storyboard | 21:19 | |
| *** jamesmcarthur has quit IRC | 21:23 | |
| *** diablo_rojo has joined #storyboard | 21:29 | |
| *** mkarray has quit IRC | 22:13 | |
| *** tosky has quit IRC | 23:11 | |
| *** diablo_rojo has quit IRC | 23:24 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!