Tuesday, 2019-06-25

* diablo_rojo opens reviews00:04
diablo_rojofungi, looks good to me and sounds like that's what SotK was asking for so I think I will just push it through.00:05
diablo_rojo=2+Wed00:08
diablo_rojo+2+Wed00:08
fungithanks!00:11
fungicloudnull: once it merges, it'll be autodeployed in ~30-60 minutes and you should be able to retry creating boards and worklists00:12
fungiassuming you're still around that late00:12
cloudnullwill give it a go later tonight and report back for sure.00:12
fungii should be up and around for a while too00:12
diablo_rojocloudnull, thanks!00:43
diablo_rojoI'll be around either here or on my other nick.00:44
openstackgerritMerged opendev/storyboard master: Correct team iterator lists in worklist creation  https://review.opendev.org/66724800:45
cloudnull^ Woot!00:56
diablo_rojoWoot indeed :)00:59
fungicloudnull: a quick check tells me it's already gotten installed on storyboard.o.o01:21
cloudnullso I'm still not able to create a new board - "500: POST /api/v1/worklists: _CallbackResult was already set" <- thats the error I'm seeing now02:04
*** whoami-rajat has joined #storyboard02:07
cloudnullI can however create a worklist02:08
cloudnulldiablo_rojo fungi ^02:08
cloudnulland if I try and create a new board, with no columns, I get - 500: POST /api/v1/boards: 'NoneType' object has no attribute 'name'02:11
cloudnullsame error if I create a board with 1 column02:12
*** diablo_rojo has quit IRC02:17
*** armstrong has quit IRC02:45
*** udesale has joined #storyboard03:53
*** jtomasek has joined #storyboard05:51
*** altlogbot_0 has quit IRC06:46
*** altlogbot_1 has joined #storyboard06:56
SotKlooks like boards had the same bug, I'll send a patch06:56
SotKsorry for the painful experience cloudnull06:57
openstackgerritAdam Coldrick proposed opendev/storyboard master: Correct team iterator lists in board creation  https://review.opendev.org/66727506:58
*** jpich has joined #storyboard07:07
*** tosky has joined #storyboard07:28
*** jtomasek has quit IRC07:31
*** jtomasek has joined #storyboard07:32
*** udesale has quit IRC08:01
*** udesale has joined #storyboard08:03
*** udesale has quit IRC08:03
*** udesale has joined #storyboard08:03
*** udesale has quit IRC11:06
*** udesale has joined #storyboard11:08
openstackgerritMerged opendev/storyboard master: Correct team iterator lists in board creation  https://review.opendev.org/66727511:36
fungiand it's also merged, should take effect here shortly11:42
SotKthanks :)12:01
fungithank you for finding and fixing!12:08
*** whoami-rajat has quit IRC13:16
*** openstackgerrit has quit IRC13:48
cloudnullfungi SotK will give it a spin again in just a few13:50
cloudnullthanks!13:50
fungiand thanks for bearing with us on these regressions13:50
*** udesale has quit IRC14:55
*** udesale has joined #storyboard16:03
*** diablo_rojo has joined #storyboard16:07
cloudnullhey all, just tried again to create a new board - https://i.snag.gy/FiXSmC.jpg - same error as before :'(16:47
cloudnullalso same error when adding a story with multiple tasks - https://i.snag.gy/5p1TCt.jpg16:49
fungithe multiple tasks problem isn't expected to be fixed yet, but i've reset the task in https://storyboard.openstack.org/#!/story/2000983 to a todo state to indicate that we don't think it's fixed16:52
fungisince we discovered the new way that's breaking after the prior attempt at solving it16:52
fungipip says the version with https://review.opendev.org/667275 is installed, so presumably we're still missing a spot. i'll check the apache logs again16:53
*** jpich has quit IRC16:56
fungithat looks like a new error, fwiw16:56
fungioh fun, that's an assertionerror exception too16:56
SotKfungi: is there any chance you can try to get the full traceback of that error please?16:58
fungii'm nearly done getting it onto paste.o.o16:58
SotKheh, thanks16:58
fungifor some reason my pastebinit install has been broken for a while, so copying and pasting around16:59
fungivoila: http://paste.openstack.org/show/753376/16:59
fungiduplicate callback for the event stream?17:00
SotKoh huh, I thought we'd blocked publishing events to rabbitmq for worklists and boards when we had a similar issue to this ages and ages ago with the intention of making it work "one day"17:03
SotKah I guess its because its a timeline event thing that triggered it not a worklist17:03
* SotK finishes what he's doing so he can pay better attention17:04
fungiright, just happened to get called through the worklist creation codepath17:04
*** udesale has quit IRC17:07
*** jtomasek has quit IRC17:21
SotKcloudnull, fungi: can either of you reproduce that board error?17:58
fungii'm not certain what steps cloudnull took to get it17:58
SotKwe started publishing timeline events for worklists a long time ago and I've never seen this error before, and I can't reproduce it locally or on storyboard-dev (assuming that the reproduction steps are the try to make a board like the one in the screenshot)18:00
SotKfungi: what version of pika is installed on storyboard.o.o out of interest?18:07
fungipika==0.13.018:09
fungiwould an api method to get detail on what dependency versions are present be worthwhile? along with one to find out what version of the api server is running?18:09
fungii've written something similar for a personal application i maintain, which i'd be happy to hack in an implementation of18:10
SotKI think that would be very useful, yeah18:11
fungii'll add that to my list18:11
fungiuseful to query the environment when the service is started, so that you know what versions were present to be imported at start time rather than possibly upgraded while it was running and so may not be the actual version in use18:13
fungigranted, it's fairly easy to return both18:13
SotKthe traceback looks like the problem is happening when pika itself is handling a `socket.error`18:17
SotKno idea what is causing it18:17
fungithere are a bunch of socket disconnects in the wsgi error log18:26
fungii had assumed they were unrelated, from clients aborting calls18:26
fungi[Tue Jun 25 16:57:42.304761 2019] [wsgi:error] [pid 4996:tid 140067423065856] 2019-06-25 16:57:42.304 4996 WARNING storyboard.notifications.publisher [-] Attempted to send message on closed connection.: ConnectionClosed: (-1, "error(32, 'Broken pipe')")18:27
fungimaybe a sign rabbit is acting out?18:28
fungirabbitmq was last started 2019-02-08 so it's been running a while18:28
fungi=INFO REPORT==== 25-Jun-2019::16:57:47 === accepting AMQP connection <0.12169.47> (127.0.0.1:45838 -> 127.0.0.1:5672)18:29
fungi=ERROR REPORT==== 25-Jun-2019::17:00:47 === closing AMQP connection <0.12169.47> (127.0.0.1:45838 -> 127.0.0.1:5672): Missed heartbeats from client, timeout: 60s18:30
fungithat's happening every few minutes18:30
fungioh, or maybe the api server is simply too busy to send heartbeats18:30
cloudnullSotK I can give it another spin ?18:44
fungiyeah, see if you can get it to happen again18:44
fungii have a feeling we're seeing something involving rabbitmq disconnects18:44
cloudnullbasically all I did was login, click boards, select create a board from the drop down, add a title, description, and a couple columns, then click save18:45
* cloudnull doing it now 18:45
fungithanks!18:45
cloudnullit worked :)18:46
cloudnullhttps://storyboard.openstack.org/#!/board/15518:46
fungifor the record, we've only seen that assertion error once today (so far) suggesting it's not happening with great frequency18:47
cloudnullI can go create a mess of boards to see if it happens again ?18:48
fungiwell, once in today's log file anyway18:48
fungiprior to log rotation there was an occurrence at 02:04:04 utc18:48
cloudnulldoes storyboard have a REST API I can use to create stories/tasks ?18:49
cloudnulland assign them to a board ?18:49
fungiprior to that, the most recent occurrence was 2019-06-13 19:41:01 utc, so ~11 days ago?18:49
*** ianychoi_ has quit IRC18:49
fungiand was also just the one, so this seems to be an infrequent race/whatever which has been around for a while18:50
fungicloudnull: yes, it even has documentation... https://docs.openstack.org/infra/storyboard/webapi/v1.html18:50
*** ianychoi_ has joined #storyboard18:50
cloudnullnice!18:50
* cloudnull reading 18:50
fungithe design is api-first, so anything the webclient can do has to be supported by the api18:51
fungicloudnull: there's also a console client... https://pypi.org/project/boartty/18:52
fungicloudnull: and a python sdk... https://docs.openstack.org/infra/python-storyboardclient/18:53
cloudnullvery cool ! this will help my trello to storyboard migration :)18:54
fungisource for all of those things reside in opendev's gerrit, in case you find bugs you want to fix18:58
fungi(or improvements you want to make)18:58
fungisame goes for the webclient too (opendev/storyboard-webclient repo)18:59
fungiSotK: anyway, in total three occurrences of "AssertionError: _CallbackResult was already set" in the past 16 days19:01
fungiso doesn't seem to be happening with any extreme frequency19:01
cloudnullI'm running into the following when trying to use the python-storyboardclient - https://pasted.tech/pastes/d5c987f1fdca2acb41d86aa933132d8ab6f9540c.raw - seems to be happening w/ both py27 and py37 from within a venv19:14
cloudnullhappens from `pip install git+https://opendev.org/openstack-infra/python-storyboardclient` using a local clone, or using the pypi package.19:16
fungihuh, i'll try the same19:17
cloudnulloh, i guess I need to RTFM harder. if `cd` into the local clone and install it works19:19
*** jtomasek has joined #storyboard19:19
cloudnullgit+ and the pypi package are not working :'(19:19
fungiit worked for me a moment ago, but yes if my cwd is not a git repo then it breaks (whether installed from pypi or not)19:24
fungii wonder if this is a pbr problem19:24
fungiit's certainly strange19:26
fungii've only ever seen this if package metadata is missing or pbr can't find where pip wrote it19:26
cloudnullI've only ever encountered this as a PBR bug19:34
fungiyes, discussing it in the infra meeting now in fact19:35
fungithere was a very old pbr bug, but this is happening with latest pbr19:35
*** tosky has quit IRC19:40
fungicloudnull: okay, so clarkb spotted the problem there20:00
fungilikely a very-long-standing error in storyboardclient/__init__.py which has gone unnoticed (though i haven't done a git blame on it)20:01
fungiwe need to explicitly pass in the package name as it's not the same as the module name20:01
fungiby default pbr assumes they match20:01
cloudnullah ha!20:02
cloudnullat least it sounds like a simple thing to resolve20:03
fungiyeah, either he or i will push a patch in just a moment20:03
fungi(a very trivial one)20:03
*** openstackgerrit has joined #storyboard20:09
openstackgerritJeremy Stanley proposed opendev/python-storyboardclient master: Correct the distname in PBR version discovery  https://review.opendev.org/66745520:09
fungicloudnull: ^20:09
cloudnullnice!20:09
fungigit blame indicates that bug has existed ever since the beginning20:10
fungiall the way back to the initial cookiecutter commit https://review.openstack.org/138090 in 201420:11
* fungi notes that neither the author nor the four people who reviewed that change (nor the ci account which verified it!) is around our community any longer20:13
diablo_rojoLol20:26
diablo_rojothats a piece of history right there20:26
Zaraheh, now I feel old, having met most of those involved at least once20:43
*** ianychoi_ has quit IRC20:59
*** ianychoi_ has joined #storyboard21:00
*** ianychoi_ has quit IRC21:05
*** ianychoi_ has joined #storyboard21:09
*** openstackgerrit has quit IRC21:18
*** ianychoi_ is now known as ianychoi21:18
*** jtomasek has quit IRC21:24
*** diablo_rojo has quit IRC22:54
*** diablo_rojo has joined #storyboard23:31

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!