Thursday, 2019-10-17

*** jamesmcarthur has joined #storyboard01:53
*** jamesmcarthur has quit IRC01:53
*** jamesmcarthur has joined #storyboard01:53
*** jamesmcarthur has quit IRC02:26
*** jamesmcarthur has joined #storyboard02:27
*** jamesmcarthur has quit IRC02:28
*** jamesmcarthur has joined #storyboard02:28
*** jamesmcarthur has quit IRC02:29
*** jamesmcarthur has joined #storyboard02:37
*** jamesmcarthur has quit IRC02:42
*** jamesmcarthur has joined #storyboard03:00
*** pleia2 has quit IRC03:04
*** jamesmcarthur has quit IRC03:08
*** pleia2 has joined #storyboard03:13
*** jamesmcarthur has joined #storyboard03:42
*** diablo_rojo has quit IRC04:17
*** jamesmcarthur has quit IRC04:35
*** jamesmcarthur has joined #storyboard04:37
*** jamesmcarthur has quit IRC04:43
*** ianw has quit IRC04:54
*** ianw_ has joined #storyboard04:55
*** ianw_ is now known as ianw04:56
*** jamesmcarthur has joined #storyboard05:05
*** jamesmcarthur has quit IRC05:12
*** jamesmcarthur has joined #storyboard05:19
*** jamesmcarthur has quit IRC05:24
*** udesale has joined #storyboard06:22
*** tosky has joined #storyboard07:16
*** zbr has quit IRC09:07
*** zbr has joined #storyboard09:10
*** udesale has quit IRC10:57
*** jamesmcarthur has joined #storyboard11:00
*** jamesmcarthur has quit IRC11:04
*** jamesmcarthur has joined #storyboard12:11
*** jamesmcarthur has quit IRC12:36
*** jamesmcarthur has joined #storyboard12:45
*** udesale has joined #storyboard13:16
*** jtomasek_ has joined #storyboard13:18
*** jtomasek has quit IRC13:21
*** jamesmcarthur has quit IRC14:20
*** diablo_rojo has joined #storyboard15:03
*** jamesmcarthur has joined #storyboard15:12
*** jamesmcarthur_ has joined #storyboard15:17
*** jamesmcarthur has quit IRC15:21
*** zbr has quit IRC15:29
*** zbr__ has joined #storyboard15:30
*** jamesmcarthur_ has quit IRC15:33
*** jtomasek_ has quit IRC15:34
diablo_rojomordred, around?15:37
diablo_rojoAny chance I can bribe you into fixing up our slow db queries?15:38
*** jamesmcarthur has joined #storyboard15:49
*** armstrong has joined #storyboard16:02
fungioh, that reminds me, maybe today i can try my query benchmarking experiment with regard to cache memory pressure16:03
*** udesale has quit IRC16:22
diablo_rojoSotK, I'll have the agenda updated in like 5 min17:43
diablo_rojoSotK, agenda is ready17:47
SotKthanks :)17:54
funginice17:54
*** jamesmcarthur has quit IRC17:55
fungiwe should probably also discuss the broken webclient drafts, which have been holding us up from approving webclient changes. i did some investigation and have a way forward, i think, but haven't started coding the solution yet17:55
diablo_rojoYeah definitely17:58
diablo_rojoWant to add that to the agenda fungi ?17:58
fungiif i remembered the url18:00
fungii can find it from eavesdrop18:00
SotKhttps://wiki.openstack.org/wiki/Meetings/StoryBoard18:00
fungiaha, thanks18:00
fungiadded18:02
*** zbr__ has quit IRC18:32
*** zbr has joined #storyboard18:33
*** jtomasek has joined #storyboard18:40
*** armstrong has quit IRC18:41
SotKI will review that change and ask about swift once I've made some food, back soon19:00
fungiyeah, i'm taking a break to make late lunch/early dinner myself19:03
*** jamesmcarthur has joined #storyboard20:32
SotKdiablo_rojo: I found a couple of places where the email isn't displayed, do you have time to send a new version or would you like me to fix it?20:39
*** jamesmcarthur has quit IRC20:59
*** jamesmcarthur has joined #storyboard21:08
diablo_rojoSotK, I can do it if you comment, or you can do it and I'll merge it21:09
* SotK left a comment21:09
diablo_rojoSotK, looking now21:13
*** openstackgerrit has joined #storyboard21:19
openstackgerritKendall Nelson proposed opendev/storyboard-webclient master: Show Email Addresses when Searching  https://review.opendev.org/58971321:19
diablo_rojoSotK, ^^ done21:19
*** jamesmcarthur has quit IRC21:20
* SotK tests21:20
SotKoh, I think my review wasn't clear, we also need to add the email in src/app/services/resource/search.js21:27
diablo_rojoSotK, oh my bad21:28
*** jamesmcarthur has joined #storyboard21:28
diablo_rojoFixing now21:28
SotKthanks21:29
diablo_rojoSotK, line 73?21:30
fungii left a fairly nitpicky comment about adding a space before the </span> in one of the html files, not sure whether that will impact rendering or not21:30
SotKdiablo_rojo: that's the one21:31
fungior whether it was done specifically to improve how the result is rendered there21:32
diablo_rojofungi,  I can clean that stuff up in this patchset too21:32
fungii'm less concerned about the hard tab indent on that line, as html should treat all whitespace the same21:33
fungibut not sure whether the final space inside the span was added on purpose or an accident21:33
openstackgerritKendall Nelson proposed opendev/storyboard-webclient master: Show Email Addresses when Searching  https://review.opendev.org/58971321:35
diablo_rojoSotK, fungi ^21:35
diablo_rojofungi, I took out the extra space too.21:35
diablo_rojoand fixed the tab21:35
fungicool, thanks!21:36
*** jamesmcarthur has quit IRC21:36
SotKargh that still hasn't fixed the dropdown, but since I think that means making that work properly will be a non-trivial rewrite of the search code mess we should merge this change as-is and fix that later21:46
diablo_rojoSounds good.21:48
diablo_rojoSotK, wanna open a story for that?21:48
diablo_rojo(and thank you for merging it :) )21:49
SotKI shall do21:49
SotKand thank you for the patch, sorry it took such a ridiculous time to merge :)21:49
diablo_rojoShit. the linter failed.21:50
diablo_rojoDoesn't sound like a think I did wrong though.21:51
diablo_rojoDoing a recheck21:52
SotKoh, line 73 is too long21:53
openstackgerritKendall Nelson proposed opendev/storyboard-webclient master: Show Email Addresses when Searching  https://review.opendev.org/58971321:53
diablo_rojoSotK, where did you see that? I looked through the logs and completely missed it21:54
diablo_rojofixed now if you wanna re +2+W21:54
SotKdiablo_rojo: confusingly at the top of the logs on https://zuul.opendev.org/t/openstack/build/0212541cd21743848eeeb3faaf9492e821:54
diablo_rojoHeh21:55
diablo_rojoThey made it so simple I straight up missed that21:55
SotKI did at first as well xD21:55
diablo_rojoThanks SotK and fungi21:56
*** tosky has quit IRC22:02
fungifirst thing i tried was a mysql service restart22:33
fungiquery time halved22:33
fungior nearly so22:34
fungithough as i keep re-testing, query times are already creeping back up22:37
*** diablo_rojo has quit IRC22:44
*** diablo_rojo has joined #storyboard22:49
fungirabbitmq-server restart didn't have anywhere near the same impact22:57
*** jamesmcarthur has joined #storyboard23:06
*** jamesmcarthur has quit IRC23:29
funginor does the apache2 restart seem to have23:38
*** jamesmcarthur has joined #storyboard23:42

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!