*** lyrrad has quit IRC | 01:46 | |
openstackgerrit | Kota Tsuyuzaki proposed openstack/swift3: Update CHANGELOG and AUTHORS for v1.9 https://review.openstack.org/255072 | 02:08 |
---|---|---|
timburke | kota_: yay! the current maintainer is an author! :P | 02:12 |
timburke | kota_: there's just one more nit: now it says "Move to new newnamespace" when we want just "Move to new namespace" | 02:13 |
kota_ | ah | 02:13 |
openstackgerrit | Kota Tsuyuzaki proposed openstack/swift3: Update CHANGELOG and AUTHORS for v1.9 https://review.openstack.org/255072 | 02:14 |
kota_ | lack of my notice...:/ | 02:14 |
timburke | no worries :) | 02:14 |
kota_ | timbuke: done, thx! | 02:14 |
kota_ | timburke: can i add +2, +A for that? | 02:15 |
timburke | looks good to me :) | 02:15 |
kota_ | ok, let's make it to land | 02:16 |
openstackgerrit | Merged openstack/swift3: Update CHANGELOG and AUTHORS for v1.9 https://review.openstack.org/255072 | 02:55 |
kota_ | yay | 02:55 |
*** bill_az has joined #swift3 | 04:17 | |
openstackgerrit | Kota Tsuyuzaki proposed openstack/swift3: Ensure X-Timestamp always https://review.openstack.org/242578 | 05:33 |
timburke | kota_: i like where that^ is going :-) is it maybe worth overriding __init__ and making the timestamp arg optional? we could set it to time.time() if it wasn't passed in | 05:40 |
kota_ | timburke: good thought, will do. | 05:42 |
kota_ | wait... | 05:43 |
kota_ | so if we already has a x-timestamp | 05:43 |
kota_ | in the request | 05:43 |
kota_ | i don't think s3 request does... | 05:44 |
kota_ | yes, i can make it to set time.time() as x-timestamp only when x-timestamp was not passed in. | 05:47 |
openstackgerrit | Tim Burke proposed openstack/swift3: Add object copy to self checks https://review.openstack.org/220336 | 05:47 |
kota_ | however, s3 api doesn't support x-timestamp header so x-timestamp never passed in to swift3 middleware | 05:48 |
kota_ | if it has x-timestamp, swift3 will handle it as *swift* request i.e. swift3 doesn't touch anything about the request. | 05:48 |
timburke | kota_: yeah, i think we're fine to always generate our own timestamp. i don't think S3 offers any way to set it | 05:49 |
timburke | if it already has an x-timestamp header, it seems appropriate for us to overwrite it | 05:50 |
kota_ | if there is such a situation, we could consider it at that time, currently i don't think tho. | 05:52 |
timburke | agreed. and if it ever *does* come up, it seems like a client bug | 05:53 |
kota_ | swift3 v1.9 released. | 06:05 |
timburke | huzzah! | 06:08 |
timburke | now to get it into my already-in-progress hotfix :) | 06:08 |
kota_ | timburke: night man! | 06:12 |
timburke | goodnight kota_! | 06:12 |
kota_ | have a good sleep :) | 06:12 |
*** bill_az has quit IRC | 06:58 | |
openstackgerrit | Kota Tsuyuzaki proposed openstack/swift3: Ensure X-Timestamp always https://review.openstack.org/242578 | 07:04 |
*** clayg has quit IRC | 08:05 | |
*** clayg has joined #swift3 | 08:07 | |
*** openstackgerrit has quit IRC | 09:32 | |
*** openstackgerrit has joined #swift3 | 09:33 | |
*** openstackgerrit has quit IRC | 12:47 | |
*** openstackgerrit has joined #swift3 | 12:48 | |
*** notmyname has quit IRC | 12:57 | |
*** notmyname has joined #swift3 | 12:57 | |
siva_krishnan | Hi All! Can you please suggest me the ways of testing s3 middleware after making code changes to it ? | 15:45 |
siva_krishnan | @kota I am currently working on 159130. I just saw your comments on that patch. I have few doubts on that. Do you have some time to clarify those ? | 16:10 |
siva_krishnan | @kota_ | 16:11 |
*** chsc has joined #swift3 | 16:26 | |
*** lyrrad has joined #swift3 | 17:54 | |
*** chsc has quit IRC | 20:31 | |
*** chsc has joined #swift3 | 20:42 | |
*** chsc has quit IRC | 22:21 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!