| *** chsc has quit IRC | 00:09 | |
| *** Taaronja has quit IRC | 00:17 | |
| timburke | kota_: do you know why we do the path quoting at https://github.com/openstack/swift3/blob/v1.11/swift3/request.py#L877 ? it seems strange to me... | 01:33 |
|---|---|---|
| timburke | i'm having trouble with users that have '@' in their name, which my auth middleware is translating to %40 before putting it into PATH_INFO. i'm trying to decide whether i need to have my auth unquote before doing that (which seems a little silly; it's a perfectly reasonable URL), have swift3 unquote when it *extracts* it around https://github.com/openstack/swift3/blob/v1.11/swift3/request.py#L1019, or just drop the quoting from the previous li | 01:33 |
| timburke | nk | 01:33 |
| kota_ | timburke: good point but i have no idea for now. maybe depends on quote/uncquote timing issue for swift world but i cannot point out right now. | 01:44 |
| timburke | i'll play around with it some more. there'll probably be a patch sometime tomorrow :-) | 01:45 |
| timburke | on the other hand, maybe my middleware *is* in the wrong; looks like eventlet unquotes PATH_INFO: https://github.com/eventlet/eventlet/blob/v0.19.0/eventlet/wsgi.py#L573 | 01:49 |
| timburke | as does swob.Request.blank: https://github.com/openstack/swift/blob/master/swift/common/swob.py#L851 | 01:49 |
| kota_ | sounds like swob.Request will unquote so that we should feed quoted value to the arg right? | 01:56 |
| timburke | yeah, that's my current thinking. looking at my history, apparently this is all notmyname's fault | 01:57 |
| timburke | :P | 01:57 |
| timburke | never mind! carry on! swift3's great | 01:58 |
| -kota_- >>> quote(quote('?')) | 01:58 | |
| -kota_- '%253F' | 01:58 | |
| kota_ | sometimes, we got problematic urls like we can unquote twice, likely | 01:58 |
| kota_ | oops | 01:58 |
| kota_ | :-) | 01:59 |
| kota_ | assuming 'my auth middleware' is written by notmyname | 01:59 |
| timburke | parts of it :) | 02:00 |
| timburke | i'm increasingly convinced that this is on us, not swift3 | 02:00 |
| kota_ | k | 02:01 |
| *** cschwede has joined #swift3 | 03:28 | |
| *** chsc has joined #swift3 | 04:05 | |
| *** chsc has quit IRC | 04:05 | |
| *** chsc has joined #swift3 | 04:05 | |
| *** chsc has quit IRC | 04:10 | |
| *** Taaronja has joined #swift3 | 05:55 | |
| *** Taaronja has quit IRC | 06:00 | |
| *** Taaronja has joined #swift3 | 06:02 | |
| *** Taaronja has quit IRC | 06:07 | |
| *** nikivi has joined #swift3 | 13:02 | |
| *** chsc has joined #swift3 | 15:02 | |
| *** chsc has quit IRC | 15:02 | |
| *** chsc has joined #swift3 | 15:02 | |
| *** Taaronja has joined #swift3 | 16:23 | |
| *** openstackgerrit has joined #swift3 | 18:10 | |
| openstackgerrit | Tim Burke proposed openstack/swift3: Put nested virtualenv in $TMP https://review.openstack.org/409287 | 18:10 |
| openstackgerrit | Karen Chan proposed openstack/swift3: Pass arguments to nosetests in run_test.sh https://review.openstack.org/409298 | 18:42 |
| openstackgerrit | Karen Chan proposed openstack/swift3: Change PUT bucket conflict error https://review.openstack.org/409299 | 18:42 |
| openstackgerrit | Karen Chan proposed openstack/swift3: PUT bucket returns new error BucketAlreadyExists https://review.openstack.org/409300 | 18:42 |
| openstackgerrit | Karen Chan proposed openstack/swift3: Fix "Handler" typo in acl_handlers.py https://review.openstack.org/409301 | 18:42 |
| notmyname | whoa. karenc off to a nice start in outreachy :-) | 19:01 |
| karenc | haha ^_^ ... The tests don't pass, might need some help with the changes | 19:07 |
| timburke | karenc: yay! i'll be sure to take a look | 19:20 |
| openstackgerrit | Tim Burke proposed openstack/swift3: Put nested virtualenv in $TMP https://review.openstack.org/409287 | 19:24 |
| karenc | timburke: thanks! | 19:25 |
| openstackgerrit | Tim Burke proposed openstack/swift3: Fix "Handler" typo in acl_handlers.py https://review.openstack.org/409301 | 19:38 |
| openstackgerrit | Merged openstack/swift3: Pass arguments to nosetests in run_test.sh https://review.openstack.org/409298 | 19:41 |
| *** openstack has joined #swift3 | 19:47 | |
| openstackgerrit | Merged openstack/swift3: Fix "Handler" typo in acl_handlers.py https://review.openstack.org/409301 | 20:15 |
| openstackgerrit | Merged openstack/swift3: Put nested virtualenv in $TMP https://review.openstack.org/409287 | 20:15 |
| *** nikivi has quit IRC | 20:44 | |
| *** chsc has quit IRC | 23:19 | |
| *** chsc has joined #swift3 | 23:24 | |
| *** chsc has quit IRC | 23:24 | |
| *** chsc has joined #swift3 | 23:24 | |
| *** chsc has quit IRC | 23:32 | |
| *** nikivi has joined #swift3 | 23:52 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!